On Fri, 11 Apr 2025 20:36:48 GMT, Marius Hanl <mh...@openjdk.org> wrote:
> These are the remaining bits and pieces in order to completely remove the > JUnit Vintage Engine, and therefore JUnit 4 from JavaFX. > After that, we should either document, that JUnit5 is used (just as > information) or close > [JDK-8296284](https://bugs.openjdk.org/browse/JDK-8296284) (Since you can not > use JUnit4 anymore). > > This also removes the `org.hamcrest` dependency, which is actually only used > in one test where it can easily be replaced by a `Predicate` (instead of > `Matcher`). I'm not convinced that we should keep that dependency for just > one test. > > ~Note: I could not get the `:swt` tests to compile/test, in order to run the > tests. > I need some guidance here how to instruct `Gradle` to compile this module > (and if I need anything else? like swt?).~ > > ~Also, this probably needs an extra ticket in the JBS?~ This pull request has now been integrated. Changeset: 367a170c Author: Marius Hanl <mh...@openjdk.org> URL: https://git.openjdk.org/jfx/commit/367a170c6493f0e795a420488ca689569031d0ea Stats: 407 lines in 10 files changed: 118 ins; 158 del; 131 mod 8354455: [TestBug] Remove JUnit Vintage Engine with JUnit 4 Reviewed-by: angorya, kcr ------------- PR: https://git.openjdk.org/jfx/pull/1774
