On Tue, 4 Feb 2025 16:01:03 GMT, Ziad El Midaoui <d...@openjdk.org> wrote:
>> When binding the promptTextProperty of a TextInputControl (TextField or
>> TextArea) to a text that contains linebreaks/newlines ("\n") the "bind" call
>> causes a RuntimeException to be thrown, the solution to it is to unbind
>> before calling the set(txt) method to set the new value for the property.
>> Also added tests to test this new fix
>
> Ziad El Midaoui has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fix formatting in TextInputControl.java
I agree with @mstr2, but I think fixing the exception at least is good IMO.
There are multiple locations in JFX where things are unbound to set a value. I
think this should never happen, as it is unexpected for the developer.
But that is a bigger problem to solve at one point.
-------------
Marked as reviewed by mhanl (Committer).
PR Review: https://git.openjdk.org/jfx/pull/1694#pullrequestreview-2595314059
