On Thu, 6 Feb 2025 13:18:35 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> This PR improves the `Tree-/TableRowSkin` code by doing a normal live lookup >> for the `fixedCellSize` instead of adding listener just to update >> variables(`fixedCellSizeEnabled` and `fixedCellSize`) which can otherwise be >> also just lookup'd without the hassle of listeners. >> >> While this is mostly a cleanup, it does improve the state of the >> `Tree-/TableRow`, as when the `TableRowSkinBase` constructor is called, the >> variables are not yet set. >> >> It is also consistent with the other cells, see also >> [JDK-8246745](https://bugs.openjdk.org/browse/JDK-8246745). >> Helps a bit with [JDK-8185887](https://bugs.openjdk.org/browse/JDK-8185887) >> (https://github.com/openjdk/jfx/pull/1644), but as written above, not >> required as there is no (visible) effect. > > Marius Hanl has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains five commits: > > - Merge and adjust logic to master > - Merge branch 'master' of https://github.com/openjdk/jfx into > 8277000-tree-table-row-skin-live-lookup > > # Conflicts: > # > modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableRowSkin.java > # > modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableRowSkinBase.java > # > modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java > - Merge branch 'master' of https://github.com/openjdk/jfx into > 8277000-tree-table-row-skin-live-lookup > - Call getFixedCellSize() once > - 8277000: Tree-/TableRowSkin: replace listener to fixedCellSize by live > lookup > Now that https://github.com/openjdk/jfx/pull/1644 has been merged, should > this PR be re-opened? Yes! I wanted to check everything first before I reopen it. Should be good now. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1645#issuecomment-2664186880
