On Fri, 22 Nov 2024 20:31:08 GMT, Marius Hanl <mh...@openjdk.org> wrote:
> This PR improves the `Tree-/TableRowSkin` code by doing a normal live lookup > for the `fixedCellSize` instead of adding listener just to update > variables(`fixedCellSizeEnabled` and `fixedCellSize`) which can otherwise be > also just lookup'd without the hassle of listeners. > > While this is mostly a cleanup, it does improve the state of the > `Tree-/TableRow`, as when the `TableRowSkinBase` constructor is called, the > variables are not yet set. > > It is also consistent with the other cells, see also > [JDK-8246745](https://bugs.openjdk.org/browse/JDK-8246745). > Helps a bit with [JDK-8185887](https://bugs.openjdk.org/browse/JDK-8185887) > (https://github.com/openjdk/jfx/pull/1644), but as written above, not > required as there is no (visible) effect. This pull request has now been integrated. Changeset: fcdccd9a Author: Marius Hanl <mh...@openjdk.org> URL: https://git.openjdk.org/jfx/commit/fcdccd9a93b826de6cba2f3c25ec5aeab5d05bcc Stats: 139 lines in 5 files changed: 77 ins; 29 del; 33 mod 8277000: Tree-/TableRowSkin: replace listener to fixedCellSize by live lookup Reviewed-by: angorya, mstrauss ------------- PR: https://git.openjdk.org/jfx/pull/1645
