Re: [PR] IGNITE-24766 Remove unnecessary parameters from storage engines [ignite-3]

ibessonov commented on code in PR #5397: URL: https://github.com/apache/ignite-3/pull/5397#discussion_r1991001017 ## modules/storage-rocksdb/src/test/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorageTest.java: ## @@ -51,15 +50,13 @@ public class RocksDbMv

Re: [PR] IGNITE-24755 Fix NPE because "localPartitionStateByNode" is null [ignite-3]

ibessonov merged PR #5389: URL: https://github.com/apache/ignite-3/pull/5389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[PR] IGNITE-24196 Sql. Merge projection into join node [ignite-3]

korlov42 opened a new pull request, #5398: URL: https://github.com/apache/ignite-3/pull/5398 https://issues.apache.org/jira/browse/IGNITE-24196 This patch introduces new `SqlJoinProjection` expression to use instead of `RowFactory#concat` in join nodes. Besides, in reorganizes schema

Re: [PR] IGNITE-24550 Port throttling metrics from AI2 [ignite-3]

ibessonov commented on code in PR #5392: URL: https://github.com/apache/ignite-3/pull/5392#discussion_r1990762620 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemoryMetricSource.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to

Re: [PR] IGNITE-24294 IgniteCatalog API. Table's IndexDefinition reports incorrect name/sorting of index column [ignite-3]

lowka commented on code in PR #5380: URL: https://github.com/apache/ignite-3/pull/5380#discussion_r1991059300 ## modules/catalog-dsl/src/main/java/org/apache/ignite/internal/catalog/sql/SelectFromView.java: ## @@ -53,16 +53,23 @@ class SelectFromView extends AbstractCatalogQuer

Re: [PR] IGNITE-24294 IgniteCatalog API. Table's IndexDefinition reports incorrect name/sorting of index column [ignite-3]

lowka commented on code in PR #5380: URL: https://github.com/apache/ignite-3/pull/5380#discussion_r1990905652 ## modules/catalog-dsl/src/integrationTest/java/org/apache/ignite/internal/catalog/ItCatalogDslTest.java: ## @@ -398,6 +405,48 @@ public void createAndGetDefinitionTest(

[PR] IGNITE-24776 Fix broken OrConditionTest [ignite-3]

ibessonov opened a new pull request, #5400: URL: https://github.com/apache/ignite-3/pull/5400 https://issues.apache.org/jira/browse/IGNITE-24776 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

Re: [PR] IGNITE-24762 Support zone partitions in unit tests of ignite-table [ignite-3]

sanpwc commented on code in PR #5391: URL: https://github.com/apache/ignite-3/pull/5391#discussion_r1991266250 ## modules/table/src/test/java/org/apache/ignite/internal/table/distributed/TableManagerRecoveryTest.java: ## @@ -239,6 +241,7 @@ public void testTableIgnoredOnRecovery

Re: [PR] IGNITE-24762 Support zone partitions in unit tests of ignite-table [ignite-3]

sanpwc commented on code in PR #5391: URL: https://github.com/apache/ignite-3/pull/5391#discussion_r1991268642 ## modules/table/src/test/java/org/apache/ignite/internal/table/distributed/TableManagerRecoveryTest.java: ## @@ -206,6 +207,7 @@ void after() throws Exception { }

Re: [PR] IGNITE-24776 Fix broken OrConditionTest [ignite-3]

ibessonov merged PR #5400: URL: https://github.com/apache/ignite-3/pull/5400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-24766 Remove unnecessary parameters from storage engines [ignite-3]

ibessonov merged PR #5397: URL: https://github.com/apache/ignite-3/pull/5397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[PR] IGNITE-24768 Support per-zone partitions in client handler [ignite-3]

rpuch opened a new pull request, #5401: URL: https://github.com/apache/ignite-3/pull/5401 https://issues.apache.org/jira/browse/IGNITE-24768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] IGNITE-24760 Sql. Flaky testComplexIndexConditionInitialTableCreate test [ignite-3]

zstan merged PR #5388: URL: https://github.com/apache/ignite-3/pull/5388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

[PR] IGNITE-24784 Fix eviction timestamp calculation in idempotent cache vacuumizer [ignite-3]

ibessonov opened a new pull request, #5403: URL: https://github.com/apache/ignite-3/pull/5403 https://issues.apache.org/jira/browse/IGNITE-24784 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

Re: [PR] IGNITE-24762 Support zone partitions in unit tests of ignite-table [ignite-3]

sanpwc commented on code in PR #5391: URL: https://github.com/apache/ignite-3/pull/5391#discussion_r1991643629 ## modules/table/src/test/java/org/apache/ignite/internal/table/distributed/TableManagerRecoveryTest.java: ## @@ -239,6 +241,7 @@ public void testTableIgnoredOnRecovery

Re: [PR] IGNITE-24429 Sql. Get rid of support of BINARY datatype. [ignite-3]

korlov42 commented on code in PR #5357: URL: https://github.com/apache/ignite-3/pull/5357#discussion_r1991284845 ## modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java: ## @@ -746,9 +746,9 @@ public void charLimitationWithMergeU

Re: [PR] IGNITE-24429 Sql. Get rid of support of BINARY datatype. [ignite-3]

ygerzhedovich commented on code in PR #5357: URL: https://github.com/apache/ignite-3/pull/5357#discussion_r1991356710 ## modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java: ## @@ -746,9 +746,9 @@ public void charLimitationWithM

Re: [PR] IGNITE-24763 Sql. Unification of column names in disaster recovery system views [ignite-3]

AMashenkov merged PR #5390: URL: https://github.com/apache/ignite-3/pull/5390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-24762 Support zone partitions in unit tests of ignite-table [ignite-3]

rpuch commented on code in PR #5391: URL: https://github.com/apache/ignite-3/pull/5391#discussion_r1991349468 ## modules/table/src/test/java/org/apache/ignite/internal/table/distributed/TableManagerRecoveryTest.java: ## @@ -239,6 +241,7 @@ public void testTableIgnoredOnRecovery(

Re: [PR] IGNITE-24766 Remove unnecessary parameters from storage engines [ignite-3]

rpuch commented on code in PR #5397: URL: https://github.com/apache/ignite-3/pull/5397#discussion_r1990983309 ## modules/storage-rocksdb/src/test/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorageTest.java: ## @@ -51,15 +50,13 @@ public class RocksDbMvPart

Re: [PR] IGNITE-24698 Add new catalog serializers that conform with the new serialization protocol [ignite-3]

lowka commented on code in PR #5373: URL: https://github.com/apache/ignite-3/pull/5373#discussion_r1991855041 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogHashIndexDescriptorSerializers.java: ## @@ -63,4 +63,33 @@ public void writeTo(Cat

Re: [PR] IGNITE-24707 Sql. Fix type coercion for quantify operators [ignite-3]

korlov42 merged PR #5350: URL: https://github.com/apache/ignite-3/pull/5350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

Re: [PR] IGNITE-24784 Fix eviction timestamp calculation in idempotent cache vacuumizer [ignite-3]

sashapolo commented on code in PR #5403: URL: https://github.com/apache/ignite-3/pull/5403#discussion_r1992159356 ## modules/metastorage-cache/src/main/java/org/apache/ignite/internal/metastorage/cache/IdempotentCacheVacuumizer.java: ## @@ -113,8 +112,9 @@ public CompletableFutu

Re: [PR] IGNITE-24782 Initial commit for ignite-commons [ignite]

sonarqubecloud[bot] commented on PR #11942: URL: https://github.com/apache/ignite/pull/11942#issuecomment-2718482018 ## [](https://son

[PR] IGNITE-24786 Cleanup GridFunc [ignite]

nizhikov opened a new pull request, #11944: URL: https://github.com/apache/ignite/pull/11944 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

Re: [PR] IGNITE-24768 Support per-zone partitions in client handler [ignite-3]

sashapolo commented on code in PR #5401: URL: https://github.com/apache/ignite-3/pull/5401#discussion_r1992172228 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientPrimaryReplicaTracker.java: ## @@ -439,4 +456,28 @@ public int partitions() {

Re: [PR] IGNITE-24728 Remove startVv from TableManager [ignite-3]

sashapolo merged PR #5367: URL: https://github.com/apache/ignite-3/pull/5367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-24782 Initial commit for ignite-commons [ignite]

sonarqubecloud[bot] commented on PR #11942: URL: https://github.com/apache/ignite/pull/11942#issuecomment-2717929680 ## [](https://son

Re: [PR] IGNITE-24762 Support zone partitions in unit tests of ignite-table [ignite-3]

rpuch commented on code in PR #5391: URL: https://github.com/apache/ignite-3/pull/5391#discussion_r1991350134 ## modules/table/src/test/java/org/apache/ignite/internal/table/distributed/TableManagerRecoveryTest.java: ## @@ -206,6 +207,7 @@ void after() throws Exception { }

Re: [PR] IGNITE-24191 Remove IGNITE_EXCHANGE_COMPATIBILITY_VER_1 [ignite]

nizhikov merged PR #11908: URL: https://github.com/apache/ignite/pull/11908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[PR] IGNITE-24782 Initial commit for ignite-commons [ignite]

nizhikov opened a new pull request, #11942: URL: https://github.com/apache/ignite/pull/11942 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

Re: [PR] IGNITE-24196 Sql. Merge projection into join node [ignite-3]

AMashenkov commented on code in PR #5398: URL: https://github.com/apache/ignite-3/pull/5398#discussion_r1991375745 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/LogicalRelImplementor.java: ## @@ -1104,4 +1123,38 @@ private static BinaryTupleSchem

Re: [PR] IGNITE-24429 Sql. Get rid of support of BINARY datatype. [ignite-3]

ygerzhedovich commented on code in PR #5357: URL: https://github.com/apache/ignite-3/pull/5357#discussion_r1991356940 ## modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/datatypes/varbinary/ItVarBinaryIndexTest.java: ## @@ -45,12 +45,12 @@ public

Re: [PR] IGNITE-24429 Sql. Get rid of support of BINARY datatype. [ignite-3]

ygerzhedovich commented on code in PR #5357: URL: https://github.com/apache/ignite-3/pull/5357#discussion_r1991357235 ## modules/sql-engine/src/integrationTest/sql/group1/types/blob/test_blob.test: ## @@ -76,28 +76,22 @@ SELECT NULL::VARBINARY NULL -statement error: BIN

Re: [PR] IGNITE-24562 Avoid "Message handling has been too long" message in custom pools [ignite-3]

tkalkirill merged PR #5399: URL: https://github.com/apache/ignite-3/pull/5399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-24562 Avoid "Message handling has been too long" message in custom pools [ignite-3]

ivanzlenko commented on code in PR #5399: URL: https://github.com/apache/ignite-3/pull/5399#discussion_r1991276592 ## modules/network-api/src/main/java/org/apache/ignite/internal/network/IgniteMessageServiceThread.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software

Re: [PR] IGNITE-24698 Add new catalog serializers that conform with the new serialization protocol [ignite-3]

AMashenkov commented on code in PR #5373: URL: https://github.com/apache/ignite-3/pull/5373#discussion_r1991444968 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogHashIndexDescriptorSerializers.java: ## @@ -63,4 +63,33 @@ public void writeT

Re: [PR] IGNITE-24294 IgniteCatalog API. Table's IndexDefinition reports incorrect name/sorting of index column [ignite-3]

lowka commented on code in PR #5380: URL: https://github.com/apache/ignite-3/pull/5380#discussion_r1990905201 ## modules/catalog-dsl/src/test/java/org/apache/ignite/internal/catalog/sql/QueryPartTest.java: ## @@ -155,40 +155,34 @@ void indexColumnPart() { assertThat(sql

Re: [PR] IGNITE-24562 Avoid "Message handling has been too long" message in custom pools [ignite-3]

tkalkirill commented on code in PR #5399: URL: https://github.com/apache/ignite-3/pull/5399#discussion_r1991344341 ## modules/network-api/src/main/java/org/apache/ignite/internal/network/IgniteMessageServiceThread.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software

Re: [PR] IGNITE-24786 Cleanup GridFunc [ignite]

sonarqubecloud[bot] commented on PR #11944: URL: https://github.com/apache/ignite/pull/11944#issuecomment-2718601914 ## [](https://son

Re: [PR] IGNITE-24562 Avoid "Message handling has been too long" message in custom pools [ignite-3]

tkalkirill commented on code in PR #5399: URL: https://github.com/apache/ignite-3/pull/5399#discussion_r1991333640 ## modules/network-api/src/main/java/org/apache/ignite/internal/network/IgniteMessageServiceThreadFactory.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache S

[PR] IGNITE-24562 Avoid "Message handling has been too long" message in custom pools [ignite-3]

tkalkirill opened a new pull request, #5399: URL: https://github.com/apache/ignite-3/pull/5399 https://issues.apache.org/jira/browse/IGNITE-24562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] IGNITE-24484 RAFT heartbeat coalescing [ignite-3]

vldpyatkov commented on code in PR #5221: URL: https://github.com/apache/ignite-3/pull/5221#discussion_r1991981730 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/impl/core/DefaultRaftClientService.java: ## @@ -88,19 +93,78 @@ public Future requestVote(final PeerI

Re: [PR] IGNITE-24484 RAFT heartbeat coalescing [ignite-3]

vldpyatkov commented on code in PR #5221: URL: https://github.com/apache/ignite-3/pull/5221#discussion_r1991930824 ## modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItComputeBaseTest.java: ## @@ -198,7 +198,7 @@ void executesWrongJobClassOnRemoteNode

Re: [PR] IGNITE-24444 Add documentation about interactive request sensitive da… [ignite]

SofiaSedova commented on code in PR #11911: URL: https://github.com/apache/ignite/pull/11911#discussion_r1990719558 ## docs/_docs/tools/control-script.adoc: ## @@ -47,16 +47,16 @@ If you want to connect to a node that is running on a remove machine, specify th | --host HOST_OR

Re: [PR] IGNITE-24191 Remove IGNITE_EXCHANGE_COMPATIBILITY_VER_1 [ignite]

sonarqubecloud[bot] commented on PR #11908: URL: https://github.com/apache/ignite/pull/11908#issuecomment-2716861222 ## [](https://son

Re: [PR] IGNITE-24771 Optimize AbstractCompoundCondition [ignite-3]

ibessonov merged PR #5393: URL: https://github.com/apache/ignite-3/pull/5393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-24550 Port throttling metrics from AI2 [ignite-3]

ibessonov merged PR #5392: URL: https://github.com/apache/ignite-3/pull/5392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[PR] IGNITE-24766 Remove unnecessary parameters from storage engines [ignite-3]

ibessonov opened a new pull request, #5397: URL: https://github.com/apache/ignite-3/pull/5397 https://issues.apache.org/jira/browse/IGNITE-24766 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

Re: [PR] IGNITE-24294 IgniteCatalog API. Table's IndexDefinition reports incorrect name/sorting of index column [ignite-3]

lowka commented on code in PR #5380: URL: https://github.com/apache/ignite-3/pull/5380#discussion_r1990903451 ## modules/catalog-dsl/src/main/java/org/apache/ignite/internal/catalog/sql/SelectFromView.java: ## @@ -53,16 +53,23 @@ class SelectFromView extends AbstractCatalogQuer

Re: [PR] IGNITE-23856 Ignite Thin Client channels unwanted duplication [ignite]

timoninmaxim commented on code in PR #11855: URL: https://github.com/apache/ignite/pull/11855#discussion_r1991061911 ## modules/core/src/main/java/org/apache/ignite/internal/client/thin/ReliableChannel.java: ## @@ -678,7 +675,7 @@ synchronized void initChannelHolders() {

Re: [PR] IGNITE-24784 Fix eviction timestamp calculation in idempotent cache vacuumizer [ignite-3]

ibessonov commented on code in PR #5403: URL: https://github.com/apache/ignite-3/pull/5403#discussion_r1992878630 ## modules/metastorage-cache/src/test/java/org/apache/ignite/internal/metastorage/cache/IdempotentCacheVacuumizerTest.java: ## @@ -79,6 +82,42 @@ public void tearDow

Re: [PR] IGNITE-24784 Fix eviction timestamp calculation in idempotent cache vacuumizer [ignite-3]

rpuch commented on code in PR #5403: URL: https://github.com/apache/ignite-3/pull/5403#discussion_r1992883940 ## modules/metastorage-cache/src/main/java/org/apache/ignite/internal/metastorage/cache/IdempotentCacheVacuumizer.java: ## @@ -113,8 +112,10 @@ public CompletableFuture

Re: [PR] IGNITE-24196 Sql. Merge projection into join node [ignite-3]

AMashenkov commented on code in PR #5398: URL: https://github.com/apache/ignite-3/pull/5398#discussion_r1991402057 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/LogicalRelImplementor.java: ## @@ -1104,4 +1123,38 @@ private static BinaryTupleSchem