korlov42 commented on code in PR #5357:
URL: https://github.com/apache/ignite-3/pull/5357#discussion_r1991284845
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java:
##########
@@ -746,9 +746,9 @@ public void charLimitationWithMergeUpdateOp() {
}
}
- @ParameterizedTest
- @CsvSource({"BINARY", "VARBINARY"})
- public void testErrorIfBinaryValueSizeGtThanTypePrecision(String type) {
+ @Test
+ public void testErrorIfBinaryValueSizeGtThanTypePrecision() {
+ String type = "VARBINARY";
Review Comment:
why don't simply inline?
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDynamicParameterTest.java:
##########
@@ -237,9 +236,9 @@ public void testWithDifferentParametersTypes() {
}
/** Check that insertion value is trimmed if leading is zeroes. */
- @ParameterizedTest
- @CsvSource({"BINARY", "VARBINARY"})
- public void testInsertZeroContainedBinary(String type) {
+ @Test
+ public void testInsertZeroContainedBinary() {
+ String type = "VARBINARY";
Review Comment:
the same: let's inline
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/datatypes/varbinary/ItVarBinaryIndexTest.java:
##########
@@ -45,12 +45,12 @@ public class ItVarBinaryIndexTest extends
BaseIndexDataTypeTest<VarBinary> {
@BeforeAll
public void createTable() {
- runSql("CREATE TABLE binary_fixed_length(id INTEGER PRIMARY KEY,
test_key BINARY(10))");
- runSql("CREATE INDEX binary_fixed_length_test_key_idx on
binary_fixed_length (test_key)");
+ runSql("CREATE TABLE varbinary_fixed_length(id INTEGER PRIMARY KEY,
test_key VARBINARY(10))");
Review Comment:
> `varbinary_fixed_length`
so... is it varbinary or fixed length?
##########
modules/sql-engine/src/integrationTest/sql/group1/types/blob/test_blob.test:
##########
@@ -76,28 +76,22 @@ SELECT NULL::VARBINARY
----
NULL
-statement error: BINARY length 0 must be between 1 and 2147483647. [column=C1]
-CREATE TABLE t_invalid_length(c1 BINARY(0));
-
statement error: VARBINARY length 0 must be between 1 and 2147483647.
[column=C1]
CREATE TABLE t_invalid_length(c1 VARBINARY(0));
-statement error: BINARY length 0 must be between 1 and 2147483647
-SELECT CAST(x'0101' AS BINARY(0))
Review Comment:
why did you removed this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
