Re: [PR] IGNITE-24429 Sql. Get rid of support of BINARY datatype. [ignite-3]

[via GitHub]

ygerzhedovich commented on code in PR #5357:
URL: https://github.com/apache/ignite-3/pull/5357#discussion_r1991356710


##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java:
##########
@@ -746,9 +746,9 @@ public void charLimitationWithMergeUpdateOp() {
         }
     }
 
-    @ParameterizedTest
-    @CsvSource({"BINARY", "VARBINARY"})
-    public void testErrorIfBinaryValueSizeGtThanTypePrecision(String type) {
+    @Test
+    public void testErrorIfBinaryValueSizeGtThanTypePrecision() {
+        String type = "VARBINARY";

Review Comment:
   done



##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDynamicParameterTest.java:
##########
@@ -237,9 +236,9 @@ public void testWithDifferentParametersTypes() {
     }
 
     /** Check that insertion value is trimmed if leading is zeroes. */
-    @ParameterizedTest
-    @CsvSource({"BINARY", "VARBINARY"})
-    public void testInsertZeroContainedBinary(String type) {
+    @Test
+    public void testInsertZeroContainedBinary() {
+        String type = "VARBINARY";

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org