ivanzlenko commented on code in PR #5399: URL: https://github.com/apache/ignite-3/pull/5399#discussion_r1991276592
########## modules/network-api/src/main/java/org/apache/ignite/internal/network/IgniteMessageServiceThread.java: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.network; + +import org.apache.ignite.internal.thread.IgniteThread; +import org.apache.ignite.internal.thread.ThreadOperation; + +/** + * Extension for use in {@link MessagingService} implementations that will allow, for example, tracking long message processing, which can + * be critical for network communications. + */ +public class IgniteMessageServiceThread extends IgniteThread { + /** + * Creates thread with given name. + * + * @param finalName Name of thread. + * @param r Runnable to execute. + * @param allowedOperations Operations which this thread allows to execute. + */ + public IgniteMessageServiceThread(String finalName, Runnable r, ThreadOperation... allowedOperations) { Review Comment: ```suggestion public IgniteMessageServiceThread(String threadName, Runnable task, ThreadOperation... allowedOperations) { ``` ########## modules/network-api/src/main/java/org/apache/ignite/internal/network/IgniteMessageServiceThreadFactory.java: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.network; + +import java.util.concurrent.ThreadFactory; +import java.util.concurrent.atomic.AtomicInteger; +import org.apache.ignite.internal.logger.IgniteLogger; +import org.apache.ignite.internal.thread.IgniteThread; +import org.apache.ignite.internal.thread.LogUncaughtExceptionHandler; +import org.apache.ignite.internal.thread.ThreadOperation; + +/** {@link IgniteMessageServiceThread} factory. */ +public class IgniteMessageServiceThreadFactory implements ThreadFactory { + /** Thread prefix (when computing final thread name, no dash will be added to the prefix). */ + private final String prefix; + + /** Thread counter. */ + private final AtomicInteger counter = new AtomicInteger(0); + + private final Thread.UncaughtExceptionHandler exceptionHandler; + + private final ThreadOperation[] allowedOperations; + + private IgniteMessageServiceThreadFactory(String prefix, ThreadOperation[] allowedOperations, IgniteLogger log) { + this.prefix = prefix; + this.allowedOperations = allowedOperations; + + this.exceptionHandler = new LogUncaughtExceptionHandler(log); + } + + @Override + public Thread newThread(Runnable r) { Review Comment: Please avoid single symbol variable names. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
