lowka commented on code in PR #5380:
URL: https://github.com/apache/ignite-3/pull/5380#discussion_r1990905201
##########
modules/catalog-dsl/src/test/java/org/apache/ignite/internal/catalog/sql/QueryPartTest.java:
##########
@@ -155,40 +155,34 @@ void indexColumnPart() {
assertThat(sql(column), is("col1 desc nulls last"));
}
- @Test
- void indexColumnParseSimple() {
- assertThat(parseIndexColumnList("col1"), contains(column("col1")));
- assertThat(parseIndexColumnList("col1, col2"),
contains(column("col1"), column("col2")));
- }
-
@Test
void indexColumnParseSorted() {
- assertThat(parseIndexColumnList("col1"), contains(column("col1",
SortOrder.DEFAULT)));
- assertThat(parseIndexColumnList("COL2_UPPER_CASE ASC"),
contains(column("COL2_UPPER_CASE", SortOrder.ASC)));
- assertThat(parseIndexColumnList("col3 ASC nUlls First "),
contains(column("col3", SortOrder.ASC_NULLS_FIRST)));
- assertThat(parseIndexColumnList(" col4 asc nulls last "),
contains(column("col4", SortOrder.ASC_NULLS_LAST)));
- assertThat(parseIndexColumnList("col5 desc"), contains(column("col5",
SortOrder.DESC)));
- assertThat(parseIndexColumnList("col6 desc nulls first"),
contains(column("col6", SortOrder.DESC_NULLS_FIRST)));
- assertThat(parseIndexColumnList("col7 desc nulls last"),
contains(column("col7", SortOrder.DESC_NULLS_LAST)));
- assertThat(parseIndexColumnList("col8 nulls first"),
contains(column("col8", SortOrder.NULLS_FIRST)));
- assertThat(parseIndexColumnList("col9 nulls last"),
contains(column("col9", SortOrder.NULLS_LAST)));
+ assertEquals(parseColumn("col1"), column("col1", SortOrder.DEFAULT));
Review Comment:
Thanks. fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
