SofiaSedova commented on code in PR #11911: URL: https://github.com/apache/ignite/pull/11911#discussion_r1990719558
########## docs/_docs/tools/control-script.adoc: ########## @@ -47,16 +47,16 @@ If you want to connect to a node that is running on a remove machine, specify th | --host HOST_OR_IP | The host name or IP address of the node. | `localhost` | --port PORT | The port to connect to. | `10800` | --user USER | The user name. | -| --password PASSWORD |The user password. | +| --password | Force `control.sh` to prompt for a User password before connecting to a cluster. Although you can explicitly specify a value for this option like `--password PASSWORD`, this is strongly not recommended for security reasons. If this option is omitted, `control.sh` will automatically prompt for a User password if the server demands password authentication. However, `control.sh` will waste a connection attempt finding out that the server wants a password. | Review Comment: ```suggestion | --password | Force `control.sh` to prompt for a user password before connecting to a cluster. Although you can explicitly specify a value for this option like `--password PASSWORD`, doing so is strongly discouraged due to security concerns. If this option is omitted, `control.sh` will automatically prompt for a user password if the server requires password authentication. However, `control.sh` will waste a connection attempt while determining whether the server needs a password. | ``` ########## docs/_docs/tools/control-script.adoc: ########## @@ -47,16 +47,16 @@ If you want to connect to a node that is running on a remove machine, specify th | --host HOST_OR_IP | The host name or IP address of the node. | `localhost` | --port PORT | The port to connect to. | `10800` | --user USER | The user name. | -| --password PASSWORD |The user password. | +| --password | Force `control.sh` to prompt for a User password before connecting to a cluster. Although you can explicitly specify a value for this option like `--password PASSWORD`, this is strongly not recommended for security reasons. If this option is omitted, `control.sh` will automatically prompt for a User password if the server demands password authentication. However, `control.sh` will waste a connection attempt finding out that the server wants a password. | | --ssl-protocol PROTOCOL1, PROTOCOL2... | A list of SSL protocols to try when connecting to the cluster. link:https://docs.oracle.com/en/java/javase/11/security/java-security-overview1.html#GUID-FCF419A7-B856-46DD-A36F-C6F88F9AF37F[Supported protocols,window=_blank]. | `TLS` | --ssl-cipher-suites CIPHER1,CIPHER2... | A list of SSL ciphers. link:https://docs.oracle.com/en/java/javase/11/docs/specs/security/standard-names.html#jsse-cipher-suite-names[Supported ciphers,window=_blank]. | | --ssl-key-algorithm ALG | The SSL key algorithm. | `SunX509` | --keystore-type KEYSTORE_TYPE | The keystore type. | `JKS` | --keystore KEYSTORE_PATH | The path to the keystore. Specify a keystore to enable SSL for the control script.| -| --keystore-password KEYSTORE_PWD | The password to the keystore. | +| --keystore-password | Force `control.sh` to prompt for a keystore password before connecting to a cluster. Although you can explicitly specify a value for this option like `--keystore-password KEYSTORE_PWD`, this is strongly not recommended for security reasons. If this option is omitted, `control.sh` will automatically prompt for a keystore password before connecting to the cluster if `--keystore KEYSTORE_PATH` argument is specified. | Review Comment: ```suggestion | --keystore-password | Force `control.sh` to prompt for a keystore password before connecting to a cluster. Although you can explicitly specify a value for this option like `--keystore-password KEYSTORE_PWD`, doing so is strongly discouraged due to security concerns. If this option is omitted, `control.sh` will automatically prompt for a keystore password before connecting to the cluster if `--keystore KEYSTORE_PATH` argument is specified. | ``` ########## docs/_docs/tools/control-script.adoc: ########## @@ -47,16 +47,16 @@ If you want to connect to a node that is running on a remove machine, specify th | --host HOST_OR_IP | The host name or IP address of the node. | `localhost` | --port PORT | The port to connect to. | `10800` | --user USER | The user name. | -| --password PASSWORD |The user password. | +| --password | Force `control.sh` to prompt for a User password before connecting to a cluster. Although you can explicitly specify a value for this option like `--password PASSWORD`, this is strongly not recommended for security reasons. If this option is omitted, `control.sh` will automatically prompt for a User password if the server demands password authentication. However, `control.sh` will waste a connection attempt finding out that the server wants a password. | | --ssl-protocol PROTOCOL1, PROTOCOL2... | A list of SSL protocols to try when connecting to the cluster. link:https://docs.oracle.com/en/java/javase/11/security/java-security-overview1.html#GUID-FCF419A7-B856-46DD-A36F-C6F88F9AF37F[Supported protocols,window=_blank]. | `TLS` | --ssl-cipher-suites CIPHER1,CIPHER2... | A list of SSL ciphers. link:https://docs.oracle.com/en/java/javase/11/docs/specs/security/standard-names.html#jsse-cipher-suite-names[Supported ciphers,window=_blank]. | | --ssl-key-algorithm ALG | The SSL key algorithm. | `SunX509` | --keystore-type KEYSTORE_TYPE | The keystore type. | `JKS` | --keystore KEYSTORE_PATH | The path to the keystore. Specify a keystore to enable SSL for the control script.| -| --keystore-password KEYSTORE_PWD | The password to the keystore. | +| --keystore-password | Force `control.sh` to prompt for a keystore password before connecting to a cluster. Although you can explicitly specify a value for this option like `--keystore-password KEYSTORE_PWD`, this is strongly not recommended for security reasons. If this option is omitted, `control.sh` will automatically prompt for a keystore password before connecting to the cluster if `--keystore KEYSTORE_PATH` argument is specified. | | --truststore-type TRUSTSTORE_TYPE | The type of the truststore. | `JKS` | --truststore TRUSTSTORE_PATH | The path to the truststore. | -| --truststore-password TRUSTSTORE_PWD | The password to the truststore. | +| --truststore-password | Force `control.sh` to prompt for a truststore password before connecting to a cluster. Although you can explicitly specify a value for this option like `--truststore-password TRUSTSTORE_PWD`, this is strongly not recommended for security reasons. If this option is omitted, `control.sh` will automatically prompt for a truststore password before connecting to the cluster if `--truststore TRUSTSTORE_PATH` argument is specified. | Review Comment: ```suggestion | --truststore-password | Force `control.sh` to prompt for a truststore password before connecting to a cluster. Although you can explicitly specify a value for this option like `--truststore-password TRUSTSTORE_PWD`, doing so is strongly discouraged due to security concerns. If this option is omitted, `control.sh` will automatically prompt for a truststore password before connecting to the cluster if `--truststore TRUSTSTORE_PATH` argument is specified. | ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
