korlov42 opened a new pull request, #5398: URL: https://github.com/apache/ignite-3/pull/5398
https://issues.apache.org/jira/browse/IGNITE-24196 This patch introduces new `SqlJoinProjection` expression to use instead of `RowFactory#concat` in join nodes. Besides, in reorganizes schema initialization in `ItJoinOrderTest` to take an advantage of DDL batching. Results of SqlJoinBenchmark on my laptop as follow: ``` Before Benchmark (clusterSize) (fsync) Mode Cnt Score Error Units SqlJoinBenchmark.leftHashJoin 1 false avgt 20 122.215 ± 0.768 ms/op SqlJoinBenchmark.leftMergeJoin 1 false avgt 20 167.923 ± 1.183 ms/op SqlJoinBenchmark.leftNestedJoin 1 false avgt 20 208.322 ± 1.220 ms/op After Benchmark (clusterSize) (fsync) Mode Cnt Score Error Units SqlJoinBenchmark.leftHashJoin 1 false avgt 20 72.667 ± 0.647 ms/op SqlJoinBenchmark.leftMergeJoin 1 false avgt 20 138.896 ± 1.919 ms/op SqlJoinBenchmark.leftNestedJoin 1 false avgt 20 173.719 ± 0.852 ms/op ``` ------------ Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: ### The Review Checklist - [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following: \- There is a single JIRA ticket related to the pull request. \- The web-link to the pull request is attached to the JIRA ticket. \- The JIRA ticket has the Patch Available state. \- The description of the JIRA ticket explains WHAT was made, WHY and HOW. \- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue. - [ ] **Design:** new code conforms with the design principles of the components it is added to. - [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable. - [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed. - [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources. ### Notes - [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
