[PR] IGNITE-24128 Remove casts to RestartProofIgnite [ignite-3]

2024-12-27 Thread via GitHub
rpuch opened a new pull request, #4983: URL: https://github.com/apache/ignite-3/pull/4983 https://issues.apache.org/jira/browse/IGNITE-24128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-27 Thread via GitHub
ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1898475251 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java: ## @@ -241,30 +215,46 @@ private void onWriteBusy(Iterat

[PR] IGNITE-24131 Reuse GroupKey.Builder for hash aggregate [ignite]

2024-12-27 Thread via GitHub
timoninmaxim opened a new pull request, #11783: URL: https://github.com/apache/ignite/pull/11783 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ##

Re: [PR] IGNITE-24131 Reuse GroupKey.Builder for hash aggregate [ignite]

2024-12-27 Thread via GitHub
sonarqubecloud[bot] commented on PR #11783: URL: https://github.com/apache/ignite/pull/11783#issuecomment-2563696594 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] IGNITE-23975 SQL Calcite: Add group partitions reservation [ignite]

2024-12-27 Thread via GitHub
asfgit closed pull request #11758: IGNITE-23975 SQL Calcite: Add group partitions reservation URL: https://github.com/apache/ignite/pull/11758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] IGNITE-23975 SQL Calcite: Add group partitions reservation [ignite]

2024-12-27 Thread via GitHub
Vladsz83 commented on code in PR #11758: URL: https://github.com/apache/ignite/pull/11758#discussion_r1898527619 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/metadata/ColocationGroup.java: ## @@ -58,6 +58,13 @@ public class ColocationGroup

Re: [PR] IGNITE-23870 Implement a method to receive a chain of topology changes [ignite-3]

2024-12-27 Thread via GitHub
sanpwc commented on code in PR #4966: URL: https://github.com/apache/ignite-3/pull/4966#discussion_r1898527437 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/RebalanceRaftGroupEventsListener.java: ## @@ -469,6 +489,67 @@ privat

Re: [PR] IGNITE-23870 Implement a method to receive a chain of topology changes [ignite-3]

2024-12-27 Thread via GitHub
sanpwc commented on code in PR #4966: URL: https://github.com/apache/ignite-3/pull/4966#discussion_r1898527765 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/RebalanceRaftGroupEventsListener.java: ## @@ -469,6 +489,67 @@ privat

Re: [PR] IGNITE-23975 SQL Calcite: Add group partitions reservation [ignite]

2024-12-27 Thread via GitHub
alex-plekhanov commented on code in PR #11758: URL: https://github.com/apache/ignite/pull/11758#discussion_r1898532480 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/PartitionReservationManager.java: ## @@ -0,0 +1,443 @@ +/* +

[PR] IGNITE-24063 Add peers count as parameter into DistributionAlgorithm [ignite-3]

2024-12-27 Thread via GitHub
denis-chudov opened a new pull request, #4985: URL: https://github.com/apache/ignite-3/pull/4985 https://issues.apache.org/jira/browse/IGNITE-24063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] IGNITE-24134 Sql. Improve performance of KV plan in SQL [ignite-3]

2024-12-27 Thread via GitHub
korlov42 opened a new pull request, #4986: URL: https://github.com/apache/ignite-3/pull/4986 https://issues.apache.org/jira/browse/IGNITE-24134 Results as follow: ``` Before Benchmark (clusterSize) (fsync) Mode Cnt Score Error Units SelectBenchmark.kvG

Re: [PR] IGNITE-24036 Sql schema. Introduce QualifiedName class [ignite-3]

2024-12-27 Thread via GitHub
AMashenkov commented on code in PR #4971: URL: https://github.com/apache/ignite-3/pull/4971#discussion_r1898433858 ## modules/api/src/main/java/org/apache/ignite/table/QualifiedName.java: ## @@ -0,0 +1,306 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] IGNITE-24036 Sql schema. Introduce QualifiedName class [ignite-3]

2024-12-27 Thread via GitHub
AMashenkov commented on code in PR #4971: URL: https://github.com/apache/ignite-3/pull/4971#discussion_r1898433982 ## modules/api/src/main/java/org/apache/ignite/table/QualifiedName.java: ## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] IGNITE-23305 Get rid of client HybridTimestampTracker [ignite-3]

2024-12-27 Thread via GitHub
vldpyatkov commented on code in PR #4929: URL: https://github.com/apache/ignite-3/pull/4929#discussion_r1898443582 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/HybridTimestampTracker.java: ## @@ -17,36 +17,102 @@ package org.apache.ignite.internal.tx;

Re: [PR] IGNITE-23893 Java thin: improve javadocs [ignite-3]

2024-12-27 Thread via GitHub
ptupitsyn merged PR #4982: URL: https://github.com/apache/ignite-3/pull/4982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-23870 Implement a method to receive a chain of topology changes [ignite-3]

2024-12-27 Thread via GitHub
alievmirza commented on code in PR #4966: URL: https://github.com/apache/ignite-3/pull/4966#discussion_r1898499034 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/RebalanceUtil.java: ## @@ -490,6 +494,17 @@ public static ByteArr

[PR] IGNITE-24123 Add DistributionAlgorithm interface [ignite-3]

2024-12-27 Thread via GitHub
denis-chudov opened a new pull request, #4984: URL: https://github.com/apache/ignite-3/pull/4984 https://issues.apache.org/jira/browse/IGNITE-24123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] IGNITE-23870 Implement a method to receive a chain of topology changes [ignite-3]

2024-12-27 Thread via GitHub
alievmirza commented on code in PR #4966: URL: https://github.com/apache/ignite-3/pull/4966#discussion_r1898499376 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/RebalanceUtil.java: ## @@ -490,6 +494,17 @@ public static ByteArr

Re: [PR] IGNITE-23870 Implement a method to receive a chain of topology changes [ignite-3]

2024-12-27 Thread via GitHub
sanpwc commented on code in PR #4966: URL: https://github.com/apache/ignite-3/pull/4966#discussion_r1898528666 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/RebalanceRaftGroupEventsListener.java: ## @@ -469,6 +489,67 @@ privat

Re: [PR] IGNITE-23870 Implement a method to receive a chain of topology changes [ignite-3]

2024-12-27 Thread via GitHub
sanpwc commented on code in PR #4966: URL: https://github.com/apache/ignite-3/pull/4966#discussion_r1898527437 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/RebalanceRaftGroupEventsListener.java: ## @@ -469,6 +489,67 @@ privat

Re: [PR] IGNITE-23870 Implement a method to receive a chain of topology changes [ignite-3]

2024-12-27 Thread via GitHub
Cyrill commented on code in PR #4966: URL: https://github.com/apache/ignite-3/pull/4966#discussion_r1898542062 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/RebalanceRaftGroupEventsListener.java: ## @@ -469,6 +489,67 @@ privat

Re: [PR] set default zone to HA [ignite-3]

2024-12-27 Thread via GitHub
kgusakov closed pull request #4979: set default zone to HA URL: https://github.com/apache/ignite-3/pull/4979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-27 Thread via GitHub
ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1898471783 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.a

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-27 Thread via GitHub
ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1898472228 ## modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java: ## @@ -447,6 +447,10 @@ public boolean startRaftNode(

Re: [PR] IGNITE-23746: Sql. ItSetOpTest uses incorrect optimizer hints for tests with Intersect operation [ignite-3]

2024-12-27 Thread via GitHub
zstan commented on code in PR #4775: URL: https://github.com/apache/ignite-3/pull/4775#discussion_r1898510302 ## modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItSetOpTest.java: ## @@ -141,57 +141,51 @@ public void testExceptNested(SetOpVariant

Re: [PR] IGNITE-23870 Implement a method to receive a chain of topology changes [ignite-3]

2024-12-27 Thread via GitHub
rpuch commented on code in PR #4966: URL: https://github.com/apache/ignite-3/pull/4966#discussion_r1898510316 ## modules/partition-distribution/src/main/java/org/apache/ignite/internal/partitiondistribution/AssignmentsChainSerializer.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-27 Thread via GitHub
ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1898489346 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -285,8 +289,10 @@ private class LogEntryAndClosureHandler implements EventHa

Re: [PR] IGNITE-23305 Get rid of client HybridTimestampTracker [ignite-3]

2024-12-27 Thread via GitHub
vldpyatkov commented on code in PR #4929: URL: https://github.com/apache/ignite-3/pull/4929#discussion_r1898489576 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java: ## @@ -801,13 +822,23 @@ private void processOperation(Ch

Re: [PR] IGNITE-23305 Get rid of client HybridTimestampTracker [ignite-3]

2024-12-27 Thread via GitHub
vldpyatkov merged PR #4929: URL: https://github.com/apache/ignite-3/pull/4929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-27 Thread via GitHub
ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1898489346 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -285,8 +289,10 @@ private class LogEntryAndClosureHandler implements EventHa

Re: [PR] IGNITE-23305 Get rid of client HybridTimestampTracker [ignite-3]

2024-12-27 Thread via GitHub
vldpyatkov commented on code in PR #4929: URL: https://github.com/apache/ignite-3/pull/4929#discussion_r1898489048 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java: ## @@ -985,17 +1016,26 @@ private static Object unpackEx

Re: [PR] IGNITE-23748 Lock LWM when executing RO operation on data node [ignite-3]

2024-12-27 Thread via GitHub
sanpwc commented on code in PR #4974: URL: https://github.com/apache/ignite-3/pull/4974#discussion_r1898464919 ## modules/client/src/test/java/org/apache/ignite/client/fakes/FakeInternalTable.java: ## @@ -147,6 +147,7 @@ public CompletableFuture get(BinaryRowEx keyRow, @Nullabl

Re: [PR] IGNITE-24128 Remove casts to RestartProofIgnite [ignite-3]

2024-12-27 Thread via GitHub
rpuch merged PR #4983: URL: https://github.com/apache/ignite-3/pull/4983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-23748 Lock LWM when executing RO operation on data node [ignite-3]

2024-12-27 Thread via GitHub
rpuch commented on code in PR #4974: URL: https://github.com/apache/ignite-3/pull/4974#discussion_r1898514210 ## modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/sqllogic/ItSqlLogicTest.java: ## @@ -142,6 +143,8 @@ @Tag("sqllogic") @ExtendWith({System

Re: [PR] IGNITE-23748 Lock LWM when executing RO operation on data node [ignite-3]

2024-12-27 Thread via GitHub
rpuch commented on code in PR #4974: URL: https://github.com/apache/ignite-3/pull/4974#discussion_r1898514977 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -2196,9 +2202,6 @@ private CompletableFuture

Re: [PR] IGNITE-23748 Lock LWM when executing RO operation on data node [ignite-3]

2024-12-27 Thread via GitHub
rpuch commented on code in PR #4974: URL: https://github.com/apache/ignite-3/pull/4974#discussion_r1898512641 ## modules/client/src/test/java/org/apache/ignite/client/fakes/FakeInternalTable.java: ## @@ -147,6 +147,7 @@ public CompletableFuture get(BinaryRowEx keyRow, @Nullable

Re: [PR] IGNITE-23748 Lock LWM when executing RO operation on data node [ignite-3]

2024-12-27 Thread via GitHub
rpuch commented on code in PR #4974: URL: https://github.com/apache/ignite-3/pull/4974#discussion_r1898514977 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -2196,9 +2202,6 @@ private CompletableFuture

Re: [PR] IGNITE-24025 Introduce catalog command to drop schema [ignite-3]

2024-12-27 Thread via GitHub
korlov42 commented on code in PR #4972: URL: https://github.com/apache/ignite-3/pull/4972#discussion_r1898508531 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/CatalogUtils.java: ## @@ -145,7 +147,11 @@ public class CatalogUtils { FUNCTIONA

Re: [PR] IGNITE-23870 Implement a method to receive a chain of topology changes [ignite-3]

2024-12-27 Thread via GitHub
Cyrill commented on code in PR #4966: URL: https://github.com/apache/ignite-3/pull/4966#discussion_r1898517446 ## modules/partition-distribution/src/main/java/org/apache/ignite/internal/partitiondistribution/AssignmentsChainSerializer.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed t

Re: [PR] IGNITE-23870 Implement a method to receive a chain of topology changes [ignite-3]

2024-12-27 Thread via GitHub
Cyrill commented on code in PR #4966: URL: https://github.com/apache/ignite-3/pull/4966#discussion_r1898517709 ## modules/partition-distribution/src/main/java/org/apache/ignite/internal/partitiondistribution/AssignmentsChainSerializer.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed t

Re: [PR] IGNITE-23748 Lock LWM when executing RO operation on data node [ignite-3]

2024-12-27 Thread via GitHub
rpuch commented on code in PR #4974: URL: https://github.com/apache/ignite-3/pull/4974#discussion_r1898517970 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -534,7 +540,7 @@ private CompletableFuture pr

Re: [PR] IGNITE-23870 Implement a method to receive a chain of topology changes [ignite-3]

2024-12-27 Thread via GitHub
Cyrill commented on code in PR #4966: URL: https://github.com/apache/ignite-3/pull/4966#discussion_r1898542319 ## modules/partition-distribution/src/main/java/org/apache/ignite/internal/partitiondistribution/AssignmentsChain.java: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apa

Re: [PR] IGNITE-23870 Implement a method to receive a chain of topology changes [ignite-3]

2024-12-27 Thread via GitHub
Cyrill commented on code in PR #4966: URL: https://github.com/apache/ignite-3/pull/4966#discussion_r1898546838 ## modules/partition-distribution/src/main/java/org/apache/ignite/internal/partitiondistribution/AssignmentsChain.java: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apa

Re: [PR] IGNITE-23870 Implement a method to receive a chain of topology changes [ignite-3]

2024-12-27 Thread via GitHub
Cyrill commented on code in PR #4966: URL: https://github.com/apache/ignite-3/pull/4966#discussion_r1898568865 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/disaster/ItDisasterRecoveryReconfigurationTest.java: ## @@ -1234,6 +1242,295 @@ void testTwoPhaseRe

Re: [PR] IGNITE-23748 Lock LWM when executing RO operation on data node [ignite-3]

2024-12-27 Thread via GitHub
rpuch commented on code in PR #4974: URL: https://github.com/apache/ignite-3/pull/4974#discussion_r1898574660 ## modules/transactions/src/integrationTest/java/org/apache/ignite/internal/tx/readonly/ItReadOnlyTxAndLowWatermarkTest.java: ## @@ -0,0 +1,251 @@ +/* + * Licensed to th

[PR] IGNITE-15803 Continue to remove BinaryMarshaller explicit usage in tests [ignite]

2024-12-27 Thread via GitHub
nizhikov opened a new pull request, #11784: URL: https://github.com/apache/ignite/pull/11784 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

Re: [PR] IGNITE-15083 Remove most of BinaryMarshaller from tests [ignite]

2024-12-27 Thread via GitHub
sonarqubecloud[bot] commented on PR #11764: URL: https://github.com/apache/ignite/pull/11764#issuecomment-2564006446 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

Re: [PR] IGNITE-15803 Continue to remove BinaryMarshaller explicit usage in tests [ignite]

2024-12-27 Thread via GitHub
sonarqubecloud[bot] commented on PR #11784: URL: https://github.com/apache/ignite/pull/11784#issuecomment-2564015873 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

Re: [PR] IGNITE-23870 Implement a method to receive a chain of topology changes [ignite-3]

2024-12-27 Thread via GitHub
sanpwc commented on code in PR #4966: URL: https://github.com/apache/ignite-3/pull/4966#discussion_r1898668775 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/disaster/ItDisasterRecoveryReconfigurationTest.java: ## @@ -1234,6 +1242,295 @@ void testTwoPhaseRe

Re: [PR] IGNITE-23748 Lock LWM when executing RO operation on data node [ignite-3]

2024-12-27 Thread via GitHub
sanpwc commented on code in PR #4974: URL: https://github.com/apache/ignite-3/pull/4974#discussion_r1898678135 ## modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/sqllogic/ItSqlLogicTest.java: ## @@ -142,6 +143,8 @@ @Tag("sqllogic") @ExtendWith({Syste

Re: [PR] IGNITE-23748 Lock LWM when executing RO operation on data node [ignite-3]

2024-12-27 Thread via GitHub
sanpwc commented on code in PR #4974: URL: https://github.com/apache/ignite-3/pull/4974#discussion_r1898678336 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -2196,9 +2202,6 @@ private CompletableFutur

Re: [PR] IGNITE-23748 Lock LWM when executing RO operation on data node [ignite-3]

2024-12-27 Thread via GitHub
sanpwc commented on code in PR #4974: URL: https://github.com/apache/ignite-3/pull/4974#discussion_r1898682066 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -534,7 +540,7 @@ private CompletableFuture p

Re: [PR] IGNITE-23748 Lock LWM when executing RO operation on data node [ignite-3]

2024-12-27 Thread via GitHub
sanpwc commented on code in PR #4974: URL: https://github.com/apache/ignite-3/pull/4974#discussion_r1898682996 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/network/replication/ReadOnlyReplicaRequest.java: ## @@ -17,12 +17,24 @@

Re: [PR] IGNITE-15803 Remove "instanceof BinaryMarshaller" from tests [ignite]

2024-12-27 Thread via GitHub
nizhikov merged PR #11780: URL: https://github.com/apache/ignite/pull/11780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

Re: [PR] IGNITE-21558 Sql. Remove ExecutionContext dependency from ExpressionFactory [ignite-3]

2024-12-27 Thread via GitHub
korlov42 commented on code in PR #4959: URL: https://github.com/apache/ignite-3/pull/4959#discussion_r1898365556 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/agg/AccumulatorsFactory.java: ## @@ -142,26 +142,24 @@ private static Function com

[PR] IGNITE-23893 Java thin: improve javadocs [ignite-3]

2024-12-27 Thread via GitHub
ptupitsyn opened a new pull request, #4982: URL: https://github.com/apache/ignite-3/pull/4982 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] IGNITE-24125 [ducktests] Fix JMXClient to read MBeans with names containing spaces [ignite]

2024-12-27 Thread via GitHub
sonarqubecloud[bot] commented on PR #11781: URL: https://github.com/apache/ignite/pull/11781#issuecomment-2563432338 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] IGNITE-24126 [ducktests] Fix flacky jdbc_thin_test [ignite]

2024-12-27 Thread via GitHub
sonarqubecloud[bot] commented on PR #11782: URL: https://github.com/apache/ignite/pull/11782#issuecomment-2563432635 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [I] Per-entry expiry policy [ignite]

2024-12-27 Thread via GitHub
ptupitsyn commented on issue #11775: URL: https://github.com/apache/ignite/issues/11775#issuecomment-2563437952 When you say `withExpiryPolicy`, no new cache is created. It is just a reference to the same cache, but all write operations will set the specified expiry for the entries.

Re: [PR] IGNITE-23975 SQL Calcite: Add group partitions reservation [ignite]

2024-12-27 Thread via GitHub
alex-plekhanov commented on code in PR #11758: URL: https://github.com/apache/ignite/pull/11758#discussion_r1898327564 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/PartitionReservationManager.java: ## @@ -0,0 +1,441 @@ +/* +

Re: [PR] IGNITE-23483 : Restore snapshot check from lesser topology for snapshot check distributed process. [ignite]

2024-12-27 Thread via GitHub
timoninmaxim commented on code in PR #11596: URL: https://github.com/apache/ignite/pull/11596#discussion_r1898402464 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotChecker.java: ## @@ -634,23 +634,16 @@ else if (!res.except

Re: [PR] IGNITE-21558 Sql. Remove ExecutionContext dependency from ExpressionFactory [ignite-3]

2024-12-27 Thread via GitHub
korlov42 commented on code in PR #4959: URL: https://github.com/apache/ignite-3/pull/4959#discussion_r1898365431 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/agg/AccumulatorsFactory.java: ## @@ -267,11 +265,13 @@ private final class Accumula

Re: [PR] IGNITE-24108 Fix client JMX export, fix MBean package [ignite-3]

2024-12-27 Thread via GitHub
ptupitsyn merged PR #4962: URL: https://github.com/apache/ignite-3/pull/4962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-21558 Sql. Remove ExecutionContext dependency from ExpressionFactory [ignite-3]

2024-12-27 Thread via GitHub
korlov42 merged PR #4959: URL: https://github.com/apache/ignite-3/pull/4959 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

Re: [PR] IGNITE-23305 Get rid of client HybridTimestampTracker [ignite-3]

2024-12-27 Thread via GitHub
ascherbakoff commented on code in PR #4929: URL: https://github.com/apache/ignite-3/pull/4929#discussion_r1898420260 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/HybridTimestampTracker.java: ## @@ -17,36 +17,102 @@ package org.apache.ignite.internal.tx;

Re: [PR] IGNITE-23305 Get rid of client HybridTimestampTracker [ignite-3]

2024-12-27 Thread via GitHub
ascherbakoff commented on code in PR #4929: URL: https://github.com/apache/ignite-3/pull/4929#discussion_r1898420260 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/HybridTimestampTracker.java: ## @@ -17,36 +17,102 @@ package org.apache.ignite.internal.tx;

[PR] IGNITE-23460 [ducktests] Use python 3.8 and 3.9 in the commit-check github action [ignite]

2024-12-27 Thread via GitHub
skorotkov opened a new pull request, #11785: URL: https://github.com/apache/ignite/pull/11785 …ithub action Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have bee

Re: [PR] IGNITE-23350 [ducktests] Add the Thin JDBC test for BLOBs [ignite]

2024-12-27 Thread via GitHub
skorotkov closed pull request #11723: IGNITE-23350 [ducktests] Add the Thin JDBC test for BLOBs URL: https://github.com/apache/ignite/pull/11723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] IGNITE-24025 Introduce catalog command to drop schema [ignite-3]

2024-12-27 Thread via GitHub
xtern commented on code in PR #4972: URL: https://github.com/apache/ignite-3/pull/4972#discussion_r1898868990 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/DropSchemaCommand.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] IGNITE-24025 Introduce catalog command to drop schema [ignite-3]

2024-12-27 Thread via GitHub
xtern commented on code in PR #4972: URL: https://github.com/apache/ignite-3/pull/4972#discussion_r1898868717 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/DropSchemaCommand.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] IGNITE-24025 Introduce catalog command to drop schema [ignite-3]

2024-12-27 Thread via GitHub
xtern commented on code in PR #4972: URL: https://github.com/apache/ignite-3/pull/4972#discussion_r1898869392 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/CatalogUtils.java: ## @@ -145,7 +147,11 @@ public class CatalogUtils { FUNCTIONAL_D