rpuch commented on code in PR #4974:
URL: https://github.com/apache/ignite-3/pull/4974#discussion_r1898514210
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/sqllogic/ItSqlLogicTest.java:
##########
@@ -142,6 +143,8 @@
@Tag("sqllogic")
@ExtendWith({SystemPropertiesExtension.class, WorkDirectoryExtension.class})
@WithSystemProperty(key = "IMPLICIT_PK_ENABLED", value = "true")
+// The following is to make sure we unlock LWM on data nodes promptly so that
dropped tables are destroyed fast.
+@WithSystemProperty(key =
ResourceVacuumManager.RESOURCE_VACUUM_INTERVAL_MILLISECONDS_PROPERTY, value =
"1000")
Review Comment:
Is 4 runs (which we already have) plus at least one after changes that will
be made to address review issues good enough? If not, how many will be
sufficient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
