rpuch commented on code in PR #4974:
URL: https://github.com/apache/ignite-3/pull/4974#discussion_r1898514977
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2196,9 +2202,6 @@ private <T> CompletableFuture<T> appendTxCommand(
}))
);
}
- } catch (Exception e) {
Review Comment:
It will just fly further. The code I removed would just add a wrapping
exception around it, but the exception text could easily be misleading (as an
exception can happen not just on an attempt to close the cursor).
I guess this `catch` was added when `Cursor#close()` was not declared, so
`AutoCloseable#close()` would be used, which declareds to throw `Exception`.
But we had an agreement somewhere in the past that `Cursor#close()` should not
declare anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
