vldpyatkov commented on code in PR #4929:
URL: https://github.com/apache/ignite-3/pull/4929#discussion_r1898489576
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -801,13 +822,23 @@ private void processOperation(ChannelHandlerContext ctx,
ClientMessageUnpacker i
return ClientJdbcFinishTxRequest.process(in, out,
jdbcQueryEventHandler);
case ClientOp.SQL_EXEC_SCRIPT:
- return ClientSqlExecuteScriptRequest.process(in,
queryProcessor, igniteTransactions);
+ return ClientSqlExecuteScriptRequest.process(in,
queryProcessor).thenRun(() -> {
+ // TODO: IGNITE-24055 Observation timestamp must be
updated only for DDL "CREATE TABLE..."
+ if (!(out.meta() instanceof HybridTimestamp)) {
+ out.meta(clockService.current());
+ }
+ });
case ClientOp.SQL_QUERY_META:
return ClientSqlQueryMetadataRequest.process(in, out,
queryProcessor, resources);
case ClientOp.SQL_EXEC_BATCH:
- return ClientSqlExecuteBatchRequest.process(in, out,
queryProcessor, resources, igniteTransactions);
+ return ClientSqlExecuteBatchRequest.process(in, out,
queryProcessor, resources).thenRun(() -> {
+ // TODO: IGNITE-24055 Observation timestamp must be
updated only for DDL "CREATE TABLE..."
Review Comment:
I changed this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
