rpuch commented on code in PR #4974:
URL: https://github.com/apache/ignite-3/pull/4974#discussion_r1898517970
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -534,7 +540,7 @@ private CompletableFuture<?> processRequest(ReplicaRequest
request, @Nullable Bo
// Don't need to validate schema.
if (opTs == null) {
assert opTsIfDirectRo == null;
- return processOperationRequestWithTxRwCounter(senderId, request,
isPrimary, null, leaseStartTime);
+ return processOperationRequestWithWrappingLogic(senderId, request,
isPrimary, null, leaseStartTime);
Review Comment:
This method now adds wrapping related to:
1. RW operation counting
2. RO operation LWM locking/unlocking
The old name only mentioned 1 and now became 'not completely true'. Adding
another suffix to mention RO+LWM to the existing one would produce a
monstrosity. That's why I chose a generic name that says that it adds some
wrapping.
Do you have a specific idea on how to improve this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
