[PATCH] ila: Fix rhashtable walker list corruption

2019-03-25 Thread Herbert Xu
ila_xlat_nl_cmd_flush uses rhashtable walkers allocated from the stack but it never frees them. This corrupts the walker list of the hash table. This patch fixes it. Reported-by: syzbot+dae72a112334aa65a...@syzkaller.appspotmail.com Fixes: b6e71bdebb12 ("ila: Flush netlink command to clear xlat.

Re: [PATCH bpf-next 0/7] bpf: Propagate cn to TCP

2019-03-25 Thread Alexei Starovoitov
On Mon, Mar 25, 2019 at 01:48:27AM -0700, Eric Dumazet wrote: > > > On 03/25/2019 01:33 AM, Eric Dumazet wrote: > > > > > > On 03/24/2019 09:19 AM, Alexei Starovoitov wrote: > > >> Cover letter also explains why bpf_skb_ecn_set_ce is not enough. > >> Please realize that existing qdiscs already

Re: [RFC PATCH net-next 01/13] lib: Add support for generic packing operations

2019-03-25 Thread Richard Cochran
On Sun, Mar 24, 2019 at 10:32:03PM +0200, Vladimir Oltean wrote: > I didn't want to pollute LKML with the entire driver patchset from the > get-go, just receive some initial feedback from netdev first (hence the > RFC). > How should I proceed? Should I resend just this patch to LKML, or a v2 > patc

[PATCH net-next v3] openvswitch: Make metadata_dst tunnel work in IP_TUNNEL_INFO_BRIDGE mode

2019-03-25 Thread wenxu
From: wenxu There is currently no support for the multicast/broadcast aspects of VXLAN in ovs. In the datapath flow the tun_dst must specific. But in the IP_TUNNEL_INFO_BRIDGE mode the tun_dst can not be specific. And the packet can forward through the fdb table of vxlan devcice. In this mode the

Re: [PATCH net-next] ipv6: Move ipv6 stubs to a separate header file

2019-03-25 Thread Alexei Starovoitov
On Mon, Mar 25, 2019 at 11:02:07AM -0600, David Ahern wrote: > > That is followed by refactoring IPv6 again in a direction that makes > IPv4 and IPv6 more consistent and enables changes (outside of the > nexthop sets) that will improve IPv6 for a number of cases by removing > the need to always ge

Re: [RFC PATCH net-next 09/13] net: dsa: sja1105: Add support for ethtool port counters

2019-03-25 Thread Florian Fainelli
On 3/23/2019 8:23 PM, Vladimir Oltean wrote: > Signed-off-by: Vladimir Oltean > --- [snip] > + > +int sja1105_get_sset_count(struct dsa_switch *ds, int port, int sset) > +{ > + int count = ARRAY_SIZE(sja1105_port_stats); > + struct sja1105_private *priv = ds->priv; There is a missing

Re: [RFC PATCH net-next 08/13] net: dsa: sja1105: Add support for VLAN operations

2019-03-25 Thread Florian Fainelli
On 3/23/2019 8:23 PM, Vladimir Oltean wrote: > VLAN filtering cannot be properly disabled in SJA1105. So in order to > emulate the "no VLAN awareness" behavior (not dropping traffic that is > tagged with a VID that isn't configured on the port), we need to hack > another switch feature: programm

Re: [RFC PATCH net-next 07/13] net: dsa: sja1105: Add support for FDB and MDB management

2019-03-25 Thread Florian Fainelli
On 3/23/2019 8:23 PM, Vladimir Oltean wrote: > Currently only the (more difficult) first generation E/T series is > supported. Here the TCAM is only 4-way associative, and to know where > the hardware will search for a FDB entry, we need to perform the same > hash algorithm in order to install t

Re: [RFC PATCH net-next 12/13] Documentation: networking: dsa: Add details about NXP SJA1105 driver

2019-03-25 Thread Florian Fainelli
On 3/23/2019 8:23 PM, Vladimir Oltean wrote: > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [RFC PATCH net-next 10/13] net: dsa: sja1105: Add support for traffic through standalone ports

2019-03-25 Thread Florian Fainelli
On 3/23/2019 8:23 PM, Vladimir Oltean wrote: > In order to support this, we are creating a make-shift switch tag out of > a VLAN trunk configured on the CPU port. Termination on switch ports > only works when not under a vlan_filtering bridge. We are making use of > the generic CONFIG_NET_DSA_TA

Re: [RFC PATCH net-next 13/13] dt-bindings: net: dsa: Add documentation for NXP SJA1105 driver

2019-03-25 Thread Florian Fainelli
On 3/23/2019 8:23 PM, Vladimir Oltean wrote: > Signed-off-by: Vladimir Oltean > --- > .../devicetree/bindings/net/dsa/sja1105.txt | 123 ++ > 1 file changed, 123 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/dsa/sja1105.txt > > diff --git a/Docume

Re: [PATCH net-next] ipv6: Move ipv6 stubs to a separate header file

2019-03-25 Thread David Ahern
On 3/24/19 9:26 PM, Alexei Starovoitov wrote: > The kernel has to be fast as a dataplane but these extra features > will slow down the routing by making kernel-as-database scale a bit better. I took Vincent Bernat's fib lookup microbenchmark and added input and output route lookups to it. Through

Re: [RFC PATCH net-next 05/13] net: dsa: Optional VLAN-based port separation for switches without tagging

2019-03-25 Thread Florian Fainelli
On 3/23/2019 8:23 PM, Vladimir Oltean wrote: > This patch provides generic DSA code for using VLAN (802.1Q) tags for > the same purpose as a dedicated switch tag for injection/extraction. > It is based on the discussions and interest that has been so far > expressed in https://www.spinics.net/li

[PATCH v2 net-next] net: openvswitch: Add a new action check_pkt_len

2019-03-25 Thread nusiddiq
From: Numan Siddique This patch adds a new action - 'check_pkt_len' which checks the packet length and executes a set of actions if the packet length is greater than the specified length or executes another set of actions if the packet length is lesser or equal to. This action takes below nlattr

[PATCH v2 bpf-next 00/21] bpf: Sysctl hook

2019-03-25 Thread Andrey Ignatov
v1->v2: - add fs/proc/proc_sysctl.c mainteners to Cc:. The patch set introduces new BPF hook for sysctl. It adds new program type BPF_PROG_TYPE_CGROUP_SYSCTL and attach type BPF_CGROUP_SYSCTL. BPF_CGROUP_SYSCTL hook is placed before calling to sysctl's proc_handler so that accesses (read/write)

Re: [RFC bpf-next v3 6/8] flow_dissector: handle no-skb use case

2019-03-25 Thread Alexei Starovoitov
On Sat, Mar 23, 2019 at 09:05:31AM -0700, Stanislav Fomichev wrote: > On 03/22, Alexei Starovoitov wrote: > > On Fri, Mar 22, 2019 at 06:19:57PM -0700, Stanislav Fomichev wrote: > > > Are we ok with breaking api in this case? I'm all in on removing this > > > extra information. We can always put it

Re: [PATCH net] net: phy: don't clear BMCR in genphy_soft_reset

2019-03-25 Thread David Miller
From: Heiner Kallweit Date: Fri, 22 Mar 2019 20:00:20 +0100 > So far we effectively clear the BMCR register. Some PHY's can deal > with this (e.g. because they reset BMCR to a default as part of a > soft-reset) whilst on others this causes issues because e.g. the > autoneg bit is cleared. Marvell

Re: random crashes, kdump and so on

2019-03-25 Thread Reindl Harald
Am 25.03.19 um 22:58 schrieb Cong Wang: > On Mon, Mar 25, 2019 at 2:37 PM Reindl Harald wrote: >> >> Am 25.03.19 um 20:07 schrieb Cong Wang: >>> On Mon, Mar 25, 2019 at 5:08 AM Reindl Harald >>> wrote: besides that i get tired about random crashes over the last months (yeah the

Re: random crashes, kdump and so on

2019-03-25 Thread Cong Wang
On Mon, Mar 25, 2019 at 2:37 PM Reindl Harald wrote: > > > > Am 25.03.19 um 20:07 schrieb Cong Wang: > > On Mon, Mar 25, 2019 at 5:08 AM Reindl Harald > > wrote: > >> > >> besides that i get tired about random crashes over the last months (yeah > >> the connlimit crashes are fixed in the meantim

[PATCH net-next v3 2/2] openvswitch: Add timeout support to ct action

2019-03-25 Thread Yi-Hung Wei
Add support for fine-grain timeout support to conntrack action. The new OVS_CT_ATTR_TIMEOUT attribute of the conntrack action specifies a timeout to be associated with this connection. If no timeout is specified, it acts as is, that is the default timeout for the connection will be automatically ap

[PATCH net-next v3 1/2] netfilter: Export nf_ct_{set,destroy}_timeout()

2019-03-25 Thread Yi-Hung Wei
This patch exports nf_ct_set_timeout() and nf_ct_destroy_timeout(). The two functions are derived from xt_ct_destroy_timeout() and xt_ct_set_timeout() in xt_CT.c, and moved to nf_conntrack_timeout.c without any functional change. It would be useful for other users (i.e. OVS) that utilizes the finer

Re: random crashes, kdump and so on

2019-03-25 Thread Reindl Harald
Am 25.03.19 um 20:07 schrieb Cong Wang: > On Mon, Mar 25, 2019 at 5:08 AM Reindl Harald wrote: >> >> besides that i get tired about random crashes over the last months (yeah >> the connlimit crashes are fixed in the meantime but there is still >> something broken) which are pretty sure in the n

[PATCH net] MAINTAINERS: Fix documentation file name for PHY Library

2019-03-25 Thread Florian Fainelli
MAINTAINERS still pointed to phy.txt after moving this file into the rst format, fix this. Reported-by: Joe Perches Fixes: 25fe02d00a1e ("Documentation: net: phy: switch documentation to rst format") Signed-off-by: Florian Fainelli --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH net-next] net: openvswitch: Add a new action check_pkt_len

2019-03-25 Thread Pravin Shelar
On Sun, Mar 24, 2019 at 11:47 AM wrote: > > From: Numan Siddique > > This patch adds a new action - 'check_pkt_len' which checks the > packet length and executes a set of actions if the packet > length is greater than the specified length or executes > another set of actions if the packet length

Re: [PATCH net-next] tcp: fix zerocopy and notsent_lowat issues

2019-03-25 Thread Willem de Bruijn
On Mon, Mar 25, 2019 at 4:48 PM Soheil Hassas Yeganeh wrote: > > On Mon, Mar 25, 2019 at 4:44 PM Eric Dumazet wrote: > > > > My recent patch had at least two problems : > > > > 1) TX zerocopy wants notification when skb is acknowledged, > >thus we need to call skb_zcopy_clear() if the skb is

Re: [PATCH net-next] tcp: fix zerocopy and notsent_lowat issues

2019-03-25 Thread Soheil Hassas Yeganeh
On Mon, Mar 25, 2019 at 4:44 PM Eric Dumazet wrote: > > My recent patch had at least two problems : > > 1) TX zerocopy wants notification when skb is acknowledged, >thus we need to call skb_zcopy_clear() if the skb is >cached into sk->sk_tx_skb_cache > > 2) Some applications might expect p

[PATCH net-next] tcp: fix zerocopy and notsent_lowat issues

2019-03-25 Thread Eric Dumazet
My recent patch had at least two problems : 1) TX zerocopy wants notification when skb is acknowledged, thus we need to call skb_zcopy_clear() if the skb is cached into sk->sk_tx_skb_cache 2) Some applications might expect precise EPOLLOUT notifications, so we need to update sk->sk_wmem_

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-25 Thread Parav Pandit
> -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Parav Pandit > Sent: Friday, March 22, 2019 7:40 PM > To: Jiri Pirko > Cc: Jakub Kicinski ; Samudrala, Sridhar > ; da...@davemloft.net; > netdev@vger.kernel.org; oss-driv...@netronome.com > Subject: RE: [PATCH net-

[net-next 06/15] ice: Pull out page reuse checks onto separate function

2019-03-25 Thread Jeff Kirsher
From: Maciej Fijalkowski Introduce ice_can_reuse_rx_page which will verify whether the page can be reused and return the boolean result to caller. Signed-off-by: Maciej Fijalkowski Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/eth

[net-next 13/15] ice: change VF VSI tc info along with num_queues

2019-03-25 Thread Jeff Kirsher
From: Preethi Banala Update VF VSI tc info along with vsi->num_txq/num_rxq when VF requests to configure queues. Signed-off-by: Preethi Banala Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 3

[net-next 04/15] ice: Enable link events over the ARQ

2019-03-25 Thread Jeff Kirsher
From: Brett Creeley The hardware now supports link events over the admin receive queue (ARQ), so enable HW link events over the ARQ and remove code for link event polling. Signed-off-by: Brett Creeley Reviewed-by: Bruce Allan Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Sig

[net-next 08/15] ice: Introduce bulk update for page count

2019-03-25 Thread Jeff Kirsher
From: Maciej Fijalkowski {get,put}_page are atomic operations which we use for page count handling. The current logic for refcount handling is that we increment it when passing a skb with the data from the first half of page up to netstack and recycle the second half of page. This operation prote

[net-next 11/15] ice: map Rx buffer pages with DMA attributes

2019-03-25 Thread Jeff Kirsher
From: Maciej Fijalkowski Provide DMA_ATTR_WEAK_ORDERING and DMA_ATTR_SKIP_CPU_SYNC attributes to the DMA API during the mapping operations on Rx side. With this change the non-x86 platforms will be able to sync only with what is being used (2k buffer) instead of entire page. This should yield a s

[net-next 05/15] ice: Retrieve rx_buf in separate function

2019-03-25 Thread Jeff Kirsher
From: Maciej Fijalkowski Introduce ice_get_rx_buf, which will fetch the Rx buffer and do the DMA synchronization. Length of the packet that hardware Rx descriptor contains is now read in ice_clean_rx_irq, so we can feed ice_get_rx_buf with it and resign from rx_desc passed as argument in ice_fetc

[net-next 09/15] ice: Gather the rx buf clean-up logic for better reuse

2019-03-25 Thread Jeff Kirsher
From: Maciej Fijalkowski Pull out the code responsible for page counting and buffer recycling so that it will be possible to clean up the Rx buffers in cases where we won't allocate skb (ex. XDP) Signed-off-by: Maciej Fijalkowski Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers

[net-next 01/15] ice: update VSI config dynamically

2019-03-25 Thread Jeff Kirsher
From: Victor Raj When VSI increases the number of queues dynamically, the scheduler just needs to add the new required nodes rather than re-adjusting with previously allocated number of nodes. Readjusting didn't provide enough parents to add the upper layer nodes also can't place lan and rdma sub

[net-next 14/15] ice: add and use new ice_for_each_traffic_class() macro

2019-03-25 Thread Jeff Kirsher
From: Bruce Allan There are numerous for() loops iterating over each of the max traffic classes. Use a simple iterator macro instead to make the code cleaner. Signed-off-by: Bruce Allan Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/n

[net-next 03/15] ice: use irq_num var in ice_vsi_req_irq_msix

2019-03-25 Thread Jeff Kirsher
From: Alan Brady Someone went through the effort of making this a variable so let's use it instead of recalculating it again. Signed-off-by: Alan Brady Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_main.c |

[net-next 07/15] ice: Get rid of ice_pull_tail

2019-03-25 Thread Jeff Kirsher
From: Maciej Fijalkowski Instead of adding a frag and later when dealing with EOP frame accessing that frag in order to copy the headers onto linear part of skb, we can do this in ice_add_rx_frag in case where the data_len is still 0 and frame won't fit onto the linear part as a whole. Function

[net-next 02/15] ice: Restore VLAN switch rule if port VLAN existed before

2019-03-25 Thread Jeff Kirsher
From: Michal Swiatkowski The VLAN rule is lost when VM starts or the AVF driver (iavf.ko) is reloaded. So it is necessary to add this rule again. Signed-off-by: Michal Swiatkowski Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethe

[net-next 12/15] ice: Prevent unintended multiple chain resets

2019-03-25 Thread Jeff Kirsher
From: Dave Ertman In the current implementation of ice_reset_subtask, if multiple reset types are set in the pf->state, the most intrusive one is meant to be performed only, but the bits requesting the other types are not being cleared. This would lead to another reset being performed the next ti

[net-next 10/15] ice: Limit the ice_add_rx_frag to frag addition

2019-03-25 Thread Jeff Kirsher
From: Maciej Fijalkowski Refactor ice_fetch_rx_buf and ice_add_rx_frag in a way that we have standalone functions that do either the skb construction or frag addition to previously constructed skb. The skb handling between rx_bufs is spread among various functions. The ice_get_rx_buf will retrie

[net-next 15/15] ice: Create a generic name for the ice_rx_flg64_bits structure

2019-03-25 Thread Jeff Kirsher
From: Chinh T Cao This structure is used to define the packet flags. These flags are applicable for both TX and RX packet. Thus, this patch changes its name from ice_rx_flag64_bits to ice_flg64_bits, and its member definition. Signed-off-by: Chinh T Cao Reviewed-by: Bruce Allan Signed-off-by:

[net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2019-03-25

2019-03-25 Thread Jeff Kirsher
This series contains updates to the ice driver only. Victor updates the ice driver to be able to update the VSI queue configuration dynamically, by providing the ability to increase or decrease the VSI's number of queues. Michal fixes an issue when the VM starts or the VF driver is reloaded, the

Re: [PATCH net-next 1/1] net: dsa: qca8k: Fix internal PHY MDIO address

2019-03-25 Thread Marek Behun
> Any news regarding your test? No, sorry, I fell ill and don't have that specific hardware at home, only at work. I will probably test it on thursday or friday. Marek

Re: [PATCH net-next v2] openvswitch: Make metadata_dst tunnel work in IP_TUNNEL_INFO_BRIDGE mode

2019-03-25 Thread Pravin Shelar
On Sat, Mar 23, 2019 at 4:03 AM wrote: > > From: wenxu > > There is currently no support for the multicast/broadcast aspects > of VXLAN in ovs. In the datapath flow the tun_dst must specific. > But in the IP_TUNNEL_INFO_BRIDGE mode the tun_dst can not be specific. > And the packet can forward thr

Re: [PATCH net-next] openvswitch: Make metadata_dst tunnel work in IP_TUNNEL_INFO_BRIDGE mode

2019-03-25 Thread Pravin Shelar
On Sun, Mar 24, 2019 at 6:24 PM wenxu wrote: > > On 2019/3/25 上午2:46, Pravin Shelar wrote: > > On Sun, Mar 24, 2019 at 12:03 AM wenxu wrote: > >> On 2019/3/24 上午5:39, Pravin Shelar wrote: > >>> On Sat, Mar 23, 2019 at 2:18 AM wenxu wrote: > On 2019/3/23 下午3:50, Pravin Shelar wrote: > >

Re: [PATCH net-next v2 2/2] net: phy: marvell: add PHY tunable fast link down support for 88E1540

2019-03-25 Thread Florian Fainelli
On 3/25/19 12:13 PM, Heiner Kallweit wrote: > On 25.03.2019 19:44, Florian Fainelli wrote: >> On 3/25/19 11:35 AM, Heiner Kallweit wrote: >>> 1000BaseT standard requires that a link is reported as down earliest >>> after 750ms. Several use case however require a much faster detecion >>> of a broken

Re: [RFC PATCH 1/1 v2] net: sched: Introduce conndscp action

2019-03-25 Thread Cong Wang
On Sat, Mar 23, 2019 at 10:45 AM Kevin 'ldir' Darbyshire-Bryant wrote: > > I will remove the functionality from conndscp that changes the conntrack > mark, so that it only restores the mark into the diffserv field. > > So that I’m clear about which direction I should be headed: > > Bearing in min

Re: [PATCH net-next v2 2/2] net: phy: marvell: add PHY tunable fast link down support for 88E1540

2019-03-25 Thread Heiner Kallweit
On 25.03.2019 19:44, Florian Fainelli wrote: > On 3/25/19 11:35 AM, Heiner Kallweit wrote: >> 1000BaseT standard requires that a link is reported as down earliest >> after 750ms. Several use case however require a much faster detecion >> of a broken link. Fast Link Down supports this by intentional

Re: random crashes, kdump and so on

2019-03-25 Thread Cong Wang
On Mon, Mar 25, 2019 at 5:08 AM Reindl Harald wrote: > > besides that i get tired about random crashes over the last months (yeah > the connlimit crashes are fixed in the meantime but there is still > something broken) which are pretty sure in the netedev/netfilter area > and "kernel.panic = 1" is

Re: [PATCH net-next v2 1/2] ethtool: add PHY Fast Link Down support

2019-03-25 Thread Michal Kubecek
On Mon, Mar 25, 2019 at 07:34:58PM +0100, Heiner Kallweit wrote: > This adds support for Fast Link Down as new PHY tunable. > Fast Link Down reduces the time until a link down event is reported > for 1000BaseT. According to the standard it's 750ms what is too long > for several use cases. > > v2:

Re: [PATCH net-next v2 2/2] net: phy: marvell: add PHY tunable fast link down support for 88E1540

2019-03-25 Thread Florian Fainelli
On 3/25/19 11:35 AM, Heiner Kallweit wrote: > 1000BaseT standard requires that a link is reported as down earliest > after 750ms. Several use case however require a much faster detecion > of a broken link. Fast Link Down supports this by intentionally > violating a the standard. This patch exposes

Re: [PATCH net-next v2 1/2] ethtool: add PHY Fast Link Down support

2019-03-25 Thread Florian Fainelli
On 3/25/19 11:34 AM, Heiner Kallweit wrote: > This adds support for Fast Link Down as new PHY tunable. > Fast Link Down reduces the time until a link down event is reported > for 1000BaseT. According to the standard it's 750ms what is too long > for several use cases. > > v2: > - add comment descr

[PATCH net-next v2 2/2] net: phy: marvell: add PHY tunable fast link down support for 88E1540

2019-03-25 Thread Heiner Kallweit
1000BaseT standard requires that a link is reported as down earliest after 750ms. Several use case however require a much faster detecion of a broken link. Fast Link Down supports this by intentionally violating a the standard. This patch exposes the Fast Link Down feature of 88E1540 and 88E6390. T

[PATCH net-next v2 1/2] ethtool: add PHY Fast Link Down support

2019-03-25 Thread Heiner Kallweit
This adds support for Fast Link Down as new PHY tunable. Fast Link Down reduces the time until a link down event is reported for 1000BaseT. According to the standard it's 750ms what is too long for several use cases. v2: - add comment describing the constants Signed-off-by: Heiner Kallweit ---

[PATCH net-next v2 0/2] ethtool: add support for Fast Link Down as new PHY tunable

2019-03-25 Thread Heiner Kallweit
This adds support for Fast Link Down as new PHY tunable. Fast Link Down reduces the time until a link down event is reported for 1000BaseT. According to the standard it's 750ms what is too long for several use cases. This is the kernel-related series, the ethtool userspace extension I'd submit onc

Re: [PATCH v2 5/5] net/core: Allow the compiler to verify declaration and definition consistency

2019-03-25 Thread Sabrina Dubroca
2019-03-25, 09:17:23 -0700, Bart Van Assche wrote: > diff --git a/net/core/datagram.h b/net/core/datagram.h > new file mode 100644 > index ..bcfb75bfa3b2 > --- /dev/null > +++ b/net/core/datagram.h > @@ -0,0 +1,15 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +#ifndef _NET_CORE_DAT

Re: [PATCH net-next 1/2] ethtool: add PHY Fast Link Down support

2019-03-25 Thread Heiner Kallweit
On 25.03.2019 18:49, Michal Kubecek wrote: > On Sun, Mar 24, 2019 at 04:02:43PM +0100, Heiner Kallweit wrote: >> This adds support for Fast Link Down as new PHY tunable. >> Fast Link Down reduces the time until a link down event is reported >> for 1000BaseT. According to the standard it's 750ms wha

Re: [PATCH net-next 1/2] ethtool: add PHY Fast Link Down support

2019-03-25 Thread Michal Kubecek
On Sun, Mar 24, 2019 at 04:02:43PM +0100, Heiner Kallweit wrote: > This adds support for Fast Link Down as new PHY tunable. > Fast Link Down reduces the time until a link down event is reported > for 1000BaseT. According to the standard it's 750ms what is too long > for several use cases. > > Sign

Re: [PATCH net-next 1/1] net: dsa: qca8k: Fix internal PHY MDIO address

2019-03-25 Thread Christian Lamparter
On Thursday, March 21, 2019 8:55:55 PM CET Marek Behun wrote: > Hi, > > Oh, I didn't know about Christian's patch. > > I shall test on our device tomorrow. If it works, we will use internal > PHY access. > > But I think that qca8k_port_to_phy should be used in the external mode > as well. On our

Re: [PATCH bpf-next 00/21] bpf: Sysctl hook

2019-03-25 Thread Andrey Ignatov
Daniel Borkmann [Mon, 2019-03-25 03:27 -0700]: > Hi Andrey, Hi Daniel, > On 03/24/2019 01:12 AM, Andrey Ignatov wrote: > > The patch set introduces new BPF hook for sysctl. ... > The change in patch 2 which this whole series is centered around would > need a consent from fs maintainers: > > dif

Re: [RFC PATCH net-next 03/13] net: dsa: Create a more convenient function for installing port VLANs

2019-03-25 Thread Florian Fainelli
On 3/23/19 8:23 PM, Vladimir Oltean wrote: > This refactors the two-phase transaction from dsa_slave_vlan_rx_add_vid > and also makes that code available for other functions from within DSA. > The newly exposed function either adds or deletes the specified VLAN > entry based on a boolean argument.

Re: [PATCH net-next] ipv6: Move ipv6 stubs to a separate header file

2019-03-25 Thread David Ahern
On 3/24/19 9:26 PM, Alexei Starovoitov wrote: > On Sun, Mar 24, 2019 at 06:56:42AM -0600, David Ahern wrote: >> >> This change also enables many other key features: >> 1. IPv4 multipath routes are not evicted just because 1 hop goes down. >> 2. IPv6 multipath routes with device only nexthops (e.g.,

Re: [RFC PATCH net-next 04/13] net: dsa: Call driver's setup callback after setting up its switchdev notifier

2019-03-25 Thread Florian Fainelli
On 3/23/19 8:23 PM, Vladimir Oltean wrote: > This allows the driver to perform some manipulations of its own during > setup, using generic code. > One current usage scenario is for the driver to request DSA to set up > 802.1Q based switch tagging for its ports. > > Signed-off-by: Vladimir Oltean

Re: [PATCH bpf-next] selftests: bpf: don't depend on hardcoded perf sample_freq

2019-03-25 Thread Stanislav Fomichev
On 03/25, Daniel Borkmann wrote: > On 03/19/2019 10:53 PM, Stanislav Fomichev wrote: > > When running stacktrace_build_id_nmi, try to query > > kernel.perf_event_max_sample_rate sysctl and use it as a sample_freq. > > If there was an error reading sysctl, fallback to 5000. > > > > kernel.perf_even

Re: [RFC PATCH net-next 02/13] net: dsa: Store vlan_filtering as a property of dsa_port

2019-03-25 Thread Florian Fainelli
On 3/23/19 8:23 PM, Vladimir Oltean wrote: > This allows drivers to query the VLAN setting imposed by the bridge > driver directly from DSA, instead of keeping their own state based on > the .port_vlan_filtering callback. > > Signed-off-by: Vladimir Oltean After you address Andrew's comment: Re

RE: WARNING: locking bug in icmp_send

2019-03-25 Thread Jon Maloy
Yet another duplicate of syzbot+a25307ad099309f1c...@syzkaller.appspotmail.com A fix has been posted. ///jon > -Original Message- > From: netdev-ow...@vger.kernel.org > On Behalf Of syzbot > Sent: 23-Mar-19 19:03 > To: da...@davemloft.net; Jon Maloy ; > kuz...@ms2.inr.ac.ru; linux-ker

Re: [RFC PATCH net-next 00/13] NXP SJA1105 DSA driver

2019-03-25 Thread Florian Fainelli
On 3/23/19 8:23 PM, Vladimir Oltean wrote: > This patchset adds a DSA driver for the SPI-managed NXP SJA1105 driver. > Due to the hardware's unfriendliness, most of its state needs to be > shadowed in kernel memory by the driver. To support this and keep a > decent amount of cleanliness in the code

[PATCH v2 4/5] net/core: Fix rtnetlink kernel-doc headers

2019-03-25 Thread Bart Van Assche
This patch avoids that the following warnings are reported when building with W=1: net/core/rtnetlink.c:3580: warning: Function parameter or member 'ndm' not described in 'ndo_dflt_fdb_add' net/core/rtnetlink.c:3580: warning: Function parameter or member 'tb' not described in 'ndo_dflt_fdb_add'

[PATCH v2 5/5] net/core: Allow the compiler to verify declaration and definition consistency

2019-03-25 Thread Bart Van Assche
Instead of declaring a function in a .c file, declare it in a header file and include that header file from the source files that define and that use the function. That allows the compiler to verify consistency of declaration and definition. See also commit 52267790ef52 ("sock: add MSG_ZEROCOPY") #

[PATCH v2 0/5] Fix net/core W=1 warnings

2019-03-25 Thread Bart Van Assche
Hi Dave, This patch series addresses the compiler warnings reported when building the code in net/core with W=1. Please consider this patch series for kernel v5.2. Thanks, Bart. Changes compared to v1: - Dropped two patches from this series. - Rebased this patch series on top of git://git.ker

[PATCH v2 1/5] net/core: Document reuseport_add_sock() bind_inany argument

2019-03-25 Thread Bart Van Assche
This patch avoids that the following warning is reported when building with W=1: warning: Function parameter or member 'bind_inany' not described in 'reuseport_add_sock' Cc: Martin KaFai Lau Fixes: 2dbb9b9e6df6 ("bpf: Introduce BPF_PROG_TYPE_SK_REUSEPORT") # v4.19. Signed-off-by: Bart Van Assch

[PATCH v2 3/5] net/core: Document __skb_flow_dissect() flags argument

2019-03-25 Thread Bart Van Assche
This patch avoids that the following warning is reported when building with W=1: warning: Function parameter or member 'flags' not described in '__skb_flow_dissect' Cc: Tom Herbert Fixes: cd79a2382aa5 ("flow_dissector: Add flags argument to skb_flow_dissector functions") # v4.3. Signed-off-by:

[PATCH v2 2/5] net/core: Document all dev_ioctl() arguments

2019-03-25 Thread Bart Van Assche
This patch avoids that the following warnings are reported when building with W=1: net/core/dev_ioctl.c:378: warning: Function parameter or member 'ifr' not described in 'dev_ioctl' net/core/dev_ioctl.c:378: warning: Function parameter or member 'need_copyout' not described in 'dev_ioctl' net/co

Re: [PATCH bpf-next] bpf, doc: fix BTF docs reflow of bullet list

2019-03-25 Thread Andrii Nakryiko
On 3/25/19 7:12 AM, Jesper Dangaard Brouer wrote: > Section 2.2.1 BTF_KIND_INT a bullet list was collapsed due to > text reflow in commit 9ab5305dbe3f ("docs/btf: reflow text to > fill up to 78 characters"). > > This patch correct the mistake. Also adjust next bullet list, > which is used for compa

Re: [PATCH v2] net: use bulk free in kfree_skb_list

2019-03-25 Thread Jesper Dangaard Brouer
On Mon, 25 Mar 2019 10:35:35 +0100 Felix Fietkau wrote: > On 2019-03-25 10:31, Eric Dumazet wrote: > > On 03/25/2019 02:09 AM, Felix Fietkau wrote: > >> On 2019-03-25 09:51, Eric Dumazet wrote: > >>> On 03/24/2019 09:56 AM, Felix Fietkau wrote: > > Since we're freeing multiple skbs

Re: [PATCH 7/7] net/utils: Use strlcpy() instead of open-coding it

2019-03-25 Thread Bart Van Assche
On Fri, 2019-03-22 at 18:46 +, Rustad, Mark D wrote: > This doesn't look right to me. The original code seemingly would stop the > copy before getting to a possible '%' character. The new code only stops at > eol. So this appears to change the functionality and I assume is broken in > any

Re: [PATCH v3] net: use bulk free in kfree_skb_list

2019-03-25 Thread Jesper Dangaard Brouer
On Mon, 25 Mar 2019 02:27:14 -0700 Eric Dumazet wrote: > > +#ifdef CONFIG_SLUB > > + /* SLUB writes into objects when freeing */ > > + prefetchw(segs); > > +#endif > > This is done too late : > You should probably either remove this prefetchw() > or do it before reading se

Re: [PATCH net-next] ipv6: Move ipv6 stubs to a separate header file

2019-03-25 Thread Stephen Suryaputra
Just a comment: on the system that I work on, the kernel closely matches the hardware data plane, so the kernel has both roles as data and control plane. Whatever routes are installed on the hardware are installed also in the kernel. On Sun, Mar 24, 2019 at 11:27 PM Alexei Starovoitov wrote: > >

[PATCH bpf-next] bpf, doc: fix BTF docs reflow of bullet list

2019-03-25 Thread Jesper Dangaard Brouer
Section 2.2.1 BTF_KIND_INT a bullet list was collapsed due to text reflow in commit 9ab5305dbe3f ("docs/btf: reflow text to fill up to 78 characters"). This patch correct the mistake. Also adjust next bullet list, which is used for comparison, to get rendered the same way. Fixes: 9ab5305dbe3f ("d

Re: [PATCH v4 bpf-next 1/3] bpf: add bpf_progenyof helper

2019-03-25 Thread Daniel Borkmann
On 03/22/2019 11:38 PM, Javier Honduvilla Coto wrote: > This patch adds the bpf_progenyof helper which receives a PID and returns > 1 if the process currently being executed is in the process hierarchy > including itself or 0 if not. > > This is very useful in tracing programs when we want to filt

Re: [PATCH bpf-next] bpf: test_tc_tunnel.sh needs reverse path filtering disabled

2019-03-25 Thread Daniel Borkmann
On 03/25/2019 10:36 AM, Alan Maguire wrote: > test_tc_tunnel.sh sets up a pair of namespaces connected by a > veth pair to verify encap/decap using bpf_skb_adjust_room. In > testing this, it uses tunnel links as the peer of the bpf-based > encap/decap. However because the same IP header is used f

[PATCH net-next] dpaa2-eth: use netif_receive_skb_list

2019-03-25 Thread Ioana Ciornei
Take advantage of the software Rx batching by using netif_receive_skb_list instead of napi_gro_receive. Signed-off-by: Ioana Ciornei --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 8 +++- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h | 1 + 2 files changed, 8 insertions(+), 1 dele

[PATCH ipsec] esp4: add length check for UDP encapsulation

2019-03-25 Thread Sabrina Dubroca
esp_output_udp_encap can produce a length that doesn't fit in the 16 bits of a UDP header's length field. In that case, we'll send a fragmented packet whose length is larger than IP_MAX_MTU (resulting in "Oversized IP packet" warnings on receive) and with a bogus UDP length. To prevent this, add a

[PATCH net] net: datagram: fix unbounded loop in __skb_try_recv_datagram()

2019-03-25 Thread Paolo Abeni
Christoph reported a stall while peeking datagram with an offset when busy polling is enabled. __skb_try_recv_datagram() uses as the loop termination condition 'queue empty'. When peeking, the socket queue can be not empty, even when no additional packets are received. Address the issue explicitly

Re: [PATCH bpf-next] bpf: test_tc_tunnel.sh needs reverse path filtering disabled

2019-03-25 Thread Willem de Bruijn
On Mon, Mar 25, 2019 at 5:36 AM Alan Maguire wrote: > > test_tc_tunnel.sh sets up a pair of namespaces connected by a > veth pair to verify encap/decap using bpf_skb_adjust_room. In > testing this, it uses tunnel links as the peer of the bpf-based > encap/decap. However because the same IP heade

[PATCH net] dpaa2-eth: fix race condition with bql frame accounting

2019-03-25 Thread Ioana Ciornei
It might happen that Tx conf acknowledges a frame before it was subscribed in bql, as subscribing was previously done after the enqueue operation. This patch moves the netdev_tx_sent_queue call before the actual frame enqueue, so that this can never happen. Fixes: 569dac6 ("dpaa2-eth: bql support

random crashes, kdump and so on

2019-03-25 Thread Reindl Harald
besides that i get tired about random crashes over the last months (yeah the connlimit crashes are fixed in the meantime but there is still something broken) which are pretty sure in the netedev/netfilter area and "kernel.panic = 1" is not a persistent solution what in the world makes kdump on a V

Re: [PATCH bpf-next] selftests: bpf: don't depend on hardcoded perf sample_freq

2019-03-25 Thread Daniel Borkmann
On 03/19/2019 10:53 PM, Stanislav Fomichev wrote: > When running stacktrace_build_id_nmi, try to query > kernel.perf_event_max_sample_rate sysctl and use it as a sample_freq. > If there was an error reading sysctl, fallback to 5000. > > kernel.perf_event_max_sample_rate sysctl can drift and/or can

Re: [PATCH net] dpaa2-eth: Fix possible access beyond end of array

2019-03-25 Thread Jesper Dangaard Brouer
On Mon, 25 Mar 2019 09:42:22 + Ioana Ciocoi Radulescu wrote: > > -Original Message- > > From: Jesper Dangaard Brouer > > Sent: Sunday, March 24, 2019 8:29 PM > > To: Ioana Ciocoi Radulescu > > Cc: netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciornei > > ; bro...@redhat.com > >

Re: [PATCH 2/2] samples/bpf: add NULL check for ksym_search

2019-03-25 Thread Daniel Borkmann
On 03/15/2019 07:42 AM, Daniel T. Lee wrote: > Since, ksym_search added with verification logic for symbols existence, > it could return NULL when the kernel symbols are not loaded. > > This commit will add NULL check logic after ksym_search. > > Signed-off-by: Daniel T. Lee > --- > samples/bpf

Re: [Patch net v2] xfrm: clean up xfrm protocol checks

2019-03-25 Thread Herbert Xu
On Fri, Mar 22, 2019 at 04:26:19PM -0700, Cong Wang wrote: > In commit 6a53b7593233 ("xfrm: check id proto in validate_tmpl()") > I introduced a check for xfrm protocol, but according to Herbert > IPSEC_PROTO_ANY should only be used as a wildcard for lookup, so > it should be removed from validate_

Re: [PATCH bpf-next 00/21] bpf: Sysctl hook

2019-03-25 Thread Daniel Borkmann
Hi Andrey, On 03/24/2019 01:12 AM, Andrey Ignatov wrote: > The patch set introduces new BPF hook for sysctl. > > It adds new program type BPF_PROG_TYPE_CGROUP_SYSCTL and attach type > BPF_CGROUP_SYSCTL. > > BPF_CGROUP_SYSCTL hook is placed before calling to sysctl's proc_handler so > that access

RE: [PATCH net] dpaa2-eth: Fix possible access beyond end of array

2019-03-25 Thread Ioana Ciocoi Radulescu
> -Original Message- > From: Jesper Dangaard Brouer > Sent: Sunday, March 24, 2019 8:29 PM > To: Ioana Ciocoi Radulescu > Cc: netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciornei > ; bro...@redhat.com > Subject: Re: [PATCH net] dpaa2-eth: Fix possible access beyond end of array > >

[PATCH bpf-next] bpf: test_tc_tunnel.sh needs reverse path filtering disabled

2019-03-25 Thread Alan Maguire
test_tc_tunnel.sh sets up a pair of namespaces connected by a veth pair to verify encap/decap using bpf_skb_adjust_room. In testing this, it uses tunnel links as the peer of the bpf-based encap/decap. However because the same IP header is used for inner and outer IP, when packets arrive at the tu

Re: [PATCH v2] net: use bulk free in kfree_skb_list

2019-03-25 Thread Felix Fietkau
On 2019-03-25 10:31, Eric Dumazet wrote: > > > On 03/25/2019 02:09 AM, Felix Fietkau wrote: >> On 2019-03-25 09:51, Eric Dumazet wrote: >>> >>> >>> On 03/24/2019 09:56 AM, Felix Fietkau wrote: Since we're freeing multiple skbs, we might as well use bulk free to save a few cycles. Use th

Re: [PATCH v2] net: use bulk free in kfree_skb_list

2019-03-25 Thread Eric Dumazet
On 03/25/2019 02:09 AM, Felix Fietkau wrote: > On 2019-03-25 09:51, Eric Dumazet wrote: >> >> >> On 03/24/2019 09:56 AM, Felix Fietkau wrote: >>> Since we're freeing multiple skbs, we might as well use bulk free to save a >>> few cycles. Use the same conditions for bulk free as in napi_consume_s

Re: [PATCH v3] net: use bulk free in kfree_skb_list

2019-03-25 Thread Eric Dumazet
On 03/25/2019 02:14 AM, Felix Fietkau wrote: > Since we're freeing multiple skbs, we might as well use bulk free to save a > few cycles. Use the same conditions for bulk free as in napi_consume_skb. > > Signed-off-by: Felix Fietkau > --- > v3: reorder checks to prevent skb double unref > v2: c

Re: [PATCH v9 3/6] anybus-s: support the Arcx anybus controller

2019-03-25 Thread kbuild test robot
Hi Sven, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on v5.1-rc2 next-20190325] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

  1   2   >