On Sat, Mar 23, 2019 at 10:45 AM Kevin 'ldir' Darbyshire-Bryant <l...@darbyshire-bryant.me.uk> wrote: > > I will remove the functionality from conndscp that changes the conntrack > mark, so that it only restores the mark into the diffserv field. > > So that I’m clear about which direction I should be headed: > > Bearing in mind that conndscp writes to the skb’s iphdr diffserv field and > *not* skb->fwmark, do you still desire to see the dscp restoration code done > as part of connmark. In other words NOT have a separate conndscp module? >
For me, the barrier is the name "connmark" is confusing if we put conndscp into it. So, I think leaving conndscp alone is fine. Perhaps we just need an action called "act_conntrack" which could retrieve any meaningful information from conntrack to skb. What do you think? Thanks.
