On 3/25/19 11:35 AM, Heiner Kallweit wrote:
> 1000BaseT standard requires that a link is reported as down earliest
> after 750ms. Several use case however require a much faster detecion
> of a broken link. Fast Link Down supports this by intentionally
> violating a the standard. This patch exposes the Fast Link Down
> feature of 88E1540 and 88E6390. These PHY's can be found as internal
> PHY's in several switches: 88E6352, 88E6240, 88E6176, 88E6172,
> and 88E6390(X). Fast Link Down and EEE are mutually exclusive.
> 
> Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>

This looks fine, just one question though: do not you need to verify
that the phy_interface_t maps to a copper medium somehow?
-- 
Florian

Reply via email to