On Mon, 25 Mar 2019 02:27:14 -0700
Eric Dumazet <eric.duma...@gmail.com> wrote:

> > +#ifdef CONFIG_SLUB
> > +           /* SLUB writes into objects when freeing */
> > +           prefetchw(segs);
> > +#endif  
> 
> This is done too late : 
> You should probably either remove this prefetchw()
> or do it before reading segs->next at the beginning of the loop.

Agree. Not sure the prefetchw optimization makes sense here. IHMO just
drop it in this patch.

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer

Reply via email to