On Mon, Mar 25, 2019 at 4:48 PM Soheil Hassas Yeganeh <soh...@google.com> wrote:
>
> On Mon, Mar 25, 2019 at 4:44 PM Eric Dumazet <eduma...@google.com> wrote:
> >
> > My recent patch had at least two problems :
> >
> > 1) TX zerocopy wants notification when skb is acknowledged,
> > thus we need to call skb_zcopy_clear() if the skb is
> > cached into sk->sk_tx_skb_cache
> >
> > 2) Some applications might expect precise EPOLLOUT notifications,
> > so we need to update sk->sk_wmem_queued and call
> > sk_mem_uncharge() from sk_wmem_free_skb() in all cases.
> > The SOCK_QUEUE_SHRUNK flag must also be set.
> >
> > Fixes: 472c2e07eef0 ("tcp: add one skb cache for tx")
> > Signed-off-by: Eric Dumazet <eduma...@google.com>
> > Cc: Willem de Bruijn <will...@google.com>
> > Cc: Soheil Hassas Yeganeh <soh...@google.com>
>
> Acked-by: Soheil Hassas Yeganeh <soh...@google.com>
Acked-by: Willem de Bruijn <will...@google.com>
