Re: [PATCH mlx5-next 12/12] net/mlx5: Set ODP SRQ support in firmware

2019-02-04 Thread Leon Romanovsky
On Mon, Feb 04, 2019 at 11:47:23PM +, Saeed Mahameed wrote: > On Tue, 2019-01-22 at 08:48 +0200, Leon Romanovsky wrote: > > From: Moni Shoua > > > > To avoid compatibility issue with older kernels the firmware doesn't > > allow SRQ to work with ODP unless kernel asks for it. > > > > Signed-off

Is advertising of 2500Mbps support must from phy device to set phy at 2500Mbps link speed

2019-02-04 Thread abhijit
Hi All, We are using Ethernet MAC which has integrated Phy. This phy supports speed up to 1Mbps. The phy has, 1000Base-X PCS(Physical Coding Sub-layer) followed by SerDes interface to support 10Mbps to 1Mbps. Currently we are trying to get this phy at 2500Mbps. This device has 16 regi

linux-next: manual merge of the akpm-current tree with the net tree

2019-02-04 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the akpm-current tree got a conflict in: net/sctp/stream.c between commit: cfe4bd7a257f ("sctp: check and update stream->out_curr when allocating stream_out") from the net tree and commit: 2bd3fbb3ff23 ("sctp: convert to genradix") from the akpm-cur

Re: [PATCH net-next v7 0/8] devlink: Add configuration parameters support for devlink_port

2019-02-04 Thread Vasundhara Volam
On Tue, Feb 5, 2019 at 8:26 AM Jakub Kicinski wrote: > > On Mon, 4 Feb 2019 12:25:13 +0530, Vasundhara Volam wrote: > > > > IMHO this is not really a problem. We can either use an additional flag > > > > telling kernel/driver if we are setting runtime or persistent WoL mask > > > > or we can pass

RE: [PATCH v2 2/2] netdev/phy: add MDIO bus multiplexer driven by a regmap

2019-02-04 Thread Pankaj Bansal
Hi Andrew, I am getting this compilation error when the mdio-mux-regmap.ko is built as standalone module. This error doesn't come when the mdio-mux-regmap is built as part of linux kernel. I don't understand the reason for it. Inline definitions of functions are only defined if CONFIG_MDIO_BUS

Re: [PATCH bpf-next] libbpf: fix libbpf_print

2019-02-04 Thread Yonghong Song
On 2/4/19 5:51 PM, Alexei Starovoitov wrote: > On Tue, Feb 05, 2019 at 12:37:29AM +, Yonghong Song wrote: >> >> >> On 2/4/19 4:20 PM, Stanislav Fomichev wrote: >>> With the recent print rework we now have the following problem: >>> pr_{warning,info,debug} expand to __pr which calls libbpf_pri

Re: [PATCH] net: fix IPv6 prefix route residue

2019-02-04 Thread David Ahern
On 2/3/19 9:04 AM, David Miller wrote: > From: Zhiqiang Liu > Date: Sun, 3 Feb 2019 14:10:31 +0800 > >> @@ -1165,7 +1165,8 @@ enum cleanup_prefix_rt_t { >> list_for_each_entry(ifa, &idev->addr_list, if_list) { >> if (ifa == ifp) >> continue; >> -

Re: [PATCH net] virtio_net: Account for tx bytes and packets on sending xdp_frames

2019-02-04 Thread David Ahern
On 2/4/19 3:53 AM, Jesper Dangaard Brouer wrote: > On Sat, 2 Feb 2019 14:27:26 -0700 > David Ahern wrote: > >> On 1/31/19 1:15 PM, Jesper Dangaard Brouer wrote: David, Jesper, care to chime in where we ended up in that last thread discussion this? >>> >>> IHMO packets RX and TX o

[PATCH] ipmr: ip6mr: Create new sockopt to clear mfc cache only

2019-02-04 Thread Callum Sinclair
Currently the only way to clear the mfc cache was to delete the entries one by one using the MRT_DEL_MFC socket option or to destroy and recreate the socket. Create a new socket option which will clear the multicast forwarding cache on the socket without destroying the socket. Signed-off-by: Call

[PATCH] ipmr: ip6mr: Create new sockopt to clear mfc cache only

2019-02-04 Thread Callum Sinclair
Created a way to clear the multicast forwarding cache on a socket without having to either remove the entries manually using the delete entry socket option or destroy and recreate the multicast socket. Patch Set 2: - Fix Compile Errors Patch Set 3: - Fix Style Errors Callum Sinclair (1): i

Re: [PATCH net-next v7 0/8] devlink: Add configuration parameters support for devlink_port

2019-02-04 Thread Jakub Kicinski
On Mon, 4 Feb 2019 12:25:13 +0530, Vasundhara Volam wrote: > > > IMHO this is not really a problem. We can either use an additional flag > > > telling kernel/driver if we are setting runtime or persistent WoL mask > > > or we can pass (up to) two bitmaps. > Jakub, I will add another two bitmask p

Re: Compiler warning

2019-02-04 Thread David Ahern
On 2/4/19 3:43 AM, Koen Vandeputte wrote: > Hi All, > > I'm seeing following compiler warning during kernel compilation > (5.0-rc5  and  4.14.96): > > > net/core/dev.c: In function 'validate_xmit_skb_list': > net/core/dev.c:3405:15: warning: 'tail' may be used uninitialized in > this function [-

Re: Compiler warning - ipv4 fib_trie

2019-02-04 Thread David Ahern
On 2/4/19 3:55 AM, Koen Vandeputte wrote: > Hi All, > > During compilation of kernel 4.14.96 and 5.0-rc5 I'm seeing following > warning: > > net/ipv4/fib_trie.c: In function 'fib_trie_unmerge': > net/ipv4/fib_trie.c:1749:8: warning: 'local_tp' may be used > uninitialized in this function [-Wmaybe

Re: [PATCH v1] net: dsa: qca8k: implement DT-based ports <-> phy translation

2019-02-04 Thread Andrew Lunn
On Mon, Feb 04, 2019 at 10:35:55PM +0100, Christian Lamparter wrote: > The QCA8337 enumerates 5 PHYs on the MDC/MDIO access: PHY0-PHY4. > Based on the System Block Diagram in Section 1.2 of the > QCA8337's datasheet. These PHYs are internally connected > to MACs of PORT 1 - PORT 5. However, neither

Re: [PATCH v2] net: dsa: mv88e6xxx: Revise irq setup ordering

2019-02-04 Thread Andrew Lunn
> The problem is INTn can go low before the interrupt handler for it is > registered and enabled. > This can't happen.  The domain is setup immediately after registering > the GPIO interrupt. > The interrupt can't fire until one of the enables is set. These two statement seem to contradict each o

Re: [PATCH net-next v2 1/1] net/mlx5: Fix code style issue in mlx driver

2019-02-04 Thread David Miller
From: Saeed Mahameed Date: Mon, 4 Feb 2019 15:26:51 -0800 > On Thu, Jan 31, 2019 at 5:20 PM wrote: >> >> From: Tonghao Zhang >> >> Add the tab before '}' and keep the code style consistent. >> >> Signed-off-by: Tonghao Zhang >> Reviewed-by: Or Gerlitz > > Acked-by: Saeed Mahameed > > Dave,

Re: [PATCH bpf-next] libbpf: fix libbpf_print

2019-02-04 Thread Alexei Starovoitov
On Tue, Feb 05, 2019 at 12:37:29AM +, Yonghong Song wrote: > > > On 2/4/19 4:20 PM, Stanislav Fomichev wrote: > > With the recent print rework we now have the following problem: > > pr_{warning,info,debug} expand to __pr which calls libbpf_print. > > libbpf_print does va_start and calls __lib

Re: [PATCH btf 0/3] Add BTF types deduplication algorithm

2019-02-04 Thread Andrii Nakryiko
On Mon, Feb 4, 2019 at 5:32 PM Daniel Borkmann wrote: > > Hi Andrii, > > On 01/31/2019 07:58 AM, Andrii Nakryiko wrote: > > This patch series adds BTF deduplication algorithm to libbpf. This algorithm > > allows to take BTF type information containing duplicate per-compilation > > unit > > inform

[PATCH btf v2 3/3] selftests/btf: add initial BTF dedup tests

2019-02-04 Thread Andrii Nakryiko
This patch sets up a new kind of tests (BTF dedup tests) and tests few aspects of BTF dedup algorithm. More complete set of tests will come in follow up patches. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/btf.c| 12 + tools/lib/bpf/btf.h| 3 + to

[PATCH btf v2 2/3] btf: add BTF types deduplication algorithm

2019-02-04 Thread Andrii Nakryiko
This patch implements BTF types deduplication algorithm. It allows to greatly compress typical output of pahole's DWARF-to-BTF conversion or LLVM's compilation output by detecting and collapsing identical types emitted in isolation per compilation unit. Algorithm also resolves struct/union forward

[PATCH btf v2 1/3] btf: extract BTF type size calculation

2019-02-04 Thread Andrii Nakryiko
This pre-patch extracts calculation of amount of space taken by BTF type descriptor for later reuse by btf_dedup functionality. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/btf.c | 98 + 1 file changed, 46 insertions(+), 52 deletions(-) diff --gi

[PATCH btf v2 0/3] Add BTF types deduplication algorithm

2019-02-04 Thread Andrii Nakryiko
This patch series adds BTF deduplication algorithm to libbpf. This algorithm allows to take BTF type information containing duplicate per-compilation unit information and reduce it to equivalent set of BTF types with no duplication without loss of information. It also deduplicates strings and remo

Re: [PATCH bpf-next 1/6] bpf: Add a bpf_sock pointer to __sk_buff and a bpf_sk_fullsock helper

2019-02-04 Thread Martin Lau
On Mon, Feb 04, 2019 at 11:33:28PM +0100, Daniel Borkmann wrote: > Hi Martin, > > On 02/01/2019 08:03 AM, Martin KaFai Lau wrote: > > In kernel, it is common to check "!skb->sk && sk_fullsock(skb->sk)" > > before accessing the fields in sock. For example, in __netdev_pick_tx: > > > > static u16

Re: [PATCH v2] net: dsa: mv88e6xxx: Revise irq setup ordering

2019-02-04 Thread John David Anglin
On 2019-02-04 6:14 p.m., Andrew Lunn wrote: > On Mon, Feb 04, 2019 at 04:59:13PM -0500, John David Anglin wrote: >> This change fixes a race condition in the setup of hardware irqs and the >> code enabling PHY link detection in the mv88e6xxx driver. >> >> This race was observed on the espressobin b

Re: [PATCH bpf-next] libbpf: fix libbpf_print

2019-02-04 Thread Yonghong Song
On 2/4/19 4:20 PM, Stanislav Fomichev wrote: > With the recent print rework we now have the following problem: > pr_{warning,info,debug} expand to __pr which calls libbpf_print. > libbpf_print does va_start and calls __libbpf_pr with va_list argument. > In __base_pr we again do va_start. Because

Re: [PATCH btf 0/3] Add BTF types deduplication algorithm

2019-02-04 Thread Daniel Borkmann
Hi Andrii, On 01/31/2019 07:58 AM, Andrii Nakryiko wrote: > This patch series adds BTF deduplication algorithm to libbpf. This algorithm > allows to take BTF type information containing duplicate per-compilation unit > information and reduce it to equivalent set of BTF types with no duplication >

[PATCH bpf-next] libbpf: fix libbpf_print

2019-02-04 Thread Stanislav Fomichev
With the recent print rework we now have the following problem: pr_{warning,info,debug} expand to __pr which calls libbpf_print. libbpf_print does va_start and calls __libbpf_pr with va_list argument. In __base_pr we again do va_start. Because the next argument is a va_list, we don't get correct po

[net-next][PATCH 0/5] rds: add tos support

2019-02-04 Thread Santosh Shilimkar
RDS applications make use of tos to classify database traffic. This feature has been used in shipping products from 2.6.32 based kernels. Its tied with RDS v4.1 protocol version and the compatibility gets negotiated as part of connections setup. Patchset keeps full backward compatibility using exi

[net-next][PATCH 4/5] rds: add transport specific tos_map hook

2019-02-04 Thread Santosh Shilimkar
RDMA transport maps user tos to underline virtual lanes(VL) for IB or DSCP values. RDMA CM transport abstract thats for RDS. TCP transport makes use of default priority 0 and maps all user tos values to it. Reviewed-by: Sowmini Varadhan Signed-off-by: Santosh Shilimkar [yanjun@oracle.com: Ad

[net-next][PATCH 2/5] rds: rdma: add consumer reject

2019-02-04 Thread Santosh Shilimkar
For legacy protocol version incompatibility with non linux RDS, consumer reject reason being used to convey it to peer. But the choice of reject reason value as '1' was really poor. Anyway for interoperability reasons with shipping products, it needs to be supported. For any future versions, prope

[net-next][PATCH 5/5] rds: rdma: update rdma transport for tos

2019-02-04 Thread Santosh Shilimkar
For RDMA transports, RDS TOS is an extension of IB QoS(Annex A13) to provide clients the ability to segregate traffic flows for different type of data. RDMA CM abstract it for ULPs using rdma_set_service_type(). Internally, each traffic flow is represented by a connection with all of its independen

[net-next][PATCH 3/5] rds: add type of service(tos) infrastructure

2019-02-04 Thread Santosh Shilimkar
RDS Service type (TOS) is user-defined and needs to be configured via RDS IOCTL interface. It must be set before initiating any traffic and once set the TOS can not be changed. All out-going traffic from the socket will be associated with its TOS. Reviewed-by: Sowmini Varadhan Signed-off-by: Sant

[net-next][PATCH 1/5] rds: make v3.1 as compat version

2019-02-04 Thread Santosh Shilimkar
Mark RDSv3.1 as compat version and add v4.1 version macro's. Subsequent patches enable TOS(Type of Service) feature which is tied with v4.1 for RDMA transport. Reviewed-by: Sowmini Varadhan Signed-off-by: Santosh Shilimkar [yanjun@oracle.com: Adapted original patch with ipv6 changes] Signed-

Re: [PATCH v1] net: dsa: qca8k: implement DT-based ports <-> phy translation

2019-02-04 Thread Christian Lamparter
Hello Andrew and Florian. I concated both replies into this post. On Monday, February 4, 2019 11:26:41 PM CET Andrew Lunn wrote: > On Mon, Feb 04, 2019 at 10:35:55PM +0100, Christian Lamparter wrote: > > The QCA8337 enumerates 5 PHYs on the MDC/MDIO access: PHY0-PHY4. > > Based on the System Bloc

Re: [PATCH mlx5-next 12/12] net/mlx5: Set ODP SRQ support in firmware

2019-02-04 Thread Saeed Mahameed
On Mon, 2019-02-04 at 14:23 -0700, Jason Gunthorpe wrote: > On Sun, Feb 03, 2019 at 11:03:11AM +0200, Leon Romanovsky wrote: > > On Thu, Jan 31, 2019 at 04:28:44PM -0700, Jason Gunthorpe wrote: > > > On Tue, Jan 22, 2019 at 08:48:51AM +0200, Leon Romanovsky wrote: > > > > From: Moni Shoua > > > >

Re: [PATCH mlx5-next 12/12] net/mlx5: Set ODP SRQ support in firmware

2019-02-04 Thread Saeed Mahameed
On Tue, 2019-01-22 at 08:48 +0200, Leon Romanovsky wrote: > From: Moni Shoua > > To avoid compatibility issue with older kernels the firmware doesn't > allow SRQ to work with ODP unless kernel asks for it. > > Signed-off-by: Moni Shoua > Reviewed-by: Majd Dibbiny > Signed-off-by: Leon Romanovs

[PATCH net-next 1/2] net: marvell: mvpp2: use phy_interface_mode_is_8023z() helper

2019-02-04 Thread Russell King
Use the phy_interface_mode_is_8023z() helper for detecting interface modes that use 802.3z serial encoding. This is equivalent to testing for both 1000base-X and 2500base-X. Signed-off-by: Russell King --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 38 ++--- 1 file ch

[PATCH net-next 2/2] net: marvell: mvpp2: fix lack of link interrupts

2019-02-04 Thread Russell King
Sven Auhagen reports that if he changes a SFP+ module for a SFP module on the Macchiatobin Single Shot, the link does not come back up. For Sven, it is as easy as: - Insert a SFP+ module connected, and use ping6 to verify link is up. - Remove SFP+ module - Insert SFP 1000base-X module use ping6 t

Re: [PATCH net-next v2 1/1] net/mlx5: Fix code style issue in mlx driver

2019-02-04 Thread Saeed Mahameed
On Thu, Jan 31, 2019 at 5:20 PM wrote: > > From: Tonghao Zhang > > Add the tab before '}' and keep the code style consistent. > > Signed-off-by: Tonghao Zhang > Reviewed-by: Or Gerlitz Acked-by: Saeed Mahameed Dave, you can take this patch to net-next. Thanks, Saeed.

Re: [PATCH v2] net: dsa: mv88e6xxx: Revise irq setup ordering

2019-02-04 Thread Andrew Lunn
On Mon, Feb 04, 2019 at 04:59:13PM -0500, John David Anglin wrote: > This change fixes a race condition in the setup of hardware irqs and the > code enabling PHY link detection in the mv88e6xxx driver. > > This race was observed on the espressobin board where the GPIO interrupt > controller only s

Re: [PATCH 1/3 net-next] net: phy: aquantia: improve setting speed and duplex in aqr_read_status

2019-02-04 Thread Heiner Kallweit
On 04.02.2019 23:23, Andrew Lunn wrote: >> I'd like to use standard registers wherever possible. This patch is >> meant as a quick win to improve what we do already in aqr_read_status. >> Once we have a generic c45 read_status function we should switch to it. > > Hi Heiner > > I don't see much po

Re: [PATCH] net: phylink: dsa: mv88e6xxx: Revise irq setup ordering

2019-02-04 Thread Andrew Lunn
On Mon, Feb 04, 2019 at 04:38:53PM -0500, John David Anglin wrote: > On 2019-02-04 3:19 p.m., Andrew Lunn wrote: > > The IRQ core would do this if it was needed. > > > > How many other irq thread work functions can you point to which do > > something similar? > This is comment for handle_edge_irq:

Re: [PATCH bpf-next 1/6] bpf: Add a bpf_sock pointer to __sk_buff and a bpf_sk_fullsock helper

2019-02-04 Thread Daniel Borkmann
Hi Martin, On 02/01/2019 08:03 AM, Martin KaFai Lau wrote: > In kernel, it is common to check "!skb->sk && sk_fullsock(skb->sk)" > before accessing the fields in sock. For example, in __netdev_pick_tx: > > static u16 __netdev_pick_tx(struct net_device *dev, struct sk_buff *skb, >

Re: [PATCH v1] net: dsa: qca8k: implement DT-based ports <-> phy translation

2019-02-04 Thread Andrew Lunn
On Mon, Feb 04, 2019 at 10:35:55PM +0100, Christian Lamparter wrote: > The QCA8337 enumerates 5 PHYs on the MDC/MDIO access: PHY0-PHY4. > Based on the System Block Diagram in Section 1.2 of the > QCA8337's datasheet. These PHYs are internally connected > to MACs of PORT 1 - PORT 5. Hi Christian I

Re: [PATCH 1/3 net-next] net: phy: aquantia: improve setting speed and duplex in aqr_read_status

2019-02-04 Thread Andrew Lunn
> I'd like to use standard registers wherever possible. This patch is > meant as a quick win to improve what we do already in aqr_read_status. > Once we have a generic c45 read_status function we should switch to it. Hi Heiner I don't see much point in adding code which we know we are soon going

Re: [PATCH bpf-next] selftests/bpf: use localhost in tcp_{server,client}.py

2019-02-04 Thread Daniel Borkmann
On 02/04/2019 07:43 PM, Stanislav Fomichev wrote: > Bind and connect to localhost. There is no reason for this test to > use non-localhost interface. This lets us run this test in a network > namespace. > > Signed-off-by: Stanislav Fomichev Applied, thanks!

Re: [PATCH v1] net: dsa: qca8k: implement DT-based ports <-> phy translation

2019-02-04 Thread Florian Fainelli
On 2/4/19 1:35 PM, Christian Lamparter wrote: > The QCA8337 enumerates 5 PHYs on the MDC/MDIO access: PHY0-PHY4. > Based on the System Block Diagram in Section 1.2 of the > QCA8337's datasheet. These PHYs are internally connected > to MACs of PORT 1 - PORT 5. However, neither qca8k's slave > mdio a

[PATCH v2] net: dsa: mv88e6xxx: Revise irq setup ordering

2019-02-04 Thread John David Anglin
This change fixes a race condition in the setup of hardware irqs and the code enabling PHY link detection in the mv88e6xxx driver. This race was observed on the espressobin board where the GPIO interrupt controller only supports edge interrupts.  If the INTn output pin goes low before the GPIO int

[PATCH v2] net: emac: remove IBM_EMAC_RX_SKB_HEADROOM

2019-02-04 Thread Christian Lamparter
The EMAC driver had a custom IBM_EMAC_RX_SKB_HEADROOM Kconfig option that reserved additional skb headroom for RX. This patch removes the option and migrates the code to use napi_alloc_skb() and netdev_alloc_skb_ip_align() in its place. Signed-off-by: Christian Lamparter --- drivers/net/ethernet

[no subject]

2019-02-04 Thread netdev-owner
I think is missing is the "io-reserve=0" property from the domain configuration (for the "pcie-root-port" devices), which we introduced for . In fact, in , Marcel recommended e1000e

Re: [PATCH rdma-next 00/12] Add SRQ and XRC support for ODP MRs

2019-02-04 Thread Jason Gunthorpe
On Sun, Feb 03, 2019 at 12:54:30PM +0200, Leon Romanovsky wrote: > On Thu, Jan 31, 2019 at 04:27:39PM -0700, Jason Gunthorpe wrote: > > On Tue, Jan 22, 2019 at 08:48:39AM +0200, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > Hi, > > > > > > This series extend ODP to work with SRQ a

Re: [PATCH 1/3 net-next] net: phy: aquantia: improve setting speed and duplex in aqr_read_status

2019-02-04 Thread Heiner Kallweit
On 04.02.2019 22:28, Andrew Lunn wrote: > On Mon, Feb 04, 2019 at 10:03:21PM +0100, Heiner Kallweit wrote: >> Add support for speeds 10Mbps, 5Gbps, and 10Gbps. In addition don't >> hardcode duplex but read it from the chip. > > Hi Heiner > > The marvell10g does this differently. It gets the local

Re: [PATCH] net: phylink: dsa: mv88e6xxx: Revise irq setup ordering

2019-02-04 Thread John David Anglin
On 2019-02-04 3:19 p.m., Andrew Lunn wrote: > The IRQ core would do this if it was needed. > > How many other irq thread work functions can you point to which do > something similar? This is comment for handle_edge_irq: /**  *    handle_edge_irq - edge type IRQ handler  *    @desc:    the interrup

[PATCH v1] net: dsa: qca8k: implement DT-based ports <-> phy translation

2019-02-04 Thread Christian Lamparter
The QCA8337 enumerates 5 PHYs on the MDC/MDIO access: PHY0-PHY4. Based on the System Block Diagram in Section 1.2 of the QCA8337's datasheet. These PHYs are internally connected to MACs of PORT 1 - PORT 5. However, neither qca8k's slave mdio access functions qca8k_phy_read()/qca8k_phy_write() nor t

Re: [PATCH v2 0/7] sh_eth: implement simple RX checksum offload

2019-02-04 Thread David Miller
From: Sergei Shtylyov Date: Mon, 4 Feb 2019 21:01:25 +0300 > Here's a set of 7 patches against DaveM's 'net-next.git' repo. I'm implemeting > the simple RX checksum offload (like was done for the 'ravb' driver by Simon > Horman); it has been only tested on the R8A7740 and R8A77980 SoCs, the other

Re: [PATCH 3/3 net-next] net: phy: aquantia: use FIELD_GET for getting speed in aqr_read_status

2019-02-04 Thread Andrew Lunn
On Mon, Feb 04, 2019 at 10:09:06PM +0100, Heiner Kallweit wrote: > Change getting the speed to use FIELD_GET() too to be in line with the > rest of the code. > > Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Andrew

Re: [PATCH 1/3 net-next] net: phy: aquantia: improve setting speed and duplex in aqr_read_status

2019-02-04 Thread Andrew Lunn
On Mon, Feb 04, 2019 at 10:03:21PM +0100, Heiner Kallweit wrote: > Add support for speeds 10Mbps, 5Gbps, and 10Gbps. In addition don't > hardcode duplex but read it from the chip. Hi Heiner The marvell10g does this differently. It gets the local and link partner advertised link modes and from tha

Re: [PATCH mlx5-next 12/12] net/mlx5: Set ODP SRQ support in firmware

2019-02-04 Thread Jason Gunthorpe
On Sun, Feb 03, 2019 at 11:03:11AM +0200, Leon Romanovsky wrote: > On Thu, Jan 31, 2019 at 04:28:44PM -0700, Jason Gunthorpe wrote: > > On Tue, Jan 22, 2019 at 08:48:51AM +0200, Leon Romanovsky wrote: > > > From: Moni Shoua > > > > > > To avoid compatibility issue with older kernels the firmware

[PATCH 3/3 net-next] net: phy: aquantia: use FIELD_GET for getting speed in aqr_read_status

2019-02-04 Thread Heiner Kallweit
Change getting the speed to use FIELD_GET() too to be in line with the rest of the code. Signed-off-by: Heiner Kallweit --- drivers/net/phy/aquantia.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/phy/aquantia.c b/drivers/net/phy/aquantia.c inde

[PATCH 1/3 net-next] net: phy: aquantia: improve setting speed and duplex in aqr_read_status

2019-02-04 Thread Heiner Kallweit
Add support for speeds 10Mbps, 5Gbps, and 10Gbps. In addition don't hardcode duplex but read it from the chip. Signed-off-by: Andrew Lunn Signed-off-by: Heiner Kallweit --- drivers/net/phy/aquantia.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/net

[PATCH 2/3 net-next] net: phy: aquantia: set interface mode in aqr_read_status

2019-02-04 Thread Heiner Kallweit
Extend aqr_read_status to set the interface mode properly. Signed-off-by: Nikita Yushchenko Signed-off-by: Andrew Lunn Signed-off-by: Heiner Kallweit --- drivers/net/phy/aquantia.c | 37 + 1 file changed, 37 insertions(+) diff --git a/drivers/net/phy/aquant

[PATCH 0/3 net-next] net: phy: aquantia: extend aqr_read_status

2019-02-04 Thread Heiner Kallweit
Extend aqr_read_status to read more parameters from the chip. Heiner Kallweit (3): net: phy: aquantia: improve setting speed and duplex in aqr_read_status net: phy: aquantia: set interface mode in aqr_read_status net: phy: aquantia: use FIELD_GET for getting speed in aqr_read_status driver

Re: [PATCH] bpf: test_maps: Avoid possible out of bound access

2019-02-04 Thread Daniel Borkmann
On 02/04/2019 05:27 PM, Breno Leitao wrote: > When compiling test_maps selftest with GCC-8, it warns that an array might > be indexed with a negative value, which could cause a negative out of bound > access, depending on parameters of the function. This is the GCC-8 warning: > > gcc -Wall -

Re: [PATCH bpf-next 0/2] tools/bpf: expose several libbpf API functions

2019-02-04 Thread Alexei Starovoitov
On Mon, Feb 4, 2019 at 12:27 PM Yonghong Song wrote: > > This patch set exposed a few functions in libbpf. > All these newly added API functions are helpful for > JIT based bpf compilation where .BTF and .BTF.ext > are available as in-memory data blobs. > > Patch #1 exposed several btf_ext__* API

Re: [PATCH bpf-next 1/3] bpf, riscv: add BPF JIT for RV64G

2019-02-04 Thread Björn Töpel
Den mån 4 feb. 2019 kl 21:06 skrev Daniel Borkmann : > > On 02/03/2019 12:51 PM, bjorn.to...@gmail.com wrote: > > From: Björn Töpel > > > > This commit adds BPF JIT for RV64G. > > > > The JIT is a two-pass JIT, and has a dynamic prolog/epilogue (similar > > to the MIPS64 BPF JIT) instead of static

Re: [PATCH bpf-next] bpf: support SO_DEBUG in bpf_setsockopt()

2019-02-04 Thread Daniel Borkmann
On 02/04/2019 06:35 PM, Alexei Starovoitov wrote: > On Sun, Feb 03, 2019 at 04:15:07PM +0800, Yafang Shao wrote: >> Then we can enable/disable socket debugging without modifying user code. >> That is more convenient for debugging. >> >> Signed-off-by: Yafang Shao >> --- >> include/net/sock.h | 8

Re: [PATCH] net: phylink: dsa: mv88e6xxx: Revise irq setup ordering

2019-02-04 Thread Andrew Lunn
> Can you be more specific regarding what you think is wrong with this hunk? Hi David The IRQ core would do this if it was needed. How many other irq thread work functions can you point to which do something similar? Andrew

Re: [PATCH bpf-next 3/3] bpf, doc: add RISC-V to filter.txt

2019-02-04 Thread Björn Töpel
Den mån 4 feb. 2019 kl 21:09 skrev Daniel Borkmann : > > On 02/03/2019 12:51 PM, bjorn.to...@gmail.com wrote: > > From: Björn Töpel > > > > Update Documentation/networking/filter.txt to mention RISC-V. > > > > Signed-off-by: Björn Töpel > > Nit: in Documentation/sysctl/net.txt under bpf_jit_enabl

Re: [PATCH bpf-next 3/3] bpf, doc: add RISC-V to filter.txt

2019-02-04 Thread Daniel Borkmann
On 02/03/2019 12:51 PM, bjorn.to...@gmail.com wrote: > From: Björn Töpel > > Update Documentation/networking/filter.txt to mention RISC-V. > > Signed-off-by: Björn Töpel Nit: in Documentation/sysctl/net.txt under bpf_jit_enable there is also a concrete list of eBPF/cBPF JITs, would be good to

Re: [ovs-dev] [PATCH net-next V2 1/1] openvswitch: Declare ovs key structures using macros

2019-02-04 Thread David Miller
From: Gregory Rose Date: Mon, 4 Feb 2019 11:41:29 -0800 > > On 2/3/2019 1:12 AM, Eli Britstein wrote: >> Declare ovs key structures using macros as a pre-step towards to >> enable retrieving fields information, as a work done in proposed >> commit in the OVS tree https://patchwork.ozlabs.org/pat

Re: [ovs-dev] [PATCH net-next V2 1/1] openvswitch: Declare ovs key structures using macros

2019-02-04 Thread David Miller
From: Yi-Hung Wei Date: Mon, 4 Feb 2019 10:47:18 -0800 > For example, to see how 'struct ovs_key_ipv6' is defined, now we need > to trace how OVS_KEY_IPV6_FIELDS is defined, and how OVS_KEY_FIELD_ARR > and OVS_KEY_FIELD defined. I think it makes the header file to be > more complicated. I compl

Re: [PATCH bpf-next 1/3] bpf, riscv: add BPF JIT for RV64G

2019-02-04 Thread Daniel Borkmann
On 02/03/2019 12:51 PM, bjorn.to...@gmail.com wrote: > From: Björn Töpel > > This commit adds BPF JIT for RV64G. > > The JIT is a two-pass JIT, and has a dynamic prolog/epilogue (similar > to the MIPS64 BPF JIT) instead of static ones (e.g. x86_64). > > At the moment the RISC-V Linux port does

Re: [PATCH] net: phylink: dsa: mv88e6xxx: Revise irq setup ordering

2019-02-04 Thread John David Anglin
Hi Andrew, On 2019-02-04 2:35 p.m., Andrew Lunn wrote: > The change to the interrupt handler i'm pretty sure is wrong. You have > to accept with edge interrupts you are going to loose interrupts. Can you be more specific regarding what you think is wrong with this hunk? I can see that an interrup

Re: [ovs-dev] [PATCH net-next V2 1/1] openvswitch: Declare ovs key structures using macros

2019-02-04 Thread Gregory Rose
On 2/3/2019 1:12 AM, Eli Britstein wrote: Declare ovs key structures using macros as a pre-step towards to enable retrieving fields information, as a work done in proposed commit in the OVS tree https://patchwork.ozlabs.org/patch/1023406/ ("odp-util: Do not rewrite fields with the same values a

Re: [PATCH] net: phylink: dsa: mv88e6xxx: Revise irq setup ordering

2019-02-04 Thread Andrew Lunn
On Mon, Feb 04, 2019 at 01:37:13PM -0500, John David Anglin wrote: > This change fixes a race condition in the setup of hardware irqs and the > code enabling PHY link > detection. > > This was observed on the espressobin board where the GPIO interrupt > controller only supports edge > interrupts. 

Re: [PATCH v2 1/2] r8169: Load MAC address from device tree if present

2019-02-04 Thread Heiner Kallweit
On 04.02.2019 17:42, Thierry Reding wrote: > From: Thierry Reding > > If the system was booted using a device tree and if the device tree > contains a MAC address, use it instead of reading one from the EEPROM. > This is useful in situations where the EEPROM isn't properly programmed > or where t

[PATCH bpf-next 0/2] tools/bpf: expose several libbpf API functions

2019-02-04 Thread Yonghong Song
This patch set exposed a few functions in libbpf. All these newly added API functions are helpful for JIT based bpf compilation where .BTF and .BTF.ext are available as in-memory data blobs. Patch #1 exposed several btf_ext__* API functions which are used to handle .BTF.ext ELF sections. Patch #2

[PATCH bpf-next 2/2] tools/bpf: implement libbpf btf__get_map_kv_tids() API function

2019-02-04 Thread Yonghong Song
Currently, to get map key/value type id's, the macro BPF_ANNOTATE_KV_PAIR(, , ) needs to be defined in the bpf program for the corresponding map. During program/map loading time, the local static function bpf_map_find_btf_info() in libbpf.c is implemented to retrieve the key/value type ids given

[PATCH bpf-next 1/2] tools/bpf: expose functions btf_ext__* as API functions

2019-02-04 Thread Yonghong Song
The following set of functions, which manipulates .BTF.ext section, are exposed as API functions: . btf_ext__new . btf_ext__free . btf_ext__reloc_func_info . btf_ext__reloc_line_info . btf_ext__func_info_rec_size . btf_ext__line_info_rec_size These functions are useful for JIT based bp

Re: bpf: BPF_PROG_TEST_RUN leads to unkillable process

2019-02-04 Thread Y Song
On Mon, Feb 4, 2019 at 9:49 AM Stanislav Fomichev wrote: > > On 02/01, Dmitry Vyukov wrote: > > Hello, > > > > The following program leads to an unkillable process that eats CPU in > > an infinite loop in BPF_PROG_TEST_RUN syscall. But kernel does not > > self-detect cpu/rcu/task stalls either. Th

[PATCH net-next 2/2] mlxsw: core: Trace EMAD errors

2019-02-04 Thread Ido Schimmel
From: Nir Dotan Trace EMAD errors returned from HW. Signed-off-by: Nir Dotan Acked-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/core.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/

Re: [ovs-dev] [PATCH net-next V2 1/1] openvswitch: Declare ovs key structures using macros

2019-02-04 Thread Yi-Hung Wei
On Sun, Feb 3, 2019 at 1:13 AM Eli Britstein wrote: > > Declare ovs key structures using macros as a pre-step towards to > enable retrieving fields information, as a work done in proposed > commit in the OVS tree https://patchwork.ozlabs.org/patch/1023406/ > ("odp-util: Do not rewrite fields with

[PATCH net-next 0/2] mlxsw: core: Trace EMAD errors

2019-02-04 Thread Ido Schimmel
Nir says: This patchset adds a trace for EMAD errors to the existing EMAD payload traces. This tracepoint is useful to track user or firmware errors during tests execution. Patch #1 defines the devlink tracepoint. Patch #2 uses it for reporting mlxsw EMAD errors. Nir Dotan (2): devlink: add ha

[PATCH net-next 1/2] devlink: add hardware errors tracing facility

2019-02-04 Thread Ido Schimmel
From: Nir Dotan Define a tracepoint and allow user to trace messages in case of an hardware error code for hardware associated with devlink instance. Signed-off-by: Nir Dotan Acked-by: Jiri Pirko Signed-off-by: Ido Schimmel --- include/trace/events/devlink.h | 33

Re: [PATCH v2 2/2] r8169: Avoid pointer aliasing

2019-02-04 Thread Heiner Kallweit
On 04.02.2019 17:42, Thierry Reding wrote: > From: Thierry Reding > > Read MAC address 32-bit at a time and manually extract the individual > bytes. This avoids pointer aliasing and gives the compiler a better > chance of optimizing the operation. > > Suggested-by: Andrew Lunn > Signed-off-by:

[PATCH bpf-next] selftests/bpf: use localhost in tcp_{server,client}.py

2019-02-04 Thread Stanislav Fomichev
Bind and connect to localhost. There is no reason for this test to use non-localhost interface. This lets us run this test in a network namespace. Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/tcp_client.py | 3 +-- tools/testing/selftests/bpf/tcp_server.py | 5 + 2 files

[PATCH] net: phylink: dsa: mv88e6xxx: Revise irq setup ordering

2019-02-04 Thread John David Anglin
This change fixes a race condition in the setup of hardware irqs and the code enabling PHY link detection. This was observed on the espressobin board where the GPIO interrupt controller only supports edge interrupts.  If the INTn output pin goes low before the GPIO interrupt is enabled, PHY link i

[PATCH v2 7/7] sh_eth: offload RX checksum on SH7763

2019-02-04 Thread Sergei Shtylyov
The SH7763 SoC manual describes the Ether MAC's RX checksum offload the same way as it's implemented in the EtherAVB MACs... Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/renesas/sh_eth.c |1 + 1 file changed, 1 insertion(+) Index: renesas/drivers/net/ethernet/renesas/sh_eth.c ==

[PATCH v2 6/7] sh_eth: offload RX checksum on SH7734

2019-02-04 Thread Sergei Shtylyov
The SH7734 SoC manual describes the Ether MAC's RX checksum offload the same way as it's implemented in the EtherAVB MACs... Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/renesas/sh_eth.c |1 + 1 file changed, 1 insertion(+) Index: renesas/drivers/net/ethernet/renesas/sh_eth.c ==

[PATCH v2 5/7] sh_eth: offload RX checksum on R8A77980

2019-02-04 Thread Sergei Shtylyov
The R-Car V3H (R8A77980) SoC manual describes the Ether MAC's RX checksum offload the same way as it's implemented in the EtherAVB MAC... Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/renesas/sh_eth.c |1 + 1 file changed, 1 insertion(+) Index: renesas/drivers/net/ethernet/renesa

[PATCH v2 4/7] sh_eth: offload RX checksum on R8A7740

2019-02-04 Thread Sergei Shtylyov
The R-Mobile A1 (R8A7740) SoC manual describes the Ether MAC's RX checksum offload the same way as it's implemented in the EtherAVB MAC... Signed-off-by: Sergei Shtylyov Tested-by: Geert Uytterhoeven --- Changes in version 2: - added Geert's tag. drivers/net/ethernet/renesas/sh_eth.c |1 +

[PATCH v2 3/7] sh_eth: offload RX checksum on R7S72100

2019-02-04 Thread Sergei Shtylyov
The RZ/A1H (R7S721000) SoC manual describes the Ether MAC's RX checksum offload the same way as it's implemented in the EtherAVB MACs... Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/renesas/sh_eth.c |1 + 1 file changed, 1 insertion(+) Index: renesas/drivers/net/ethernet/renesas

[PATCH v2 2/7] sh_eth: RX checksum offload support

2019-02-04 Thread Sergei Shtylyov
Add support for the RX checksum offload. This is enabled by default and may be disabled and re-enabled using 'ethtool': # ethtool -K eth0 rx off # ethtool -K eth0 rx on Some Ether MACs provide a simple checksumming scheme which appears to be completely compatible with CHECKSUM_COMPLETE: sum of al

[PATCH v2 1/7] sh_eth: rename sh_eth_cpu_data::hw_checksum

2019-02-04 Thread Sergei Shtylyov
Commit 62e04b7e0e3c ("sh_eth: rename 'sh_eth_cpu_data::hw_crc'") renamed the field to 'hw_checksum' for the Ether DMAC "intelligent checksum", however some Ether MACs implement a simpler checksumming scheme, so that name now seems misleading. Rename that field to 'csmr' as the "intelligent checksum

[PATCH v2 0/7] sh_eth: implement simple RX checksum offload

2019-02-04 Thread Sergei Shtylyov
Hello! Here's a set of 7 patches against DaveM's 'net-next.git' repo. I'm implemeting the simple RX checksum offload (like was done for the 'ravb' driver by Simon Horman); it has been only tested on the R8A7740 and R8A77980 SoCs, the other SoCs should just work (according to their manuals)... [1/

Re: bpf: BPF_PROG_TEST_RUN leads to unkillable process

2019-02-04 Thread Stanislav Fomichev
On 02/01, Dmitry Vyukov wrote: > Hello, > > The following program leads to an unkillable process that eats CPU in > an infinite loop in BPF_PROG_TEST_RUN syscall. But kernel does not > self-detect cpu/rcu/task stalls either. The program contains max > number of repetitions, but as far as I see the

Re: [PATCH] s390: bpf: fix JMP32 code-gen

2019-02-04 Thread Alexei Starovoitov
On Mon, Feb 04, 2019 at 04:44:55PM +0100, Heiko Carstens wrote: > Commit 626a5f66da0d19 ("s390: bpf: implement jitting of JMP32") added > JMP32 code-gen support for s390. However it triggers the warning below > due to some unusual gotos in the original s390 bpf jit code. > > Add a couple of additi

Re: [PATCH bpf-next v4 0/3] tools/bpf: changes of libbpf debug interfaces

2019-02-04 Thread Alexei Starovoitov
On Mon, Feb 04, 2019 at 12:51:34PM -0200, Arnaldo Carvalho de Melo wrote: > Em Sat, Feb 02, 2019 at 08:52:30AM -0800, Alexei Starovoitov escreveu: > > On Fri, Feb 01, 2019 at 04:14:13PM -0800, Yonghong Song wrote: > > > These are patches responding to my comments for > > > Magnus's patch (https://p

Re: [PATCH net 0/4] s390/qeth: fixes 2019-02-04

2019-02-04 Thread David Miller
From: Julian Wiedmann Date: Mon, 4 Feb 2019 17:40:05 +0100 > please apply the following four fixes to -net. > > Patch 1 takes care of a common resource leak in various error paths, while the > second patch fixes a misordered kfree when cleaning up after an error. > The other two patches ensure

Re: [PATCH bpf-next] bpf: support SO_DEBUG in bpf_setsockopt()

2019-02-04 Thread Alexei Starovoitov
On Sun, Feb 03, 2019 at 04:15:07PM +0800, Yafang Shao wrote: > Then we can enable/disable socket debugging without modifying user code. > That is more convenient for debugging. > > Signed-off-by: Yafang Shao > --- > include/net/sock.h | 8 > net/core/filter.c | 3 +++ > net/core/sock.c

  1   2   3   >