On Mon, 4 Feb 2019 12:25:13 +0530, Vasundhara Volam wrote: > > > IMHO this is not really a problem. We can either use an additional flag > > > telling kernel/driver if we are setting runtime or persistent WoL mask > > > or we can pass (up to) two bitmaps. > Jakub, I will add another two bitmask parameters for WoL named as > wake_on_lan_runtime > and wake_on_lan_persistent. This will give information about what > types are runtime and > what types are persistent, does the device support for any given WoL types. > > Does that sound good?
No? We were talking about using the soon-too-come ethtool netlink API with additional indication that given configuration request is supposed to be persisted. Adding more devlink parameters is exactly the opposite of what you should be doing.
