On Tue, Feb 5, 2019 at 8:26 AM Jakub Kicinski <jakub.kicin...@netronome.com> wrote: > > On Mon, 4 Feb 2019 12:25:13 +0530, Vasundhara Volam wrote: > > > > IMHO this is not really a problem. We can either use an additional flag > > > > telling kernel/driver if we are setting runtime or persistent WoL mask > > > > or we can pass (up to) two bitmaps. > > Jakub, I will add another two bitmask parameters for WoL named as > > wake_on_lan_runtime > > and wake_on_lan_persistent. This will give information about what > > types are runtime and > > what types are persistent, does the device support for any given WoL types. > > > > Does that sound good? > > No? We were talking about using the soon-too-come ethtool netlink > API with additional indication that given configuration request is > supposed to be persisted. Adding more devlink parameters is exactly > the opposite of what you should be doing. Okay. So, till then can we have the devlink wake_on_lan parameter or you want this to be removed? Could you please clarify?
Once ethtool netlink API is available with persisted support, I can remove this wake_on_lan parameter from devlink. Thanks.
