On 2/3/19 9:04 AM, David Miller wrote:
> From: Zhiqiang Liu <liuzhiqian...@huawei.com>
> Date: Sun, 3 Feb 2019 14:10:31 +0800
> 
>> @@ -1165,7 +1165,8 @@ enum cleanup_prefix_rt_t {
>>      list_for_each_entry(ifa, &idev->addr_list, if_list) {
>>              if (ifa == ifp)
>>                      continue;
>> -            if (!ipv6_prefix_equal(&ifa->addr, &ifp->addr,
>> +            if (ifa->prefix_len != ifp->prefix_len ||
>> +                    !ipv6_prefix_equal(&ifa->addr, &ifp->addr,
>>                                     ifp->prefix_len))
> 
> Please fix the indentation of this conditional, it should be:
> 
>               if (ifa->prefix_len != ifp->prefix_len ||
>                   !ipv6_prefix_equal(&ifa->addr, &ifp->addr,
>                                      ifp->prefix_len))
> 
> Thank you.
> 

Needs a Fixes tag too.

Fixes: 5b84efecb7d9 ("ipv6 addrconf: don't cleanup prefix route for
IFA_F_NOPREFIXROUTE")

and cc to that author Thomas Haller <thal...@redhat.com>

Reply via email to