Hi Daniel,
Overall changes looks good to me, in "B6726695.java" you have used ".loopback()" which is not consistent with the other similar URL construction changes although i can see that "ProxyTest.java" uses ".loopback()" as well.
Thanks,
Vyom
- Original message -From: Daniel Fuchs
Hi Chris,
Change looks OK to me as method specifications tells " This method returns null if the JAR file URL corresponding to this connection points to a JAR file and not a JAR file entry."
Thanks,
Vyom
- Original message -From: Chris Hegarty Sent by: "net-dev" To: OpenJDK Network
Hi Daniel,
Changes looks good to me, although it is different issue, i can see lots of '.*' in import statements, as you are touching these files did you considered removing them ?.
Thanks,
Vyom
- Original message -From: Daniel Fuchs Sent by: "net-dev" To: OpenJDK Network Dev list Cc:
Looks good to me Daniel.
Vyom
- Original message -From: Daniel Fuchs Sent by: "net-dev" To: OpenJDK Network Dev list Cc:Subject: [EXTERNAL] [teststabilization] RFR: 8226514: Replace wildcard address with loopback or local host in tests - part 17Date: Wed, Jun 26, 2019 9:00 PM
Hi,Please f
Hi Frank,
thanks for fixing this issue, in test setup we are setting the permissions explicitly to 333, can we set the permissions 733 in test setup itself ?.
i changed the permission to 733 in test setup and run the test at my Linux box and test ran successfully without any problem.
th
that's what i suspected, but test is passing at my local env even after i changes the permission to 733.
Vyom
- Original message -From: "Frank Yuan" To: "'Vyom Tewari26'" Cc: Subject: [EXTERNAL] RE: RFR (13) [testbug]: 8227422: sun/net/www/protocol/f
et 333 permission, please read https://bugs.openjdk.java.net/browse/JDK-6977851
Anyway, please note this patch is to fix the directory was not cleaned after test completed to run.
Thanks
Frank
From: Vyom Tewari26 [mailto:vtewa...@in.ibm.com]Sent: Wednesday, July 10, 2019 2:34 PMTo: fr
Looks good to me.
Vyom
- Original message -From: Claes Redestad Sent by: "net-dev" To: OpenJDK Network Dev list Cc:Subject: [EXTERNAL] RFR: 8227720: Improve ExtendedSocketOptions initializationDate: Tue, Jul 16, 2019 7:36 PM
Hi,a small cleanup and startup optimization for apps that setup
looks good to me.
Thanks,
Vyom
- Original message -From: Aleks Efimov Sent by: "net-dev" To: net-dev Cc:Subject: [teststabilization] RFR: 8225430: Replace wildcard address with loopback or local host in tests - part 14Date: Tue, Aug 6, 2019 8:13 PM
Hi,Please help to review few test fixes
Hi Jaikiran,
Code changes look OK to me , couple of minor comments
1-> you don't need "this" to access stop(this.stop)
2-> i think super.stop() should be the first line in the overridden stop method.
3-> it is matter of personal preference but my preference is use the new variable name 'running'
Hi Julia,
Thanks for fixing this test issue, in your modified code server will get closed twice once in main thread(server.setFinished(true);) and once in server run method. Please close server if it is already not closed(if (!server.isClosed()) { server.close();}) or remove server.close() from
Hi Patric,
code change looks OK to me.
Thanks,
Vyom
- Original message -From: Patrick Concannon Sent by: "net-dev" To: OpenJDK Network Dev list Cc:Subject: [EXTERNAL] RFR[8230132]: java/net/NetworkInterface/NetworkInterfaceRetrievalTests.java to skip Teredo Tunneling Pseudo-InterfaceD
Hi Jaikiran,
Please find my comments inline.
- Original message -From: Jaikiran Pai To: Vyom Tewari26 Cc: daniel.fu...@oracle.com, net-dev@openjdk.java.netSubject: [EXTERNAL] Re: RFR: 8223714: HTTPSetAuthenticatorTest could be made more resilientDate: Mon, Sep 2, 2019 9:21 AM
Hello
Hi Patrick,
New test looks good to me, minor bit jtreg tag order in not correct , generally @run tag comes last.
Thanks,
Vyom
- Original message -From: Daniel Fuchs Sent by: "net-dev" To: Patrick Concannon , OpenJDK Network Dev list Cc:Subject: [EXTERNAL] Re: RFR[8230159]: Add test t
looks OK to me.
Vyom
- Original message -From: Patrick Concannon To: Vyom Tewari26 , daniel.fu...@oracle.comCc: net-dev@openjdk.java.netSubject: [EXTERNAL] Re: RFR[8230159]: Add test to verify that com.sun.net.httpserver.BasicAuthenticator constructors throw expected exceptionsDate: Wed
Hi Mathias,
Code change looks OK to me.
Thanks,
Vyom
- Original message -From: "Baesken, Matthias" Sent by: "net-dev" To: "net-dev@openjdk.java.net" Cc:Subject: [EXTERNAL] RFR [XS] : 8230856: Java_java_net_NetworkInterface_getByName0 on unix misses ReleaseStringUTFChars in early retur
Hi Julia,
Fix looks good to me, i tested the fix it worked for us.
Thanks,
Vyom
- Original message -From: Julia Boes Sent by: "net-dev" To: net-dev@openjdk.java.netCc:Subject: [EXTERNAL] RFR: 8209178: Proxied HttpsURLConnection doesn't send BODY when retrying POST requestDate: Tue, Se
+1
Vyom
- Original message -From: Daniel Fuchs Sent by: "net-dev" To: Julia Boes , net-dev@openjdk.java.netCc:Subject: [EXTERNAL] Re: RFR: 8231632: HttpURLConnection::usingProxy could specify that it may lazily evaluate the factDate: Wed, Oct 30, 2019 12:26 AM
Looks good to me Julia!best
Hi Julia,
Your new iterator approach looks good to me. one minor comment as you are using 'var' language construct the variable name 'au' is not a meaning full name .
Thanks,
Vyom
- Original message -From: Julia Boes Sent by: "net-dev" To: OpenJDK Network Dev list Cc:Subject: [EXTERN
Hi Ivan,
cookie expiration date change(Sat, 09-Nov-2019 23:12:40 GMT) looks ok to me.
Thanks,
Vyom
- Original message -From: Ivan Gerasimov Sent by: "net-dev" To: net-dev@openjdk.java.netCc:Subject: [EXTERNAL] RFR 8233886 : TEST_BUG jdk/java/net/CookieHandler/B6791927.java hit hardcod
Hi Patric,
Change looks ok to me, one minor bit i will suggest you to use "List.of()" in place of "new ArrayList<>();".
Thanks,
Vyom
- Original message -From: Patrick Concannon Sent by: "net-dev" To: Alan Bateman , OpenJDK Network Dev list Cc:Subject: [EXTERNAL] Re: RFR[8233860]: java/n
looks good to me.
Vyom
- Original message -From: Patrick Concannon To: Vyom Tewari26 Cc: alan.bate...@oracle.com, net-dev@openjdk.java.netSubject: [EXTERNAL] Re: RFR[8233860]: java/net/SocketOption/AfterClose.java test incorrectly handles IP_MULTICAST_IFDate: Thu, Nov 14, 2019 4:27 PM
Hi Patric,
Changes looks good to me.
Thanks,
Vyom
- Original message -From: Patrick Concannon Sent by: "net-dev" To: OpenJDK Network Dev list Cc:Subject: [EXTERNAL] RFR[8234083]: DatagramSocket should report SO_BROADCAST as a supported optionDate: Fri, Nov 15, 2019 6:45 PM
Hi,Could s
looks OK to me, i searched through entire JDK code base and i did not found any uses of "NET_ReadV" .
Thanks,
Vyom
- Original message -From: "Baesken, Matthias" Sent by: "net-dev" To: "net-dev@openjdk.java.net" Cc:Subject: [EXTERNAL] RFR: [XS] 8234501 : remove obsolete NET_ReadVDate: W
Hi Mathias,
Code change looks OK to me, although i am not the official OpenJDK reviewer.
Thanks,
Vyom
- Original message -From: "Baesken, Matthias" Sent by: "net-dev" To: Alan Bateman , "net-dev@openjdk.java.net" Cc:Subject: [EXTERNAL] RE: RFR: 8234629: remove unused functions from li
Hi Julia,
thanks for looking into this issue, it looks like regression, in JDK8 we don't do join() on "dispatcherThread" in stop(). We need to find out why we introduce the below code.
if (dispatcherThread != null) { try {
Hi Patrick,
Changes looks OK to me except, SupportedOptionsCheck tests
if (!Platform.isWindows())
55 assertTrue(options.containsAll(multicastOptions));
What this test will do on Windows ?.
Thanks,
Vyom
- Original message -From: Alan Bateman Sent by: "net-dev" T
Hi Patrick,
Thanks for explanation.
Vyom
- Original message -From: Patrick Concannon To: Vyom Tewari26 , alan.bate...@oracle.comCc: daniel.fu...@oracle.com, net-dev@openjdk.java.netSubject: [EXTERNAL] Re: RFR[8234148]: DatagramSocket.setOption/getOption/supportedOption should support
Hi Julia,
Your change looks OK but it will increase the worst case, running time of test from (2500+1000)ms to (15000 + 1000)ms and this will definitely decrease the probability of intermittent failure but not 100% full proof.
Thanks,
Vyom
- Original message -From: Julia Boes Sent
Hi Felix,
Thanks for review, writing a test case is not straight forward.
we have to manually inject the write failure, if you see the attached reproducer with the issue it hacks the send native API and inject on the client side which simulates a transient network failure.
Even i was not a
Sounds good
Thanks,
Vyom
- Original message -From: Daniel Fuchs Sent by: "net-dev" To: Vyom Tiwari , net-dev , core-libs-dev Cc:Subject: [EXTERNAL] Re: RFR 8238579: HttpsURLConnection drops the timeout and hangs forever in readDate: Sat, Feb 15, 2020 1:11 AM
Hi Vyom,On the surface, your
Hi ,
Please find the below fix for the issue(https://bugs.openjdk.java.net/browse/JDK-8237858). In "PlainSocketImpl_socketAccept" did not handle -1 timeout properly.
In case of -1 timeout, "PlainSocketImpl_socketAccept" calls "NET_Timeout" if it is interrupted by signal(EINTR) then in case of
Hi Daniel,
Thanks for the review i need a favor , as my OpenJDK(vtewari) id is not working so i can not push the code.
Can you please push the code once review is done.
Thanks,
Vyom
- Original message -From: Daniel Fuchs To: Vyom Tewari26 Cc: core-libs-...@openjdk.java.net, net
Hi Ravi,
Latest changes looks good to me.
Thanks,
Vyom
- Original message -From: Ravi Reddy Sent by: "net-dev" To: Daniel Fuchs , Vyom Tiwari Cc: net-dev Subject: [EXTERNAL] RE: RFR[15] JDK-8183369 : RFC unconformity of HttpURLConnection with proxyDate: Mon, Mar 2, 2020 8:32 PM
Hi Da
Ping,
please review the below code.
Vyom
- Original message -From: "Vyom Tewari26" Sent by: "net-dev" To: net-dev@openjdk.java.netCc:Subject: [EXTERNAL] RFR 8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectlyDate: Tue, Feb 25, 2020 10:07 PM
Hi ,
P
Hi Daniel,
thanks for the review, i pushed the change(https://hg.openjdk.java.net/jdk/jdk/rev/ca2dcaf37fad).
Thanks,
Vyom
- Original message -From: Daniel Fuchs To: Vyom Tewari26 Cc: core-libs-...@openjdk.java.net, net-dev@openjdk.java.net, vyomm...@gmail.comSubject: [EXTERNAL] Re
Hi,
Patch looks OK to me, although i am not the official reviewer.
Thanks,
Vyom
- Original message -From: sha.ji...@oracle.comSent by: "net-dev" To: net-dev@openjdk.java.netCc:Subject: [EXTERNAL] Re: RFR[15] JDK-8238740: java/net/httpclient/whitebox/FlowTestDriver.java would not specify
age -From: Daniel Fuchs To: Vyom Tewari26 , net-dev@openjdk.java.netCc:Subject: [EXTERNAL] Re: RFR 8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectlyDate: Tue, Mar 10, 2020 9:07 PM
Hi Vyom,I have sent your proposed fix to our test system and observed noregression. I agree your pro
I think changes are good & safe and we don't need to do any additional changes.
Thanks,
Vyom
- Original message -From: Daniel Fuchs To: Vyom Tewari26 Cc: net-dev@openjdk.java.netSubject: [EXTERNAL] Re: RFR 8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectlyDate:
t do you think?>> Also JDK-8179905 [1] also modified aix_close.c, solaris_close.c,> bsd_close.c [2] - so I believe you should also fix all these places.>> best regards,>> -- daniel>> [1] https://bugs.openjdk.java.net/browse/JDK-8179905 > [2] http://hg.openjdk.java.net/jdk1
yom
- Original message -From: Alan Bateman To: Vyom Tewari26 Cc: net-dev@openjdk.java.netSubject: [EXTERNAL] Re: RFR 8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectlyDate: Wed, Mar 11, 2020 12:49 PM
Vyom,Are you planning to create a native test for this? I realize the fix youare discuss
Hi Vipin,
changes looks OK to me as well , i will sponsor this doc patch for you.
Thanks,
Vyom
- Original message -From: Alan Bateman Sent by: "net-dev" To: Vipin Mv1 , net-dev@openjdk.java.netCc:Subject: [EXTERNAL] Re: Fw: RE: RFR 8129841 Update comment for Java_java_net_Inet6Address
42 matches
Mail list logo
