Hi Patrick,
Changes looks OK to me except, SupportedOptionsCheck tests
if (!Platform.isWindows()) 55 assertTrue(options.containsAll(multicastOptions));
What this test will do on Windows ?.
Thanks,
Vyom
----- Original message -----
From: Alan Bateman <alan.bate...@oracle.com>
Sent by: "net-dev" <net-dev-boun...@openjdk.java.net>
To: Daniel Fuchs <daniel.fu...@oracle.com>, Patrick Concannon <patrick.concan...@oracle.com>, OpenJDK Network Dev list <net-dev@openjdk.java.net>
Cc:
Subject: [EXTERNAL] Re: RFR[8234148]: DatagramSocket.setOption/getOption/supportedOption should support multicast options
Date: Fri, Dec 6, 2019 4:06 AM
On 05/12/2019 16:01, Daniel Fuchs wrote:
> This looks good to me Patrick.
> With this fix multicast socket options can be set on DatagramSocket,
> except on windows when the DualStackPlainDatagramSocketImpl is used.
>
> DualStackPlainDatagramSocketImpl.java:
>
> 246 if (isReusePortAvailable())
> 247 options.add(StandardSocketOptions.SO_REUSEPORT);
>
> I believe you can remove these two lines as SO_REUSEPORT
> is obviously not supported as per line 215.
Good catch, otherwise looks good to me too.
-Alan
