Looks good to me Daniel.
Vyom
----- Original message -----
From: Daniel Fuchs <daniel.fu...@oracle.com>
Sent by: "net-dev" <net-dev-boun...@openjdk.java.net>
To: OpenJDK Network Dev list <net-dev@openjdk.java.net>
Cc:
Subject: [EXTERNAL] [teststabilization] RFR: 8226514: Replace wildcard address with loopback or local host in tests - part 17
Date: Wed, Jun 26, 2019 9:00 PM
Hi,
Please find below a patch for:
8226514: Replace wildcard address with loopback or local host in
tests - part 17
https://bugs.openjdk.java.net/browse/JDK-8226514
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8226514/webrev.00/
- The SetAuthenticator/ test had already been
updated but still required some cleanup WRT setting up the
proxy correctly.
- The NoNTLM test was passing trivially - I reworked it
slightly as some of the tests could be run whether
NTLM was supported or not.
- The FtpURLConnectionLeak was observed failing once in
what looked like a timeout occurring after the tests
seemed to have completed its job. It was interrupted
while sleeping for the last time before successful
completion... My suspicion is that this might have
happened because the test was running in samevm mode.
That test probably deserves to run in its own VM (and
is so updated)
- RetryPost was just missing a volatile.
The rest is BAU for this task as subject indicates...
best regards,
-- daniel
