Hi Patric,
Changes looks good to me.
Thanks,
Vyom
----- Original message -----
From: Patrick Concannon <patrick.concan...@oracle.com>
Sent by: "net-dev" <net-dev-boun...@openjdk.java.net>
To: OpenJDK Network Dev list <net-dev@openjdk.java.net>
Cc:
Subject: [EXTERNAL] RFR[8234083]: DatagramSocket should report SO_BROADCAST as a supported option
Date: Fri, Nov 15, 2019 6:45 PM
Hi,
Could someone please review my fix for issue JDK-8234083 'DatagramSocket
should report SO_BROADCAST as a supported option'?
DatagramSocket has setBroadcast/getBroadcast methods, but omits
SO_BROADCAST as a supported option. This fix adds SO_BROADCAST as a
valid option, and updates OptionsTest.java to reflect this addition.
As this change effects the source - the options are added to
AbstractPlainDatagramSocketImpl - I was wondering if a CSR would be needed?
bug: https://bugs.openjdk.java.net/browse/JDK-8234083
webrev: http://cr.openjdk.java.net/~pconcannon/8234083/webrevs/webrev.00/
Kind regards,
Patrick
