Hi Daniel,
Changes looks good to me, although it is different issue, i can see lots of '.*' in import statements, as you are touching these files did you considered removing them ?.
Thanks,
Vyom
----- Original message -----
From: Daniel Fuchs <daniel.fu...@oracle.com>
Sent by: "net-dev" <net-dev-boun...@openjdk.java.net>
To: OpenJDK Network Dev list <net-dev@openjdk.java.net>
Cc:
Subject: [EXTERNAL] [teststabilization] RFR: 8224865: Replace wildcard address with loopback or local host in tests - part 13
Date: Fri, Jun 7, 2019 4:57 PM
Hi,
Please find below a fix for:
8224865: Replace wildcard address with loopback or local host in
tests - part 13
https://bugs.openjdk.java.net/browse/JDK-8224865
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8224865/webrev.00/
Additional changes to note:
Some tests (B6401598.java, B6431193.java) were catching exceptions
too aggressively, hiding potential test issues. This is now fixed.
I had to revamp DigestTest.java. This test was passing for the
wrong reason. The test expected an exception when supplying
the wrong credential. However, the request was misformatted,
and the exception was generated because of that, making the
test happy.
I have added a test system property allowing to test both
the positive and negative cases, thus ensuring that the
request is properly formatted.
best regards,
-- daniel
