Hi,
Patch looks OK to me, although i am not the official reviewer.
Thanks,
Vyom
----- Original message -----
From: sha.ji...@oracle.com
Sent by: "net-dev" <net-dev-boun...@openjdk.java.net>
To: net-dev@openjdk.java.net
Cc:
Subject: [EXTERNAL] Re: RFR[15] JDK-8238740: java/net/httpclient/whitebox/FlowTestDriver.java would not specify a TLS protocol
Date: Mon, Mar 9, 2020 7:37 AM
Could this simple patch be reviewed?
John
On 2020/3/2 16:08, sha.ji...@oracle.com wrote:
> Hi,
> java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/FlowTest.java
> would not use a specific TLS protocol, instead just use the default
> TLS protocol, exactly TLSv1.3 now.
>
> diff -r 4a5a7dc9d05c
> test/jdk/java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/FlowTest.java
> ---
> a/test/jdk/java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/FlowTest.java
> Sun Mar 01 17:36:03 2020 -0800
> +++
> b/test/jdk/java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/FlowTest.java
> Mon Mar 02 16:01:15 2020 +0800
> @@ -1,5 +1,5 @@
> /*
> - * Copyright (c) 2017, 2018, Oracle and/or its affiliates. All rights
> reserved.
> + * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights
> reserved.
> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> *
> * This code is free software; you can redistribute it and/or modify it
> @@ -80,7 +80,6 @@
> SSLEngine engineClient = ctx.createSSLEngine();
> SSLParameters params = ctx.getSupportedSSLParameters();
> params.setApplicationProtocols(new String[]{"proto1",
> "proto2"}); // server will choose proto2
> - params.setProtocols(new String[]{"TLSv1.2"}); // TODO: This
> is essential. Needs to be protocol impl
> engineClient.setSSLParameters(params);
> engineClient.setUseClientMode(true);
> completion = new CompletableFuture<>();
>
> Best regards,
> John Jiang
>
