Re: RE: RE: RFR (13) [testbug]: 8227422: sun/net/www/protocol/file/DirPermissionDenied.java failed on Windows 2016 because DirPermissionDenied directory has no read permission

[Vyom Tewari26]

Hi,

 

Your changes  specific to this issue looks good and after your change directory is getting deleted on Windows as well.

 

DirPermissionDenied.java  is running successfully with 733 permission may be a separate issue.

 

Thanks,

Vyom

 

----- Original message -----
From: "Frank Yuan" <frank.y...@oracle.com>
To: "'Vyom Tewari26'" <vtewa...@in.ibm.com>
Cc: <net-dev@openjdk.java.net>
Subject: [EXTERNAL] RE: RE: RFR (13) [testbug]: 8227422: sun/net/www/protocol/file/DirPermissionDenied.java failed on Windows 2016 because DirPermissionDenied directory has no read permission
Date: Wed, Jul 10, 2019 2:04 PM
 

IOException is expected by set 333 permission, please read https://bugs.openjdk.java.net/browse/JDK-6977851

Anyway, please note this patch is to fix the directory was not cleaned after test completed to run.

 

Thanks

Frank

 

 

From: Vyom Tewari26 [mailto:vtewa...@in.ibm.com]
Sent: Wednesday, July 10, 2019 2:34 PM
To: frank.y...@oracle.com
Cc: net-dev@openjdk.java.net
Subject: Re: RE: RFR (13) [testbug]: 8227422: sun/net/www/protocol/file/DirPermissionDenied.java failed on Windows 2016 because DirPermissionDenied directory has no read permission

 

that's what i suspected, but test is passing at my local env  even after i changes the permission to 733.

Vyom

 

----- Original message -----
From: "Frank Yuan" <frank.y...@oracle.com>
To: "'Vyom Tewari26'" <vtewa...@in.ibm.com>
Cc: <net-dev@openjdk.java.net>
Subject: [EXTERNAL] RE: RFR (13) [testbug]: 8227422: sun/net/www/protocol/file/DirPermissionDenied.java failed on Windows 2016 because DirPermissionDenied directory has no read permission
Date: Wed, Jul 10, 2019 11:33 AM
 

Hi Vyom

 

The test requires the directory to be unreadable.

 

Thanks

Frank

 

From: Vyom Tewari26 [mailto:vtewa...@in.ibm.com]
Sent: Wednesday, July 10, 2019 1:53 PM
To: frank.y...@oracle.com
Cc: net-dev@openjdk.java.net
Subject: Re: RFR (13) [testbug]: 8227422: sun/net/www/protocol/file/DirPermissionDenied.java failed on Windows 2016 because DirPermissionDenied directory has no read permission

 

 

Hi Frank,

 

thanks for fixing this issue, in test setup we are setting the permissions explicitly to 333, can we set the permissions  733 in test setup  itself ?.

 

i changed the permission to 733 in test setup and run the test at my Linux box and test ran successfully without any problem.

 

 

thanks,

Vyom

----- Original message -----
From: "Frank Yuan" <frank.y...@oracle.com>
Sent by: "net-dev" <net-dev-boun...@openjdk.java.net>
To: <net-dev@openjdk.java.net>
Cc:
Subject: [EXTERNAL] RFR (13) [testbug]: 8227422: sun/net/www/protocol/file/DirPermissionDenied.java failed on Windows 2016 because DirPermissionDenied directory has no read permission
Date: Wed, Jul 10, 2019 10:37 AM
 

Hi all

 

Would you like to review this patch?

Bug: https://bugs.openjdk.java.net/browse/JDK-8227422

Webrev: http://cr.openjdk.java.net/~fyuan/8227422/webrev.00/

 

In this patch, I add read permission before cleaning up the test directory to make sure the directory is removable on Windows system.

 

Thanks

Frank