This is currently 'tidying' in my tree. It applies on top of my last 3 part
series of BO bugfixes and tidying ('bofixes' in my tree).
Patch 1 is
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@l
On 07/02/2013 01:54 AM, Kenneth Graunke wrote:
There are always better ways to do things.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/intel_screen.c | 5 -
1 file changed, 5 deletions(-)
Patches 2-5 are
Reviewed-by: Chad Versace
(-)
Patches 7-9 are
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 07/02/2013 01:54 AM, Kenneth Graunke wrote:
The __DRI_USE_INVALIDATE extension was added in May 11th, 2010 by commit
4258e3a2e1c327. At this point, it's unlikely that anyone's using the
right mix of new and old components to hit this path. Deleting it
removes an untested code path and cleans
s into
one location until a better approach becomes apparent.
Patches 10-11 are
Reviewed-by: Chad Versace
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_context.h | 2 ++
src/mesa/drivers/dri/i965/brw_vtbl.c | 1 -
src/mesa/drivers/dri/i965/brw_wm.h| 2 --
+-
src/mesa/drivers/dri/i965/intel_context.c | 1 -
src/mesa/drivers/dri/i965/intel_context.h | 1 -
4 files changed, 3 insertions(+), 5 deletions(-)
Patches 12-14 are
Reviewed-by: Chad Versace
Thanks for breaking up the vtbl patches into digestible chunks
s/dri/i965/intel_tex_layout.c
delete mode 100644 src/mesa/drivers/dri/i965/intel_tex_layout.h
This mini series is
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
e copy constructor, and its signature is `T::T(const
T&)`.
I'm still uncomfortable that we're not deep-copying
ast_type_specifier::structure,
but I'll trust you.
With the commit subject fixed,
Reviewed-by: Chad Versace
___
mesa-dev m
On 07/03/2013 12:03 PM, Matt Turner wrote:
---
src/glsl/ast.h | 12
1 file changed, 12 insertions(+)
diff --git a/src/glsl/ast.h b/src/glsl/ast.h
index 3bb33c5..f00ef3a 100644
--- a/src/glsl/ast.h
+++ b/src/glsl/ast.h
@@ -453,6 +453,18 @@ class ast_declarator_list;
class ast_s
atch 8 is
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 07/08/2013 04:09 PM, Matt Turner wrote:
Fixes MESA_GL_VERSION_OVERRIDE=3.2 egl-create-context-verify-gl-flavor.
---
src/mesa/main/context.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c
index 5ad04cc..d687fb7 1006
Acked-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 07/11/2013 10:18 PM, Paul Berry wrote:
On 11 July 2013 16:30, Ian Romanick wrote:
I believe you're right, that there's a bug in our implementation--it would
successfully compile this shader, and it shouldn't.
In fact, based on my discussion with Chad today, it sounds like we don't
have a
On 07/12/2013 12:25 PM, Fredrik Höglund wrote:
On Friday 12 July 2013, Chad Versace wrote:
On 07/11/2013 10:18 PM, Paul Berry wrote:
Another possibility that Chad suggested when I was talking to him this
afternoon is to just just return BAD_MATCH if the client supplies the
forward
Add dri2_egl_display_vtbl::create_pbuffer_surface, set it for each
platform, and let egl_dri2 dispatch eglCreatePixmapSurface to that.
This prepares for the EGL platform extensions.
Signed-off-by: Chad Versace
---
src/egl/drivers/dri2/egl_dri2.c | 11 +++
src/egl/drivers/dri2
This pulls in EGL_EXT_platform_base, EGL_EXT_platform_wayland,
EGL_EXT_platform_x11, and EGL_MESA_platform_gbm.
This patch has a lot of churn because Khronos recently changed its
method of generating headers. Khronos now generates it headers from XML.
Signed-off-by: Chad Versace
---
include
but those patches are also quite small.
Chad Versace (25):
egl: Update to revision 24567 of eglext.h
egl/dri2: Move dri2_egl_display virtual funcs to vtbl
egl/dri2: Put platform func names into proper namespaces
egl/wl: Call dri2_swap_interval() statically
egl/dri2: Dispatch eglSwapInterval
Add dri2_egl_display_vtbl::swap_buffers_with_damage, set it for each
platform, and let egl_dri2 dispatch eglSwapBuffersWithDamageEXT to that.
This prepares for the EGL platform extensions.
Signed-off-by: Chad Versace
---
src/egl/drivers/dri2/egl_dri2.c | 11 +++
src/egl
dri2_egl_display has only one virtual function, 'authenticate'. Define
dri2_egl_display::vtbl and move 'authenticate' there.
This prepares for the EGL platform extensions, which will add many
more virtual functions to dri2_egl_display.
Signed-off-by: Chad Versace
---
n
tools.
For each function in platform_x11.c prefixed with 'dri2', this patch
changes its prefix to 'dri2_x11'. Likewise for platform_drm.c and
'dri2_drm'; and platform_wayland.c and 'dri2_wl'.
Signed-off-by: Chad Versace
---
src/egl/drivers/dri2/platform_drm.c
Don't call it through the driver dispatch table. Just call it
statically.
This prepares for the EGL platform extensions.
Signed-off-by: Chad Versace
---
src/egl/drivers/dri2/platform_wayland.c | 6 +-
src/egl/drivers/dri2/platform_x11.c | 6 +-
2 files changed, 10 insertions(
Add dri2_egl_display_vtbl::swap_interval, set it for each platform, and
let egl_dri2 dispatch eglSwapInterval to that.
This prepares for the EGL platform extensions.
Signed-off-by: Chad Versace
---
src/egl/drivers/dri2/egl_dri2.c | 9
src/egl/drivers/dri2/egl_dri2.h
Add dri2_egl_display_vtbl::create_window_surface, set it for each
platform, and let egl_dri2 dispatch eglCreateWindowSurface to that.
This prepares for the EGL platform extensions.
Signed-off-by: Chad Versace
---
src/egl/drivers/dri2/egl_dri2.c | 11 +++
src/egl/drivers/dri2
Add dri2_egl_display_vtbl::swap_buffers, set it for each platform, and
let egl_dri2 dispatch eglSwapBuffers to that.
This prepares for the EGL platform extensions.
Signed-off-by: Chad Versace
---
src/egl/drivers/dri2/egl_dri2.c | 8
src/egl/drivers/dri2/egl_dri2.h | 3
Add dri2_egl_display_vtbl::destroy_surface, set it for each
platform, and let egl_dri2 dispatch eglDestroySurface to that.
This prepares for the EGL platform extensions.
Signed-off-by: Chad Versace
---
src/egl/drivers/dri2/egl_dri2.c | 8
src/egl/drivers/dri2/egl_dri2.h
n was running
and the kernel had render nodes enabled.
Also tested by running weston-smoke in stand-alone Weston.
Signed-off-by: Chad Versace
---
src/egl/main/eglapi.c | 132 ++
src/egl/main/egldisplay.c | 72 +
src/egl
ch removes from egl/main and egl/dri2 all internal use of the
EGLNative types. It replaces them with 'void*' and checks each explicit
cast with a static assertion. Also, the patch touches egl_gallium the
minimal amount to keep it compatible with eglapi.h.
Signed-off-by: Chad Versace
Add dri2_egl_display_vtbl::copy_buffers, set it for each
platform, and let egl_dri2 dispatch eglCopyBuffers to that.
This prepares for the EGL platform extensions.
Signed-off-by: Chad Versace
---
src/egl/drivers/dri2/egl_dri2.c | 9 +
src/egl/drivers/dri2/egl_dri2.h
Add dri2_egl_display_vtbl::query_buffer_age, set it for each
platform, and let egl_dri2 dispatch API.QueryBufferAge to that.
This prepares for the EGL platform extensions.
Signed-off-by: Chad Versace
---
src/egl/drivers/dri2/egl_dri2.c | 8
src/egl/drivers/dri2/egl_dri2.h
Add dri2_egl_display_vtbl::post_sub_buffer, set it for each
platform, and let egl_dri2 dispatch eglPostSubBufferNV to that.
This prepares for the EGL platform extensions.
Signed-off-by: Chad Versace
---
src/egl/drivers/dri2/egl_dri2.c | 9 +
src/egl/drivers/dri2/egl_dri2.h
Add dri2_egl_display_vtbl::swap_buffers_region, set it for each
platform, and let egl_dri2 dispatch eglSwapBuffersRegionNOK to that.
This prepares for the EGL platform extensions.
Signed-off-by: Chad Versace
---
src/egl/drivers/dri2/egl_dri2.c | 9 +
src/egl/drivers/dri2
>From the EGL_EXT_wayland_spec, version 3:
It is not valid to call eglCreatePlatformPixmapSurfaceEXT with a
that belongs to Wayland. Any such call fails and generates
EGL_BAD_PARAMETER.
Signed-off-by: Chad Versace
---
src/egl/drivers/dri2/platform_wayland.c | 18 +-
Signed-off-by: Chad Versace
---
src/egl/main/eglcompiler.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/egl/main/eglcompiler.h b/src/egl/main/eglcompiler.h
index 2499172..53dab54 100644
--- a/src/egl/main/eglcompiler.h
+++ b/src/egl/main/eglcompiler.h
@@ -89,4 +89,9 @@
# define
supported.
Signed-off-by: Chad Versace
---
src/egl/drivers/dri2/platform_x11.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_x11.c
b/src/egl/drivers/dri2/platform_x11.c
index e41758b..3c97a95 100644
--- a/src/egl/drivers/dri2/platform_x11.c
+++ b/src/egl/dr
>From the EGL_MESA_platform_gbm spec, version 5:
It is not valid to call eglCreatePlatformPixmapSurfaceEXT with a
that belongs to the GBM platform. Any such call fails and generates
EGL_BAD_PARAMETER.
Signed-off-by: Chad Versace
---
src/egl/drivers/dri2/platform_drm.c |
Add dri2_egl_display_vtbl::create_pbuffer_surface, set it for each
platform, and let egl_dri2 dispatch eglCreatePbufferSurface to that.
This prepares for the EGL platform extensions.
Signed-off-by: Chad Versace
---
src/egl/drivers/dri2/egl_dri2.c | 9 +
src/egl/drivers/dri2
When the user calls eglGetDisplay(EGL_DEFAULT_DISPLAY), the Wayland and
DRM platforms set dri2_dpy->own_device=true. This patch makes the X11
platform do the same for consistency.
Signed-off-by: Chad Versace
---
src/egl/drivers/dri2/platform_x11.c | 3 +++
1 file changed, 3 insertions(+)
d
Add dri2_egl_display_vtbl::create_image, set it for each platform, and
let egl_dri2 dispatch eglCreateImageKHR to that.
To remove ambiguity, rename egl_dri2.c:dri2_create_image() to
dri2_create_image_from_dri().
This prepares for the EGL platform extensions.
Signed-off-by: Chad Versace
Add dri2_egl_display_vtbl::create_wayland_buffer_from_image, set it for
each platform, and let egl_dri2 dispatch
eglCreateWaylandBufferFromImageWL to that.
This prepares for the EGL platform extensions.
Signed-off-by: Chad Versace
---
src/egl/drivers/dri2/egl_dri2.c | 9
d action even when EGL didn't own the native display. In the
inversion, I replaced `disp->PlatformDisplay == NULL` with
`dri2_dpy->own_device` because the two expressions are synonymous, but
the latter's meaning is clearer.
Signed-off-by: Chad Versace
---
src/egl/drivers/dri2
On Tue, Mar 11, 2014 at 04:20:41PM +, Jordan Justen wrote:
> On Mon, Mar 10, 2014 at 11:19 AM, Vidudaya Bandara
> wrote:
> > Hi all,
> > I'm Vidudaya Neranjan Bandara , Currently I'm an undergraduate from
> > University of Moratuwa , Department of Computer Science and Engineering, Sri
> > Lan
Vidudaya,
I have some comments on Jordan's list of subgoals.
1. Waffle's examples/gl_basic.c
gl_basic is a little toy program that developers can use to test
Waffle when adding support for new platforms, such as WGL. If
you can get gl_basic to work on WGL, then that wil
On 12/08/2014 01:45 PM, Ian Romanick wrote:
> On 12/02/2014 12:10 AM, Valentin Corfu wrote:
>> With this check we can avoid segmentation fault when invalid value used
>> during eglCreateContext.
>>
>> Cc: mesa-sta...@lists.freedesktop.org
>> Cc: mesa-dev@lists.freedesktop.org
>> Signed-off-by: Val
On 12/10/2014 07:08 AM, Valentin Corfu wrote:
>
> On 10.12.2014 07:02, Chad Versace wrote:
>> On 12/08/2014 01:45 PM, Ian Romanick wrote:
>>> On 12/02/2014 12:10 AM, Valentin Corfu wrote:
>>>> With this check we can avoid segmentation fault when invalid value u
On 12/19/2014 11:58 AM, Ian Romanick wrote:
> On 12/18/2014 10:14 PM, Kenneth Graunke wrote:
>> On Tuesday, November 18, 2014 09:11:26 PM Chad Versace wrote:
>>> This patch reduces the likelihood of pointer arithmetic overflow bugs in
>>> gather_oa_results(), like
cube_level_complete(texObj, texObj->BaseLevel);
You forgot to return here ^^^
> +}
This patch makes sense to me after our irc conversation.
With the return fixed,
Reviewed-by: Chad Versace
signature.asc
Description: OpenPGP digital signature
__
On 12/31/2014 05:26 PM, Laura Ekstrand wrote:
> This is part of a potential solution to Khronos Bug 13223. Cube completeness
> is a concept from glGenerateMipmap, but it seems reasonable to check for it in
> GetTextureImage when the target is GL_TEXTURE_CUBE_MAP.
> ---
> src/mesa/main/texgetimage
On 12/31/2014 05:26 PM, Laura Ekstrand wrote:
> This is part of a potential solution to Khronos Bug 13223. Cube completeness
> is a concept from glGenerateMipmap, but it seems reasonable to check for it in
> TextureSubImage when target=GL_TEXTURE_CUBE_MAP.
> ---
> src/mesa/main/teximage.c | 42 ++
On 01/05/2015 10:34 AM, Laura Ekstrand wrote:
> I added a clearer explanation based on our irc discussion:
>
> http://cgit.freedesktop.org/~ldeks/mesa/commit/?h=adsa-textures&id=db418437915bba959c0b6c8babe40f675bbdf31c
Thanks. LGTM.
signature.asc
Description: OpenPGP digital signature
age.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Patch is
Reviewed-by: Chad Versace
signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 01/03/2015 11:54 AM, Jason Ekstrand wrote:
> From: Sisinty Sasmita Patra
>
> This commit refactors the tiled_memcpy code in intel_tex_subimage.c and
> moves it into its own file intel_tiled_memcpy files. Also, xtile_copy and
> ytile_copy are renamed to linear_to_xtiled and linear_to_ytiled
>
oc tile_copy_fn
> + */
> +static FLATTEN void
> +ytiled_to_linear_faster(uint32_t x0, uint32_t x1, uint32_t x2, uint32_t x3,
> +uint32_t y0, uint32_t y1,
> +char *dst, const char *src,
> +uint32_t dst_pitch,
> +
On 11/25/2014 11:09 PM, Tapani Pälli wrote:
> Patch enables ES2 extension that utilizes existing ES3 functionality.
>
> Changes make all the subtests to run and pass in WebGL conformance
> test 'webgl-draw-buffers' when running Chrome on OpenGL ES.
>
> v2: remove unused boolean (Ilia Mirkin)
>
>
On 01/09/2015 02:11 PM, michael.w.ma...@intel.com wrote:
> From: Mike Mason
The substance of this patch looks good to me. I have a few formatting nitpicks
though.
> Removes commit 7894278 changes and moves fix to _mesa_GetInternalformativ().
> The original commit enabled the GL_RGB and GL_RGBA
om
> intel_tiled_memcpy.h to intel_tiled_memcpy.c
>- Added proper documentation for intel_get_memcpy
>- Incorperated the ptrdiff_t tweaks from commit 225a09790
>
> v3: Jason Ekstrand
>- Fixed a comment
>- Move the tile size constants into the .c fil
On 01/12/2015 10:22 AM, Jason Ekstrand wrote:
> From: Sisinty Sasmita Patra
>
> Added intel_readpixels_tiled_mempcpy and intel_gettexsubimage_tiled_mempcpy
> functions. These are the fast paths for glReadPixels and glGetTexImage.
>
> On chrome, using the RoboHornet 2D Canvas toDataURL test, this
On 01/09/2015 05:21 PM, michael.w.ma...@intel.com wrote:
> From: Mike Mason
>
> Changes the initial internal format of a render buffer
> to GL_RGBA4. This fixes a failure in the following
> DrawElements test:
>
> dEQP-GLES3.functional.state_query.rbo.renderbuffer_internal_format
> ---
> src/mes
ions(+), 7 deletions(-)
Reviewed-by: Chad Versace
Matt commented on v1, so let's wait for his comments on this version too
before committing the patch.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 01/13/2015 11:12 AM, Matt Turner wrote:
> On Tue, Jan 13, 2015 at 10:49 AM, Chad Versace wrote:
>> On 01/12/2015 02:37 PM, michael.w.ma...@intel.com wrote:
>>> From: Mike Mason
>>>
>>> Removes commit 7894278 changes and moves fix to _mesa_GetInternalformati
-buffers' when running Chrome on OpenGL ES, also
>> Piglit test 'draw_buffers_gles2' passes.
>>
>> v2: remove unused boolean (Ilia Mirkin)
>> v3: proper error checking for invalid values (Chad Versace)
>> v4: run error check explicitly for ES2 and ES3 (
On 01/13/2015 02:34 PM, Mason, Michael W wrote:
>> -Original Message-
>> From: Versace, Chad
>> Sent: Tuesday, January 13, 2015 10:47 AM
>> To: Mason, Michael W; mesa-dev@lists.freedesktop.org
>> Subject: Re: [Mesa-dev] [PATCH] mesa: Fix render buffer initial internal
>> format type
>>
>>
Brian and Ian, me and Michael have a Mesa TLS question at the message's bottom.
On 01/13/2015 04:41 PM, Mason, Michael W wrote:
>> -Original Message-
>> From: Versace, Chad
>> Sent: Tuesday, January 13, 2015 3:42 PM
>> To: Mason, Michael W; mesa-dev@lists.freedesktop.org
>> Subject: Re: [
On 01/09/2015 11:07 PM, Kenneth Graunke wrote:
> Sandybridge requires the post-sync non-zero workaround in a ton of
> places, and if you ever miss one, the GPU usually hangs.
>
> Currently, we try to track exactly when a workaround flush is
> necessary (via the brw->batch.need_workaround_flush fla
On Wed 19 Aug 2015, Anuj Phogat wrote:
> V2:
> - Do the tile width/height computations in the new helper
> function and use it later in intel_miptree_get_tile_masks().
> - Change the name to intel_get_tile_dims().
>
> Cc: Ben Widawsky
> Signed-off-by: Anuj Phogat
> ---
> src/mesa/drivers/dri/
On Fri 11 Sep 2015, Ville Syrjälä wrote:
> As it turns out I was just looking at Yf and whatnot from display POV,
> and I came to the conclusion that I'll change the kernel to just have a
> function to return the tile width in bytes based on the cpp passed in,
> and then I can simply compute tile
On Wed 19 Aug 2015, Anuj Phogat wrote:
> This will require change in the parameters passed to
> intel_miptree_get_tile_masks().
>
> V2: Rearrange the order of parameters. (Ben)
> Change the name to intel_get_tile_masks(). (Topi)
>
> Cc: Ben Widawsky
> Cc: Topi Pohjolainen
> Signed-off-by: A
src/mesa/drivers/dri/i965/gen8_surface_state.c | 14 --
> 1 file changed, 12 insertions(+), 2 deletions(-)
Patch 3/8 is
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
<= dst_y || dst_x2 <= dst_x) {
> + if (dst_y2 <= dst_y || dst_x2 <= dst_x)
>return true;
> - }
The diff's last 4 lines add noise to the diff, and I'd like to see that
as a seprate mini-patch.
Either way, with or without the separate mini-p
uot;
>
> This patch adds the restriction for X tiling as well.
>
> Signed-off-by: Anuj Phogat
> Reviewed-by: Ben Widawsky
> ---
> src/mesa/drivers/dri/i965/intel_blit.c | 9 +++--
> 1 file changed, 7 insertions(+), 2 del
rc/mesa/drivers/dri/i965/intel_blit.c | 18 +++---
> 1 file changed, 7 insertions(+), 11 deletions(-)
Patch 7/8 is
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Wed 19 Aug 2015, Anuj Phogat wrote:
> This function isn't specific to miptrees. So, drop the "miptree"
> from function name.
>
> Signed-off-by: Anuj Phogat
> ---
> src/mesa/drivers/dri/i965/intel_fbo.c | 2 +-
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 6 +++---
> src/mesa/dr
Clarify that this bit extends the set of GL_MAP_*_BIT enums.
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
index c28162a..a65dae9 100644
--- a/sr
The comment for intel_miptree_map::mode claimed that it was a bitmask of
GL_MAP_{READ,WRITE,INVALIDATE}_BIT. In reality, the bitmask may include
any of {GL,BRW}_MAP_*_BIT.
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa
The values of intel_mipmap_tree::align_w and ::align_h correspond to the
hardware enums HALIGN_* and VALIGN_*.
See the confusion?
align_h != HALIGN
align_h == VALIGN
Reduce the confusion by renaming the variables to match the hardware
enum names:
git ls-files |
xargs sed -i -e 's/
Add comments that link the driver's miptree structures to the hardware
structures documented in the PRM. This provides sorely needed
orientation to developers new to the miptree code. And for miptree
veterans, this clarifies some of the more obscure miptree data.
For each driver struct field that
Conversations with Ken encouraged me to begin cleaning up and
documenting the miptree code. This patch series will likely be the first
of many.
Chad Versace (5):
i965/miptree: More comments for BRW_MAP_DIRECT_BIT
i965/miptree: Fix comments for map mode
i965/miptree: Rename intel_miptree_map
Because that's what it is. It's an untiled, *linear* miptree.
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 27 ++-
src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2 +-
2 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_
Because that's what it is. It's an untiled, *linear* miptree.
v2:
- Add space after /*.
- Use one comment per function argument.
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 28 ++-
src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2 +-
2 files changed, 16 inser
On Fri 25 Sep 2015, Anuj Phogat wrote:
> On Fri, Sep 25, 2015 at 12:05 PM, Chad Versace wrote:
> > Clarify that this bit extends the set of GL_MAP_*_BIT enums.
> > ---
> > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2 ++
> > 1 file changed, 2 insertions(+)
&g
> Document the units of tile_w, tile_h parameters.
>
> Cc: Chad Versace
> Cc: Topi Pohjolainen
> Signed-off-by: Anuj Phogat
> Reviewed-by: Topi Pohjolainen
> ---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 82
> ---
> src/mesa/d
intel_get_tile_masks()
> for clarity. Fix mask_y computation.
>
> Cc: Chad Versace
> Cc: Topi Pohjolainen
> Signed-off-by: Anuj Phogat
> Reviewed-by: Topi Pohjolainen
> ---
> src/mesa/drivers/dri/i965/brw_blorp.cpp | 4 +++-
> src/mesa/drivers/dri/i965/brw_mi
On Tue 22 Sep 2015, Anuj Phogat wrote:
> This function isn't specific to miptrees. So, drop the "miptree"
> from function name.
>
> V3: Add a comment explaining how the 1D Array texture height and
> depth is interpreted by Intel hardware.
>
> Cc: Chad V
src_offset is
OWord-aligned. So... I believe checking the alignment of only the (dst_x
* cpp) component of (src_bo_base_address + src_offset + src_x * cpp) is
sufficient.
> /* For all surface types buffers must be cacheline-aligned. */
> if ((dst_offset | src_
On Wed 19 Aug 2015, Anuj Phogat wrote:
> Signed-off-by: Anuj Phogat
> ---
> src/mesa/drivers/dri/i965/intel_blit.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
Reviewed-by: Chad Versace
___
mesa-dev mailing l
The major issue I found is the
> >> Camera and Youtube crashing in mesa.
> >
> > OK, I can almost confirm this is a known issue
> > I reported to mesa devs before.
> > It is caused by this commit:
> >
> > commit c636284ee8ee95bb3f3ad31aaf26a9512ec500
On Sun 27 Sep 2015, Ben Widawsky wrote:
> On Fri, Sep 25, 2015 at 12:05:49PM -0700, Chad Versace wrote:
> > The values of intel_mipmap_tree::align_w and ::align_h correspond to the
> > hardware enums HALIGN_* and VALIGN_*.
> >
> > See the confusion?
> >
On Sun 27 Sep 2015, Ben Widawsky wrote:
> On Fri, Sep 25, 2015 at 12:05:49PM -0700, Chad Versace wrote:
> > The values of intel_mipmap_tree::align_w and ::align_h correspond to the
> > hardware enums HALIGN_* and VALIGN_*.
> >
> > See the confusion?
> >
On Mon 28 Sep 2015, Martin Peres wrote:
> On 28/09/15 17:27, Emil Velikov wrote:
> >Hi all,
> >
> >On 17 August 2015 at 19:06, Chad Versace wrote:
> >>On Fri 14 Aug 2015, Chris Wilson wrote:
> >>>On Thu, Aug 13, 2015 at 09:58:52PM -0700, Kenneth Graunke
On Mon 28 Sep 2015, Marek Olšák wrote:
> On Mon, Sep 28, 2015 at 1:29 PM, Emil Velikov
> wrote:
> > As the spec allows for {server,client}_wait_sync to be called without
> > currently bound context, while our implementation requires context
> > pointer.
> >
> >
On Sat 12 Sep 2015, Chris Wilson wrote:
> On Thu, Sep 10, 2015 at 08:41:37AM +0100, Chris Wilson wrote:
> > http://people.freedesktop.org/~ickle/vbo/
> >
> > ministat 63c4b7e_bench_synmark:OglBatch7 2fbce8b_bench_synmark:OglBatch7
> > x 63c4b7e_bench_synmark:OglBatch7
> > + 2fbce8b_bench_synmark:O
intel_tiling_supports_non_msrt_mcs() and
intel_miptree_is_fast_clear_capable() are not used outside of
intel_mipmap_tree.c.
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 ++--
src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 6 +-
2 files changed, 3 insertions(+), 7 deletions(-)
diff -
There are three types of fast clears:
a. fast depth clears
b. fast singlesample color clears
c. fast multisample color clears
Function intel_miptree_is_fast_clear_capable() checks if a miptree
supports fast clears of type (b).
Rename the function to disambiguate what it does:
old: intel_mi
Chad Versace (2):
i965/mt: Declare some functions as static
i965: Fix intel_miptree_is_fast_clear_capable()
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 28 ---
src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 6 +-
2 files changed, 22 insertions(+), 12
On Thu 01 Oct 2015, Ben Widawsky wrote:
> On Thu, Oct 01, 2015 at 08:20:07AM -0700, Chad Versace wrote:
> > There are three types of fast clears:
> > a. fast depth clears
> > b. fast singlesample color clears
> > c. fast multisampl
---
src/mesa/drivers/dri/i965/gen8_surface_state.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/gen8_surface_state.c
b/src/mesa/drivers/dri/i965/gen8_surface_state.c
index e1e7704..1e3ae3f 100644
--- a/src/mesa/drivers/dri/i965/gen8_surface_state.c
+++ b/src/mesa
Nevermind this patch. It contains a stupid mistake.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Some assertions in gen8_surface_state.c checked for gen < 8.
---
src/mesa/drivers/dri/i965/gen8_surface_state.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/gen8_surface_state.c
b/src/mesa/drivers/dri/i965/gen8_surface_state.c
index e1e7704
This series lives at
git://github.com/chadversary/mesa refs/tags/skl-fast-clear-v08.01
No Piglit regressions on:
- Skylake 0x1912 (rev 06)
- linux 4.3-rc4
- piglit master@2b23e7b
Chad Versace (2):
i965/gen9: Disable MCS for 1x color surfaces
i965/gen9: Enable rep clears on gen9
src
Fast color clears are disabled for gen9 (see the checks in
brw_meta_fast_clear), so there is no reason to allocate the MCS and
track its clear/resolve state.
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/inte
The (gen < 9) check in brw_clear() was too broad. It disabled all types
of fast color clears:
a. singlesample rep clears
b. singlesample MCS fast clears
c. multisample MCS fast clears
The MCS clears are still buggy, but the rep clear works well. So let's
enable it.
---
src/mesa/driver
801 - 900 of 2787 matches
Mail list logo
