[Mesa-dev] [PATCH v4] anv/blorp: multisample resolve all attachment layers

2018-02-21 Thread Iago Toral Quiroga
We were only resolving the first. v2: - Do not require that the number of layers on dst and src are an exact match, it is okay if the dst has more layers so long as it has at least the same that we are going to resolve. - Do not always resolve array_len layers, we should resolve on

Re: [Mesa-dev] [PATCH 1/2] ac/nir: set the DA field when performing atomics on 3D images

2018-02-21 Thread Samuel Pitoiset
On 02/21/2018 05:11 AM, Timothy Arceri wrote: On 21/02/18 07:29, Samuel Pitoiset wrote: On VI, 3D images are considered as 2D arrays. RadeonSI sets DA for loads/stores/atomics and RADV only for loads/stores, so I guess there is a reason for that? I've changed the nir->llvm code recently in

Re: [Mesa-dev] [PATCH 1/2] ac/nir: set the DA field when performing atomics on 3D images

2018-02-21 Thread Timothy Arceri
On 21/02/18 19:22, Samuel Pitoiset wrote: On 02/21/2018 05:11 AM, Timothy Arceri wrote: On 21/02/18 07:29, Samuel Pitoiset wrote: On VI, 3D images are considered as 2D arrays. RadeonSI sets DA for loads/stores/atomics and RADV only for loads/stores, so I guess there is a reason for that? I'v

Re: [Mesa-dev] [PATCH 1/2] ac/nir: set the DA field when performing atomics on 3D images

2018-02-21 Thread Samuel Pitoiset
On 02/21/2018 09:24 AM, Timothy Arceri wrote: On 21/02/18 19:22, Samuel Pitoiset wrote: On 02/21/2018 05:11 AM, Timothy Arceri wrote: On 21/02/18 07:29, Samuel Pitoiset wrote: On VI, 3D images are considered as 2D arrays. RadeonSI sets DA for loads/stores/atomics and RADV only for loads/stor

Re: [Mesa-dev] [PATCH] etnaviv: npot_tex_any_wrap needs one bit only

2018-02-21 Thread Lucas Stach
Am Dienstag, den 20.02.2018, 20:47 +0100 schrieb Christian Gmeiner: > Reduces size of struct etna_specs from 100 to 94 bytes. > > Signed-off-by: Christian Gmeiner Reviewed-by: Lucas Stach > --- >  src/gallium/drivers/etnaviv/etnaviv_internal.h | 2 +- >  1 file changed, 1 insertion(+), 1 deleti

[Mesa-dev] [PATCH v3 1/2] anv/cmd_buffer: consider multiview masks for tracking pending clear aspects

2018-02-21 Thread Iago Toral Quiroga
When multiview is active a subpass clear may only clear a subset of the attachment layers. Other subpasses in the same render pass may also clear too and we want to honor those clears as well, however, we need to ensure that we only clear a layer once, on the first subpass that uses a particular la

[Mesa-dev] [PATCH v3 2/2] anv/cmd_buffer: honor pending clear views for depth/stencil attachments

2018-02-21 Thread Iago Toral Quiroga
v2: - rebased on top of subpass rework. --- src/intel/vulkan/genX_cmd_buffer.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index a9e5b2e78c..010b52c10a 100644 --- a/src/intel/vu

Re: [Mesa-dev] [PATCH 03/17] intel: Disable 64-bit extensions on platforms without 64-bit types

2018-02-21 Thread Iago Toral
On Tue, 2018-02-20 at 21:15 -0800, Matt Turner wrote: > Gen11 does not support DF, Q, UQ types in hardware. As a result, we > have > to disable some GL extensions until they can be reimplemented. > --- > src/intel/common/gen_device_info.c | 3 +++ > src/intel/common/gen_device_info.h

Re: [Mesa-dev] [PATCH] nir: remove old assert

2018-02-21 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Wed, 2018-02-21 at 14:42 +1100, Timothy Arceri wrote: > This was originally intended to make sure the remap location > was not -1. However the code has changed alot since then, > the location is now never set to -1 and we also handle > components meaning this ol

Re: [Mesa-dev] [PATCH 0/6] i965: Fix TFP for CCS modifiers

2018-02-21 Thread Daniel Stone
Hi Jason, On 24 January 2018 at 23:46, Jason Ekstrand wrote: > This patch series provides fixes for the texture_from_pixmap path when > modifiers are used. All but the first and last patches are reviewed. I > haven't pushed to land anything yet because ee57b15ec764736e disabled CCS > for miptre

Re: [Mesa-dev] [PATCH 0/6] i965: Fix TFP for CCS modifiers

2018-02-21 Thread Daniel Stone
On 21 February 2018 at 10:49, Daniel Stone wrote: > On 24 January 2018 at 23:46, Jason Ekstrand wrote: >> This patch series provides fixes for the texture_from_pixmap path when >> modifiers are used. All but the first and last patches are reviewed. I >> haven't pushed to land anything yet becau

Re: [Mesa-dev] [PATCH] radv: enable lowering of fpow to fexp2 and flog2

2018-02-21 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Fri, Feb 2, 2018 at 7:04 PM, Samuel Pitoiset wrote: > There is no fpow in hardware, so it's always lowered somewhere, > but it appears that lowering at NIR level is better. Figured while > comparing compute shaders between RadeonSI and RADV. > > Polaris10: > To

Re: [Mesa-dev] [PATCH] nir: lower fexp2(fmul(flog2(a), 2)) to fmul(a, a)

2018-02-21 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Wed, Feb 7, 2018 at 10:29 AM, Samuel Pitoiset wrote: > > > On 02/06/2018 12:29 AM, Ian Romanick wrote: > >> Do you have any data from shader-db for this change (and the other patch)? >> > > We didn't see any changes for this patch on ivy bridge, but it helps wh

Re: [Mesa-dev] [PATCH] nir: add is_used_once for fmul(fexp2(a), fexp2(b)) to fexp2(fadd(a, b))

2018-02-21 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Feb 15, 2018 at 10:56 PM, Timothy Arceri wrote: > Here are the IVB shader-db results: > > instructions helped: shaders/closed/steam/dex/63.shader_test FS SIMD8: > 1303 -> 1300 (-0.23%) > instructions helped: shaders/closed/steam/gang-beasts/111.shader_

[Mesa-dev] [PATCH v11 01/15] vulkan/wsi: Add multiple planes to wsi_image

2018-02-21 Thread Daniel Stone
Not currently used. Signed-off-by: Daniel Stone Reviewed-by: Jason Ekstrand --- src/vulkan/wsi/wsi_common.c | 20 src/vulkan/wsi/wsi_common_private.h | 9 + src/vulkan/wsi/wsi_common_wayland.c | 11 +++ src/vulkan/wsi/wsi_common_x11.c | 11 +

[Mesa-dev] [PATCH v11 13/15] x11/dri3: Store raw present completion mode

2018-02-21 Thread Daniel Stone
The DRI3 drawable info struct currently stores a boolean for whether the last completed operation was a flip or not. As we need to track the full completion mode for handling suboptimal returns, change the 'flipping' field to the raw present completion mode from the server. Signed-off-by: Daniel S

[Mesa-dev] [PATCH v11 15/15] egl/x11: Re-allocate buffers if format is suboptimal

2018-02-21 Thread Daniel Stone
From: Louis-Francis Ratté-Boulianne If PresentCompleteNotify event says the pixmap was presented with mode PresentCompleteModeSuboptimalCopy, it means the pixmap could possibly have been flipped instead if allocated with a different format/modifier. Signed-off-by: Louis-Francis Ratté-Boulianne

[Mesa-dev] [PATCH v11 06/15] vulkan/wsi/wayland: Add support for zwp_dmabuf

2018-02-21 Thread Daniel Stone
zwp_linux_dmabuf_v1 lets us use multi-planar images and buffer modifiers. Signed-off-by: Daniel Stone --- src/vulkan/Makefile.am | 10 +++ src/vulkan/Makefile.sources | 4 +- src/vulkan/wsi/meson.build | 2 + src/vulkan/wsi/wsi_common_wayland.c | 141 ++

[Mesa-dev] [PATCH v11 08/15] vulkan/wsi/x11: Consistently update swapchain status

2018-02-21 Thread Daniel Stone
Use a helper function for updating the swapchain status. This will be used later to handle VK_SUBOPTIMAL_KHR, where we need to make a non-error status stick to the swapchain until recreation. Signed-off-by: Daniel Stone --- src/vulkan/wsi/wsi_common_x11.c | 90 ---

[Mesa-dev] [PATCH v11 07/15] vulkan/wsi/x11: Expand set of swapchain statuses

2018-02-21 Thread Daniel Stone
Instead of direct comparisons to VK_SUCCESS, test for negative numbers meaning an error status, and positive numbers indicating non-error statuses. Signed-off-by: Daniel Stone --- src/vulkan/wsi/wsi_common_x11.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a

[Mesa-dev] [PATCH v11 02/15] vulkan/wsi: Add drm_modifier member to wsi_image

2018-02-21 Thread Daniel Stone
Not yet used anywhere. Signed-off-by: Daniel Stone Reviewed-by: Jason Ekstrand --- src/vulkan/Makefile.am | 1 + src/vulkan/wsi/meson.build | 2 +- src/vulkan/wsi/wsi_common.c | 3 +++ src/vulkan/wsi/wsi_common_private.h | 1 + 4 files changed, 6 insertions(+), 1 d

[Mesa-dev] [PATCH v11 14/15] egl/x11: Support DRI3 v1.1

2018-02-21 Thread Daniel Stone
From: Louis-Francis Ratté-Boulianne Add support for DRI3 v1.1, which allows pixmaps to be backed by multi-planar buffers, or those with format modifiers. This is both for allocating render buffers, as well as EGLImage imports from a native pixmap (EGL_NATIVE_PIXMAP_KHR). Signed-off-by: Louis-Fra

[Mesa-dev] [PATCH v11 10/15] vulkan/wsi/x11: Add support for DRI3 v1.1

2018-02-21 Thread Daniel Stone
Adds support for multiple planes and buffer modifiers. v4: Rename "has_dri3_v1_1" to "has_dri3_modifiers" Signed-off-by: Daniel Stone --- src/vulkan/wsi/wsi_common_x11.c | 185 1 file changed, 168 insertions(+), 17 deletions(-) diff --git a/src/vulkan/ws

[Mesa-dev] [PATCH v11 03/15] vulkan/wsi: Add modifiers support to wsi_create_native_image

2018-02-21 Thread Daniel Stone
From: Jason Ekstrand This involves extending our fake extension a bit to allow for additional querying and passing of modifier information. The added bits are intended to look a lot like the draft of VK_EXT_image_drm_format_modifier. Once the extension gets finalized, we'll simply transition all

[Mesa-dev] [PATCH v11 11/15] vulkan/wsi/x11: Return VK_SUBOPTIMAL_KHR for X11

2018-02-21 Thread Daniel Stone
From: Louis-Francis Ratté-Boulianne When it is detected that a window could have been flipped but has been copied because of suboptimal format/modifier. The Vulkan client should then re-create the swapchain. Signed-off-by: Louis-Francis Ratté-Boulianne Reviewed-by: Daniel Stone Signed-off-by:

[Mesa-dev] [PATCH v11 04/15] anv/image: Separate modifiers from legacy scanout

2018-02-21 Thread Daniel Stone
From: Jason Ekstrand For a bit there, we had a bug in i965 where it ignored the tiling of the modifier and used the one from the BO instead. At one point, we though this was best fixed by setting a tiling from Vulkan. However, we've decided that i965 was just doing the wrong thing and have fixe

[Mesa-dev] [PATCH v11 05/15] anv/image: Add support for modifiers for WSI

2018-02-21 Thread Daniel Stone
From: Jason Ekstrand This adds support for the modifiers portion of the WSI "extension". Reviewed-by: Daniel Stone Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_formats.c | 38 ++ src/intel/vulkan/anv_image.c | 40 ++

[Mesa-dev] [PATCH v11 00/15] Modifiers for X11 EGL/Vulkan, WL/VK

2018-02-21 Thread Daniel Stone
Hi, This series adds support for buffer modifiers through ANV and the common WSI infrastructure (AMD has no defined modifiers), as well as specifically for X11 and Wayland. It also adds support for the X11 DRI3 v1.1 and Present v1.2 protocols to EGL and GLX, which does not require changes to the DR

[Mesa-dev] [PATCH v11 09/15] vulkan/wsi/x11: Cleanly handle shutdowns in FIFO thread

2018-02-21 Thread Daniel Stone
The FIFO thread signals shutdown by pushing UINT32_MAX into the acquire queue, and shutdown is signaled to it by pushing UINT32_MAX into the present queue. Explicitly catch a push of UINT32_MAX in either direction and treat this as error. Signed-off-by: Daniel Stone --- src/vulkan/wsi/wsi_commo

[Mesa-dev] [PATCH v11 12/15] x11/dri3: Don't open-code ARRAY_SIZE

2018-02-21 Thread Daniel Stone
Signed-off-by: Daniel Stone --- src/loader/loader_dri3_helper.c | 5 +++-- src/loader/meson.build | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/loader/loader_dri3_helper.c b/src/loader/loader_dri3_helper.c index 30ea133f7e5..cb947c58728 100644 --- a/src/loade

[Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

2018-02-21 Thread Chuck Atkins
This fixes a segfault exposed by a29d63ecf7 which occurs when swr is used on an unsupported architecture. Signed-off-by: Chuck Atkins Cc: mesa-sta...@lists.freedesktop.org Cc: George Kyriazis Cc: Bruce Cherniak --- src/gallium/state_trackers/glx/xlib/xm_api.c | 11 +++ 1 file changed,

[Mesa-dev] [PATCH 2/2] ac/nir: clean up a hack about rounding 2nd coord component

2018-02-21 Thread Samuel Pitoiset
It's basically just the opposite, and it only makes sense to round the layer for 2D texture arrays. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir

[Mesa-dev] [PATCH 1/2] radv: remove one invalid case in radv_tex_dim()

2018-02-21 Thread Samuel Pitoiset
According to "Table 1. Image and image view parameter compatibility requirements", this is invalid. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_image.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c ind

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: Properly handle cases where screen creation fails

2018-02-21 Thread Chuck Atkins
Sorry for the repeat, I was adding the Intel devs to the CC list since it's related to swr -Chuck On Wed, Feb 21, 2018 at 9:26 AM, Chuck Atkins wrote: > This fixes a segfault exposed by a29d63ecf7 which occurs when swr is > used on an unsupported architecture. > > Signed-off-by: Chuck Atkins >

Re: [Mesa-dev] [PATCH 1/2] radv: remove one invalid case in radv_tex_dim()

2018-02-21 Thread Józef Kucia
On Wed, Feb 21, 2018 at 3:27 PM, Samuel Pitoiset wrote: > According to "Table 1. Image and image view parameter compatibility > requirements", this is invalid. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_image.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > d

Re: [Mesa-dev] [PATCH 1/2] radv: remove one invalid case in radv_tex_dim()

2018-02-21 Thread Samuel Pitoiset
On 02/21/2018 03:37 PM, Józef Kucia wrote: On Wed, Feb 21, 2018 at 3:27 PM, Samuel Pitoiset wrote: According to "Table 1. Image and image view parameter compatibility requirements", this is invalid. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_image.c | 5 + 1 file changed,

Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

2018-02-21 Thread Eric Engestrom
On Wednesday, 2018-02-21 09:26:34 -0500, Chuck Atkins wrote: > This fixes a segfault exposed by a29d63ecf7 which occurs when swr is > used on an unsupported architecture. > > Signed-off-by: Chuck Atkins > Cc: mesa-sta...@lists.freedesktop.org > Cc: George Kyriazis > Cc: Bruce Cherniak > --- >

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: Properly handle cases where screen creation fails

2018-02-21 Thread Emil Velikov
On 21 February 2018 at 14:26, Chuck Atkins wrote: > This fixes a segfault exposed by a29d63ecf7 which occurs when swr is > used on an unsupported architecture. > > Signed-off-by: Chuck Atkins > Cc: mesa-sta...@lists.freedesktop.org > Cc: George Kyriazis > Cc: Bruce Cherniak > --- > src/gallium

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: Properly handle cases where screen creation fails

2018-02-21 Thread Emil Velikov
On 21 February 2018 at 14:41, Emil Velikov wrote: > On 21 February 2018 at 14:26, Chuck Atkins wrote: >> This fixes a segfault exposed by a29d63ecf7 which occurs when swr is >> used on an unsupported architecture. >> >> Signed-off-by: Chuck Atkins >> Cc: mesa-sta...@lists.freedesktop.org >> Cc:

Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

2018-02-21 Thread Chuck Atkins
> > - if (xmdpy->smapi->destroy) > > - xmdpy->smapi->destroy(xmdpy->smapi); > > - free(xmdpy->smapi); > > + if (xmdpy->smapi) > > + { > > + if (xmdpy->smapi->destroy) > > + xmdpy->smapi->destroy(xmdpy->smapi); > > + free(xmdpy->smapi); > > + } > > I don't know this

Re: [Mesa-dev] [PATCH v11 13/15] x11/dri3: Store raw present completion mode

2018-02-21 Thread Eric Engestrom
On Wednesday, 2018-02-21 14:05:57 +, Daniel Stone wrote: > The DRI3 drawable info struct currently stores a boolean for whether the > last completed operation was a flip or not. As we need to track the full > completion mode for handling suboptimal returns, change the 'flipping' > field to the

Re: [Mesa-dev] [PATCH v11 12/15] x11/dri3: Don't open-code ARRAY_SIZE

2018-02-21 Thread Eric Engestrom
On Wednesday, 2018-02-21 14:05:56 +, Daniel Stone wrote: > Signed-off-by: Daniel Stone > --- > src/loader/loader_dri3_helper.c | 5 +++-- > src/loader/meson.build | 2 +- Assuming automake already has the right include path, Reviewed-by: Eric Engestrom > 2 files changed, 4 inserti

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: Properly handle cases where screen creation fails

2018-02-21 Thread Chuck Atkins
> > Something doesn't look quite right - it seems that xmesa_init_display > should be fixed instead. > > Currently it returns non-NULL when either of the following fail: > - driver.create_pipe_screen() > - CALLOC_STRUCT > > I would add an explicit check after those + goto err_path. > The latter o

Re: [Mesa-dev] [PATCH v11 07/15] vulkan/wsi/x11: Expand set of swapchain statuses

2018-02-21 Thread Daniel Stone
On 21 February 2018 at 14:05, Daniel Stone wrote: > @@ -781,7 +781,7 @@ x11_acquire_next_image_from_queue(struct x11_swapchain > *chain, > uint32_t image_index; > VkResult result = wsi_queue_pull(&chain->acquire_queue, > &image_index, timeout); > - i

[Mesa-dev] [PATCH 0/5] NVIDIA Tegra support

2018-02-21 Thread Thierry Reding
From: Thierry Reding This series of patches implements initial support for Tegra. The first two patches import DRM UAPI from v4.16-rc1 that provide framebuffer modifiers that can be used to specify buffers shared between Nouveau and the Tegra DRM driver. Patches 3 and 4 add support for framebuff

[Mesa-dev] [PATCH 1/5] drm/fourcc: Fix fourcc_mod_code() definition

2018-02-21 Thread Thierry Reding
From: Thierry Reding Avoid a compiler warnings when the val parameter is an expression. This is based on commit 5843f4e02fbe86a59981e35adc6cabebee46fdc0 from Linux v4.16-rc1. Signed-off-by: Thierry Reding --- include/drm-uapi/drm_fourcc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Mesa-dev] [PATCH 2/5] drm/tegra: Sanitize format modifiers

2018-02-21 Thread Thierry Reding
From: Thierry Reding The existing format modifier definitions were merged prematurely, and recent work has unveiled that the definitions are suboptimal in several ways: - The format specifiers, except for one, are not Tegra specific, but the names don't reflect that. - The number space i

[Mesa-dev] [PATCH 3/5] nouveau/nvc0: Extract common tile mode macro

2018-02-21 Thread Thierry Reding
From: Thierry Reding Add a new macro that can be used to extract the tiling mode from a tile_mode value. This is will be used to determine the number of GOBs used in block linear mode. Signed-off-by: Thierry Reding --- src/gallium/drivers/nouveau/nvc0/nvc0_resource.h | 15 +-- 1 fi

[Mesa-dev] [PATCH 4/5] nouveau: Add framebuffer modifier support

2018-02-21 Thread Thierry Reding
From: Thierry Reding This adds support for framebuffer modifiers to Nouveau. This will be used by the Tegra driver to share metadata about the format of buffers (such as the tiling mode or compression). Signed-off-by: Thierry Reding --- src/gallium/drivers/nouveau/Android.mk | 3 +

[Mesa-dev] [PATCH 5/5] tegra: Initial support

2018-02-21 Thread Thierry Reding
Tegra K1 and later use a GPU that can be driven by the Nouveau driver. But the GPU is a pure render node and has no display engine, hence the scanout needs to happen on the Tegra display hardware. The GPU and the display engine each have a separate DRM device node exposed by the kernel. To make th

Re: [Mesa-dev] [PATCH] gallium/winsys/kms: Add support for multi-planes (v2)

2018-02-21 Thread Emil Velikov
HI Lepton, It seems that this has fallen through the cracks. There's one important functionality change which should be split out and documented. The rest is just style nitpicks. On 28 December 2017 at 07:35, Lepton Wu wrote: > v2: address comments from Tomasz Figa >a) Add more check for pl

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-21 Thread Emil Velikov
Hi all, Pardon for dropping in late. I think you've got nearly everything settled down, just sharing a couple of ideas. On 21 February 2018 at 04:19, Tomasz Figa wrote: > On Wed, Feb 21, 2018 at 4:03 AM, Rob Herring wrote: >> On Tue, Feb 20, 2018 at 4:26 AM, Tomasz Figa wrote: > It is actuall

Re: [Mesa-dev] [PATCH 4/5] nouveau: Add framebuffer modifier support

2018-02-21 Thread Ilia Mirkin
On Wed, Feb 21, 2018 at 10:30 AM, Thierry Reding wrote: > From: Thierry Reding > > This adds support for framebuffer modifiers to Nouveau. This will be > used by the Tegra driver to share metadata about the format of buffers > (such as the tiling mode or compression). > > Signed-off-by: Thierry R

[Mesa-dev] [PATCH 1/2] glxinfo/wglinfo: add queries of GL_ARB_tessellation_shader limits

2018-02-21 Thread Brian Paul
--- src/xdemos/glinfo_common.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/xdemos/glinfo_common.c b/src/xdemos/glinfo_common.c index a61061c..0411891 100644 --- a/src/xdemos/glinfo_common.c +++ b/src/xdemos/glinfo_common.c @@ -610,6 +610,24 @@ print_limits(const cha

[Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-21 Thread Brian Paul
--- src/xdemos/glinfo_common.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/xdemos/glinfo_common.c b/src/xdemos/glinfo_common.c index 0411891..c36cff1 100644 --- a/src/xdemos/glinfo_common.c +++ b/src/xdemos/glinfo_common.c @@ -794,6 +794,19 @@ print_limits(const char *ex

[Mesa-dev] Mesamatrix donator message

2018-02-21 Thread Romain Failliot
Hi! I received a donation on Mesamatrix with this message with it: > Please fix long-standing bug, not allowing to properly > recognize my Bonaire XT card with glxinfo tool; for now, > it reports Bonaire. See my WineHQ bug: #38921 Bonaire cards don't speak to me much, but if someone is welling t

Re: [Mesa-dev] [PATCH 4/5] nouveau: Add framebuffer modifier support

2018-02-21 Thread Emil Velikov
Hi Thierry, On 21 February 2018 at 15:30, Thierry Reding wrote: > > struct pipe_resource * > nouveau_buffer_create(struct pipe_screen *pscreen, > - const struct pipe_resource *templ); > + const struct pipe_resource *templ, > + cons

Re: [Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-21 Thread Mike Lothian
This doesn't show as default and seems to be tucked away under GL_ARB_transform_feedback3 GL_ARB_transform_feedback3: GL_MAX_TRANSFORM_FEEDBACK_BUFFERS = 4 GL_MAX_VERTEX_STREAMS = 4 GL_NUM_SHADING_LANGUAGE_VERSIONS = 16 450 440 430 420 410

Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

2018-02-21 Thread Eric Engestrom
On Wednesday, 2018-02-21 09:48:54 -0500, Chuck Atkins wrote: > > > - if (xmdpy->smapi->destroy) > > > - xmdpy->smapi->destroy(xmdpy->smapi); > > > - free(xmdpy->smapi); > > > + if (xmdpy->smapi) > > > + { > > > + if (xmdpy->smapi->destroy) > > > + xmdpy->smapi->destroy(xmd

Re: [Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-21 Thread Mike Lothian
It also seems to have an off by one error On Wed, 21 Feb 2018 at 16:41 Mike Lothian wrote: > This doesn't show as default and seems to be tucked away > under GL_ARB_transform_feedback3 > > GL_ARB_transform_feedback3: > GL_MAX_TRANSFORM_FEEDBACK_BUFFERS = 4 > GL_MAX_VERTEX_STREAMS = 4 >

Re: [Mesa-dev] [PATCH 5/5] tegra: Initial support

2018-02-21 Thread Emil Velikov
Hi Thierry, On 21 February 2018 at 15:30, Thierry Reding wrote: > @@ -2595,6 +2596,11 @@ if test -n "$with_gallium_drivers"; then > ximx) > HAVE_GALLIUM_IMX=yes > ;; > +xtegra) > +HAVE_GALLIUM_TEGRA=yes > +PKG_CHECK_MODULES([TEGRA

Re: [Mesa-dev] [PATCH 0/5] NVIDIA Tegra support

2018-02-21 Thread Emil Velikov
Hi Thierry, On 21 February 2018 at 15:30, Thierry Reding wrote: > From: Thierry Reding > > This series of patches implements initial support for Tegra. The first > two patches import DRM UAPI from v4.16-rc1 that provide framebuffer > modifiers that can be used to specify buffers shared between N

Re: [Mesa-dev] [PATCH] anv: Only copy clear dwords if we're rendering to the first slice

2018-02-21 Thread Rafael Antognolli
Makes sense to me, there's no need to keep copying the clear color for every slice if we only fast clear the first one. Reviewed-by: Rafael Antognolli On Tue, Feb 20, 2018 at 03:08:11PM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/genX_cmd_buffer.c | 5 - > 1 file changed, 4 insert

Re: [Mesa-dev] [PATCH v11 12/15] x11/dri3: Don't open-code ARRAY_SIZE

2018-02-21 Thread Emil Velikov
On 21 February 2018 at 14:51, Eric Engestrom wrote: > On Wednesday, 2018-02-21 14:05:56 +, Daniel Stone wrote: >> Signed-off-by: Daniel Stone >> --- >> src/loader/loader_dri3_helper.c | 5 +++-- >> src/loader/meson.build | 2 +- > > Assuming automake already has the right include pat

Re: [Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-21 Thread Brian Paul
On 02/21/2018 09:41 AM, Mike Lothian wrote: This doesn't show as default and seems to be tucked away under GL_ARB_transform_feedback3 I copied the indentation used for the texture compression formats code above. That needs to be fixed. I'll fix that in another patch and update this one. -

Re: [Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-21 Thread Brian Paul
On 02/21/2018 09:43 AM, Mike Lothian wrote: It also seems to have an off by one error The empty line is actually a valid result of the glGetStringi(GL_SHADING_LANGUAGE_VERSION) query. Per the GL 4.3 spec, page 628: "An empty string indicates support for OpenGL Shading Language 1.10, which

Re: [Mesa-dev] [PATCH 01/17] intel: Add a preliminary device for Ice Lake

2018-02-21 Thread Rafael Antognolli
My understanding is that this commit is enough to make the driver try to initialize, at least for i965. If that's the case, how about we add something like what was removed by commit bf1577fe0972ae910c071743dc89d261a46c2926 for CNL? It could be either in this commit, or in a commit that precedes t

Re: [Mesa-dev] [PATCH 03/17] intel: Disable 64-bit extensions on platforms without 64-bit types

2018-02-21 Thread Matt Turner
On Wed, Feb 21, 2018 at 2:05 AM, Iago Toral wrote: > On Tue, 2018-02-20 at 21:15 -0800, Matt Turner wrote: >> Gen11 does not support DF, Q, UQ types in hardware. As a result, we >> have >> to disable some GL extensions until they can be reimplemented. >> --- >> src/intel/common/gen_device_info.c

Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

2018-02-21 Thread Kyriazis, George
Chuck, In which cases do you hit this? When an architecture is not supported, then swr_create_screen() falls back to a different (older) architecture. Thanks, George > On Feb 21, 2018, at 8:26 AM, Chuck Atkins wrote: > > This fixes a segfault exposed by a29d63ecf7 which occurs when swr is >

Re: [Mesa-dev] Mesamatrix donator message

2018-02-21 Thread Alex Deucher
On Wed, Feb 21, 2018 at 11:12 AM, Romain Failliot wrote: > Hi! > > I received a donation on Mesamatrix with this message with it: > >> Please fix long-standing bug, not allowing to properly >> recognize my Bonaire XT card with glxinfo tool; for now, >> it reports Bonaire. See my WineHQ bug: #38921

Re: [Mesa-dev] [PATCH v4] anv/blorp: multisample resolve all attachment layers

2018-02-21 Thread Nanley Chery
On Wed, Feb 21, 2018 at 09:18:49AM +0100, Iago Toral Quiroga wrote: > We were only resolving the first. > > v2: > - Do not require that the number of layers on dst and src are an > exact match, it is okay if the dst has more layers so long as > it has at least the same that we are going

Re: [Mesa-dev] [PATCH 01/17] intel: Add a preliminary device for Ice Lake

2018-02-21 Thread Matt Turner
On Wed, Feb 21, 2018 at 9:22 AM, Rafael Antognolli wrote: > My understanding is that this commit is enough to make the driver try to > initialize, at least for i965. If that's the case, how about we add > something like what was removed by commit > bf1577fe0972ae910c071743dc89d261a46c2926 for CNL?

Re: [Mesa-dev] [PATCH 01/17] intel: Add a preliminary device for Ice Lake

2018-02-21 Thread Scott D Phillips
Matt Turner writes: > From: Anuj Phogat > > Signed-off-by: Anuj Phogat > --- > include/pci_ids/i965_pci_ids.h | 9 ++ > src/intel/common/gen_device_info.c | 56 > +- > 2 files changed, 64 insertions(+), 1 deletion(-) > > diff --git a/include/pci_id

[Mesa-dev] [PATCH v2 2/2] radv: implement AMD_gcn_shader extension

2018-02-21 Thread daniel.schuermann
From: Dave Airlie Co-authored-by: Daniel Schürmann Signed-off-by: Daniel Schürmann --- src/amd/common/ac_llvm_build.c| 3 +- src/amd/common/ac_nir_to_llvm.c | 39 ++ src/amd/vulkan/radv_extensions.py | 1 + src/compiler/nir/meson.build | 1 + src/compiler/nir/

[Mesa-dev] [PATCH v2 1/2] spirv: import AMD extensions header from glslang

2018-02-21 Thread daniel.schuermann
From: Daniel Schürmann Signed-off-by: Daniel Schürmann --- src/compiler/spirv/GLSL.ext.AMD.h | 110 ++ 1 file changed, 110 insertions(+) create mode 100644 src/compiler/spirv/GLSL.ext.AMD.h diff --git a/src/compiler/spirv/GLSL.ext.AMD.h b/src/compiler/spir

Re: [Mesa-dev] [PATCH 1/2] glxinfo/wglinfo: add queries of GL_ARB_tessellation_shader limits

2018-02-21 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Feb 21, 2018 at 5:12 PM, Brian Paul wrote: > --- > src/xdemos/glinfo_common.c | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/src/xdemos/glinfo_common.c b/src/xdemos/glinfo_common.c > index a61061c..0411891 100644 > --- a/src/

Re: [Mesa-dev] [PATCH 01/17] intel: Add a preliminary device for Ice Lake

2018-02-21 Thread Anuj Phogat
On Wed, Feb 21, 2018 at 10:00 AM, Scott D Phillips wrote: > Matt Turner writes: > >> From: Anuj Phogat >> >> Signed-off-by: Anuj Phogat >> --- >> include/pci_ids/i965_pci_ids.h | 9 ++ >> src/intel/common/gen_device_info.c | 56 >> +- >> 2 files ch

Re: [Mesa-dev] [PATCH] radeonsi/nir: disable GLSL IR loop unrolling

2018-02-21 Thread Marek Olšák
Nice. Reviewed-by: Marek Olšák Marek On Wed, Feb 21, 2018 at 2:35 AM, Timothy Arceri wrote: > Delaying unrolling and allowing NIR to do it instead has been shown > to result in better code in drivers such as i965. shader-db results > appear to should the same is true for radeonsi. > > The othe

Re: [Mesa-dev] [PATCH] radeonsi/nir: disable GLSL IR loop unrolling

2018-02-21 Thread Ilia Mirkin
On Tue, Feb 20, 2018 at 8:35 PM, Timothy Arceri wrote: > Delaying unrolling and allowing NIR to do it instead has been shown > to result in better code in drivers such as i965. shader-db results > appear to should the same is true for radeonsi. > > The other advantage is that using NIR unrolling i

Re: [Mesa-dev] [PATCH 01/17] intel: Add a preliminary device for Ice Lake

2018-02-21 Thread Scott D Phillips
Anuj Phogat writes: > On Wed, Feb 21, 2018 at 10:00 AM, Scott D Phillips > wrote: >> Matt Turner writes: >> >>> From: Anuj Phogat >>> >>> Signed-off-by: Anuj Phogat >>> --- >>> include/pci_ids/i965_pci_ids.h | 9 ++ >>> src/intel/common/gen_device_info.c | 56 >>> ++

[Mesa-dev] [PATCH v11 07+08/15] vulkan/wsi/x11: Consistently update and return swapchain status

2018-02-21 Thread Jason Ekstrand
From: Daniel Stone Use a helper function for updating the swapchain status. This will be used later to handle VK_SUBOPTIMAL_KHR, where we need to make a non-error status stick to the swapchain until recreation. Instead of direct comparisons to VK_SUCCESS to check for error, test for negative num

Re: [Mesa-dev] [PATCH v11 08/15] vulkan/wsi/x11: Consistently update swapchain status

2018-02-21 Thread Jason Ekstrand
I'm going to squash this with the previous one and send review comments on the combined patch. It's terribly difficult to reason about the two individually. On Wed, Feb 21, 2018 at 6:05 AM, Daniel Stone wrote: > Use a helper function for updating the swapchain status. This will be > used later

Re: [Mesa-dev] [PATCH v2 2/2] radv: implement AMD_gcn_shader extension

2018-02-21 Thread Connor Abbott
On Wed, Feb 21, 2018 at 1:00 PM, wrote: > From: Dave Airlie > > Co-authored-by: Daniel Schürmann > Signed-off-by: Daniel Schürmann > --- > src/amd/common/ac_llvm_build.c| 3 +- > src/amd/common/ac_nir_to_llvm.c | 39 ++ > src/amd/vulkan/radv_extensions.py | 1 + >

Re: [Mesa-dev] [PATCH v11 07+08/15] vulkan/wsi/x11: Consistently update and return swapchain status

2018-02-21 Thread Jason Ekstrand
On Wed, Feb 21, 2018 at 11:53 AM, Jason Ekstrand wrote: > For this one, I'm making live edits to see if I like the suggested > changes. I'll send out the v2 with the comments incorporated when I'm done. > > On Wed, Feb 21, 2018 at 11:32 AM, Jason Ekstrand > wrote: > >> From: Daniel Stone >> >>

Re: [Mesa-dev] [PATCH v2 2/2] radv: implement AMD_gcn_shader extension

2018-02-21 Thread Daniel Schürmann
On Wed, Feb 21, 2018 at 1:00 PM, wrote: From: Dave Airlie Co-authored-by: Daniel Schürmann Signed-off-by: Daniel Schürmann --- src/amd/common/ac_llvm_build.c| 3 +- src/amd/common/ac_nir_to_llvm.c | 39 ++ src/amd/vulkan/radv_extensions.py | 1 + src/compi

[Mesa-dev] [PATCH] anv: Add WSI support for the I915_FORMAT_MOD_Y_TILED_CCS

2018-02-21 Thread Jason Ekstrand
v2 (Jason Ekstrand): - Return the correct enum values from anv_layout_to_fast_clear_type v3 (Jason Ekstrand): - Always return ANV_FAST_CLEAR_NONE and leave doing the right thing for the patch which adds a modifier which supports fast-clears. --- src/intel/vulkan/anv_formats.c | 9

[Mesa-dev] [PATCH 1/2] glxinfo/wglinfo: fix indentation for listing compression formats

2018-02-21 Thread Brian Paul
And prefix with "GL_ARB_texture_compression:" like other sections. --- src/xdemos/glinfo_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/xdemos/glinfo_common.c b/src/xdemos/glinfo_common.c index 0411891..efa96e6 100644 --- a/src/xdemos/glinfo_common.c +++ b/src/x

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.4 release candidate

2018-02-21 Thread Kenneth Graunke
On Thursday, February 8, 2018 8:47:00 PM PST Emil Velikov wrote: > Rejected (9) > > Jason Ekstrand (2): > e52a9f18d69c94b7cb7f81361cdb9e2582c3d742 i965: Replace > draw_aux_buffer_disabled with draw_aux_usage > 20f70ae3858bc213e052a8434f0e637eb36203c4 i965/draw: Set > NEW_AU

Re: [Mesa-dev] [PATCH 0/5] NVIDIA Tegra support

2018-02-21 Thread Andre Heider
Hi Thierry, On 21/02/18 16:30, Thierry Reding wrote: From: Thierry Reding This series of patches implements initial support for Tegra. The first two patches import DRM UAPI from v4.16-rc1 that provide framebuffer modifiers that can be used to specify buffers shared between Nouveau and the Tegr

[Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-21 Thread Brian Paul
v2: fix indentation, prefix with "4.3:" like other sections. --- src/xdemos/glinfo_common.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/xdemos/glinfo_common.c b/src/xdemos/glinfo_common.c index efa96e6..3668026 100644 --- a/src/xdemos/glinfo_common.c +++ b/src/xdemos/gl

[Mesa-dev] [Bug 105161] Validation of KHR_blend_equation_advanced stricter than NVidia

2018-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105161 --- Comment #6 from Allan Sandfeld Jensen --- Right. I think NVidia can get away with it because this requirement is new in the KHR version, they also implement the original NV version which doesnt have it (and like is OpenGL norm, they share th

Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

2018-02-21 Thread Kyriazis, George
I believed I created the same failure by deleting libswr*.so, however in my case (running glxgears) I hit a SEGV in XMesaCreateVisual (calling xmdpy->screen->is_format_supported()), because xmesa_init_display() created an xmdpy with a NULL screen. I never get to the xmesa_close_display(). Were

Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

2018-02-21 Thread Chuck Atkins
Hi George, This first showed up on one of our older dashboard machines without AVX (Nehalem processor). You can easily reproduce it by building with --with-swr-archs=knl,skx when the machine you're trying to use it on is neither. Note that dri-glx seems to handle this case just fine but xlib-gl

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

2018-02-21 Thread Daniel Vetter
On Tue, Feb 20, 2018 at 10:14:47PM -0800, Chad Versace wrote: > On Thu 21 Dec 2017, Daniel Vetter wrote: > > On Thu, Dec 21, 2017 at 12:22 AM, Kristian Kristensen > > wrote: > >> On Wed, Dec 20, 2017 at 12:41 PM, Miguel Angel Vico > >> wrote: > >>> On Wed, 20 Dec 2017 11:54:10 -0800 Kristian Hø

Re: [Mesa-dev] [PATCH v2 2/2] radv: implement AMD_gcn_shader extension

2018-02-21 Thread Bas Nieuwenhuizen
Please split this up into 4 patches: 1 for the core nir part, 1 for the spirv part, 1 for the ac part and finally 1 for the radv. On Wed, Feb 21, 2018 at 7:00 PM, wrote: > From: Dave Airlie > > Co-authored-by: Daniel Schürmann > Signed-off-by: Daniel Schürmann > --- > src/amd/common/ac_llvm_

Re: [Mesa-dev] [PATCH 01/17] intel: Add a preliminary device for Ice Lake

2018-02-21 Thread Anuj Phogat
On Wed, Feb 21, 2018 at 11:09 AM, Scott D Phillips wrote: > Anuj Phogat writes: > >> On Wed, Feb 21, 2018 at 10:00 AM, Scott D Phillips >> wrote: >>> Matt Turner writes: >>> From: Anuj Phogat Signed-off-by: Anuj Phogat --- include/pci_ids/i965_pci_ids.h | 9

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-21 Thread Rob Herring
On Wed, Feb 21, 2018 at 10:01 AM, Emil Velikov wrote: > Hi all, > > Pardon for dropping in late. I think you've got nearly everything > settled down, just sharing a couple of ideas. > > On 21 February 2018 at 04:19, Tomasz Figa wrote: >> On Wed, Feb 21, 2018 at 4:03 AM, Rob Herring wrote: >>> On

Re: [Mesa-dev] [PATCH v2 2/2] radv: implement AMD_gcn_shader extension

2018-02-21 Thread Connor Abbott
On Wed, Feb 21, 2018 at 3:13 PM, Connor Abbott wrote: > On Wed, Feb 21, 2018 at 3:03 PM, Daniel Schürmann > wrote: >> >>> On Wed, Feb 21, 2018 at 1:00 PM, >>> wrote: From: Dave Airlie Co-authored-by: Daniel Schürmann Signed-off-by: Daniel Schürmann --- sr

Re: [Mesa-dev] [PATCH v11 07+08/15] vulkan/wsi/x11: Consistently update and return swapchain status

2018-02-21 Thread Jason Ekstrand
For this one, I'm making live edits to see if I like the suggested changes. I'll send out the v2 with the comments incorporated when I'm done. On Wed, Feb 21, 2018 at 11:32 AM, Jason Ekstrand wrote: > From: Daniel Stone > > Use a helper function for updating the swapchain status. This will be

Re: [Mesa-dev] [PATCH 01/17] intel: Add a preliminary device for Ice Lake

2018-02-21 Thread Anuj Phogat
On Wed, Feb 21, 2018 at 9:22 AM, Rafael Antognolli wrote: > My understanding is that this commit is enough to make the driver try to > initialize, at least for i965. If that's the case, how about we add > something like what was removed by commit > bf1577fe0972ae910c071743dc89d261a46c2926 for CNL?

  1   2   >