[Mesa-dev] [PATCH] isl: take tilesize into account in isl_calc_row_pitch checks

Function isl_calc_min_row_pitch multiplies pitch by tilesize but the checks in isl_calc_row_pitch do not take this to account when comparing against caller provided row_pitch. Fixes: e9017d5 ("isl: Let isl_surf_init's caller set the exact row pitch (v2)") Signed-off-by: Tapani Pälli --- src/inte

[Mesa-dev] [PATCH 0/6] gallium, radeonsi: ARB_shader_clock implementation

Hi all, a pretty trivial extension. Maybe someone finds it useful for some micro-benchmarks and analysis of shader performance. Please review! Thanks, Nicolai -- docs/features.txt| 2 +- docs/relnotes/17.1.0.html| 1 + src/compiler/glsl/builtin_f

[Mesa-dev] [PATCH 4/6] st/mesa: implement ARB_shader_clock

From: Nicolai Hähnle --- src/mesa/state_tracker/st_extensions.c | 1 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 11 ++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 16f8685..

[Mesa-dev] [PATCH 3/6] tgsi: add CLOCK opcode

From: Ilia Mirkin Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_info.c | 2 +- src/gallium/docs/source/tgsi.rst | 14 ++ src/gallium/include/pipe/p_shader_tokens.h | 2 +- 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/src/gallium/au

[Mesa-dev] [PATCH 1/6] glsl: fix clockARB builtin function

From: Nicolai Hähnle The underlying intrinsic is defined to always have a uvec2 return type. --- src/compiler/glsl/builtin_functions.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/builtin_functions.cpp b/src/compiler/glsl/builtin_functions.cpp index e3

[Mesa-dev] [PATCH 5/6] radeonsi: emit TGSI_OPCODE_CLOCK

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 46c7d41..415d13b 100644 --- a/src/gallium/drivers/radeonsi/si_sh

[Mesa-dev] [PATCH 6/6] radeonsi: enable ARB_shader_clock

From: Nicolai Hähnle --- docs/features.txt | 2 +- docs/relnotes/17.1.0.html | 1 + src/gallium/drivers/radeonsi/si_pipe.c | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index b4e54a7..d707f01 100644

[Mesa-dev] [PATCH 2/6] gallium: add PIPE_CAP_TGSI CLOCK

From: Nicolai Hähnle --- src/gallium/docs/source/screen.rst | 1 + src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 + src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/llvmpipe/lp_screen.c

Re: [Mesa-dev] [PATCH 8/9] radeonsi: decompress DCC in set_framebuffer_state instead of create_surface

On 29.03.2017 19:58, Marek Olšák wrote: From: Marek Olšák for threaded gallium, which can't use pipe_context in create_surface --- src/gallium/drivers/radeon/r600_pipe_common.h | 8 +++ src/gallium/drivers/radeon/r600_texture.c | 33 +++ src/gallium/drivers/rad

Re: [Mesa-dev] [PATCH] st/glsl_to_tgsi: use glsl_type::sampler_index()

On 30.03.2017 00:28, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset Nice cleanup. Reviewed-by: Nicolai Hähnle --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 68 +- 1 file changed, 2 insertions(+), 66 deletions(-) diff --git a/src/mesa/state_tracker/st

Re: [Mesa-dev] [PATCH] glsl: allow glsl_type::sampler_index() with images

On 30.03.2017 00:33, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset Maybe some of those names should be changed to reflect the dual use? Anyway, this patch is Reviewed-by: Nicolai Hähnle --- src/compiler/glsl_types.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [Mesa-dev] [PATCH] mesa: disable glthread when DEBUG_OUTPUT_SYNCHRONOUS is enabled

On 30.03.2017 07:21, Timothy Arceri wrote: We could re-enable it also but I haven't tested that yet, and I'm not sure we care much anyway. Reviewed-by: Nicolai Hähnle --- src/mesa/main/debug_output.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/main/debug_output.c b/src

Re: [Mesa-dev] [PATCH] winsys/amdgpu: remove AMDGPU_INFO_NUM_EVICTIONS

On 29.03.2017 21:06, Samuel Pitoiset wrote: This is now exposed with libdrm_amdgpu 2.4.76. Reviewed-by: Nicolai Hähnle Signed-off-by: Samuel Pitoiset --- src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 4 1 file changed, 4 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdg

Re: [Mesa-dev] [PATCH] configure.ac: require libdrm_amdgpu 2.4.76 for Vega

Reviewed-by: Nicolai Hähnle On 29.03.2017 20:23, Marek Olšák wrote: From: Marek Olšák --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index ab9a91e..70885fb 100644 --- a/configure.ac +++ b/configure.ac @@ -67,21 +67,21 @@ OPENC

[Mesa-dev] [PATCH 05/25] radv: add tess shader stage user data support.

From: Dave Airlie This just adds support for tess to the shader stage conversion and emits the per-stage descriptors/constants for tess stages. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 45 +--- 1 file changed, 38 insertions(+), 7 del

[Mesa-dev] [PATCH 04/25] radv: use defines for ring descriptor offsets.

From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 8 src/amd/common/ac_nir_to_llvm.h | 7 +++ 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index d3f6112..97f6972 10

[Mesa-dev] [PATCH 06/25] radv/ac: add tess changes to shader keys/info

From: Dave Airlie This adds the tess pieces for shader keys and shader info, it adds the necessary bits to the vertex key/info as well. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.h | 40 1 file changed, 40 insertions(+) diff --git a/s

[Mesa-dev] [PATCH 03/25] radv: add helper function to denote if tess is enabled on a pipeline.

From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_private.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/amd/vulkan/radv_private.h b/src/amd/vulkan/radv_private.h index 31e0828..c5c872f 100644 --- a/src/amd/vulkan/radv_private.h +++ b/src/amd/vulkan/radv_priva

[Mesa-dev] [PATCH 07/25] radv: add support for some device specific tess information.

From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 6 ++ src/amd/vulkan/radv_private.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 64970bd..fe531e1 100644 --- a/src/amd/vulkan/radv_dev

[Mesa-dev] [RFC] radv initial tessellation support

This contains the initial tessellation shader support for radv. It currently passes all the tess tests in CTS when run under piglit, but when run in CTS itself I seem to get some misc fails when multiple tests are run in one process. I'll be chasing that down asap. But I thought it would be good

[Mesa-dev] [PATCH 14/25] radv: add tess ctrl stage barrier workaround for SI.

From: Dave Airlie This just ports the workaround from radeonsi. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index f8350d8..2828

[Mesa-dev] [PATCH 11/25] radv: configure tessellation distribution register.

From: Dave Airlie This just takes the radeonsi values. Signed-off-by: Dave Airlie --- src/amd/vulkan/si_cmd_buffer.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c index 6e50f64..ad6ba68 1006

[Mesa-dev] [PATCH 02/25] radv: handle clip dist in es outputs.

From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 4 1 file changed, 4 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 16c1eae..d3f6112 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_

[Mesa-dev] [PATCH 01/25] radv: drop unneeded start

From: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 8e77049..16c1eae 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_llvm.

[Mesa-dev] [PATCH 08/25] radv: add tessellation ring allocation support.

From: Dave Airlie This patch adds support for the offchip rings for storing tessellation factors and attribute data. It includes the register setup for the TF ring Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 6 ++ src/amd/vulkan/radv_device.c | 210

[Mesa-dev] [PATCH 13/25] radv/ac: add support for patch inputs to unique index code.

From: Dave Airlie This add support for tessellation patch inputs to the code that finds the unique parameter index. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 8 1 file changed, 8 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir

[Mesa-dev] [PATCH 16/25] radv: add tessellation support to variant code.

From: Dave Airlie This just fills out the rsrc registers for tess shaders. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_pipeline.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 944

[Mesa-dev] [PATCH 10/25] radv/ac: setup tessellation shader inputs.

From: Dave Airlie This just configures all the register inputs for the tessellation related stages. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 82 - 1 file changed, 81 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir

[Mesa-dev] [PATCH 17/25] radv/pipeline: start calculating tess stage.

From: Dave Airlie This calculates the pipeline state for tessellation. It moves the gs ring calculation down to below where the tessellation shaders will be compiled, as it needs the info from those shaders. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_pipeline.c | 204 +

[Mesa-dev] [PATCH 15/25] radv: add tessellation support to shader naming

From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_pipeline.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index df46276..944e393 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/amd

[Mesa-dev] [PATCH 23/25] radv/pipeline: handle tessellation shader compilation

From: Dave Airlie So tess shaders have some circular dependencies, TCS needs the TES primitive mode TES needs the TCS vertices out This builds the nir for each shader first to get the info, executes a tes specific nir pass, then builds the LLVM shaders. Signed-off-by: Dave Airlie --- src/amd

[Mesa-dev] [PATCH 18/25] radv/ac: hook up shader information handling for tessellation

From: Dave Airlie This hooks up the tessellation shader info to the nir values and ctx generated ones. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common

[Mesa-dev] [PATCH 12/25] radv: port polaris vgt vertex reuse workaround.

From: Dave Airlie This ports the VGT_VERTEX_REUSE register settings for Polaris GPUs from radeonsi. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 16 src/amd/vulkan/si_cmd_buffer.c | 3 ++- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/s

[Mesa-dev] [PATCH 24/25] radv/cmd: emit tessellation state.

From: Dave Airlie This emits the tessellation shaders and state to the command stream. It contains the logic to emit the LS/HS shaders. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 113 +-- 1 file changed, 109 insertions(+), 4 deletions

[Mesa-dev] [PATCH 19/25] radv/ac: hook up tessellation intrinsics.

From: Dave Airlie This just adds support for the nir intrinsics that tessellation uses. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 35 ++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/a

[Mesa-dev] [PATCH 20/25] radv/ac: add clip support for tess eval shader.

From: Dave Airlie As this may be the last shader to emit clip distances. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 8f7273e..7340475 100644 --- a

[Mesa-dev] [PATCH 09/25] radv/ac: setup tess rings on compiler side.

From: Dave Airlie This just sets up the necessary pointers on the compiler side for the rings needed for tessellation. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 13 - src/amd/common/ac_nir_to_llvm.h | 2 ++ 2 files changed, 14 insertions(+), 1 deletion(-) d

[Mesa-dev] [PATCH 25/25] radv: enable tessellation shaders.

From: Dave Airlie This enables tessellation shaders and sets some values for the maximums. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 18 +- src/amd/vulkan/radv_pipeline.c | 1 + 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/amd/vulka

[Mesa-dev] [PATCH 22/25] radv/ac: handle writing out tess factors.

From: Dave Airlie This ports the code from radeonsi to build the if/endif, and ports the tess factor emission code. This code has an optimisation TODO that we can deal with later. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 238 1 f

[Mesa-dev] [PATCH 21/25] radv/ac: add support for TCS/TES inputs/outputs.

From: Dave Airlie This adds support for the tessellation inputs/outputs to the shader compiler, this is one of the main pieces of the patch. It is very similiar to the radeonsi code (post merge we should consider if there are better sharing opportunities). The main differences from radeonsi, is

Re: [Mesa-dev] [PATCH] gbm/dri: Flush after unmap

On 03/30/2017 05:48 AM, Michel Dänzer wrote: > On 30/03/17 12:56 AM, Thomas Hellstrom wrote: >> On 03/29/2017 02:34 PM, Emil Velikov wrote: >>> On 29 March 2017 at 13:02, Thomas Hellstrom wrote: On 03/29/2017 01:30 PM, Emil Velikov wrote: > On 28 March 2017 at 20:39, Thomas Hellstrom wro

Re: [Mesa-dev] [PATCH] isl: take tilesize into account in isl_calc_row_pitch checks

Forget this one, it's not correct or needs some more checks/changes. On 03/30/2017 10:17 AM, Tapani Pälli wrote: Function isl_calc_min_row_pitch multiplies pitch by tilesize but the checks in isl_calc_row_pitch do not take this to account when comparing against caller provided row_pitch. Fixes:

Re: [Mesa-dev] [PATCH] gbm/dri: Flush after unmap

On 30/03/17 05:09 PM, Thomas Hellstrom wrote: > On 03/30/2017 05:48 AM, Michel Dänzer wrote: >> On 30/03/17 12:56 AM, Thomas Hellstrom wrote: >>> On 03/29/2017 02:34 PM, Emil Velikov wrote: On 29 March 2017 at 13:02, Thomas Hellstrom wrote: > On 03/29/2017 01:30 PM, Emil Velikov wrote: >>

Re: [Mesa-dev] [PATCH] [RFC v3] mesa/glthread: Call unmarshal_batch directly in glthread_finish

Thank you guys for testing. I'll address all issues in next patch if we decide to merge it. Nicolai, Could you comment on _glapi_{get/set}_dispatch part. I'm not familiar with it and I'm not sure if it's correct. On Thu, Mar 30, 2017 at 5:38 AM, Michel Dänzer wrote: > On 30/03/17 02:31 AM, Ba

[Mesa-dev] [PATCH] radeonsi: implement ARB_shader_group_vote

From: Nicolai Hähnle --- docs/features.txt| 2 +- docs/relnotes/17.1.0.html| 1 + src/gallium/drivers/radeonsi/si_pipe.c | 4 +- src/gallium/drivers/radeonsi/si_shader.c | 82 4 files changed, 87 insertions(+), 2 delet

Re: [Mesa-dev] [PATCH 4/6] st/mesa: implement ARB_shader_clock

On 03/30/2017 09:38 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/mesa/state_tracker/st_extensions.c | 1 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 11 ++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/

[Mesa-dev] [PATCH 1/2] mesa/glthread: add async support to ARB_gpu_shader_fp64 uniform functions

--- This is a resend. For some reason the patches didn't make it to the list last time. src/mapi/glapi/gen/ARB_gpu_shader_fp64.xml | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_gpu_shader_fp64.xml b/src/mapi/glapi/gen/A

[Mesa-dev] [PATCH 2/2] mesa/glthread: add async support to ARB_gpu_shader_int64 uniform functions

--- src/mapi/glapi/gen/ARB_gpu_shader_int64.xml | 32 ++--- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_gpu_shader_int64.xml b/src/mapi/glapi/gen/ARB_gpu_shader_int64.xml index d0e4c54..f6ee64c 100644 --- a/src/mapi/glapi/gen/ARB_

Re: [Mesa-dev] [PATCH 0/6] gallium, radeonsi: ARB_shader_clock implementation

Except a small thing in patch 4, the series is: Reviewed-by: Samuel Pitoiset Thanks! On 03/30/2017 09:38 AM, Nicolai Hähnle wrote: Hi all, a pretty trivial extension. Maybe someone finds it useful for some micro-benchmarks and analysis of shader performance. Please review! Thanks, Nicolai -

[Mesa-dev] [Bug 100201] llvmpipe Windows scons build with MSVC toolchain and LLVM 4.0 fails

https://bugs.freedesktop.org/show_bug.cgi?id=100201 --- Comment #10 from Anonymous Helper --- Thanks, for the suggestion on how to build LLVM 4.0 with MSVC 2015 toolset when having Visual Studio 2017 installed, unfortunately it didn't help. Building both LLVM 4.0 and Mesa 17.0.2 with C11 threads

[Mesa-dev] [Bug 100201] llvmpipe Windows scons build with MSVC toolchain and LLVM 4.0 fails

https://bugs.freedesktop.org/show_bug.cgi?id=100201 --- Comment #11 from Anonymous Helper --- Created attachment 130561 --> https://bugs.freedesktop.org/attachment.cgi?id=130561&action=edit llvmpipe 17.0.2 with xtime patch build log with LLVM 4.0 using MSVC 2015 toolset for both -- You are re

[Mesa-dev] [Bug 100201] llvmpipe Windows scons build with MSVC toolchain and LLVM 4.0 fails

https://bugs.freedesktop.org/show_bug.cgi?id=100201 Anonymous Helper changed: What|Removed |Added Attachment #130219|0 |1 is obsolete|

[Mesa-dev] [Bug 100201] llvmpipe Windows scons build with MSVC toolchain and LLVM 4.0 fails

https://bugs.freedesktop.org/show_bug.cgi?id=100201 Anonymous Helper changed: What|Removed |Added Attachment #130561|llvmpipe 17.0.2 with xtime |llvmpipe 17.0.2 with xtime de

[Mesa-dev] [Bug 100201] Windows scons build with MSVC toolchain and LLVM 4.0 fails

https://bugs.freedesktop.org/show_bug.cgi?id=100201 Anonymous Helper changed: What|Removed |Added Summary|llvmpipe Windows scons |Windows scons build with

[Mesa-dev] [RFC PATCH] egl/android: Dequeue buffers inside EGL calls

Android buffer queues can be abandoned, which results in failing to dequeue next buffer. Currently this would fail somewhere deep within the DRI stack calling loader's getBuffers*(), without any error reporting to the client app. However Android framework code relies on proper signaling of this eve

[Mesa-dev] [PATCH] anv: change BLOCK_POOL_MEMFD_SIZE to 1GB

This allows us to run 32bit Vulkan apps on Android, ftruncate call would fail on 2GB (max size being 2GB - 1). Signed-off-by: Tapani Pälli --- history: we had some discussion about this some weeks back and Jason proposed to simply set the size to 1GB: https://lists.freedesktop.org/archives/mesa-

Re: [Mesa-dev] [RFC PATCH] egl/android: Dequeue buffers inside EGL calls

Uhh, last minute rebase without compile re-testing, sorry. On Thu, Mar 30, 2017 at 7:55 PM, Tomasz Figa wrote: [snip] > diff --git a/src/egl/drivers/dri2/platform_android.c > b/src/egl/drivers/dri2/platform_android.c > index 6db4015cc9..571afa8004 100644 > --- a/src/egl/drivers/dri2/platform_an

[Mesa-dev] [RFC PATCH RESEND] CHROMIUM: egl/android: Dequeue buffers inside EGL calls

Android buffer queues can be abandoned, which results in failing to dequeue next buffer. Currently this would fail somewhere deep within the DRI stack calling loader's getBuffers*(), without any error reporting to the client app. However Android framework code relies on proper signaling of this eve

Re: [Mesa-dev] [PATCH] glsl: allow glsl_type::sampler_index() with images

On 03/30/2017 09:49 AM, Nicolai Hähnle wrote: On 30.03.2017 00:33, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset Maybe some of those names should be changed to reflect the dual use? Anyway, this patch is sampler_index() looks fine to me. What do you have in mind? Reviewed-by: N

[Mesa-dev] [PATCH 0/4] i965: Ivybridge ARB_vertex_attrib_64bit / OpenGL 4.2

Hi. This series enables the support for Ivybridge VA64, and thus enabling also OpenGL 4.2 in Ivybridge. These patches are available in our repository for testing. You can clone it using the following command: $ git clone -b i965-va64-gen7-ivb-scalar-vec4-rc1 \ https://github.com/Igalia/mesa.git

[Mesa-dev] [PATCH 2/4] i965: enable ARB_shader_precision in gen7+

From: Samuel Iglesias Gonsálvez --- src/mesa/drivers/dri/i965/intel_extensions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 53b5eaf8a0..fc974b9860 100644 --- a/src/mesa/dri

[Mesa-dev] [PATCH 1/4] i965: enable ARB_vertex_attrib_64bit for gen7+

--- src/mesa/drivers/dri/i965/intel_extensions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 467a0d3e84..53b5eaf8a0 100644 --- a/src/mesa/drivers/dri/i965/intel_extensions.c +

[Mesa-dev] [PATCH 3/4] i965: enable OpenGL 4.2 in Ivybridge

--- src/mesa/drivers/dri/i965/intel_extensions.c | 2 +- src/mesa/drivers/dri/i965/intel_screen.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index fc974b9860..0133fa1006 100

[Mesa-dev] [PATCH 4/4] docs: mark GL_ARB_vertex_attrib_64bit and OpenGL 4.2 as supported by i965/gen7+

--- docs/features.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index d34bef157c..5c22acfb17 100644 --- a/docs/features.txt +++ b/docs/features.txt @@ -142,11 +142,11 @@ GL 4.1, GLSL 4.10 --- all DONE: i965/hsw+, nvc0, r600, rade

Re: [Mesa-dev] [PATCH 1/2] nir/constant_expressions: Pull the guts out into a helper block

Looks good and clearer. Series is: Reviewed-by: Eduardo Lima Mitev On 03/14/2017 10:08 PM, Jason Ekstrand wrote: > --- > src/compiler/nir/nir_constant_expressions.py | 199 > ++- > 1 file changed, 101 insertions(+), 98 deletions(-) > > diff --git a/src/compiler/nir/nir

[Mesa-dev] [PATCH 1/4] mesa/vbo: remove redundant _mesa_is_bufferobj() calls

This is already called inside the vbo_exec_vtx_{unmap,map}() functions. --- src/mesa/vbo/vbo_exec_draw.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_draw.c b/src/mesa/vbo/vbo_exec_draw.c index c2fcb66..7e538c3 100644 --- a/src/mesa/vbo/vbo_

[Mesa-dev] [PATCH 3/4] mesa: remove MESA_GLSL=no_opts env option

This is confusing because is only applys to ARB shaders, and because of that its also not very useful. If someone requires this for debugging they can just make an ad-hoc code change. --- docs/shading.html | 1 - src/mesa/main/mtypes.h | 15 +++ src/mesa/main/s

[Mesa-dev] [PATCH 2/4] mesa: move FLUSH_VERTICES() call to meta

There is no need for this to be in the common code. --- src/mesa/drivers/common/meta.c | 11 ++- src/mesa/main/varray.c | 9 ++--- src/mesa/main/varray.h | 2 +- 3 files changed, 9 insertions(+), 13 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/

[Mesa-dev] [PATCH 4/4] mesa: remove MESA_GLSL=opt

This is unused. --- docs/shading.html | 1 - src/mesa/main/mtypes.h| 15 +++ src/mesa/main/shaderapi.c | 2 -- 3 files changed, 7 insertions(+), 11 deletions(-) diff --git a/docs/shading.html b/docs/shading.html index cd01af0..7e3d2e4 100644 --- a/docs/shading.html +++ b

[Mesa-dev] [PATCH] st/mesa: add st_convert_image()

Should be used by the state tracker when glGetImageHandleARB() is called in order to create a pipe_image_view template. Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_atom_image.c | 103 ++--- src/mesa/state_tracker/st_texture.h| 4 ++ 2 files chan

Re: [Mesa-dev] [PATCH] [RFC v3] mesa/glthread: Call unmarshal_batch directly in glthread_finish

On 30.03.2017 10:30, Bartosz Tomczyk wrote: Thank you guys for testing. I'll address all issues in next patch if we decide to merge it. Nicolai, Could you comment on _glapi_{get/set}_dispatch part. I'm not familiar with it and I'm not sure if it's correct. It looks good to me. Cheers, Nicol

Re: [Mesa-dev] [PATCH 4/6] st/mesa: implement ARB_shader_clock

On 30.03.2017 11:41, Samuel Pitoiset wrote: On 03/30/2017 09:38 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/mesa/state_tracker/st_extensions.c | 1 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 11 ++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/s

Re: [Mesa-dev] [PATCH] glsl: allow glsl_type::sampler_index() with images

On 30.03.2017 13:09, Samuel Pitoiset wrote: On 03/30/2017 09:49 AM, Nicolai Hähnle wrote: On 30.03.2017 00:33, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset Maybe some of those names should be changed to reflect the dual use? Anyway, this patch is sampler_index() looks fine to me

Re: [Mesa-dev] [PATCH] [RFC v3] mesa/glthread: Call unmarshal_batch directly in glthread_finish

Thanks Nicolai, Adding Timothy who seems most active on glthread topic. Guys, do you think we can land this, with above comments addressed? On Thu, Mar 30, 2017 at 1:40 PM, Nicolai Hähnle wrote: > On 30.03.2017 10:30, Bartosz Tomczyk wrote: > >> Thank you guys for testing. >> >> I'll address a

Re: [Mesa-dev] [PATCH 2/2] mesa/glthread: add async support to ARB_gpu_shader_int64 uniform functions

Both patches: Reviewed-by: Nicolai Hähnle On 30.03.2017 11:43, Timothy Arceri wrote: --- src/mapi/glapi/gen/ARB_gpu_shader_int64.xml | 32 ++--- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_gpu_shader_int64.xml b/src/mapi/glap

Re: [Mesa-dev] [PATCH] gbm/dri: Flush after unmap

On 29 March 2017 at 13:34, Emil Velikov wrote: > On 29 March 2017 at 13:02, Thomas Hellstrom wrote: >> Hi, Emil, >> >> On 03/29/2017 01:30 PM, Emil Velikov wrote: >>> Hi Thomas, >>> >>> On 28 March 2017 at 20:39, Thomas Hellstrom wrote: Drivers may queue dma operations on the context at unm

Re: [Mesa-dev] [PATCH 4/4] mesa: remove MESA_GLSL=opt

On 30.03.2017 13:26, Timothy Arceri wrote: This is unused. --- docs/shading.html | 1 - src/mesa/main/mtypes.h| 15 +++ src/mesa/main/shaderapi.c | 2 -- 3 files changed, 7 insertions(+), 11 deletions(-) diff --git a/docs/shading.html b/docs/shading.html index cd01af0.

Re: [Mesa-dev] [PATCH 123/140] radeonsi/gfx9: set/validate GFX9 BO metadata

This patch gives me a warning /var/tmp/portage/media-libs/mesa-/work/mesa-/src/gallium/drivers/radeon/r600_texture.c: In function ‘r600_texture_from_handle’: /var/tmp/portage/media-libs/mesa-/work/mesa-/src/gallium/drivers/radeon/r600_texture.c:1441:28: warning: unused variable ‘gf

Re: [Mesa-dev] [PATCH] AndroidIA: android: Pass sse4.1 flag as appropriate.

Hi Harish, On 28 March 2017 at 19:38, Harish Krupo wrote: > We have functions which depend on sse4.1 support but we didnt pass > the right compile flag for it. This patch fixes it. > Normally you want to include a snipped of the build issue, esp. when it's something non obvious. For future patche

Re: [Mesa-dev] [PATCH 000/140] RadeonSI: Initial Vega10 support

I get warnings with patch 058/140 /var/tmp/portage/media-libs/mesa-/work/mesa-/src/amd/addrlib/inc/chip/gfx9/gfx9_gb_reg.h:39:7: warning: type 'union GB_ADDR_CONFIG' violates the C++ One Definition Rule [-Wodr] union GB_ADDR_CONFIG { ^ /var/tmp/portage/media-libs/mesa-/work/mes

Re: [Mesa-dev] [PATCH] AndroidIA: android: add libmesa_genxml as dep to libmesa_isl

On 30 March 2017 at 06:56, Tapani Pälli wrote: > doh sorry about that 'AndroidIA' there, we are using it to differentiate > patches that we have in our tree and are not in Mesa master yet. > With s/Android-IA/intel/ in the subject Reviewed-by: Emli Velikov -Emil _

Re: [Mesa-dev] [PATCH] st/mesa: add st_convert_image()

On Thu, Mar 30, 2017 at 5:37 AM, Samuel Pitoiset wrote: > Should be used by the state tracker when glGetImageHandleARB() > is called in order to create a pipe_image_view template. > > Signed-off-by: Samuel Pitoiset > --- > src/mesa/state_tracker/st_atom_image.c | 103 > ++---

Re: [Mesa-dev] [RFC PATCH] egl/android: Dequeue buffers inside EGL calls

On 30 March 2017 at 11:55, Tomasz Figa wrote: > Android buffer queues can be abandoned, which results in failing to > dequeue next buffer. Currently this would fail somewhere deep within > the DRI stack calling loader's getBuffers*(), without any error > reporting to the client app. However Androi

[Mesa-dev] [Bug 100487] st_cb_eglimage.c:64:7: error: format not a string literal and no format arguments

https://bugs.freedesktop.org/show_bug.cgi?id=100487 Bug ID: 100487 Summary: st_cb_eglimage.c:64:7: error: format not a string literal and no format arguments Product: Mesa Version: git Hardware: All OS: Linu

[Mesa-dev] [PATCH v1] Android: Add an error handling for the null buffer

Add an error handling to droid_swap_buffers() to handle the undefined case of dri2_surf->buffer==null. We found that when running CTS testAbandonRepeatingRequestSurface on Chromebook, the test would fail. After digging, we found that the Android framework relied on an undefined behavior to abort th

Re: [Mesa-dev] [PATCH 4/4] mesa: remove MESA_GLSL=opt

On 30 March 2017 at 12:26, Timothy Arceri wrote: > This is unused. > --- > docs/shading.html | 1 - > src/mesa/main/mtypes.h| 15 +++ > src/mesa/main/shaderapi.c | 2 -- > 3 files changed, 7 insertions(+), 11 deletions(-) > > diff --git a/docs/shading.html b/docs/shading

Re: [Mesa-dev] [PATCH v1] Android: Add an error handling for the null buffer

Hi Zhou-hao, On 30 March 2017 at 10:53, Zhuo-hao Lee wrote: > Add an error handling to droid_swap_buffers() to handle the undefined > case of dri2_surf->buffer==null. > We found that when running CTS testAbandonRepeatingRequestSurface on > Chromebook, the test would fail. After digging, we found

[Mesa-dev] [PATCH 1/2] radeonsi: decompress DCC in set_framebuffer_state instead of create_surface (v2)

From: Marek Olšák for threaded gallium, which can't use pipe_context in create_surface v2: don't add a new decompress helper function --- src/gallium/drivers/radeon/r600_pipe_common.h | 4 src/gallium/drivers/radeon/r600_texture.c | 22 ++-- src/gallium/drivers/radeons

[Mesa-dev] [PATCH 2/2] radeonsi: decompress DCC in set_sampler_view instead of create_sampler_view (v2)

From: Marek Olšák v2: don't add a new decompress helper function --- src/gallium/drivers/radeonsi/si_descriptors.c | 14 +++--- src/gallium/drivers/radeonsi/si_pipe.h| 1 + src/gallium/drivers/radeonsi/si_state.c | 7 --- 3 files changed, 16 insertions(+), 6 deletions

Re: [Mesa-dev] [RFC PATCH] egl/android: Dequeue buffers inside EGL calls

On Thu, Mar 30, 2017 at 11:17 PM, Emil Velikov wrote: > > On 30 March 2017 at 11:55, Tomasz Figa wrote: > > Android buffer queues can be abandoned, which results in failing to > > dequeue next buffer. Currently this would fail somewhere deep within > > the DRI stack calling loader's getBuffers*()

[Mesa-dev] [Bug 100259] [EGL] [GBM] undefined reference to `gbm_bo_create_with_modifiers'

https://bugs.freedesktop.org/show_bug.cgi?id=100259 --- Comment #12 from Emil Velikov --- ovarieg...@yahoo.com If you're running into issue as described - `make' succeeds, while `make install' fails then it's the libtool bug/feature mentioned. Any of the four workarounds proposed should you up a

[Mesa-dev] [PATCH] gbm/dri: Check dri extension version before flush after unmap

The commit mentioned below required the __DRI2FlushExtension to have version 4 or above, for GBM functionality. That broke GBM with some classic dri drivers. Relax that requirement so that we only flush after unmap if we have version 4 or above. Drivers that require the flush for correct functional

Re: [Mesa-dev] [PATCH 4/4] docs: mark GL_ARB_vertex_attrib_64bit and OpenGL 4.2 as supported by i965/gen7+

2017-03-30 13:13 GMT+02:00 Juan A. Suarez Romero : > --- > docs/features.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/docs/features.txt b/docs/features.txt > index d34bef157c..5c22acfb17 100644 > --- a/docs/features.txt > +++ b/docs/features.txt > @@ -142,11 +1

Re: [Mesa-dev] [RFC PATCH] egl/android: Dequeue buffers inside EGL calls

On 30 March 2017 at 15:30, Tomasz Figa wrote: > On Thu, Mar 30, 2017 at 11:17 PM, Emil Velikov > wrote: >> >> On 30 March 2017 at 11:55, Tomasz Figa wrote: >> > Android buffer queues can be abandoned, which results in failing to >> > dequeue next buffer. Currently this would fail somewhere deep

[Mesa-dev] [Bug 100487] st_cb_eglimage.c:64:7: error: format not a string literal and no format arguments

https://bugs.freedesktop.org/show_bug.cgi?id=100487 Nicolai Hähnle changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 21/25] radv/ac: add support for TCS/TES inputs/outputs.

On Thu, 2017-03-30 at 18:01 +1000, Dave Airlie wrote: > --- a/src/amd/common/ac_nir_to_llvm.c > +++ b/src/amd/common/ac_nir_to_llvm.c > @@ -2244,6 +2370,322 @@ radv_get_deref_offset(struct > nir_to_llvm_context *ctx, nir_deref *tail, >  } >   >  static LLVMValueRef > +lds_load(struct nir_to_llvm_co

Re: [Mesa-dev] [Mesa-stable] [PATCH] gbm/dri: Check dri extension version before flush after unmap

On 30 March 2017 at 15:44, Thomas Hellstrom wrote: > The commit mentioned below required the __DRI2FlushExtension to have > version 4 or above, for GBM functionality. That broke GBM with some > classic dri drivers. Relax that requirement so that we only flush > after unmap if we have version 4 or

[Mesa-dev] [PATCH 1/2] mesa/glthread: add async support to ARB_gpu_shader_fp64 uniform functions

--- src/mapi/glapi/gen/ARB_gpu_shader_fp64.xml | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_gpu_shader_fp64.xml b/src/mapi/glapi/gen/ARB_gpu_shader_fp64.xml index fd1ad11..2f2b914 100644 --- a/src/mapi/glapi/gen/ARB_gpu_sh

[Mesa-dev] [PATCH 2/2] mesa/glthread: add async support to ARB_gpu_shader_int64 uniform functions

--- src/mapi/glapi/gen/ARB_gpu_shader_int64.xml | 32 ++--- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_gpu_shader_int64.xml b/src/mapi/glapi/gen/ARB_gpu_shader_int64.xml index d0e4c54..f6ee64c 100644 --- a/src/mapi/glapi/gen/ARB_

[Mesa-dev] Mesa 17.0.3 release candidate

Hello list, The candidate for the Mesa 17.0.3 is now available. Currently we have:  - 32 queued  - 1 nominated (outstanding)  - and 2 rejected patch(es) The current queue consists of fixes in several fronts. There are several patches addressing improvements in the API validation and the GLSL co

  1   2   3   >