Re: [Mesa-dev] [PATCH] i965/vec4: skip registers already marked as no_spill

2016-11-14 Thread Juan A. Suarez Romero
On Sun, 2016-11-13 at 23:00 -0800, Kenneth Graunke wrote: > On Friday, November 11, 2016 9:41:11 AM PST Juan A. Suarez Romero > wrote: > > > > Do not evaluate spill costs for registers that were already marked > > as > > no_spill. > > --- > >  src/mesa/drivers/dri/i965/brw_vec4_reg_allocate.cpp |

Re: [Mesa-dev] [PATCH] meta/GetTexSubImage: Account for GL_PACK_SKIP_IMAGES on compressed textures

2016-11-14 Thread Eduardo Lima Mitev
On 11/14/2016 07:41 AM, Kenneth Graunke wrote: On Sunday, November 13, 2016 10:21:11 AM PST Eduardo Lima Mitev wrote: This option is currently ignored when packing compressed textures. Fixes CTS test (on gen8+): * GL45-CTS.gtf32.GL3Tests.packed_pixels.packed_pixels_pixelstore --- src/mesa/driv

Re: [Mesa-dev] [PATCH] gbm/drm: Pick the oldest available buffer in get_back_bo

2016-11-14 Thread Pekka Paalanen
On Thu, 10 Nov 2016 16:01:32 + Daniel Stone wrote: > Hi, > > > > On Nov 10 2016, at 2:09 pm, Pekka Paalanen wrote: > > > On Wed, 9 Nov 2016 14:57:22 -0600 > Derek Foreman wrote: > > > > > > > We find the oldest backbuffer we can, on the grounds that clients are > > o

[Mesa-dev] [Bug 98691] egl.h:55: error: redefinition of typedef ‘EGLDisplay’

2016-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98691 --- Comment #1 from Emil Velikov --- I feared this might happen :-\ Vinson, can you please try a fix similar to c85b34ffd04f9a7a16fe30173474e857d0f42d5f -- You are receiving this mail because: You are the assignee for the bug. You are the QA C

Re: [Mesa-dev] [PATCH 1/2] util: import cache.c/h from glsl

2016-11-14 Thread Emil Velikov
Hi Marek, Please mention the reason behind the move - afaict it's not being used in 2/2. I'm have no objection against the move. There's a few comments below - feel free to squash those here or address as follow-up(s). On 13 November 2016 at 16:05, Marek Olšák wrote: > -if ENABLE_SHADER_CACHE

Re: [Mesa-dev] [PATCH] util: Fix Clang trivial destructor check.

2016-11-14 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Nov 14, 2016 at 8:11 AM, Vinson Lee wrote: > Check for Clang before GCC. > > Clang defines __GNUC__ == 4 and __GNUC_MINOR__ == 2 and matches the GCC > check but not the GCC version for trivial destructor. > > Fixes: 98ab905af0e0 ("mesa: Define introspectio

[Mesa-dev] [PATCH v2] meta/GetTexSubImage: Account for GL_PACK_SKIP_IMAGES on compressed textures

2016-11-14 Thread Eduardo Lima Mitev
This option is currently ignored when packing compressed textures. Fixes CTS test (on gen8+): * GL45-CTS.gtf32.GL3Tests.packed_pixels.packed_pixels_pixelstore --- src/mesa/drivers/common/meta.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/common/me

Re: [Mesa-dev] [PATCH 11/20] anv/pipeline: Unify 3DSTATE_PS emission

2016-11-14 Thread Timothy Arceri
On Sat, 2016-11-12 at 13:34 -0800, Jason Ekstrand wrote: In this patch we no longer do:   ps.RenderTargetResolveEnable = false; It would be nice to be consistent and either initialise everything or just drop all the lines setting things to false/0 and let the memset do its job. > --- >  src/int

Re: [Mesa-dev] [PATCH 10/20] intel/genxml: Make some 3DSTATE_PS fields more consistent

2016-11-14 Thread Timothy Arceri
Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 12/20] intel/genxml: Make 3DSTATE_WM more consistent across gens

2016-11-14 Thread Timothy Arceri
On Sat, 2016-11-12 at 13:34 -0800, Jason Ekstrand wrote: > --- >  src/intel/blorp/blorp_genX_exec.h |  4 ++-- >  src/intel/genxml/gen6.xml | 16 +--- >  src/intel/genxml/gen7.xml | 16 +--- >  src/intel/genxml/gen75.xml| 16 +--- >  src/intel

Re: [Mesa-dev] [PATCH 14/20] anv/pipeline: Move 3DSTATE_PS_EXTRA setup into a helper

2016-11-14 Thread Timothy Arceri
Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 15/20] anv/pipeline: Rework the 3DSTATE_VF_TOPOLOGY helper

2016-11-14 Thread Timothy Arceri
Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 16/20] anv/pipline: Re-order state emission and make it consistent

2016-11-14 Thread Timothy Arceri
Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 20/20] anv/pipeline: Use get_scratch_space/address for compute shaders

2016-11-14 Thread Timothy Arceri
Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2] meta/GetTexSubImage: Account for GL_PACK_SKIP_IMAGES on compressed textures

2016-11-14 Thread Edward O'Callaghan
V2 is Acked-by: Edward O'Callaghan On 11/14/2016 09:32 PM, Eduardo Lima Mitev wrote: > This option is currently ignored when packing compressed textures. > > Fixes CTS test (on gen8+): > * GL45-CTS.gtf32.GL3Tests.packed_pixels.packed_pixels_pixelstore > --- > src/mesa/drivers/common/meta.c | 9

Re: [Mesa-dev] [PATCH] util: Fix Clang trivial destructor check.

2016-11-14 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 11/14/2016 06:11 PM, Vinson Lee wrote: > Check for Clang before GCC. > > Clang defines __GNUC__ == 4 and __GNUC_MINOR__ == 2 and matches the GCC > check but not the GCC version for trivial destructor. > > Fixes: 98ab905af0e0 ("mesa: Define introspection macro

Re: [Mesa-dev] [Clover] Compilations error with latest LLVM version 4.0.0svn in llvm/codegen/bitcode.cpp

2016-11-14 Thread Vedran Miletić
On 11/14/2016 04:40 AM, Dieter Nützel wrote: > Hello Francisco, > > next little change needed. > > Thanks, > Dieter > > make[4]: Entering directory '/opt/mesa/src/gallium/state_trackers/clover' > CXX llvm/codegen/libclllvm_la-bitcode.lo > llvm/codegen/bitcode.cpp: In function 'std::unique

[Mesa-dev] [PATCH] clover: adapt to new error API since LLVM r286752

2016-11-14 Thread Vedran Miletić
--- src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp b/src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp index 8e89a49..5dcc4f8 100644 --- a

[Mesa-dev] [ANNOUNCE] mesa 13.0.1

2016-11-14 Thread Emil Velikov
Mesa 13.0.1 is now available. The release contains multiple fixes amongst which: Up-to 30% performance increase using the Intel ANV Vulkan driver. The Radeon RADV Vulkan driver now ships with distinctly named json files, which include the full Vulkan driver path. Making it possible for people to

Re: [Mesa-dev] Mesa 13.0.1 release candidate

2016-11-14 Thread Emil Velikov
On 12 November 2016 at 14:24, Darren Salt wrote: > Could you also add commit 9b121512ac0f78d0996613664b456005d88370d2? It's a > correctness fix for radv (ported from anv) which fixes segfaults which I'd > observed in Talos Principle. > Thanks for the nominations gents. They should be all in 13.0.1

[Mesa-dev] EGL/android: pbuffer implementation.

2016-11-14 Thread Liu Zhiquan
mesa android path didn't support pbuffer, so add pbuffer support to fix most deqp and cts pbuffer test cases fail; add support of front buffer and single buffer config. Test status: android CTS EGL pbuffer test can run without native crash. test:[DEQP,EGL]all deqp pbuffer case passed. V2: remove

Re: [Mesa-dev] [PATCH 1/2] mesa: add NV_image_formats extension support

2016-11-14 Thread Lionel Landwerlin
On 11/11/16 18:39, Ilia Mirkin wrote: On Fri, Nov 11, 2016 at 10:40 AM, Lionel Landwerlin wrote: Signed-off-by: Lionel Landwerlin Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98480 --- src/compiler/glsl/glsl_parser.yy | 5 +-- src/compiler/glsl/glsl_parser_extras.cpp | 58

[Mesa-dev] [PATCH] clover: adapt to new error API since LLVM r286752

2016-11-14 Thread Dieter Nützel
Tested-by: Dieter Nützel Thanks Vedran! Dieter Am 14.11.2016 12:17, schrieb Vedran Miletić: --- src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/clover/llvm/codegen/bitcode.c

[Mesa-dev] [PATCH 1/2] anv/format: handle unsupported formats properly

2016-11-14 Thread Iago Toral Quiroga
According to the spec for vkGetPhysicalDeviceImageFormatProperties: "If format is not a supported image format, or if the combination of format, type, tiling, usage, and flags is not supported for images, then vkGetPhysicalDeviceImageFormatProperties returns VK_ERROR_FORMAT_NOT_SUPPORTED." Mak

[Mesa-dev] [PATCH 2/2] anv/format: support VK_FORMAT_R8G8B8_SRGB

2016-11-14 Thread Iago Toral Quiroga
Fixes dEQP-VK.api.image_clearing.clear_color_image.1d_r8g8b8_srgb --- src/intel/vulkan/anv_formats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c index bca9aeb..2adde8b 100644 --- a/src/intel/vulkan/anv_formats.

Re: [Mesa-dev] [PATCH 1/2] anv/format: handle unsupported formats properly

2016-11-14 Thread Lionel Landwerlin
Thanks for Spotting this. Reviewed-by: Lionel Landwerlin On 14/11/16 13:23, Iago Toral Quiroga wrote: According to the spec for vkGetPhysicalDeviceImageFormatProperties: "If format is not a supported image format, or if the combination of format, type, tiling, usage, and flags is not suppor

Re: [Mesa-dev] [PATCH 2/2] anv/format: support VK_FORMAT_R8G8B8_SRGB

2016-11-14 Thread Lionel Landwerlin
Sounds good too. Reviewed-by: Lionel Landwerlin On 14/11/16 13:23, Iago Toral Quiroga wrote: Fixes dEQP-VK.api.image_clearing.clear_color_image.1d_r8g8b8_srgb --- src/intel/vulkan/anv_formats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_formats.

Re: [Mesa-dev] [PATCH 1/2] mesa: add NV_image_formats extension support

2016-11-14 Thread Ilia Mirkin
On Mon, Nov 14, 2016 at 6:55 AM, Lionel Landwerlin wrote: > On 11/11/16 18:39, Ilia Mirkin wrote: >> On Fri, Nov 11, 2016 at 10:40 AM, Lionel Landwerlin >> wrote: >>> diff --git a/src/mesa/main/extensions_table.h >>> b/src/mesa/main/extensions_table.h >>> index 2dbd7da..f58f2ad 100644 >>> --- a/

Re: [Mesa-dev] EGL/android: pbuffer implementation.

2016-11-14 Thread Emil Velikov
On 14 November 2016 at 11:49, Liu Zhiquan wrote: > mesa android path didn't support pbuffer, so add pbuffer support to > fix most deqp and cts pbuffer test cases fail; > add support of front buffer and single buffer config. > > Test status: android CTS EGL pbuffer test can run without native crash

Re: [Mesa-dev] [PATCH] clover: adapt to new error API since LLVM r286752

2016-11-14 Thread Tom Stellard
On Mon, Nov 14, 2016 at 01:44:18PM +0100, Dieter Nützel wrote: > Tested-by: Dieter Nützel > > Thanks Vedran! > Pushed, thanks! -Tom > Dieter > > Am 14.11.2016 12:17, schrieb Vedran Miletić: > > --- > > src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp | 10 > > -- > > 1 fi

Re: [Mesa-dev] [PATCH] clover: adapt to new error API since LLVM r286752

2016-11-14 Thread Vedran Miletić
On 11/14/2016 04:49 PM, Tom Stellard wrote: > On Mon, Nov 14, 2016 at 01:44:18PM +0100, Dieter Nützel wrote: >> Tested-by: Dieter Nützel >> >> Thanks Vedran! >> > > Pushed, thanks! > > -Tom > Thank you! Vedran -- Vedran Miletić vedran.miletic.net

Re: [Mesa-dev] [PATCH 1/2] anv/descriptor_set: Write the state offset in the surface state free list.

2016-11-14 Thread Iago Toral
On Thu, 2016-11-10 at 16:53 -0800, Jason Ekstrand wrote: > When Kristian reworked descriptor set allocation, somehow he forgot > to > actually store the offset in the free list.  Somehow, this completely > missed CTS testing until now... This fixes all 2744 of the new > 'dEQP-VK.texture.filtering.*

Re: [Mesa-dev] [PATCH] clover: adapt to new error API since LLVM r286752

2016-11-14 Thread Jan Vesely
On Mon, 2016-11-14 at 12:17 +0100, Vedran Miletić wrote: > --- > src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp > b/src/gallium/state_tracker

Re: [Mesa-dev] [PATCH 08/20] anv/pipeline: Unify 3DSTATE_GS emission

2016-11-14 Thread Jason Ekstrand
On Sat, Nov 12, 2016 at 2:54 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > On Sat, 2016-11-12 at 13:34 -0800, Jason Ekstrand wrote: > > I have two questions and two suggestions below. > > With the suggestions addressed and assuming the answer to both > questions is yes, Patch 7-8 are

[Mesa-dev] [PATCH 01/13] glsl: ignore all but the rightmost layout-qualifier-name

2016-11-14 Thread Andres Gomez
When a layout contains a duplicated layout-qualifier-name in a single declaration, only the last occurrence should be taken into account. From page 59 (page 65 of the PDF) of the GLSL 4.40 spec: " More than one layout qualifier may appear in a single declaration. Additionally, the same layo

[Mesa-dev] [PATCH v4 00/13] deal with multiple appearances of the same layout-qualifier-name in a single declaration

2016-11-14 Thread Andres Gomez
In the case of layout-qualifier-names that can appear multiple times in different declarations of the same shader or, even, the same program, but that have to consistently hold the same value we are using the ast_layout_expression class which holds a list to store all the appearances to be able to

[Mesa-dev] [PATCH 03/13] glsl: Split default out layout qualifier merge

2016-11-14 Thread Andres Gomez
Currently, the default out layout qualifier merge performs specific validation and merge. We want to split out the validation from the merge so they can be done independently. Additionally, for simplification, the direction of the validation and merge is changed so the ast_type_qualifier calling

[Mesa-dev] [PATCH 07/13] glsl: Add comments for the point mode layout-id-qualifier validation

2016-11-14 Thread Andres Gomez
The point mode value in an ast_type_qualifier can only be true if the flag is already set since this layout-id-qualifier can only be or not be present in a shader. Hence, it is useless to check for its value if the flag is already set. However, for coherence and compatibility with future changes w

[Mesa-dev] [PATCH 08/13] glsl: ignore all but the rightmost layout qualifier name from the rightmost layout qualifier

2016-11-14 Thread Andres Gomez
From page 46 (page 52 of the PDF) of the GLSL 4.20 spec: " More than one layout qualifier may appear in a single declaration. If the same layout-qualifier-name occurs in multiple layout qualifiers for the same declaration, the last one overrides the former ones." Consider this examp

[Mesa-dev] [PATCH 11/13] glsl: push layout-qualifier-name values from variable declarations to global

2016-11-14 Thread Andres Gomez
After the previous modifications in the merging of the layout-qualifier-name values, we no longer push the final value in a declaration to the global values. This regression happens because we don't call for merging on the right-most layout qualifier of a declaration which is also the overriding o

[Mesa-dev] [PATCH 10/13] glsl: simplified error checking for duplicated layout-qualifiers

2016-11-14 Thread Andres Gomez
The GLSL parser has been simplified to check for the needed GL_ARB_shading_language_420pack extension just when merging the qualifiers in the proper cases. Reviewed-by: Timothy Arceri Signed-off-by: Andres Gomez --- src/compiler/glsl/ast_type.cpp | 6 ++ src/compiler/glsl/glsl_parser.yy

[Mesa-dev] [PATCH 04/13] glsl: Split default in layout qualifier merge

2016-11-14 Thread Andres Gomez
Currently, the default in layout qualifier merge performs specific validation and merge. We want to split out the validation from the merge so they can be done independently. Additionally, for simplification, the direction of the validation and merge is changed so the ast_type_qualifier calling t

[Mesa-dev] [PATCH 09/13] glsl: simplified ast_type_qualifier::merge_into_[in|out]_qualifier API

2016-11-14 Thread Andres Gomez
Since we modified the way in which multiple repetitions of the same layout-qualifier-name in a single declaration collapse into the ast_type_qualifier class, we can simplify the merge_into_[in|out]_qualifier APIs through removing the create_node parameter. Signed-off-by: Andres Gomez --- src/com

[Mesa-dev] [PATCH 02/13] glsl: merge layouts into the default one as the last step in interface blocks

2016-11-14 Thread Andres Gomez
Consider this example: " #version 150 core #extension GL_ARB_shading_language_420pack: require #extension GL_ARB_explicit_attrib_location: require layout(location=0) out vec4 o; layout(binding=2) layout(binding=3, std140) uniform U { vec4 a; } u[2];" A

[Mesa-dev] [PATCH 12/13] Revert "glsl: geom shader max_vertices layout must match."

2016-11-14 Thread Andres Gomez
This reverts commit 4c863993780a11cea6f88fa0682796bee5794042. The commit was erroneous because the ast_layout_expression class was created to hold a list of values for a layout-qualifier-name which is allowed to appear in more than one expression in the same shader/program but not to hold differen

[Mesa-dev] [PATCH 05/13] glsl: simplifies the merge of the default in layout qualifier

2016-11-14 Thread Andres Gomez
The merge into the default in layout qualifier duplicates a lot of code that can be reused from the generic merge method. Now, we use the generic merge method inside the specific merge for the default in layout qualifier. The generic merge method has been completed with some bits that were only pr

[Mesa-dev] [PATCH 13/13] Revert "glsl: allow layout qualifier overrides with ARB_shading_language_420pack"

2016-11-14 Thread Andres Gomez
This reverts commit aaa69c79cd584db4d9c6ea7794e93d29f3d54572. The commit was erroneous because the ast_layout_expression class is meant to hold a list used for an after check that all the declared values for a layout-qualifier-name are consistent. Therefore, the check for the possibility of dupli

[Mesa-dev] [PATCH 06/13] glsl: Remove unneeded check for incompatible primitive types in GS

2016-11-14 Thread Andres Gomez
The validation of the default in layout qualifier already assures that we won't have 2 ast_gs_input_layout objects with different primitive type values. In fact, the validation already assures that we won't have 2 ast_gs_input_layout objects in the AST tree at all. The check for an error in the sh

Re: [Mesa-dev] [PATCH 11/20] anv/pipeline: Unify 3DSTATE_PS emission

2016-11-14 Thread Jason Ekstrand
On Mon, Nov 14, 2016 at 2:35 AM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > On Sat, 2016-11-12 at 13:34 -0800, Jason Ekstrand wrote: > > In this patch we no longer do: > > ps.RenderTargetResolveEnable = false; > > It would be nice to be consistent and either initialise everything or

Re: [Mesa-dev] [PATCH] util: Fix Clang trivial destructor check.

2016-11-14 Thread Francisco Jerez
Vinson Lee writes: > Check for Clang before GCC. > > Clang defines __GNUC__ == 4 and __GNUC_MINOR__ == 2 and matches the GCC > check but not the GCC version for trivial destructor. > > Fixes: 98ab905af0e0 ("mesa: Define introspection macro to determine > whether a type is trivially destructible."

[Mesa-dev] [PATCH] anv: fix multi level clears with VK_REMAINING_MIP_LEVELS

2016-11-14 Thread Lionel Landwerlin
A commit from the CTS suite on the 1.0-dev branch started using VK_REMAINING_MIP_LEVELS, we're not dealing with it properly for clears. Fixes: dEQP-VK.api.image_clearing.clear_color_image.* Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_blorp.c | 4 ++-- 1 file changed, 2 insertio

Re: [Mesa-dev] [PATCH 12/20] intel/genxml: Make 3DSTATE_WM more consistent across gens

2016-11-14 Thread Jason Ekstrand
On Mon, Nov 14, 2016 at 2:46 AM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > On Sat, 2016-11-12 at 13:34 -0800, Jason Ekstrand wrote: > > --- > > src/intel/blorp/blorp_genX_exec.h | 4 ++-- > > src/intel/genxml/gen6.xml | 16 +--- > > src/intel/genxml/gen7.xml

Re: [Mesa-dev] [PATCH 1/2] anv/format: handle unsupported formats properly

2016-11-14 Thread Jason Ekstrand
On Mon, Nov 14, 2016 at 5:23 AM, Iago Toral Quiroga wrote: > According to the spec for vkGetPhysicalDeviceImageFormatProperties: > > "If format is not a supported image format, or if the combination of > format, > type, tiling, usage, and flags is not supported for images, then > vkGetPhysicalD

Re: [Mesa-dev] [PATCH 2/2] anv/format: support VK_FORMAT_R8G8B8_SRGB

2016-11-14 Thread Jason Ekstrand
I don't see a problem here Reviewed-by: Jason Ekstrand On Mon, Nov 14, 2016 at 6:10 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Sounds good too. > > Reviewed-by: Lionel Landwerlin > > On 14/11/16 13:23, Iago Toral Quiroga wrote: > >> Fixes dEQP-VK.api.image_clearing.clear_c

Re: [Mesa-dev] [PATCH 1/2] anv/format: handle unsupported formats properly

2016-11-14 Thread Jason Ekstrand
Also, please Cc stable On Mon, Nov 14, 2016 at 9:29 AM, Jason Ekstrand wrote: > On Mon, Nov 14, 2016 at 5:23 AM, Iago Toral Quiroga > wrote: > >> According to the spec for vkGetPhysicalDeviceImageFormatProperties: >> >> "If format is not a supported image format, or if the combination of >> for

Re: [Mesa-dev] [PATCH] anv: fix multi level clears with VK_REMAINING_MIP_LEVELS

2016-11-14 Thread Jason Ekstrand
Thanks! Reviewed-by: Jason Ekstrand Cc: "13.0" On Mon, Nov 14, 2016 at 9:26 AM, Lionel Landwerlin wrote: > A commit from the CTS suite on the 1.0-dev branch started using > VK_REMAINING_MIP_LEVELS, we're not dealing with it properly for clears. > > Fixes: >dEQP-VK.api.image_clearing.clear

[Mesa-dev] [Bug 98595] glsl: ralloc assertion "info->canary == CANARY" failed

2016-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98595 --- Comment #12 from Brian Paul --- (In reply to Jonathan Gray from comment #11) > The proposed fix stops the assertion for me. > > With i965 I now hit a different problem that seems to be unrelated, the > (OpenBSD) kernel logs > error: [drm:pid

Re: [Mesa-dev] [PATCH] clover: adapt to new error API since LLVM r286752

2016-11-14 Thread Francisco Jerez
Jan Vesely writes: > On Mon, 2016-11-14 at 12:17 +0100, Vedran Miletić wrote: >> --- >> src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp | 10 -- >> 1 file changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp >

Re: [Mesa-dev] [PATCH v2] nvc0/ir: use levelZero flag when the lod is set to 0

2016-11-14 Thread Samuel Pitoiset
On 11/10/2016 03:42 AM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- v1 -> v2: Move to handling this at SSA time. This is a lot more fragile since the texture arguments have been reordered already, but it's still easy enough to find the LOD argument. .../nouveau/codegen/nv50_ir_l

Re: [Mesa-dev] [PATCH 1/2] mesa: add NV_image_formats extension support

2016-11-14 Thread Francisco Jerez
Ilia Mirkin writes: > On Mon, Nov 14, 2016 at 6:55 AM, Lionel Landwerlin > wrote: >> On 11/11/16 18:39, Ilia Mirkin wrote: >>> On Fri, Nov 11, 2016 at 10:40 AM, Lionel Landwerlin >>> wrote: diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h index 2d

Re: [Mesa-dev] [PATCH] anv: fix multi level clears with VK_REMAINING_MIP_LEVELS

2016-11-14 Thread Nanley Chery
On Mon, Nov 14, 2016 at 05:26:09PM +, Lionel Landwerlin wrote: > A commit from the CTS suite on the 1.0-dev branch started using > VK_REMAINING_MIP_LEVELS, we're not dealing with it properly for clears. > > Fixes: >dEQP-VK.api.image_clearing.clear_color_image.* > > Signed-off-by: Lionel L

Re: [Mesa-dev] [PATCH v2] nvc0/ir: use levelZero flag when the lod is set to 0

2016-11-14 Thread Ilia Mirkin
On Mon, Nov 14, 2016 at 12:39 PM, Samuel Pitoiset wrote: > > > On 11/10/2016 03:42 AM, Ilia Mirkin wrote: >> >> Signed-off-by: Ilia Mirkin >> --- >> >> v1 -> v2: >> Move to handling this at SSA time. This is a lot more fragile since the >> texture arguments have been reordered already, but it

Re: [Mesa-dev] [PATCH v2] nvc0/ir: use levelZero flag when the lod is set to 0

2016-11-14 Thread Samuel Pitoiset
On 11/14/2016 06:53 PM, Ilia Mirkin wrote: On Mon, Nov 14, 2016 at 12:39 PM, Samuel Pitoiset wrote: On 11/10/2016 03:42 AM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- v1 -> v2: Move to handling this at SSA time. This is a lot more fragile since the texture arguments have been

Re: [Mesa-dev] [PATCH v2] clover: add GetKernelArgInfo (CL 1.2)

2016-11-14 Thread Francisco Jerez
Serge Martin writes: > On Sunday 30 October 2016 16:07:25 Francisco Jerez wrote: >> Serge Martin writes: >> > --- >> > >> > src/gallium/state_trackers/clover/api/kernel.cpp | 47 >> > -- >> > src/gallium/state_trackers/clover/core/kernel.cpp | 6 +++ >> > src/gallium/state

Re: [Mesa-dev] [PATCH 08/14] swr: [rasterizer core/jitter] fix alpha test bug

2016-11-14 Thread Ilia Mirkin
It seems like this still doesn't quite fix things - have a look at fbo-mrt-alphatest in piglit. I had assumed this change would do the trick, but no such luck. On Wed, Nov 9, 2016 at 10:18 PM, Tim Rowley wrote: > Alpha from render target 0 should always be used for alpha test for all > render tar

Re: [Mesa-dev] [PATCH 00/20] anv: Unify pipeline setup across gens

2016-11-14 Thread Kristian Høgsberg
On Sat, Nov 12, 2016 at 1:35 PM Jason Ekstrand wrote: > This series started off as me thinking that we should set the correct > sampler and binding table entry counts because maybe caching those things > would improve performance. Then it turned into spring cleaning. The end > result is that ge

Re: [Mesa-dev] [PATCH] i965/vec4: skip registers already marked as no_spill

2016-11-14 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] GL_ARB_copy_image in OpenSWR?

2016-11-14 Thread Ilia Mirkin
My guess is that it can just be flipped on. You can force-enable it with MESA_EXTENSION_OVERRIDE=GL_ARB_copy_image to see if it works. Cheers, -ilia On Mon, Nov 14, 2016 at 1:34 PM, A223 A223 wrote: > Is there any possibility that SWR will see GL_ARB_copy_image support > sometime soon? > > T

Re: [Mesa-dev] GL_ARB_copy_image in OpenSWR?

2016-11-14 Thread Ilia Mirkin
On Mon, Nov 14, 2016 at 1:53 PM, A223 A223 wrote: > On Mon, Nov 14, 2016 at 10:37 AM, Ilia Mirkin wrote: >> My guess is that it can just be flipped on. You can force-enable it >> with MESA_EXTENSION_OVERRIDE=GL_ARB_copy_image to see if it works. > > This does indeed get rid of the error. I'm stil

Re: [Mesa-dev] Compute shader support in LLVMpipe and/or OpenSWR?

2016-11-14 Thread Ilia Mirkin
On Mon, Nov 14, 2016 at 1:48 PM, A223 A223 wrote: > On Sun, Nov 13, 2016 at 11:58 PM, A223 A223 wrote: >> Hello, >> >> I was curious if there are any near/medium-term plans to add compute >> shader support to the following: >> >> llvmpipe? >> openswr? > > CCing Ilia Mirkin, as I feel you may know

Re: [Mesa-dev] [PATCH 08/20] anv/pipeline: Unify 3DSTATE_GS emission

2016-11-14 Thread Timothy Arceri
On Mon, 2016-11-14 at 08:46 -0800, Jason Ekstrand wrote: > > > On Sat, Nov 12, 2016 at 2:54 PM, Timothy Arceri bora.com> wrote: > > On Sat, 2016-11-12 at 13:34 -0800, Jason Ekstrand wrote: > > > > I have two questions and two suggestions below.  > > > > With the suggestions addressed and assum

Re: [Mesa-dev] [PATCH v2 6/8] gallium: Enable swr driver

2016-11-14 Thread Jose Fonseca
On 10/11/16 17:27, Kyriazis, George wrote: -Original Message- From: Emil Velikov [mailto:emil.l.veli...@gmail.com] Sent: Thursday, November 10, 2016 8:14 AM To: Kyriazis, George Cc: ML mesa-dev Subject: Re: [Mesa-dev] [PATCH v2 6/8] gallium: Enable swr driver "gallium/targets: scons

[Mesa-dev] Stable release process

2016-11-14 Thread Matt Turner
A long time ago, patch authors were tasked with cherry-picking their patches to stable branches. Today we Cc mesa-sta...@lists.freedesktop.org and Emil rebases those patches onto stable. Cc'ing the list happens even on patches sent for their first review that are ultimately rejected, creating a lot

[Mesa-dev] [PATCH v3] meta/GetTexSubImage: Account for GL_PACK_SKIP_IMAGES on compressed textures

2016-11-14 Thread Kenneth Graunke
From: Eduardo Lima Mitev This option was being ignored when packing compressed 3D and cube textures. Fixes CTS test (on gen8+): * GL45-CTS.gtf32.GL3Tests.packed_pixels.packed_pixels_pixelstore v2: Drop API checks. v3 (Ken): Just apply the existing code in more cases. --- src/mesa/drivers/commo

[Mesa-dev] [PATCH 1/3] swr: add support for upper-left fragcoord position

2016-11-14 Thread Ilia Mirkin
Fixes glsl-arb-fragment-coord-conventions. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/swr/swr_shader.cpp | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/swr_shader.cpp b/src/gallium/drivers/swr/swr_shader.cpp index f639df3..e4f9796

[Mesa-dev] [PATCH 2/3] swr: always enable adding start/base vertex to gl_VertexId

2016-11-14 Thread Ilia Mirkin
Fixes gl-3.2-basevertex-vertexid Signed-off-by: Ilia Mirkin --- src/gallium/drivers/swr/swr_state.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/swr/swr_state.cpp b/src/gallium/drivers/swr/swr_state.cpp index 2c7f3be..8038ef5 100644 --- a/src/gallium/drivers/swr/swr

[Mesa-dev] [PATCH 3/3] swr: mark color clamping as unsupported

2016-11-14 Thread Ilia Mirkin
There is no functionality in swr to clamp either vertex or frag colors. This could be added in swr_shader, at which point these could be re-enabled. Fixes arb_color_buffer_float-render Signed-off-by: Ilia Mirkin --- src/gallium/drivers/swr/swr_screen.cpp | 5 +++-- 1 file changed, 3 insertions(

[Mesa-dev] Compute shader support in LLVMpipe and/or OpenSWR?

2016-11-14 Thread A223 A223
Hello, I was curious if there are any near/medium-term plans to add compute shader support to the following: llvmpipe? openswr? Thanks! Andrew ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa

[Mesa-dev] softpipe and PIPE_CAP_MIXED_COLORBUFFER_FORMATS?

2016-11-14 Thread A223 A223
My application requires PIPE_CAP_MIXED_COLORBUFFER_FORMATS and I noticed that it is not enabled for softpipe. I hardcoded it to be turned on and did not notice any ill effects so far. Is it necessary that PIPE_CAP_MIXED_COLORBUFFER_FORMATS be disabled for softpipe?

[Mesa-dev] GL_ARB_copy_image in OpenSWR?

2016-11-14 Thread A223 A223
Is there any possibility that SWR will see GL_ARB_copy_image support sometime soon? Thanks, Andrew ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] GL_ARB_copy_image in OpenSWR?

2016-11-14 Thread A223 A223
On Mon, Nov 14, 2016 at 10:37 AM, Ilia Mirkin wrote: > My guess is that it can just be flipped on. You can force-enable it > with MESA_EXTENSION_OVERRIDE=GL_ARB_copy_image to see if it works. This does indeed get rid of the error. I'm still getting a white clear color in my OpenGL application, an

Re: [Mesa-dev] Compute shader support in LLVMpipe and/or OpenSWR?

2016-11-14 Thread A223 A223
On Sun, Nov 13, 2016 at 11:58 PM, A223 A223 wrote: > Hello, > > I was curious if there are any near/medium-term plans to add compute > shader support to the following: > > llvmpipe? > openswr? CCing Ilia Mirkin, as I feel you may know something about this for SWR... Thank you. ___

Re: [Mesa-dev] GL_ARB_copy_image in OpenSWR?

2016-11-14 Thread A223 A223
On Mon, Nov 14, 2016 at 11:10 AM, Ilia Mirkin wrote: > On Mon, Nov 14, 2016 at 1:53 PM, A223 A223 wrote: >> On Mon, Nov 14, 2016 at 10:37 AM, Ilia Mirkin wrote: >>> My guess is that it can just be flipped on. You can force-enable it >>> with MESA_EXTENSION_OVERRIDE=GL_ARB_copy_image to see if it

[Mesa-dev] [PATCH 04/14] i965: Store a clip_distance_mask field similar to cull_distance_mask.

2016-11-14 Thread Kenneth Graunke
This isn't useful for legacy GL, but will be used in Vulkan. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_compiler.h | 1 + src/mesa/drivers/dri/i965/brw_shader.cpp | 2 ++ src/mesa/drivers/dri/i965/brw_vec4.cpp| 2 ++ src/mesa/drivers/dri/i965/b

[Mesa-dev] [PATCH 02/14] compiler: Store the clip/cull distance array sizes in shader_info.

2016-11-14 Thread Kenneth Graunke
We switched from a boolean to array lengths in gl_program a while back. Signed-off-by: Kenneth Graunke --- src/compiler/glsl/glsl_to_nir.cpp | 4 ++-- src/compiler/shader_info.h| 7 +-- src/mesa/program/prog_to_nir.c| 3 ++- 3 files changed, 9 insertions(+), 5 deletions(-) diff

[Mesa-dev] [PATCH 01/14] i965: Fix GS push inputs with enhanced layouts.

2016-11-14 Thread Kenneth Graunke
We weren't taking first_component into account when handling GS push inputs. We hardly ever push GS inputs, so this was not caught by existing tests. When I started using component qualifiers for the gl_ClipDistance arrays, glsl-1.50-transform-feedback-type-and-size started catching this. Cc: "1

[Mesa-dev] [PATCH 07/14] nir: add a pass to compact clip/cull distances.

2016-11-14 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/compiler/Makefile.sources | 1 + src/compiler/nir/nir.h | 1 + .../nir/nir_lower_clip_cull_distance_arrays.c | 187 + 3 files changed, 189 insertions(+) create mode 100644 src/com

[Mesa-dev] [PATCH 09/14] anv: Set clip/cull distances fields in packets.

2016-11-14 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/intel/vulkan/anv_private.h| 18 ++ src/intel/vulkan/gen8_pipeline.c | 15 --- src/intel/vulkan/genX_pipeline_util.h | 5 + 3 files changed, 31 insertions(+), 7 deletions(-) diff --git a/src/intel/vulkan/anv_priv

[Mesa-dev] [PATCH 00/14] anv: clip/cull distance support

2016-11-14 Thread Kenneth Graunke
Hello, This series adds support for clip/cull distances in the Intel Vulkan driver. It works a little differently than how we did it in OpenGL. In GL, we have a pass that combines both float[] arrays into a single vec4[2] variable. Drivers see a vec4[2] with swizzles and writemasks. The pass is

[Mesa-dev] [PATCH 05/14] nir: Add a C wrapper for glsl_type::is_array_of_arrays().

2016-11-14 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/compiler/nir_types.cpp | 6 ++ src/compiler/nir_types.h | 1 + 2 files changed, 7 insertions(+) diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp index 5b04e18..cc90efd 100644 --- a/src/compiler/nir_types.cpp +++ b/src/compiler/nir_

[Mesa-dev] [PATCH 11/14] i965/fs: Handle compact outputs.

2016-11-14 Thread Kenneth Graunke
We need to calculate the number of vec4 slots correctly. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs.h | 2 +- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src

[Mesa-dev] [PATCH 08/14] anv: Combine ClipDistance and CullDistance arrays.

2016-11-14 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/intel/vulkan/anv_pipeline.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c index bdc2f01..ab268c6 100644 --- a/src/intel/vulkan/anv_pipeline.c +++ b/src/intel/vulkan/anv_pipeline.c @@

[Mesa-dev] [PATCH 14/14] i965: Use NIR-based clip/cull lowering for OpenGL as well.

2016-11-14 Thread Kenneth Graunke
The old approach works fine, and this approach isn't necessarily better. But it at least has the advantage that Vulkan and GL use the same approach. I originally wrote it to gain additional testing for the new paths. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_compiler.c |

[Mesa-dev] [PATCH 12/14] i965/vec4: Handle component qualifiers on non-generic varyings.

2016-11-14 Thread Kenneth Graunke
ARB_enhanced_layouts only requires component qualifier support for generic varyings, so this is all the vec4 backend knew how to handle. This patch extends the backend to handle it for all varyings, so we can use store_output intrinsics with a component set for things like clip/cull distances. We

[Mesa-dev] [PATCH 03/14] i965: Use shader_info for brw_vue_prog_data::cull_distance_mask.

2016-11-14 Thread Kenneth Graunke
This also allows us to move it from a GL specific location to a part of the compiler shared by both GL and Vulkan. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_gs.c| 4 src/mesa/drivers/dri/i965/brw_shader.cpp | 4 src/mesa/drivers/dri/i965/

[Mesa-dev] [PATCH 10/14] spirv: Silence unsupported capability warnings for Clip/CullDistance.

2016-11-14 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/compiler/spirv/spirv_to_nir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 9c5d331..5ff09c9 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compi

[Mesa-dev] [PATCH 06/14] nir: Add a "compact array" flag and IO lowering code.

2016-11-14 Thread Kenneth Graunke
Certain built-in arrays, such as gl_ClipDistance[], gl_CullDistance[], gl_TessLevelInner[], and gl_TessLevelOuter[] are specified as scalar arrays. Normal scalar arrays are sparse - each array element usually occupies a whole vec4 slot. However, most hardware assumes these built-in arrays are tig

[Mesa-dev] [PATCH 13/14] anv: Enable clip and cull distance support.

2016-11-14 Thread Kenneth Graunke
Everything is now in place, and we appear to pass the tests on Gen7+. Signed-off-by: Kenneth Graunke --- src/intel/vulkan/anv_device.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 0999fcf..2516f

[Mesa-dev] [Bug 77662] Fail to render to different faces of depth-stencil cube map

2016-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77662 Nanley Chery changed: What|Removed |Added Summary|[SNB] fail to render to |Fail to render to different

[Mesa-dev] [Bug 77662] [SNB] fail to render to different faces of depth-stencil cube map

2016-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77662 Nanley Chery changed: What|Removed |Added Version|10.1|13.0 Assignee|i...@freedesktop.

  1   2   >