[Mesa-dev] [Bug 97231] GL_DEPTH_CLAMP doesn't clamp to the far plane

2016-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97231 --- Comment #17 from Jules Blok --- (In reply to Roland Scheidegger from comment #16) > Although I really believe this to be a llvmpipe problem - if other mesa > drivers are affected by it too they probably have their own, different bugs > with i

[Mesa-dev] [Bug 97285] Darkness in Dota 2 after Patch "Make Gallium's BlitFramebuffer follow the GL 4.4 sRGB rules"

2016-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97285 --- Comment #6 from Christoph Haag --- If you are unsure whether you are affected, you are not affected. It's *very* dark and you will immediately see it on the startup logo and menu of dota 2 already. Since nobody posted a screenshot or so yet

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Release previous context's display

2016-08-11 Thread Nicolas Boichat
On Thu, Aug 11, 2016 at 12:10 AM, Nicolas Boichat wrote: > On Wed, Aug 10, 2016 at 9:44 AM, Michel Dänzer wrote: >> On 10/08/16 03:00 PM, Nicolas Boichat wrote: >>> eglMakeCurrent can also be used to change the active display. In that >>> case, we need to decrement ref_count of the previous displ

[Mesa-dev] [PATCH v2] egl/dri2: dri2_make_current: Release previous context's display

2016-08-11 Thread Nicolas Boichat
eglMakeCurrent can also be used to change the active display. In that case, we need to decrement ref_count of the previous display (possibly destroying it), and increment it on the next display. Also, old_dsurf/old_rsurf cannot be non-NULL if old_ctx is NULL, so we only need to test if old_ctx is

[Mesa-dev] [Bug 97291] Incorrect packing of struct

2016-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97291 Bug ID: 97291 Summary: Incorrect packing of struct Product: Mesa Version: 11.2 Hardware: All OS: Linux (All) Status: NEW Severity: major Priorit

[Mesa-dev] [Bug 97291] Incorrect packing of struct

2016-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97291 --- Comment #1 from Matias N. Goldberg --- Bahahuoasudh Just close it down. I thought I was on latest version but I was not. On Mesa 12.1 this issue has been fixed. Our Compute samples refuse to run, which I guess that's expected. Our Forw

Re: [Mesa-dev] [PATCH v2 00/16] radeonsi: improve handling of temporary arrays

2016-08-11 Thread Nicolai Hähnle
On 10.08.2016 23:36, Marek Olšák wrote: On Wed, Aug 10, 2016 at 9:23 PM, Nicolai Hähnle wrote: Hi, this is a respin of the series which scans the shader's TGSI to determine which channels of an array are actually written to. Most of the st/mesa changes have become unnecessary. Most of the rade

Re: [Mesa-dev] [PATCH v2 00/16] radeonsi: improve handling of temporary arrays

2016-08-11 Thread Christian König
Am 11.08.2016 um 11:29 schrieb Nicolai Hähnle: On 10.08.2016 23:36, Marek Olšák wrote: On Wed, Aug 10, 2016 at 9:23 PM, Nicolai Hähnle wrote: Hi, this is a respin of the series which scans the shader's TGSI to determine which channels of an array are actually written to. Most of the st/mesa

Re: [Mesa-dev] [PATCH v2 00/16] radeonsi: improve handling of temporary arrays

2016-08-11 Thread Nicolai Hähnle
On 11.08.2016 11:44, Christian König wrote: Am 11.08.2016 um 11:29 schrieb Nicolai Hähnle: On 10.08.2016 23:36, Marek Olšák wrote: On Wed, Aug 10, 2016 at 9:23 PM, Nicolai Hähnle wrote: Hi, this is a respin of the series which scans the shader's TGSI to determine which channels of an array a

Re: [Mesa-dev] [PATCH 2/2] aubinator: Fix the tool to correctly decode the DWords

2016-08-11 Thread Jason Ekstrand
On Wed, Aug 10, 2016 at 11:18 PM, Kenneth Graunke wrote: > On Wednesday, August 10, 2016 2:22:29 PM PDT Jason Ekstrand wrote: > > On Tue, Aug 9, 2016 at 4:52 PM, Sirisha Gandikota < > > sirisha.gandik...@intel.com> wrote: > > > > > From: Sirisha Gandikota > > > > > > Several fixes have been adde

Re: [Mesa-dev] [PATCH] st/omx/dec/h264: pass default scaling lists in raster format

2016-08-11 Thread Christian König
Leo, could you take a look, test and/or review this? If you don't have time just say so and I'm going to give it a try. Regards, Christian. Am 09.08.2016 um 11:54 schrieb Christian König: From: Indrajit Das --- src/gallium/state_trackers/omx/vid_dec_h264.c | 40 +--

Re: [Mesa-dev] [PATCH v2 00/16] radeonsi: improve handling of temporary arrays

2016-08-11 Thread Marek Olšák
On Thu, Aug 11, 2016 at 11:29 AM, Nicolai Hähnle wrote: > On 10.08.2016 23:36, Marek Olšák wrote: >> >> On Wed, Aug 10, 2016 at 9:23 PM, Nicolai Hähnle >> wrote: >>> >>> Hi, >>> >>> this is a respin of the series which scans the shader's TGSI to determine >>> which channels of an array are actual

[Mesa-dev] [Bug 97285] Darkness in Dota 2 after Patch "Make Gallium's BlitFramebuffer follow the GL 4.4 sRGB rules"

2016-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97285 --- Comment #7 from Nicolai Hähnle --- Created attachment 125699 --> https://bugs.freedesktop.org/attachment.cgi?id=125699&action=edit possible fix I seem to have trashed my Steam installation, so I cannot currently test the attached patch wit

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-11 Thread Enrico Weigelt, metux IT consult
On 10.08.2016 15:19, Nicolai Hähnle wrote: > It would be nice to have something more concrete to go on, like what are > the problems _really_ :) Actually, I haven't understood who the other users of addrlib actually are - is it just AMDs proprietary driver ? > What pain do submodules give you tha

[Mesa-dev] [Bug 96626] New account request

2016-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96626 Marek Olšák changed: What|Removed |Added QA Contact|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.

[Mesa-dev] [Bug 97285] Darkness in Dota 2 after Patch "Make Gallium's BlitFramebuffer follow the GL 4.4 sRGB rules"

2016-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97285 --- Comment #8 from network...@rkmail.ru --- The patched fixed brightness issues for me, tested in TF2, CS:Source, Left4Dead2, ETS2. OpenGL renderer string: Gallium 0.4 on AMD TAHITI (DRM 2.45.0 / 4.7.0-4.g89a2ada-default, LLVM 4.0.0) OpenGL core

Re: [Mesa-dev] shader subroutine per-context uniform support

2016-08-11 Thread Andres Gomez
FTR, I rebased this series on top of current master (minimal changes) and run a full CTS and piglit run with the i965 [gen 8]. The failing CTS now passes and I have not observed any regression nor in CTS neither in piglit. On Tue, 2016-06-07 at 15:25 +1000, Dave Airlie wrote: > So when I impleme

Re: [Mesa-dev] [PATCH 1/5] mesa/subroutines: start adding per-context subroutine index support

2016-08-11 Thread Andres Gomez
On Tue, 2016-06-07 at 16:23 +0200, Iago Toral wrote: > On Tue, 2016-06-07 at 15:25 +1000, Dave Airlie wrote: > > From: Dave Airlie > > > > One piece of ARB_shader_subroutine I ignored was the fact that it > > needs to store the subroutine index data per context and not per > > shader program. > >

[Mesa-dev] [AppVeyor] mesa master #1912 completed

2016-08-11 Thread AppVeyor
Build mesa 1912 completed Commit 06b63f1f43 by Jose Fonseca on 8/11/2016 1:11 PM: appveyor: Force Visual Studio 2013 image.\n\nIt seems the default build image is now Visual Studio 2015, and Visual\nStudio 2013 is not installed. Configure your notific

Re: [Mesa-dev] [PATCH] st/omx/dec/h264: pass default scaling lists in raster format

2016-08-11 Thread Leo Liu
On 08/11/2016 06:54 AM, Christian König wrote: Leo, could you take a look, test and/or review this? Yeah. It fixes the corruption for certain clip, and no regression found for other clips. Patch is: Tested-by: Leo Liu Regards, Leo If you don't have time just say so and I'm going to gi

Re: [Mesa-dev] [PATCH 1/5] mesa/subroutines: start adding per-context subroutine index support

2016-08-11 Thread Andres Gomez
On Tue, 2016-06-07 at 15:25 +1000, Dave Airlie wrote: [snip] > diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h > index 471d41d..a7ffbf7 100644 > --- a/src/mesa/main/mtypes.h > +++ b/src/mesa/main/mtypes.h > @@ -4307,6 +4307,15 @@ struct gl_atomic_buffer_binding > }; > > /** > + *

Re: [Mesa-dev] [PATCH 2/5] mesa: add api to write subroutine indicies to the program storage.

2016-08-11 Thread Andres Gomez
On Tue, 2016-06-07 at 15:25 +1000, Dave Airlie wrote: > From: Dave Airlie > > This writes the subroutine indicies to the program storage for > a stage. This API is intended to be used by drivers to update > the uniform storage before uploading to the hw. > > This isn't the most thread safe effor

Re: [Mesa-dev] [PATCH 3/5] i965: use new subroutine index uploader.

2016-08-11 Thread Andres Gomez
On Tue, 2016-06-07 at 15:25 +1000, Dave Airlie wrote: > From: Dave Airlie > > This plugs the subroutine index updates into the i965 backend, > where it loads constants. > > Signed-off-by: Dave Airlie > --- > src/mesa/drivers/dri/i965/brw_gs_surface_state.c | 2 ++ > src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCH 4/5] st/mesa: use the new subroutine index upload API.

2016-08-11 Thread Andres Gomez
On Tue, 2016-06-07 at 15:25 +1000, Dave Airlie wrote: > From: Dave Airlie > > This plugs the new API into the gallium state tracker. > > Signed-off-by: Dave Airlie > --- > src/mesa/state_tracker/st_atom_constbuf.c | 19 +++ > src/mesa/state_tracker/st_cb_bitmap.c | 2 +- >

Re: [Mesa-dev] [PATCH 5/5] mesa/subroutines: drop the old subroutine index uploads.

2016-08-11 Thread Andres Gomez
On Tue, 2016-06-07 at 15:25 +1000, Dave Airlie wrote: > From: Dave Airlie > > We used to upload the indices when they changed, now we rely > on the drivers calling the correct hook to have the values > updated from the context storage. > > Signed-off-by: Dave Airlie > --- > src/mesa/main/shade

[Mesa-dev] [Bug 97291] Incorrect packing of struct

2016-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97291 Brian Paul changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 96626] New account request

2016-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96626 Brian Paul changed: What|Removed |Added Product|Mesa|freedesktop.org Version|git

[Mesa-dev] [PATCH] st/vdpau: change the order in which filters are applied

2016-08-11 Thread Nayan Deshmukh
Apply the median and matrix filter before the compostioning we apply the deinterlacing first to avoid the extra overhead in processing the past and the future surfaces in deinterlacing. Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/mixer.c | 23 +-- 1 fil

Re: [Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v3

2016-08-11 Thread Nayan Deshmukh
Hi Christian, I have a sent a patch which deals with the order in which filter are applied. I will send a patch probably by tomorrow which we use temporary surfaces. Regards, Nayan. On Wed, Aug 10, 2016 at 12:49 AM, Christian König wrote: > Am 09.08.2016 um 19:21 schrieb Nayan Deshmukh: > > Hi

Re: [Mesa-dev] [PATCH] st/vdpau: change the order in which filters are applied

2016-08-11 Thread Christian König
Am 11.08.2016 um 16:27 schrieb Nayan Deshmukh: Apply the median and matrix filter before the compostioning we apply the deinterlacing first to avoid the extra overhead in processing the past and the future surfaces in deinterlacing. Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers

[Mesa-dev] [Bug 97291] Incorrect packing of struct

2016-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97291 --- Comment #3 from Ilia Mirkin --- (In reply to Matias N. Goldberg from comment #1) > Bahahuoasudh > > Just close it down. > I thought I was on latest version but I was not. > > On Mesa 12.1 this issue has been fixed. > > Our Compute samp

Re: [Mesa-dev] Question about tesselation shader out varyings and transform feedback

2016-08-11 Thread Alejandro Piñeiro
On 05/08/16 12:20, Alejandro Piñeiro wrote: > On 05/08/16 01:53, Timothy Arceri wrote: >> On Thu, 2016-08-04 at 18:36 +0200, Alejandro Piñeiro wrote: >>> Hi, >>> >>> these days I have been trying to fix a test that uses transform >>> feedback >>> on the out varying of a tessellation shader. The rel

[Mesa-dev] [PATCH] st/vdpau: change the order in which filters are applied

2016-08-11 Thread Nayan Deshmukh
Apply the median and matrix filter before the compostioning we apply the deinterlacing first to avoid the extra overhead in processing the past and the future surfaces in deinterlacing. Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/mixer.c | 25 +++-- 1 f

[Mesa-dev] [Bug 97285] Darkness in Dota 2 after Patch "Make Gallium's BlitFramebuffer follow the GL 4.4 sRGB rules"

2016-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97285 --- Comment #9 from Matthew Dawson --- (In reply to Kenneth Graunke from comment #3) > It might also be worth testing with and without multisampling... Oh, I tested this without the patch as well in TF2, and I saw no change enabling or disabling

Re: [Mesa-dev] [PATCH 2/5] mesa: add api to write subroutine indicies to the program storage.

2016-08-11 Thread Alejandro Piñeiro
On 11/08/16 15:56, Andres Gomez wrote: > On Tue, 2016-06-07 at 15:25 +1000, Dave Airlie wrote: >> From: Dave Airlie >> >> This writes the subroutine indicies to the program storage for >> a stage. This API is intended to be used by drivers to update >> the uniform storage before uploading to the h

[Mesa-dev] [PATCH 2/5] radeonsi: eliminate PS OUT[1] if dual src blending is off and CB1 is not bound

2016-08-11 Thread Marek Olšák
From: Marek Olšák All VP DX9 ports benefit from this. --- src/gallium/drivers/radeonsi/si_state.c | 11 --- src/gallium/drivers/radeonsi/si_state_shaders.c | 7 +++ 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src

[Mesa-dev] [PATCH 1/5] gallium/radeon: use unflushed fences for PIPE_QUERY_GPU_FINISHED

2016-08-11 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_query.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_query.c b/src/gallium/drivers/radeon/r600_query.c index 592cec1..5825e8b 100644 --- a/src/gallium/drivers/radeon/r600_query.c +++

[Mesa-dev] [PATCH 4/5] radeonsi: simplify CB_TARGET_MASK logic

2016-08-11 Thread Marek Olšák
From: Marek Olšák we can now rely on CB_COLORn_INFO to disable empty slots. --- src/gallium/drivers/radeonsi/si_state.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c in

Re: [Mesa-dev] [PATCH 2/2] nir/algebraic: Optimize common array indexing sequence

2016-08-11 Thread Ian Romanick
ping On 07/19/2016 10:37 PM, Ian Romanick wrote: > From: Ian Romanick > > Some shaders include code that looks like: > >uniform int i; >uniform vec4 bones[...]; > >foo(bones[i * 3], bones[i * 3 + 1], bones[i * 3 + 2]); > > CSE would do some work on this: > >x = i * 3 >foo

[Mesa-dev] [PATCH 3/5] radeonsi: don't set CB_COLOR1_INFO for dual src blending

2016-08-11 Thread Marek Olšák
From: Marek Olšák Vulkan doesn't do this. The reason may be that CB_COLOR1_INFO.SOURCE_FORMAT from NI was moved to SPI_SHADER_COL_FORMAT for SI. I asked CB guys about this 2 days ago and they still haven't replied. --- src/gallium/drivers/radeonsi/si_state.c | 7 --- 1 file changed, 7 delet

[Mesa-dev] [PATCH 5/5] radeonsi: use current context for DCC feedback-loop decompress, fixes Elemental

2016-08-11 Thread Marek Olšák
From: Marek Olšák This is just a workaround. The problem is described in the code. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96541 --- src/gallium/drivers/radeon/r600_pipe_common.h | 2 +- src/gallium/drivers/radeon/r600_texture.c | 35 ++- src/gallium/

Re: [Mesa-dev] [PATCH 2/2] aubinator: Fix the tool to correctly decode the DWords

2016-08-11 Thread Kristian Høgsberg
On Wed, Aug 10, 2016 at 11:18 PM, Kenneth Graunke wrote: > On Wednesday, August 10, 2016 2:22:29 PM PDT Jason Ekstrand wrote: >> On Tue, Aug 9, 2016 at 4:52 PM, Sirisha Gandikota < >> sirisha.gandik...@intel.com> wrote: >> >> > From: Sirisha Gandikota >> > >> > Several fixes have been added as pa

[Mesa-dev] [Bug 97285] Darkness in Dota 2 after Patch "Make Gallium's BlitFramebuffer follow the GL 4.4 sRGB rules"

2016-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97285 --- Comment #10 from Edmondo Tommasina --- Hi Nicolai Your patch fixes the darkness issue for me. Tested-by: Edmondo Tommasina Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

Re: [Mesa-dev] [PATCH] glsl: look for frag data bindings with [0] tacked onto the end for arrays

2016-08-11 Thread Ian Romanick
This seems okay... let me run it through our CI first. I should have results later today. I'm going to step out for a bit. On 08/09/2016 05:43 PM, Ilia Mirkin wrote: > ping? do we want this? should i drop it? > > On Wed, Jul 13, 2016 at 3:37 PM, Ilia Mirkin wrote: >> Thanks for confirming, Cor

[Mesa-dev] [Bug 97285] Darkness in Dota 2 after Patch "Make Gallium's BlitFramebuffer follow the GL 4.4 sRGB rules"

2016-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97285 Vladimir Usikov changed: What|Removed |Added CC||granti...@gmail.com -- You are receiv

[Mesa-dev] [PATCH 2/3] mesa: Add _mesa_enum_to_string2()

2016-08-11 Thread Chad Versace
The new function is identical to _mesa_enum_to_string(), except that it returns false if the given number is an invalid enum. Bundling validation and lookup into a single function allows us to do both with a single lookup into the enum table. Cc: Haixia Shi Change-Id: I83d9a6e53223d1a971cf8dc22cb

[Mesa-dev] [PATCH 0/3] mesa: Fix a dEQP test

2016-08-11 Thread Chad Versace
Fixes test dEQP-GLES3.functional.negative_api.buffer.framebuffer_texture2d. I tested this patch for regressions on Skylake with: % ./deqp-gles3 --deqp-case= 'dEQP-GLES3.functional.negative_api.*' % ./deqp-gles3 --deqp-case='dEQP-GLES3.functional.fbo.color.texcube.*' This patch series lives at

[Mesa-dev] [PATCH 3/3] mesa: Fix glFramebufferTexture* error codes

2016-08-11 Thread Chad Versace
If check_textarget() determined that textarget was incorrect, it emitted GL_INVALID_OPERATION. This is the correct behavior when textarget is a valid GLenum but an invalid parameter to the current variant of glFramebufferTexture*(). However, when textarget is not a GLenum at all, then the GL spec

[Mesa-dev] [PATCH 1/3] mesa: Document that _mesa_enum_to_string() returns non-null

2016-08-11 Thread Chad Versace
It always returns non-null, even if the number is an invalid enum. Cc: Haixia Shi Change-Id: I26e8843c96130be972e66f48a49e362442e1bf97 --- src/mapi/glapi/gen/gl_enums.py | 4 1 file changed, 4 insertions(+) diff --git a/src/mapi/glapi/gen/gl_enums.py b/src/mapi/glapi/gen/gl_enums.py index

Re: [Mesa-dev] [PATCH 1/3] mesa: Document that _mesa_enum_to_string() returns non-null

2016-08-11 Thread Ian Romanick
On 08/11/2016 10:11 AM, Chad Versace wrote: > It always returns non-null, even if the number is an invalid enum. > > Cc: Haixia Shi > Change-Id: I26e8843c96130be972e66f48a49e362442e1bf97 > --- > src/mapi/glapi/gen/gl_enums.py | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/mapi

[Mesa-dev] [PATCH 1/2] anv: pipeline: gen7: fix assert in debug mode

2016-08-11 Thread Lionel Landwerlin
SampleMask is only 8bits long on gen7. Signed-off-by: Lionel Landwerlin Cc: Jason Ekstrand --- src/intel/vulkan/genX_pipeline_util.h | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/vulkan/genX_pipeline_util.h b/src/intel/vulkan/genX_pipeline_util.h index 64b89cd..d56eeb8 1006

[Mesa-dev] [PATCH 2/2] anv: GetDeviceImageFormatProperties: fix TRANSFER formats

2016-08-11 Thread Lionel Landwerlin
We let the user believe we support some transfer formats which we don't. This can lead to crashes when actually trying to use those formats for example on dEQP-VK.api.copy_and_blit.image_to_image.* tests. Let all formats we can render to or sample from as meta implements transfers using attachment

Re: [Mesa-dev] [PATCH 3/3] mesa: Fix glFramebufferTexture* error codes

2016-08-11 Thread Ian Romanick
On 08/11/2016 10:11 AM, Chad Versace wrote: > If check_textarget() determined that textarget was incorrect, it emitted > GL_INVALID_OPERATION. This is the correct behavior when textarget is > a valid GLenum but an invalid parameter to the current variant of > glFramebufferTexture*(). > > However,

Re: [Mesa-dev] [PATCH 1/3] mesa: Document that _mesa_enum_to_string() returns non-null

2016-08-11 Thread Ian Romanick
On 08/11/2016 10:22 AM, Ian Romanick wrote: > On 08/11/2016 10:11 AM, Chad Versace wrote: >> It always returns non-null, even if the number is an invalid enum. >> >> Cc: Haixia Shi >> Change-Id: I26e8843c96130be972e66f48a49e362442e1bf97 >> --- >> src/mapi/glapi/gen/gl_enums.py | 4 >> 1 file

Re: [Mesa-dev] [PATCH 3/3] mesa: Fix glFramebufferTexture* error codes

2016-08-11 Thread Ilia Mirkin
On Thu, Aug 11, 2016 at 1:11 PM, Chad Versace wrote: > If check_textarget() determined that textarget was incorrect, it emitted > GL_INVALID_OPERATION. This is the correct behavior when textarget is > a valid GLenum but an invalid parameter to the current variant of > glFramebufferTexture*(). > >

Re: [Mesa-dev] [PATCH 2/3] mesa: Add _mesa_enum_to_string2()

2016-08-11 Thread Ian Romanick
On 08/11/2016 10:11 AM, Chad Versace wrote: > The new function is identical to _mesa_enum_to_string(), except that it > returns false if the given number is an invalid enum. Bundling > validation and lookup into a single function allows us to do both with > a single lookup into the enum table. > >

Re: [Mesa-dev] [PATCH 1/3] mesa: Document that _mesa_enum_to_string() returns non-null

2016-08-11 Thread Chad Versace
On 08/11/2016 10:30 AM, Ian Romanick wrote: On 08/11/2016 10:22 AM, Ian Romanick wrote: On 08/11/2016 10:11 AM, Chad Versace wrote: It always returns non-null, even if the number is an invalid enum. Cc: Haixia Shi Change-Id: I26e8843c96130be972e66f48a49e362442e1bf97 --- src/mapi/glapi/gen/gl

Re: [Mesa-dev] [PATCH] glsl: look for frag data bindings with [0] tacked onto the end for arrays

2016-08-11 Thread Ian Romanick
Or not. :( The patch no longer applies, and I wasn't able to trivially make it apply. I suspect one of Timothy's recent patches is to blame. On 08/11/2016 10:06 AM, Ian Romanick wrote: > This seems okay... let me run it through our CI first. I should have > results later today. I'm going to st

[Mesa-dev] [PATCH] anv: Use macro to avoid code duplication for sample positions

2016-08-11 Thread Anuj Phogat
Suggested-by: Jason Ekstrand Signed-off-by: Anuj Phogat --- src/intel/vulkan/genX_multisample.h | 95 +++ src/intel/vulkan/genX_pipeline_util.h | 35 ++--- src/intel/vulkan/genX_state.c | 68 +++-- 3 files changed, 106 inserti

[Mesa-dev] [PATCH] i965: Change 8x multisample positions

2016-08-11 Thread Anuj Phogat
There are no standard sample positions defined in OpenGL and OpenGL ES specs. Implementations have the freedom to pick the positions which give plausible results. But the Vulkan 1.0 spec does define standard sample positions for different sample counts. Defined positions in Vulkan for all the sampl

Re: [Mesa-dev] [PATCH 2/3] mesa: Add _mesa_enum_to_string2()

2016-08-11 Thread Chad Versace
On 08/11/2016 10:24 AM, Ian Romanick wrote: On 08/11/2016 10:11 AM, Chad Versace wrote: The new function is identical to _mesa_enum_to_string(), except that it returns false if the given number is an invalid enum. Bundling validation and lookup into a single function allows us to do both with a

Re: [Mesa-dev] [PATCH] glsl: look for frag data bindings with [0] tacked onto the end for arrays

2016-08-11 Thread Ilia Mirkin
I'll rebase and feed it through Jenkins (I was given a branch of late). On Thu, Aug 11, 2016 at 1:38 PM, Ian Romanick wrote: > Or not. :( The patch no longer applies, and I wasn't able to trivially > make it apply. I suspect one of Timothy's recent patches is to blame. > > On 08/11/2016 10:06 A

Re: [Mesa-dev] [PATCH] anv/device: Add limits for InterpolationOffset

2016-08-11 Thread Anuj Phogat
On Fri, Jul 29, 2016 at 2:30 PM, Anuj Phogat wrote: > > > On Fri, Jul 29, 2016 at 12:32 PM, Anuj Phogat wrote: >> >> >> >> On Thu, Jul 28, 2016 at 6:31 PM, Jason Ekstrand >> wrote: >>> >>> On Jul 28, 2016 7:37 PM, "Anuj Phogat" wrote: >>> > >>> > Fixes the vulkan cts regression in test >>> > dE

Re: [Mesa-dev] [PATCH] i965: Change 8x multisample positions

2016-08-11 Thread Jason Ekstrand
On Thu, Aug 11, 2016 at 10:41 AM, Anuj Phogat wrote: > There are no standard sample positions defined in OpenGL and OpenGL > ES specs. Implementations have the freedom to pick the positions > which give plausible results. But the Vulkan 1.0 spec does define > standard sample positions for differe

Re: [Mesa-dev] [PATCH 3/3] mesa: Fix glFramebufferTexture* error codes

2016-08-11 Thread Chad Versace
On 08/11/2016 10:22 AM, Ilia Mirkin wrote: On Thu, Aug 11, 2016 at 1:11 PM, Chad Versace wrote: If check_textarget() determined that textarget was incorrect, it emitted GL_INVALID_OPERATION. This is the correct behavior when textarget is a valid GLenum but an invalid parameter to the current v

Re: [Mesa-dev] [PATCH 2/3] mesa: Add _mesa_enum_to_string2()

2016-08-11 Thread Matt Turner
On Thu, Aug 11, 2016 at 10:42 AM, Chad Versace wrote: > On 08/11/2016 10:24 AM, Ian Romanick wrote: >> >> On 08/11/2016 10:11 AM, Chad Versace wrote: >>> >>> The new function is identical to _mesa_enum_to_string(), except that it >>> returns false if the given number is an invalid enum. Bundling >

Re: [Mesa-dev] [PATCH 1/5] i965/surface_formats: Don't advertise 8 or 16-bit RGB formats

2016-08-11 Thread Nanley Chery
On Tue, Jul 26, 2016 at 10:04:22PM -0700, Jason Ekstrand wrote: > We have implicitly been not advertising these formats since we had them > turned off in the format capabilities table. We are about to update that > table and this prevents a change in behavior. The only change in behavior > create

[Mesa-dev] [PATCH 2/2] mesa: Fix glFramebufferTexture* error codes (v2)

2016-08-11 Thread Chad Versace
If check_textarget() determined that textarget was incorrect, it emitted GL_INVALID_OPERATION. This is the correct behavior when target and textarget are mismatched but textarget is a valid textarget enum. When textarget is not a valid textarget enum, the GL spec requires that GL_INVALID_ENUM be

[Mesa-dev] [PATCH 0/3] mesa: Fix a dEQP test (v2)

2016-08-11 Thread Chad Versace
Fixes test dEQP-GLES3.functional.negative_api.buffer.framebuffer_texture2d. I tested this patch for regressions on Skylake with: % ./deqp-gles3 --deqp-case= 'dEQP-GLES3.functional.negative_api.*' % ./deqp-gles3 --deqp-case='dEQP-GLES3.functional.fbo.color.texcube.*' This patch series lives at

[Mesa-dev] [PATCH 1/2] mesa: Document that _mesa_enum_to_string() returns non-null

2016-08-11 Thread Chad Versace
It always returns non-null, even if the number is an invalid enum. Cc: Haixia Shi Reviewed-by: Ian Romanick Change-Id: I26e8843c96130be972e66f48a49e362442e1bf97 --- src/mapi/glapi/gen/gl_enums.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_enu

Re: [Mesa-dev] [PATCH 3/5] isl/formats: Update the table with more samplable formats

2016-08-11 Thread Nanley Chery
On Tue, Jul 26, 2016 at 10:04:24PM -0700, Jason Ekstrand wrote: > There were a lot of formats where support was added on Haswell or later but > we never updated the format table. > --- > src/intel/isl/isl_format.c | 30 +++--- > 1 file changed, 15 insertions(+), 15 deletion

Re: [Mesa-dev] [PATCH] i965: Change 8x multisample positions

2016-08-11 Thread Anuj Phogat
On Thu, Aug 11, 2016 at 10:53 AM, Jason Ekstrand wrote: > > > On Thu, Aug 11, 2016 at 10:41 AM, Anuj Phogat wrote: >> >> There are no standard sample positions defined in OpenGL and OpenGL >> ES specs. Implementations have the freedom to pick the positions >> which give plausible results. But the

[Mesa-dev] [Bug 97285] Darkness in Dota 2 after Patch "Make Gallium's BlitFramebuffer follow the GL 4.4 sRGB rules"

2016-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97285 --- Comment #11 from Marek Olšák --- The patch looks good to me. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 2/2] nir/algebraic: Optimize common array indexing sequence

2016-08-11 Thread Thomas Helland
2016-08-11 18:19 GMT+02:00 Ian Romanick : > ping > > On 07/19/2016 10:37 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> Some shaders include code that looks like: >> >>uniform int i; >>uniform vec4 bones[...]; >> >>foo(bones[i * 3], bones[i * 3 + 1], bones[i * 3 + 2]); >> >> CSE w

Re: [Mesa-dev] [PATCH 3/5] isl/formats: Update the table with more samplable formats

2016-08-11 Thread Nanley Chery
On Tue, Jul 26, 2016 at 10:04:24PM -0700, Jason Ekstrand wrote: > There were a lot of formats where support was added on Haswell or later but > we never updated the format table. > --- > src/intel/isl/isl_format.c | 30 +++--- > 1 file changed, 15 insertions(+), 15 deletion

[Mesa-dev] [PATCH V2 2/2] i965: Change 8X MSAA sample mapping

2016-08-11 Thread Anuj Phogat
This is required following the change in 8X sample positions. Fixes the recently modified multisample-scaled-blit piglit tests. Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 10 +- src/mesa/drivers/dri/i965/gen6_multisample_state.c | 2 +- 2 files c

[Mesa-dev] [PATCH V2 1/2] i965: Change 8x multisample positions

2016-08-11 Thread Anuj Phogat
There are no standard sample positions defined in OpenGL and OpenGL ES specs. Implementations have the freedom to pick the positions which give plausible results. But the Vulkan 1.0 spec does define standard sample positions for different sample counts. Defined positions in Vulkan for all the sampl

[Mesa-dev] [Bug 97291] Incorrect packing of struct

2016-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97291 --- Comment #4 from Matias N. Goldberg --- OK I'm fully re-powered and thinking straight now: I've built Mesa from scratch. Tried commits git-edfc17a (current head of branch 12.0) and commit 17f1c49b9ad05af4f6482f6fa950e5dcc1a779d1 (current head

Re: [Mesa-dev] [PATCH 0/5] isl: Update the format table and add asserts

2016-08-11 Thread Nanley Chery
On Tue, Jul 26, 2016 at 10:04:21PM -0700, Jason Ekstrand wrote: > The real objective of this series is patch 5 which prevents us from > accidentally creating a surface state with a format unsupported by the > hardware. This turns some of the new Vulkan CTS tests from a hang into an > informative c

[Mesa-dev] [PATCH 1/4] gallium/radeon: set SHADER_RW_BUFFER priority for streamout buffers

2016-08-11 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_streamout.c | 4 ++-- src/gallium/drivers/radeonsi/si_descriptors.c | 6 -- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_streamout.c b/src/gallium/drivers/radeon/r600_streamout.c index

[Mesa-dev] [PATCH 4/4] gallium/radeon: assign the highest priority to scratch; make rings second

2016-08-11 Thread Marek Olšák
From: Marek Olšák just FYI, the kernel receives priority/4 --- src/gallium/drivers/radeon/radeon_winsys.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_winsys.h b/src/gallium/drivers/radeon/radeon_winsys.h index 8a98ebf..c65b9a4 1006

[Mesa-dev] [PATCH 2/4] gallium/radeon: mark shader rings as highest-priority buffers

2016-08-11 Thread Marek Olšák
From: Marek Olšák and rename the enum --- src/gallium/drivers/r600/evergreen_state.c| 4 ++-- src/gallium/drivers/r600/r600_state.c | 4 ++-- src/gallium/drivers/radeon/radeon_winsys.h| 2 +- src/gallium/drivers/radeonsi/si_debug.c | 2 +- src/gallium/drivers/radeonsi/si_de

[Mesa-dev] [PATCH 3/4] gallium/winsys: re-number winsys priority flags

2016-08-11 Thread Marek Olšák
From: Marek Olšák free 60..63, move CP_DMA up --- src/gallium/drivers/radeon/radeon_winsys.h | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_winsys.h b/src/gallium/drivers/radeon/radeon_winsys.h index e4d669f.

[Mesa-dev] [Bug 97307] glsl/glcpp/tests/glcpp-test regression

2016-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97307 Bug ID: 97307 Summary: glsl/glcpp/tests/glcpp-test regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: All Status: NEW Keywords: bisected,

[Mesa-dev] [PATCH 3/3] glsl: Fix invariant matching in GLSL 4.30 and GLSL ES 1.00.

2016-08-11 Thread Kenneth Graunke
Old languages (GLSL <= 4.20 and GLSL ES 1.00) require "invariant" to be specified on both inputs and outputs, and match when linking. New languages only allow outputs to be qualified as "invariant" and remove the "invariant must match" restriction when linking varyings (because no input can have t

[Mesa-dev] [PATCH 2/3] glsl: Tidy stream handling in merge_qualifier().

2016-08-11 Thread Kenneth Graunke
The previous commit fixed xfb_buffer handling, which was largely copy and pasted from the stream handling. The difference is that stream was set in input_layout_mask, so it worked. However, that's totally rubbish: stream is only valid on geometry shader outputs. Presumably this was to hack aroun

[Mesa-dev] [PATCH 1/3] glsl: Fix inout qualifier handling in GLSL 4.40.

2016-08-11 Thread Kenneth Graunke
inout variables have q.in and q.out set. We were trying to set xfb_buffer = 1 for shader output variables (and inadvertantly setting it on inout parameters, too). But input_layout_mask doesn't have xfb_buffer set, so it was seen as in invalid input qualifier. This meant that all 'inout' paramete

[Mesa-dev] [PATCH 02/32] genxml/gen6: Add a Surface Base Address field to HIER_DEPTH_BUFFER

2016-08-11 Thread Jason Ekstrand
--- src/intel/genxml/gen6.xml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml index 0f2be24..6ece749 100644 --- a/src/intel/genxml/gen6.xml +++ b/src/intel/genxml/gen6.xml @@ -1007,14 +1007,15 @@ - +

[Mesa-dev] [PATCH 01/32] genxml/gen6: Add uint MOCS fields for most things

2016-08-11 Thread Jason Ekstrand
--- src/intel/genxml/gen6.xml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml index cf94efc..0f2be24 100644 --- a/src/intel/genxml/gen6.xml +++ b/src/intel/genxml/gen6.xml @@ -1883,20 +1883,26 @@ + +

[Mesa-dev] [PATCH 03/32] genxml/gen6: Fix the length of 3DSTATE_WM

2016-08-11 Thread Jason Ekstrand
--- src/intel/genxml/gen6.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml index 6ece749..1be0ede 100644 --- a/src/intel/genxml/gen6.xml +++ b/src/intel/genxml/gen6.xml @@ -1365,12 +1365,12 @@ - +

[Mesa-dev] [PATCH 00/32] i965/blorp: Use genxml for state setup

2016-08-11 Thread Jason Ekstrand
This patch series is the next on the way towards generalizing blorp for usin in Vulkan. At this point, I'd say the project is about 80% complete. This series only applies on top of the last two blorp isl series which are still undergoing review. Patches 1-11 make minor genxml improvements. Some

[Mesa-dev] [PATCH 05/32] genxml/gen6: Make "Depth Clear Value" a uint

2016-08-11 Thread Jason Ekstrand
The actual data storred is in float, UNORM24, or UNORM16 depending on the actual depth format. --- src/intel/genxml/gen6.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml index ae317a13..06b441b 100644 --- a/src/intel/genx

[Mesa-dev] [PATCH 06/32] genxml: Add a uint MOCS field to DEPTH_BUFFER packets

2016-08-11 Thread Jason Ekstrand
This is easier than dealing with structs all the time --- src/intel/genxml/gen6.xml | 2 ++ src/intel/genxml/gen7.xml | 2 ++ src/intel/genxml/gen75.xml | 2 ++ src/intel/genxml/gen8.xml | 2 ++ src/intel/genxml/gen9.xml | 2 ++ 5 files changed, 10 insertions(+) diff --git a/src/intel/genxml/

[Mesa-dev] [PATCH 04/32] genxml/gen6: Add the 3D_Prim_Topo_Type enum

2016-08-11 Thread Jason Ekstrand
--- src/intel/genxml/gen6.xml | 24 1 file changed, 24 insertions(+) diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml index 1be0ede..ae317a13 100644 --- a/src/intel/genxml/gen6.xml +++ b/src/intel/genxml/gen6.xml @@ -447,6 +447,30 @@ + +

[Mesa-dev] [PATCH 11/32] genxml/gen9: Make 3DSTATE_SBE::AttributeActiveComponentFormat an array

2016-08-11 Thread Jason Ekstrand
--- src/intel/genxml/gen9.xml | 35 +++- src/intel/vulkan/genX_pipeline_util.h | 38 +++ 2 files changed, 6 insertions(+), 67 deletions(-) diff --git a/src/intel/genxml/gen9.xml b/src/intel/genxml/gen9.xml index 51a2420..547d

[Mesa-dev] [PATCH 21/32] i965/blorp/gen6-7: Move multisample setup to right after samplers

2016-08-11 Thread Jason Ekstrand
This mimics gen8 blorp --- src/mesa/drivers/dri/i965/gen6_blorp.c | 9 + src/mesa/drivers/dri/i965/gen7_blorp.c | 10 +- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_blorp.c b/src/mesa/drivers/dri/i965/gen6_blorp.c index b252d78..

[Mesa-dev] [PATCH 07/32] genxml/gen6: Make SAMPLER_STATE look a bit more like gen7

2016-08-11 Thread Jason Ekstrand
--- src/intel/genxml/gen6.xml | 45 ++--- 1 file changed, 26 insertions(+), 19 deletions(-) diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml index 3fe7377..2499b46 100644 --- a/src/intel/genxml/gen6.xml +++ b/src/intel/genxml/gen6.xml @@ -

[Mesa-dev] [PATCH 08/32] genxml: Make VERTEX_ELEMENT_STATE::Valid a bool

2016-08-11 Thread Jason Ekstrand
--- src/intel/genxml/gen6.xml | 2 +- src/intel/genxml/gen7.xml | 2 +- src/intel/genxml/gen75.xml | 2 +- src/intel/genxml/gen8.xml | 2 +- src/intel/genxml/gen9.xml | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml in

[Mesa-dev] [PATCH 09/32] genxml: Make a couple of VERTEX_BUFFER_STATE fields boolean

2016-08-11 Thread Jason Ekstrand
--- src/intel/genxml/gen6.xml | 2 +- src/intel/genxml/gen7.xml | 4 ++-- src/intel/genxml/gen75.xml | 4 ++-- src/intel/genxml/gen8.xml | 2 +- src/intel/genxml/gen9.xml | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xm

[Mesa-dev] [PATCH 17/32] i965/blorp: Don't clear an empty region

2016-08-11 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_blorp.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index f12c1f8..ccc7136 100644 --- a/src/mesa/drivers/dri/i965/brw_blorp.c +++ b/src/mesa/drivers/dri/i965/brw_blorp.c @@

  1   2   >