On 08/18/2015 12:30 AM, Timothy Arceri wrote:
On Mon, 2015-08-17 at 08:12 +0300, Tapani Pälli wrote:
On 08/14/2015 04:01 PM, Timothy Arceri wrote:
On Fri, 2015-08-14 at 08:55 +0300, Tapani Pälli wrote:
On 08/13/2015 11:54 AM, Timothy Arceri wrote:
I've sent a couple of follow-up patches I
Patch refactors existing parameters check to first check common enums
between desktop GL and GLES 3.1 and modifies get_tex_level_parameter_image
to be compatible with enums specified in 3.1.
Signed-off-by: Tapani Pälli
---
src/mesa/main/texparam.c | 34 +++---
1 file
On Tue, 2015-08-18 at 10:16 +0300, Tapani Pälli wrote:
>
> On 08/18/2015 12:30 AM, Timothy Arceri wrote:
> > On Mon, 2015-08-17 at 08:12 +0300, Tapani Pälli wrote:
> > >
> > > On 08/14/2015 04:01 PM, Timothy Arceri wrote:
> > > > On Fri, 2015-08-14 at 08:55 +0300, Tapani Pälli wrote:
> > > > >
>
On 08/18/2015 11:11 AM, Timothy Arceri wrote:
On Tue, 2015-08-18 at 10:16 +0300, Tapani Pälli wrote:
On 08/18/2015 12:30 AM, Timothy Arceri wrote:
On Mon, 2015-08-17 at 08:12 +0300, Tapani Pälli wrote:
On 08/14/2015 04:01 PM, Timothy Arceri wrote:
On Fri, 2015-08-14 at 08:55 +0300, Tapani
On Monday, August 17, 2015 09:53:20 PM Jason Ekstrand wrote:
> On Aug 17, 2015 4:08 PM, "Kenneth Graunke" wrote:
> >
> > Previously, ATTR was indexed by VERT_ATTRIB_* slots; at the end of
> > compilation, assign_vs_urb_setup() translated those into GRF units,
> > and converted ATTR to HW_REGs.
> >
On 18.08.2015 01:51, Grazvydas Ignotas wrote:
Recent commits introduced new unused variable warnings, fix them.
Reviewed-by: Christian König
Do you have commit access?
Regards,
Christian.
---
src/gallium/drivers/radeon/radeon_uvd.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(
Tapani Pälli writes:
> On 08/17/2015 07:45 PM, Francisco Jerez wrote:
>> The ES31-CTS.shader_image_load_store.basic-api-bind conformance test
>> expects the whole image unit state to be reset when the bound texture
>> object is deleted. The ARB_shader_image_load_store extension is
>> rather vagu
Ian Romanick writes:
> On 08/17/2015 09:45 AM, Francisco Jerez wrote:
>> There is no GL_R8 image format in GLES, according to the state table
>> 20.32 of the GLES 3.1 spec the default value should be GL_R32UI.
>
> Was any conformance test affected by this change?
Yeah, ES31-CTS.shader_image_load
Tapani Pälli writes:
> I find it strange that 7.10 Images does not mention this difference to
> desktop GL (when mentioning that locations can be queried with
> GetUniformLocation), one can only learn this by checking that all
> references to 'image' have been removed from the Uniform* calls.
Connor Abbott writes:
> On Mon, Aug 17, 2015 at 2:41 AM, Francisco Jerez
> wrote:
>> Connor Abbott writes:
>>
>>> On Mon, Aug 17, 2015 at 12:09 AM, Pohjolainen, Topi
>>> wrote:
On Fri, Aug 14, 2015 at 03:30:18PM -0700, Connor Abbott wrote:
> In some cases, we need to emit ALU instruc
patches 17,18,19,20:
Reviewed-by: Tapani Pälli
On 08/17/2015 07:45 PM, Francisco Jerez wrote:
These seem to have been re-added at some point during the
ARB_tessellation_shader implementation work. AFAICT the second
(correct) definition of each constant would have had no effect because
the symb
https://bugs.freedesktop.org/show_bug.cgi?id=91673
--- Comment #2 from Tapani Pälli ---
With a bit of testing it seems things work fine if glTexStorage2D call is moved
to happen right after first glBindTexture call (this is also how is being done
in some Piglit tests). Maybe this will help you ge
On Tue, Aug 18, 2015 at 11:30 AM, Christian König
wrote:
> On 18.08.2015 01:51, Grazvydas Ignotas wrote:
>>
>> Recent commits introduced new unused variable warnings, fix them.
>
>
> Reviewed-by: Christian König
>
> Do you have commit access?
No, it's only my 5th mesa patch :)
Gražvydas
__
On 18.08.2015 14:09, Grazvydas Ignotas wrote:
On Tue, Aug 18, 2015 at 11:30 AM, Christian König
wrote:
On 18.08.2015 01:51, Grazvydas Ignotas wrote:
Recent commits introduced new unused variable warnings, fix them.
Reviewed-by: Christian König
Do you have commit access?
No, it's only my 5
This support should be removed in favor of something that actually works
in all the weird cases. However this is simple and is enough to allow
Bioshock Infinite to render properly on nvc0.
Since the functionality is not implemented correctly, the extension will
not appear in the extension string a
The more specific GLES constrains should be checked after the general
validation performed by _mesa_error_check_format_and_type(). This is also
for consistency with the error checks order of glTexSubImage ops.
Fixes 1 dEQP test:
* dEQP-GLES2.functional.negative_api.texture.teximage2d_invalid_forma
When validating format+type+internalFormat for texture pixel operations
on GLES3, the effective internal format should be used if the one
specified is an unsized internal format. Page 127, section "3.8 Texturing"
of the GLES 3.0.4 spec says:
"if internalformat is a base internal format, the ef
From: Marek Olšák
FMASK wasn't handled correctly.
---
src/gallium/drivers/radeonsi/si_shader.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader.c
b/src/gallium/drivers/radeonsi/si_shader.c
index 4288e9b..066732d 100644
From: Marek Olšák
---
src/gallium/winsys/amdgpu/drm/amdgpu_cs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.h
b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.h
index 0842259..12c6b62 100644
--- a/src/gallium/winsys/amdgpu/drm/amdgpu_
On Tue, Aug 18, 2015 at 12:43 PM, Marek Olšák wrote:
> From: Marek Olšák
Reviewed-by: Alex Deucher
>
> ---
> src/gallium/winsys/amdgpu/drm/amdgpu_cs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.h
> b/src/gallium/winsys
On Tue, Aug 18, 2015 at 2:29 AM, Francisco Jerez wrote:
> Connor Abbott writes:
>
>> On Mon, Aug 17, 2015 at 2:41 AM, Francisco Jerez
>> wrote:
>>> Connor Abbott writes:
>>>
On Mon, Aug 17, 2015 at 12:09 AM, Pohjolainen, Topi
wrote:
> On Fri, Aug 14, 2015 at 03:30:18PM -0700, Co
Hey,
I was thinking about using an anonymous union. Specifically, something
like:
struct shader {
...
union {
struct geometry_shader_info gs;
struct tess_eval_shader_info tes;
...
};
};
Are those acceptable in Mesa? I don't think we've traditionally used
them, but I'
If this is all that's needed for Bioshock, it's okay with me.
Reviewed-by: Marek Olšák
Marek
On Tue, Aug 18, 2015 at 5:50 PM, Ilia Mirkin wrote:
> This support should be removed in favor of something that actually works
> in all the weird cases. However this is simple and is enough to allow
>
On Tue, Aug 18, 2015 at 9:56 AM, Kenneth Graunke wrote:
> Hey,
>
> I was thinking about using an anonymous union. Specifically, something
> like:
>
> struct shader {
>...
>union {
> struct geometry_shader_info gs;
> struct tess_eval_shader_info tes;
> ...
>};
> };
>
On Mon, Jun 1, 2015 at 3:29 AM, Pohjolainen, Topi
wrote:
> On Fri, May 22, 2015 at 02:24:51PM -0400, Connor Abbott wrote:
>> This can be used for both CSE and value numbering.
>>
>> Signed-off-by: Connor Abbott
>> ---
>> src/glsl/Makefile.sources | 2 +
>> src/glsl/nir/nir_instr_hash.c | 2
On Tue, Aug 18, 2015 at 1:28 AM, Kenneth Graunke wrote:
> On Monday, August 17, 2015 09:53:20 PM Jason Ekstrand wrote:
>> On Aug 17, 2015 4:08 PM, "Kenneth Graunke" wrote:
>> >
>> > Previously, ATTR was indexed by VERT_ATTRIB_* slots; at the end of
>> > compilation, assign_vs_urb_setup() translat
On Fri, May 22, 2015 at 11:24 AM, Connor Abbott wrote:
> This can be used for both CSE and value numbering.
>
> Signed-off-by: Connor Abbott
> ---
> src/glsl/Makefile.sources | 2 +
> src/glsl/nir/nir_instr_hash.c | 255
> ++
> src/glsl/nir/nir_inst
I really like this. It's nice, straight-forward, and to-the-point.
Once the other issues have been cleared up,
Reviewed-by: Jason Ekstrand
On Fri, May 22, 2015 at 11:24 AM, Connor Abbott wrote:
> This replaces an O(n^2) algorithm with an O(n) one, while allowing us to
> import most of the infr
On Fri, May 22, 2015 at 11:24 AM, Connor Abbott wrote:
> This replaces an O(n^2) algorithm with an O(n) one, while allowing us to
> import most of the infrastructure required for GVN. The idea is to walk
> the dominance tree depth-first, similar when converting to SSA, and
> remove the instruction
Connor Abbott writes:
> On Tue, Aug 18, 2015 at 2:29 AM, Francisco Jerez
> wrote:
>> Connor Abbott writes:
>>
>>> On Mon, Aug 17, 2015 at 2:41 AM, Francisco Jerez
>>> wrote:
Connor Abbott writes:
> On Mon, Aug 17, 2015 at 12:09 AM, Pohjolainen, Topi
> wrote:
>> On Fri
On Tue, Jul 21, 2015 at 2:08 PM, Vinson Lee wrote:
> Fixes 'make check' on FreeBSD.
>
> Signed-off-by: Vinson Lee
> ---
Seems fine to me.
Reviewed-by: Matt Turner
At the same time, I don't have any idea if the scripts actually rely
on bash itself. I think I've heard that Debian has a tool to
On Tue, Aug 18, 2015 at 10:53 AM, Francisco Jerez wrote:
> Connor Abbott writes:
>> and so many of them are interconnected and won't even make sense until
>> we have SSA, that it's not always useful to think about the IR we want
>> to have in the distant future in order to decide what to do today
On Mon, Jun 1, 2015 at 3:29 AM, Pohjolainen, Topi
wrote:
> On Fri, May 22, 2015 at 02:24:51PM -0400, Connor Abbott wrote:
>> This can be used for both CSE and value numbering.
>>
>> Signed-off-by: Connor Abbott
>> ---
>> src/glsl/Makefile.sources | 2 +
>> src/glsl/nir/nir_instr_hash.c | 2
I pushed this because it was annoying me and Neil is on vacation.
On Thu, Aug 13, 2015 at 09:06:39AM +0300, Tapani Pälli wrote:
> Reviewed-by: Tapani Palli
>
> On 08/10/2015 07:31 PM, Neil Roberts wrote:
> >Since 4d7e0fa8c731776 this file is generated by the configure script.
> >---
> > src/gal
On Mon 17 Aug 2015, Nanley Chery wrote:
> Cc'ing Brian.
>
> I'm planning to make a patch to implement the first (3-step) solution.
Sounds good to me.
[reproducing in-person conversation for mesa-dev]
For the functions touched by patches 1/4 and 2/4, Mesa verifies
(pre-patch) that each functi
This patch regresses the following tests:
piglit.spec.oes_compressed_paletted_texture.basic api
piglit.spec.oes_compressed_paletted_texture.basic api
piglit.spec.oes_compressed_etc1_rgb8_texture.basic
When you submit v4, please verify that there are no piglit or dEQP
regressions. Also, please co
These three patches are
Tested-by: Mark Janes
Neil Roberts writes:
> When the edge flag element is enabled then the elements are slightly
> reordered so that the edge flag is always the last one. This was
> confusing the code to upload the 3DSTATE_VF_INSTANCING state because
> that is upload
On Mon, Aug 17, 2015 at 4:07 PM, Kenneth Graunke wrote:
> I want to use C function pointers to these, and they don't use anything
> in the visitor classes anyway.
>
> Signed-off-by: Kenneth Graunke
> ---
> src/mesa/drivers/dri/i965/brw_fs.cpp | 10 +-
> src/mesa/drivers/dri/i96
Jason Ekstrand writes:
> This series was inspired by a patch from Chris Willson entitled
> "util/register_allocate: Compute transitive conflicts using 2-passes"
>
> The basic idea is the same: Instead of marking transitive conflicts as you
> go, just mark conflicts with the base register up-front
On Tue, Aug 18, 2015 at 3:42 PM, Eric Anholt wrote:
> Jason Ekstrand writes:
>
>> This series was inspired by a patch from Chris Willson entitled
>> "util/register_allocate: Compute transitive conflicts using 2-passes"
>>
>> The basic idea is the same: Instead of marking transitive conflicts as y
Reviewed-by: Edward O'Callaghan
--
Edward O'Callaghan
edward.ocallag...@koparo.com
On Wed, Aug 19, 2015, at 02:48 AM, Alex Deucher wrote:
> On Tue, Aug 18, 2015 at 12:43 PM, Marek Olšák wrote:
> > From: Marek Olšák
>
> Reviewed-by: Alex Deucher
>
> >
> > ---
> > src/gallium/winsys/amd
On 08/18/2015 01:45 AM, Francisco Jerez wrote:
> Ian Romanick writes:
>
>> On 08/17/2015 09:45 AM, Francisco Jerez wrote:
>>> There is no GL_R8 image format in GLES, according to the state table
>>> 20.32 of the GLES 3.1 spec the default value should be GL_R32UI.
>>
>> Was any conformance test af
On Mon, 2015-08-17 at 19:45 +0300, Francisco Jerez wrote:
> ---
> src/mesa/main/shaderimage.c | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git a/src/mesa/main/shaderimage.c b/src/mesa/main/shaderimage.c
> index 5a3c47a..6f7d1c9 100644
> --- a/src/mesa/main/shaderimage.c
> +++ b
On 08/12/2015 02:23 PM, Thomas Helland wrote:
> 2015-08-12 18:56 GMT+02:00 Kenneth Graunke :
>> On Wednesday, August 12, 2015 06:32:50 PM Thomas Helland wrote:
>>> 2015-08-12 17:48 GMT+02:00 Ilia Mirkin :
On Tue, Aug 11, 2015 at 1:48 PM, Thomas Helland
wrote:
> Signed-off-by: Thomas
On Mon, 2015-08-17 at 19:45 +0300, Francisco Jerez wrote:
> Support for binding an image to an image unit explicitly in the shader
> source is required by both GLSL 4.2 and GLSL ES 3.1, but not by the
> original ARB_shader_image_load_store extension.
> ---
> src/glsl/ast_to_hir.cpp
On 08/18/2015 10:08 AM, Connor Abbott wrote:
> On Tue, Aug 18, 2015 at 9:56 AM, Kenneth Graunke
> wrote:
>> Hey,
>>
>> I was thinking about using an anonymous union. Specifically, something
>> like:
>>
>> struct shader {
>>...
>>union {
>> struct geometry_shader_info gs;
>> s
On Tue, Aug 18, 2015 at 5:36 PM, Ian Romanick wrote:
> On 08/18/2015 10:08 AM, Connor Abbott wrote:
>> On Tue, Aug 18, 2015 at 9:56 AM, Kenneth Graunke
>> wrote:
>>> Hey,
>>>
>>> I was thinking about using an anonymous union. Specifically, something
>>> like:
>>>
>>> struct shader {
>>>...
---
src/gallium/targets/dri/Android.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/targets/dri/Android.mk
b/src/gallium/targets/dri/Android.mk
index 7168e1d..a33d7f8 100644
--- a/src/gallium/targets/dri/Android.mk
+++ b/src/gallium/targets/dri/Android.mk
@@
---
src/gallium/winsys/amdgpu/drm/Android.mk | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/gallium/winsys/amdgpu/drm/Android.mk
b/src/gallium/winsys/amdgpu/drm/Android.mk
index 7d507aa..5773234 100644
--- a/src/gallium/winsys/amdgpu/drm/Android.mk
+++ b/src/gallium/winsys/am
On Mon, Jul 13, 2015 at 06:01:14PM +0100, Neil Roberts wrote:
> The edge flag data on Gen6+ is passed through the fixed function hardware as
> an extra attribute. According to the PRM it must be the last valid
> VERTEX_ELEMENT structure. However if the vertex ID is also used then another
> extra el
---
src/egl/SConscript |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/egl/SConscript b/src/egl/SConscript
index 1b2a427..b05da84 100644
--- a/src/egl/SConscript
+++ b/src/egl/SConscript
@@ -1,6 +1,7 @@
Reviewed-by: Edward O'Callaghan
--
Edward O'Callaghan
edward.ocallag...@koparo.com
On Tue, Aug 18, 2015, at 07:53 PM, Mauro Rossi wrote:
> ---
> src/gallium/targets/dri/Android.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/targets/dri/Android.
Reviewed-by: Edward O'Callaghan
--
Edward O'Callaghan
edward.ocallag...@koparo.com
On Tue, Aug 18, 2015, at 07:53 PM, Mauro Rossi wrote:
> ---
> src/gallium/winsys/amdgpu/drm/Android.mk | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/src/gallium/winsys/amdgpu/drm/Andr
Some shaders appear to extract bits using shift/and combos. Detect
(some) of those and convert to EXTBF instead.
Signed-off-by: Ilia Mirkin
---
.../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 66 +++---
1 file changed, 46 insertions(+), 20 deletions(-)
diff --git a/src/gall
Some Unigine shaders have been observed to unpack bytes out of 32-bit
integers and convert them to floats. I2F/I2I can handle this sort of
thing directly. Detect the handleable situations.
This misses 16-bit word capabilities in nv50, but I haven't seen shaders
that would actually make use of that
On Tue, Aug 18, 2015 at 6:49 PM, Ilia Mirkin wrote:
> Some shaders appear to extract bits using shift/and combos. Detect
> (some) of those and convert to EXTBF instead.
What is EXTBF? Extract byte to float?
I ask because Unigine Heaven has shaders that pack 3x byte-integers
into one component of
On Tue, Aug 18, 2015 at 6:57 PM, Matt Turner wrote:
> On Tue, Aug 18, 2015 at 6:49 PM, Ilia Mirkin wrote:
>> Some shaders appear to extract bits using shift/and combos. Detect
>> (some) of those and convert to EXTBF instead.
>
> What is EXTBF? Extract byte to float?
>
> I ask because Unigine Heav
On Tue, Aug 18, 2015 at 9:57 PM, Matt Turner wrote:
> On Tue, Aug 18, 2015 at 6:49 PM, Ilia Mirkin wrote:
>> Some shaders appear to extract bits using shift/and combos. Detect
>> (some) of those and convert to EXTBF instead.
>
> What is EXTBF? Extract byte to float?
Extract Bitfield.
>
> I ask
Previously, setting up image uniforms relied on being called after
fs_visitor::uniforms was set and with fs_visitor::uniforms not allocating
space for it. This made sense in an ir_visitor world because the visitor
assigns locations and uploads data as it walks through the variables. In
NIR it als
On Mon, Aug 17, 2015 at 4:44 PM, Jason Ekstrand wrote:
> The first four are
>
> Reviewed-by: Jason Ekstrand
Before you push any of these, this patch (number 4) breaks
image_load_store in a kind-of obscure way. I just sent a patch to fix
it up. That patch needs to be applied before this one.
>
Previously, setting up image uniforms relied on being called after
fs_visitor::uniforms was set and with fs_visitor::uniforms not allocating
space for it. This made sense in an ir_visitor world because the visitor
assigns locations and uploads data as it walks through the variables. In
NIR it als
On 19.08.2015 01:43, Marek Olšák wrote:
> From: Marek Olšák
I can guess what the problem was and why this change fixes it, but it
would be nice if the commit log explained that a bit more explicitly.
With that,
Reviewed-by: Michel Dänzer
--
Earthling Michel Dänzer |
On 19.08.2015 01:42, Marek Olšák wrote:
> From: Marek Olšák
>
> FMASK wasn't handled correctly.
> ---
> src/gallium/drivers/radeonsi/si_shader.c | 17 +
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_shader.c
> b/src/gallium/
Hi All,
Could you please adapt the r600g driver for the changed PIPE_FORMAT_*
semantics for big endian machines, please?
All Power Mac and AMIGA one users can't use AMD Radeon HD7xxx or higher
for 3D acceleration. The r600g driver needs to be adapted to changes in
the way the Gallium3D infra
From: Edward O'Callaghan
This gets some churn out the way while prepping for r600g tessellation
support that I am trying to work on. Since that will take me some time
this also avoids rebases and the such like while keeping seperate
indirectly related patches to the actual tessellation support.
From: Edward O'Callaghan
Signed-off-by: Edward O'Callaghan
---
src/gallium/drivers/r600/r600_state_common.c | 24 +---
1 file changed, 17 insertions(+), 7 deletions(-)
diff --git a/src/gallium/drivers/r600/r600_state_common.c
b/src/gallium/drivers/r600/r600_state_common.c
66 matches
Mail list logo
