[Mesa-dev] [PATCH] i965/gen8: Fix antialiased line rendering with width < 1.5

2015-06-11 Thread Iago Toral Quiroga
The same fix Marius implemented for gen6 (commit a9b04d8a) and gen7 (commit 24ecf37a). --- src/mesa/drivers/dri/i965/gen8_sf_state.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) Ken, I don't have gen8 hardware available to test this so it would be nice if someone

Re: [Mesa-dev] [PATCH] i965/gen8: Fix antialiased line rendering with width < 1.5

2015-06-11 Thread Kenneth Graunke
On Thursday, June 11, 2015 09:03:37 AM Iago Toral Quiroga wrote: > The same fix Marius implemented for gen6 (commit a9b04d8a) and > gen7 (commit 24ecf37a). > --- > src/mesa/drivers/dri/i965/gen8_sf_state.c | 22 -- > 1 file changed, 20 insertions(+), 2 deletions(-) > > Ken, I

Re: [Mesa-dev] [PATCH] i965/gen8: Fix antialiased line rendering with width < 1.5

2015-06-11 Thread Iago Toral
On Thu, 2015-06-11 at 00:18 -0700, Kenneth Graunke wrote: > On Thursday, June 11, 2015 09:03:37 AM Iago Toral Quiroga wrote: > > The same fix Marius implemented for gen6 (commit a9b04d8a) and > > gen7 (commit 24ecf37a). > > --- > > src/mesa/drivers/dri/i965/gen8_sf_state.c | 22 +++

[Mesa-dev] [PATCH 1/2] glsl: clone inputs and outputs during linking

2015-06-11 Thread Tapani Pälli
This increases memory pressure during linking but makes it easier for backend to free IR after it is not needed anymore. v2: use resource list as ralloc context in case of relink (Kenneth) Signed-off-by: Tapani Pälli --- src/glsl/linker.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(

[Mesa-dev] [PATCH 2/2] i965: Delete linked GLSL IR when using NIR.

2015-06-11 Thread Tapani Pälli
This is based on Kenneth's patch to delete 'most of the IR'. Due to linker changes to clone variables, we can now free all of IR. Saves 58MB of memory when replaying a Dota 2 trace on Broadwell. Signed-off-by: Tapani Pälli --- src/mesa/drivers/dri/i965/brw_shader.cpp | 5 - 1 file changed,

Re: [Mesa-dev] [PATCH 3/4] i965: use UnrollSamplerArrayDynamicIndexing for gen < 7

2015-06-11 Thread Tapani Pälli
On 06/09/2015 03:52 PM, Francisco Jerez wrote: Tapani Pälli writes: Signed-off-by: Tapani Pälli --- src/mesa/drivers/dri/i965/brw_context.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index 652

[Mesa-dev] [PATCH v2] i965/gen8: Fix antialiased line rendering with width < 1.5

2015-06-11 Thread Iago Toral Quiroga
The same fix Marius implemented for gen6 (commit a9b04d8a) and gen7 (commit 24ecf37a). Also, we need the same code to handle special cases of line width in gen6, gen7 and now gen8, so put that in the helper function we use to compute the line width. --- src/mesa/drivers/dri/i965/brw_util.h |

Re: [Mesa-dev] [PATCH 3/3] meta: Abort meta path if ReadPixels need rgb to luminance conversion

2015-06-11 Thread Tapani Pälli
On 06/11/2015 02:54 AM, Anuj Phogat wrote: After recent addition of pbo testing in piglit test getteximage-luminance, it fails on i965. This patch makes a sub test pass. Signed-off-by: Anuj Phogat Cc: --- src/mesa/drivers/common/meta_tex_subimage.c | 8 1 file changed, 8 insertio

Re: [Mesa-dev] [PATCH 2/2] i965: Delete linked GLSL IR when using NIR.

2015-06-11 Thread Kenneth Graunke
On Thursday, June 11, 2015 10:41:53 AM Tapani Pälli wrote: > This is based on Kenneth's patch to delete 'most of the IR'. Due to > linker changes to clone variables, we can now free all of IR. > > Saves 58MB of memory when replaying a Dota 2 trace on Broadwell. > > Signed-off-by: Tapani Pälli >

Re: [Mesa-dev] [PATCH v2] i965/gen8: Fix antialiased line rendering with width < 1.5

2015-06-11 Thread Kenneth Graunke
On Thursday, June 11, 2015 09:50:53 AM Iago Toral Quiroga wrote: > The same fix Marius implemented for gen6 (commit a9b04d8a) and > gen7 (commit 24ecf37a). > > Also, we need the same code to handle special cases of line width > in gen6, gen7 and now gen8, so put that in the helper function > we us

[Mesa-dev] [PATCH] nir: Recognize max(min(a, 1.0), 0.0) as fsat(a).

2015-06-11 Thread Kenneth Graunke
We already recognize min(max(a, 0.0), 1.0) as a saturate, but neglected this variant (which is also handled by the GLSL IR pass). shader-db results on Broadwell: total instructions in shared programs: 7363046 -> 7362788 (-0.00%) instructions in affected programs: 11928 -> 11670 (-2.16%) helped

Re: [Mesa-dev] [PATCH v3] egl/dri2: implement platform_surfaceless (v3)

2015-06-11 Thread Marek Olšák
On Thu, Jun 11, 2015 at 1:59 AM, Emil Velikov wrote: > Hi gents, > > On 10 June 2015 at 23:20, Zach Reizner wrote: >> From: Haixia Shi >> >> The surfaceless platform is for off-screen rendering only. Render node >> support >> is required. >> >> Only consider the render nodes. Do not use normal

Re: [Mesa-dev] [PATCH 5/7] util/blitter (and friends): generate appropriate SVIEW decls

2015-06-11 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Jun 11, 2015 at 2:14 AM, Rob Clark wrote: > From: Rob Clark > > Some hardware needs to know the sampler type. Update the blit related > shaders to include SVIEW decl. > > Signed-off-by: Rob Clark > --- > Possibly I should have refactored the existing co

Re: [Mesa-dev] [PATCH 6/7] glsl_to_tgsi: add SVIEW decl support

2015-06-11 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Jun 11, 2015 at 2:14 AM, Rob Clark wrote: > From: Rob Clark > > Freedreno needs sampler type information to deal with int/uint textures. > To accomplish this, start creating sampler-view declarations, as > suggested here: > > http://lists.freedesktop.org

Re: [Mesa-dev] [PATCH 1/3] mesa: Use helper function need_rgb_to_luminance_conversion()

2015-06-11 Thread Tapani Pälli
On 06/11/2015 02:54 AM, Anuj Phogat wrote: Signed-off-by: Anuj Phogat --- src/mesa/main/readpix.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c index 9166a50..cba9db8 100644 --- a/src/mesa/main/readpix.c +++

Re: [Mesa-dev] [PATCH 6/7] mesa: build xmlconfig to a separate static library

2015-06-11 Thread Erik Faye-Lund
On Thu, Jun 11, 2015 at 1:19 AM, Matt Turner wrote: > On Wed, Jun 10, 2015 at 3:54 PM, Emil Velikov > wrote: >> From: Erik Faye-Lund >> >> As we use the file from both the dri modules and loader, we end up with >> multiple definition of the symbols provided in our gallium dri modules. >> Addit

Re: [Mesa-dev] [PATCH 2/3] mesa: Turn need_rgb_to_luminance_conversion() in to a global function

2015-06-11 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 06/11/2015 02:54 AM, Anuj Phogat wrote: This will be used by _mesa_meta_pbo_GetTexSubImage() in a later patch. Signed-off-by: Anuj Phogat --- src/mesa/main/readpix.c | 11 ++- src/mesa/main/readpix.h | 3 +++ 2 files changed, 9 insertions(+), 5 deleti

Re: [Mesa-dev] [PATCH v3] egl/dri2: implement platform_surfaceless (v3)

2015-06-11 Thread Emil Velikov
On 11 June 2015 at 10:02, Marek Olšák wrote: > On Thu, Jun 11, 2015 at 1:59 AM, Emil Velikov > wrote: >> Hi gents, >> >> On 10 June 2015 at 23:20, Zach Reizner wrote: >>> From: Haixia Shi >>> >>> The surfaceless platform is for off-screen rendering only. Render node >>> support >>> is require

Re: [Mesa-dev] [PATCH v3] egl/dri2: implement platform_surfaceless

2015-06-11 Thread Emil Velikov
Hi Zach, On 11 June 2015 at 03:25, Zach Reizner wrote: > From: Haixia Shi > > The surfaceless platform is for off-screen rendering only. Render node support > is required. > > Only consider the render nodes. Do not use normal nodes as they require > auth hooks. > > v3: change platform_null to pl

Re: [Mesa-dev] EGL: Add pbuffer support for drm platform

2015-06-11 Thread Marek Olšák
On Thu, Jun 11, 2015 at 1:05 AM, Ying Liu wrote: > Add pbuffer support for drm platform, because some customers are still using > this feature. > > Signed-off-by: Ying Liu > --- > src/egl/drivers/dri2/egl_dri2.c | 3 +++ > src/egl/drivers/dri2/platform_drm.c | 30 +++---

Re: [Mesa-dev] [PATCH v2 0/6] Continu enabling Open Gl ES 3.1

2015-06-11 Thread Tapani Pälli
Patches 1,2,4,5 Reviewed-by: Tapani Pälli For 3 and 6 (multisample + explicit_uniform_locaion) you need to move the enums in to the following array: { "apis": ["GL", "GL_CORE", "GLES3"], "params": [ On 05/07/2015 10:57 AM, Marta Lofstedt wrote: Changes to my previous patch-set accoring to

Re: [Mesa-dev] [PATCH v2 0/6] Continu enabling Open Gl ES 3.1

2015-06-11 Thread Tapani Pälli
On 06/11/2015 03:01 PM, Tapani Pälli wrote: Patches 1,2,4,5 Reviewed-by: Tapani Pälli Just to add the r-b is for v3 that you sent separately for: "mesa/es3.1: enable ARB_shader_atomic_counters for GLES 3.1" (not the one in this particular series) For 3 and 6 (multisample + explicit_unifo

[Mesa-dev] [PATCH 01/10] egl/haiku: use correct version variable

2015-06-11 Thread Emil Velikov
Earlier commitfolded the two separate variables into one, but forgot to update the haiku driver. Fixes: 0e4b564ef28(egl: combine VersionMajor and VersionMinor into one variable) Cc: Marek Olšák > Cc: Alexander von Gluck IV Signed-off-by: Emil Velikov --- src/egl/drivers/haiku/egl_haiku.cpp | 3

[Mesa-dev] [PATCH 04/10] egl/haiku: handle memory allocation failure

2015-06-11 Thread Emil Velikov
Cc: Alexander von Gluck IV Signed-off-by: Emil Velikov --- src/egl/drivers/haiku/egl_haiku.cpp | 35 --- 1 file changed, 28 insertions(+), 7 deletions(-) diff --git a/src/egl/drivers/haiku/egl_haiku.cpp b/src/egl/drivers/haiku/egl_haiku.cpp index 36e1277..760ee4

[Mesa-dev] [PATCH 05/10] egl/haiku: remove unused variables in struct haiku_egl_driver

2015-06-11 Thread Emil Velikov
Cc: Alexander von Gluck IV Signed-off-by: Emil Velikov --- src/egl/drivers/haiku/egl_haiku.cpp | 4 1 file changed, 4 deletions(-) diff --git a/src/egl/drivers/haiku/egl_haiku.cpp b/src/egl/drivers/haiku/egl_haiku.cpp index 760ee45..cfe8817 100644 --- a/src/egl/drivers/haiku/egl_haiku.cpp

[Mesa-dev] [PATCH 06/10] egl/haiku: we don't use src/loader, drop all the references to it

2015-06-11 Thread Emil Velikov
Cc: Alexander von Gluck IV Signed-off-by: Emil Velikov --- src/egl/drivers/haiku/SConscript| 5 - src/egl/drivers/haiku/egl_haiku.cpp | 3 --- 2 files changed, 8 deletions(-) diff --git a/src/egl/drivers/haiku/SConscript b/src/egl/drivers/haiku/SConscript index 9dd2f70..ec6020e 100644 -

[Mesa-dev] [PATCH 09/10] egl/haiku: plug some obvious memory leaks

2015-06-11 Thread Emil Velikov
Cc: Alexander von Gluck IV Signed-off-by: Emil Velikov --- src/egl/drivers/haiku/egl_haiku.cpp | 32 +--- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/src/egl/drivers/haiku/egl_haiku.cpp b/src/egl/drivers/haiku/egl_haiku.cpp index 154b3af..da72895 1

[Mesa-dev] [PATCH 08/10] egl/haiku: minor surface management cleanups

2015-06-11 Thread Emil Velikov
Drop the stub/unused function haiku_create_surface() and add some basic implementation for destroy_surface() Cc: Alexander von Gluck IV Signed-off-by: Emil Velikov --- src/egl/drivers/haiku/egl_haiku.cpp | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/src/e

[Mesa-dev] [PATCH 02/10] egl/haiku: remove commented out code

2015-06-11 Thread Emil Velikov
It serves little to no purpose. As the driver gets updated, one can look at the existing implementation (dri2) for reference rather than letting the commented functions bitrot. Cc: Alexander von Gluck IV Signed-off-by: Emil Velikov --- src/egl/drivers/haiku/egl_haiku.cpp | 93 --

[Mesa-dev] [PATCH 10/10] egl/haiku: coding style fixes

2015-06-11 Thread Emil Velikov
Cc: Alexander von Gluck IV Signed-off-by: Emil Velikov --- src/egl/drivers/haiku/egl_haiku.cpp | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/egl/drivers/haiku/egl_haiku.cpp b/src/egl/drivers/haiku/egl_haiku.cpp index da72895..3d00e47 100644 --- a/src/egl/drive

[Mesa-dev] [PATCH 07/10] egl/haiku: kill off haiku_log()

2015-06-11 Thread Emil Velikov
It's an incompletecopy of the default _eglLog() implementation. Just use the default logger. Cc: Alexander von Gluck IV Signed-off-by: Emil Velikov --- src/egl/drivers/haiku/egl_haiku.cpp | 24 1 file changed, 24 deletions(-) diff --git a/src/egl/drivers/haiku/egl_haik

[Mesa-dev] [PATCH 03/10] egl/haiku: use CALL/TRACE/ERROR over _eglLog() for haiku specifics

2015-06-11 Thread Emil Velikov
Cc: Alexander von Gluck IV Signed-off-by: Emil Velikov --- src/egl/drivers/haiku/egl_haiku.cpp | 64 ++--- 1 file changed, 39 insertions(+), 25 deletions(-) diff --git a/src/egl/drivers/haiku/egl_haiku.cpp b/src/egl/drivers/haiku/egl_haiku.cpp index b09239c..36e

Re: [Mesa-dev] [PATCH 01/10] egl/haiku: use correct version variable

2015-06-11 Thread Emil Velikov
Forgot to mention: The series is untested, although it should not have any negative effects. Everyone familiar with Haiku is welcome to test it. Afaict the current implementation is a simple wrapper around BGLView and looks rather incomplete - patches with implementation and/or comments on the mis

Re: [Mesa-dev] [PATCH 2/3] mesa/main: avoid null access in format_array_table_init()

2015-06-11 Thread Jose Fonseca
On 05/05/15 11:50, Juha-Pekka Heikkila wrote: If _mesa_hash_table_create failed we'd get null pointer. Report error and go away. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/formats.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/mesa/main/formats.c b/src/mesa/m

[Mesa-dev] [PATCH] nir: Fix output swizzle in get_mul_for_src

2015-06-11 Thread Samuel Iglesias Gonsalvez
When we compute output swizzle, avoid reusing it as the source of the computation because, otherwise, it could calculate it wrongly. Signed-off-by: Samuel Iglesias Gonsalvez --- src/glsl/nir/nir_opt_peephole_ffma.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/glsl/

Re: [Mesa-dev] [PATCH 0/4] drisw/glx: use XShm if possible

2015-06-11 Thread Marc-André Lureau
Hi Axel On Thu, Jun 11, 2015 at 7:37 AM, Axel Davy wrote: > XPutImage requires to copy the images around, and the request may be >> split over several chunks. Using XShm should improve performance. >> >> >> >> Another way of doing that is to make the swrast loader allocate the > buffers, > and

Re: [Mesa-dev] [PATCH 01/10] egl/haiku: use correct version variable

2015-06-11 Thread Brian Paul
On 06/11/2015 06:15 AM, Emil Velikov wrote: Earlier commitfolded the two separate variables into one, but forgot to "commit folded" and in patch 7/10: "incomplete copy". For the series, Acked-by: Brian Paul update the haiku driver. Fixes: 0e4b564ef28(egl: combine VersionMajor and Version

Re: [Mesa-dev] [PATCH] nir: Recognize max(min(a, 1.0), 0.0) as fsat(a).

2015-06-11 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Thu, 2015-06-11 at 01:59 -0700, Kenneth Graunke wrote: > We already recognize min(max(a, 0.0), 1.0) as a saturate, but neglected > this variant (which is also handled by the GLSL IR pass). > > shader-db results on Broadwell: > total instructions in shared progr

Re: [Mesa-dev] [PATCH 2/7] tgsi/transform: add support for SVIEW decls

2015-06-11 Thread Brian Paul
On 06/10/2015 06:14 PM, Rob Clark wrote: From: Rob Clark Signed-off-by: Rob Clark --- src/gallium/auxiliary/tgsi/tgsi_transform.h | 24 1 file changed, 24 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_transform.h b/src/gallium/auxiliary/tgsi/tgsi_tran

Re: [Mesa-dev] [PATCH 5/7] util/blitter (and friends): generate appropriate SVIEW decls

2015-06-11 Thread Brian Paul
On 06/10/2015 06:14 PM, Rob Clark wrote: From: Rob Clark Some hardware needs to know the sampler type. Update the blit related shaders to include SVIEW decl. Signed-off-by: Rob Clark --- Possibly I should have refactored the existing code to pass around a return_type rather than doing the is

Re: [Mesa-dev] [PATCH 5/7] util/blitter (and friends): generate appropriate SVIEW decls

2015-06-11 Thread Roland Scheidegger
For 1-4/7, 6/7: Reviewed-by: Roland Scheidegger I think though using two exclusive booleans is really ugly. Probably should just use a tgsi_return_type enum instead indeed, and treat the unorm/snorm cases as float. I'm not entirely sure what the unorm/snorm types are for neither, this is a d3d10-

Re: [Mesa-dev] [PATCH] i965: Re-index SSA definitions before printing NIR code.

2015-06-11 Thread Iago Toral
Thanks Ken, this does make debugging NIR code a bit easier :) Reviewed-by: Iago Toral Quiroga On Wed, 2015-06-10 at 02:39 -0700, Kenneth Graunke wrote: > This makes the SSA definitions use sequential numbers (0, 1, 2, ...) > instead of seemingly random ones. There's not much point normally, > b

Re: [Mesa-dev] [PATCH] i965: Re-index SSA definitions before printing NIR code.

2015-06-11 Thread Connor Abbott
The one thing this will hurt is that diff'ing shaders from before and after an optimization becomes harder, since just printing the shader will re-order the numbers and add spurious changes. If we want to make the result of doing INTEL_DEBUG=fs more reasonable, we could just do it at the end of the

Re: [Mesa-dev] [PATCH 5/7] util/blitter (and friends): generate appropriate SVIEW decls

2015-06-11 Thread Rob Clark
On Thu, Jun 11, 2015 at 10:53 AM, Roland Scheidegger wrote: > For 1-4/7, 6/7: > Reviewed-by: Roland Scheidegger > > I think though using two exclusive booleans is really ugly. Probably > should just use a tgsi_return_type enum instead indeed, and treat the > unorm/snorm cases as float. I'm not en

Re: [Mesa-dev] [PATCH] i965: Re-index SSA definitions before printing NIR code.

2015-06-11 Thread Jason Ekstrand
On Thu, Jun 11, 2015 at 8:12 AM, Connor Abbott wrote: > The one thing this will hurt is that diff'ing shaders from before and > after an optimization becomes harder, since just printing the shader > will re-order the numbers and add spurious changes. If we want to make > the result of doing INTEL_

Re: [Mesa-dev] [PATCH] gallium: remove explicit values from PIPE_CAP_ enums

2015-06-11 Thread Jose Fonseca
On 10/06/15 18:01, Brian Paul wrote: The other PIPE_CAPF_ and PIPE_SHADER_CAP_ enums don't have explicit values. --- src/gallium/include/pipe/p_defines.h | 196 +-- 1 file changed, 98 insertions(+), 98 deletions(-) diff --git a/src/gallium/include/pipe/p_define

Re: [Mesa-dev] [PATCH] i965: correct alignment units for 2D compressed textures on Skylake

2015-06-11 Thread Neil Roberts
Hi Nanley, Could you explain the reasoning behind this patch? I can't find any mention of needing to align to the square of the block size in the docs. I think how it works is that on Skylake you can pick any alignment value you want out of 4, 8 or 16 but for compressed textures that is counted i

[Mesa-dev] [PATCH] i965: Fix aligning to the block size in intel_miptree_copy_slice

2015-06-11 Thread Neil Roberts
This function was trying to align the width and height to a multiple of the block size for compressed textures. It was using align_w/h as a shortcut to get the block size as up until Gen9 this always happens to match. However in Gen9+ the alignment values are expressed as multiples of the block siz

Re: [Mesa-dev] [PATCH] i965: correct alignment units for 2D compressed textures on Skylake

2015-06-11 Thread Ben Widawsky
On Wed, Jun 10, 2015 at 05:01:44PM -0700, Nanley Chery wrote: > From: Nanley Chery > > On Gen9+, vertical and horizontal alignment values for compressed textures are > equal to the pre-Gen9 value squared. Each miplevel must be aligned to this > value. > > Signed-off-by: Nanley Chery While not

Re: [Mesa-dev] [PATCH 5/7] util/blitter (and friends): generate appropriate SVIEW decls

2015-06-11 Thread Roland Scheidegger
Am 11.06.2015 um 17:33 schrieb Rob Clark: > On Thu, Jun 11, 2015 at 10:53 AM, Roland Scheidegger > wrote: >> For 1-4/7, 6/7: >> Reviewed-by: Roland Scheidegger >> >> I think though using two exclusive booleans is really ugly. Probably >> should just use a tgsi_return_type enum instead indeed, an

Re: [Mesa-dev] [PATCH 2/2] i965: Delete linked GLSL IR when using NIR.

2015-06-11 Thread Jason Ekstrand
On Thu, Jun 11, 2015 at 12:41 AM, Tapani Pälli wrote: > This is based on Kenneth's patch to delete 'most of the IR'. Due to > linker changes to clone variables, we can now free all of IR. > > Saves 58MB of memory when replaying a Dota 2 trace on Broadwell. I think we've saved ~50 MB 3 times now o

Re: [Mesa-dev] [PATCH] i965: Re-index SSA definitions before printing NIR code.

2015-06-11 Thread Connor Abbott
On Thu, Jun 11, 2015 at 8:27 AM, Jason Ekstrand wrote: > On Thu, Jun 11, 2015 at 8:12 AM, Connor Abbott wrote: >> The one thing this will hurt is that diff'ing shaders from before and >> after an optimization becomes harder, since just printing the shader >> will re-order the numbers and add spur

[Mesa-dev] [PATCH 0.5/3] mesa: Handle integer formats in need_rgb_to_luminance_conversion()

2015-06-11 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/mesa/main/readpix.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c index df46f83..9166a50 100644 --- a/src/mesa/main/readpix.c +++ b/src/mesa/main/readpix.c @@ -54,7 +54,10 @@ need_rgb_to

Re: [Mesa-dev] [PATCH 1/3] mesa: Use helper function need_rgb_to_luminance_conversion()

2015-06-11 Thread Anuj Phogat
On Thu, Jun 11, 2015 at 2:44 AM, Tapani Pälli wrote: > > > On 06/11/2015 02:54 AM, Anuj Phogat wrote: >> >> Signed-off-by: Anuj Phogat >> --- >> src/mesa/main/readpix.c | 11 --- >> 1 file changed, 4 insertions(+), 7 deletions(-) >> >> diff --git a/src/mesa/main/readpix.c b/src/mesa/ma

Re: [Mesa-dev] [PATCH 0.5/3] mesa: Handle integer formats in need_rgb_to_luminance_conversion()

2015-06-11 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 06/11/2015 07:58 PM, Anuj Phogat wrote: Signed-off-by: Anuj Phogat --- src/mesa/main/readpix.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c index df46f83..9166a50 100644 --- a/src/mesa/

Re: [Mesa-dev] [PATCH 1/3] mesa: Use helper function need_rgb_to_luminance_conversion()

2015-06-11 Thread Tapani Pälli
On 06/11/2015 08:00 PM, Anuj Phogat wrote: On Thu, Jun 11, 2015 at 2:44 AM, Tapani Pälli wrote: On 06/11/2015 02:54 AM, Anuj Phogat wrote: Signed-off-by: Anuj Phogat --- src/mesa/main/readpix.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/mesa/main

Re: [Mesa-dev] [PATCH v2 09/82] mesa: Add shader storage buffer support to struct gl_context

2015-06-11 Thread Jordan Justen
On 2015-06-10 02:30:10, Samuel Iglesias Gonsálvez wrote: > On 09/06/15 19:34, Jordan Justen wrote: > > On 2015-06-09 00:30:45, Samuel Iglesias Gonsálvez wrote: > >> On 09/06/15 08:18, Samuel Iglesias Gonsálvez wrote: > >> I plan to modify patch [0] to set prog->MaxShaderStorageBlocks = 8 and > >> w

[Mesa-dev] [Bug 28130] vbo: premature flushing breaks GL_LINE_LOOP

2015-06-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28130 --- Comment #8 from marius predut --- My investigation till now : Because the test code call twice the glBegin(GL_LINE_LOOP);glVertex3fv(); glEnd() and then glFlush() if we add an intermediary glFlush() between those sequential call then the bu

[Mesa-dev] [Bug 28130] vbo: premature flushing breaks GL_LINE_LOOP

2015-06-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28130 --- Comment #9 from Roland Scheidegger --- (In reply to marius predut from comment #8) > My investigation till now : > Because the test code call twice the > glBegin(GL_LINE_LOOP);glVertex3fv(); glEnd() and then glFlush() > if we add an interme

[Mesa-dev] [PATCH v2 3/3] meta: Abort meta path if ReadPixels need rgb to luminance conversion

2015-06-11 Thread Anuj Phogat
After recent addition of pbo testing in piglit test getteximage-luminance, it fails on i965. This patch makes a sub test pass. Signed-off-by: Anuj Phogat Cc: Cc: Tapani Palli --- src/mesa/drivers/common/meta_tex_subimage.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/d

Re: [Mesa-dev] [PATCH 3/3] meta: Abort meta path if ReadPixels need rgb to luminance conversion

2015-06-11 Thread Anuj Phogat
On Thu, Jun 11, 2015 at 1:41 AM, Tapani Pälli wrote: > > > On 06/11/2015 02:54 AM, Anuj Phogat wrote: >> >> After recent addition of pbo testing in piglit test getteximage-luminance, >> it fails on i965. This patch makes a sub test pass. >> >> Signed-off-by: Anuj Phogat >> Cc: >> --- >> src/me

Re: [Mesa-dev] [PATCH] mesa: set override_version per api version override

2015-06-11 Thread Jordan Justen
On 2015-06-10 13:03:20, Jordan Justen wrote: > Whoops. I re-wrote this last night: > > http://cgit.freedesktop.org/~jljusten/mesa/commit/?h=cs-33&id=3ebe7b79 > > On 2015-06-04 21:41:15, Tapani Pälli wrote: > > Before 9b5e92f get_gl_override was called only once, but now it is > > called for multi

Re: [Mesa-dev] [PATCH v2 13/82] glsl: buffer variables cannot be defined outside interface blocks

2015-06-11 Thread Jordan Justen
On 2015-06-03 00:01:03, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > Section 4.3.7 "Buffer Variables", GLSL 4.30 spec: > > "Buffer variables may only be declared inside interface blocks > (section 4.3.9 “Interface Blocks”), which are then referred to as > shader storage blocks

[Mesa-dev] [PATCH] meta: Abort texture upload if pixels == null and no pixel unpack buffer set

2015-06-11 Thread Anuj Phogat
in case of glTex{Sub}Image{1,2,3}D(). Texture has already been allocated at this point and we have no data to upload. With out this patch, with create_pbo = true, we end up creating a temporary pbo and then uploading uninitialzed texture data. Signed-off-by: Anuj Phogat Cc: Neil Roberts --- src

[Mesa-dev] [PATCH 4/7] util/pstipple: updates for SVIEW decls

2015-06-11 Thread Rob Clark
From: Rob Clark To allow for shaders which use SVIEW decls for TEX* instructions, we need to preserve the constraint that the shader either has no SVIEW's or it has one matching SVIEW for each SAMP. Signed-off-by: Rob Clark Reviewed-by: Roland Scheidegger --- src/gallium/auxiliary/util/u_psti

[Mesa-dev] [PATCH 1/7] tgsi: update docs for SVIEW usage with TEX* instructions

2015-06-11 Thread Rob Clark
From: Rob Clark Based on mailing list discussion here: http://lists.freedesktop.org/archives/mesa-dev/2014-November/071583.html Signed-off-by: Rob Clark Reviewed-by: Roland Scheidegger --- src/gallium/docs/source/tgsi.rst | 12 1 file changed, 12 insertions(+) diff --git a/src/

[Mesa-dev] [PATCH 2/7] tgsi/transform: add support for SVIEW decls

2015-06-11 Thread Rob Clark
From: Rob Clark TODO single return_type (use enum) v2: single return_type arg, and use enum Signed-off-by: Rob Clark Reviewed-by: Roland Scheidegger --- src/gallium/auxiliary/tgsi/tgsi_transform.h | 21 + 1 file changed, 21 insertions(+) diff --git a/src/gallium/auxiliar

[Mesa-dev] [PATCH 6/7] glsl_to_tgsi: add SVIEW decl support

2015-06-11 Thread Rob Clark
From: Rob Clark Freedreno needs sampler type information to deal with int/uint textures. To accomplish this, start creating sampler-view declarations, as suggested here: http://lists.freedesktop.org/archives/mesa-dev/2014-November/071583.html create a sampler-view with index matching the sampl

[Mesa-dev] [PATCH 7/7] gallium/ttn: add texture-type support

2015-06-11 Thread Rob Clark
From: Rob Clark v2: rebased on using SVIEW to hold type information Signed-off-by: Rob Clark Reviewed-by: Eric Anholt --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 44 - 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/nir/tgs

[Mesa-dev] [PATCH 3/7] draw: updates to support SVIEW decls

2015-06-11 Thread Rob Clark
From: Rob Clark To allow for shaders which use SVIEW decls for TEX* instructions, we need to preserve the constraint that the shader either has no SVIEW's or it has one matching SVIEW for each SAMP. Signed-off-by: Rob Clark Reviewed-by: Roland Scheidegger --- src/gallium/auxiliary/draw/draw_p

[Mesa-dev] [PATCH 5/7] util/blitter (and friends): generate appropriate SVIEW decls

2015-06-11 Thread Rob Clark
From: Rob Clark Some hardware needs to know the sampler type. Update the blit related shaders to include SVIEW decl. Signed-off-by: Rob Clark --- src/gallium/auxiliary/util/u_blit.c | 35 +--- src/gallium/auxiliary/util/u_blitter.c| 53 +- src/gallium

Re: [Mesa-dev] [PATCH 5/7] util/blitter (and friends): generate appropriate SVIEW decls

2015-06-11 Thread Roland Scheidegger
Am 11.06.2015 um 22:38 schrieb Rob Clark: > From: Rob Clark > > Some hardware needs to know the sampler type. Update the blit related > shaders to include SVIEW decl. > > Signed-off-by: Rob Clark > --- > src/gallium/auxiliary/util/u_blit.c | 35 +--- > src/gallium/auxiliary/

Re: [Mesa-dev] [PATCH 5/7] util/blitter (and friends): generate appropriate SVIEW decls

2015-06-11 Thread Rob Clark
On Thu, Jun 11, 2015 at 4:51 PM, Roland Scheidegger wrote: > Am 11.06.2015 um 22:38 schrieb Rob Clark: >> From: Rob Clark >> >> Some hardware needs to know the sampler type. Update the blit related >> shaders to include SVIEW decl. >> >> Signed-off-by: Rob Clark >> --- >> src/gallium/auxiliary

Re: [Mesa-dev] [PATCH 5/7] util/blitter (and friends): generate appropriate SVIEW decls

2015-06-11 Thread Brian Paul
On 06/11/2015 02:38 PM, Rob Clark wrote: From: Rob Clark Some hardware needs to know the sampler type. Update the blit related shaders to include SVIEW decl. Signed-off-by: Rob Clark --- src/gallium/auxiliary/util/u_blit.c | 35 +--- src/gallium/auxiliary/util/u_blitter.

Re: [Mesa-dev] COMPSIZE function in OpenGL XML registry

2015-06-11 Thread Shervin Sharifi
Thank you Ian, Jose and Matt. I'll take a look at the pointers you provided. Probably would come back with some more questions. Thanks, Shervin On Wed, Jun 10, 2015 at 3:55 PM, Ian Romanick wrote: > On 06/10/2015 03:05 PM, Shervin Sharifi wrote: > > Thanks Ian. > > If I want to implement

Re: [Mesa-dev] [PATCH 5/7] util/blitter (and friends): generate appropriate SVIEW decls

2015-06-11 Thread Rob Clark
On Thu, Jun 11, 2015 at 5:47 PM, Brian Paul wrote: > On 06/11/2015 02:38 PM, Rob Clark wrote: >> >> From: Rob Clark >> >> Some hardware needs to know the sampler type. Update the blit related >> shaders to include SVIEW decl. >> >> Signed-off-by: Rob Clark >> --- >> src/gallium/auxiliary/util

Re: [Mesa-dev] [PATCH 0.5/3] mesa: Handle integer formats in need_rgb_to_luminance_conversion()

2015-06-11 Thread Anuj Phogat
On Thu, Jun 11, 2015 at 10:05 AM, Tapani Pälli wrote: > Reviewed-by: Tapani Pälli > > > On 06/11/2015 07:58 PM, Anuj Phogat wrote: >> >> Signed-off-by: Anuj Phogat >> --- >> src/mesa/main/readpix.c | 5 - >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/src/mesa/main/r

Re: [Mesa-dev] [PATCH 5/7] util/blitter (and friends): generate appropriate SVIEW decls

2015-06-11 Thread Brian Paul
On 06/11/2015 06:02 PM, Rob Clark wrote: On Thu, Jun 11, 2015 at 5:47 PM, Brian Paul wrote: On 06/11/2015 02:38 PM, Rob Clark wrote: From: Rob Clark Some hardware needs to know the sampler type. Update the blit related shaders to include SVIEW decl. Signed-off-by: Rob Clark --- src/ga

Re: [Mesa-dev] [PATCH 5/7] util/blitter (and friends): generate appropriate SVIEW decls

2015-06-11 Thread Roland Scheidegger
Am 12.06.2015 um 02:02 schrieb Rob Clark: > On Thu, Jun 11, 2015 at 5:47 PM, Brian Paul wrote: >> On 06/11/2015 02:38 PM, Rob Clark wrote: >>> >>> From: Rob Clark >>> >>> Some hardware needs to know the sampler type. Update the blit related >>> shaders to include SVIEW decl. >>> >>> Signed-off-b

[Mesa-dev] [PATCH] radeon/llvm: Handle LLVM backend rename from R600 to AMDGPU

2015-06-11 Thread Tom Stellard
--- configure.ac | 13 - src/gallium/drivers/radeon/radeon_llvm_emit.c | 8 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index d32aa24..eda8d23 100644 --- a/configure.ac +++ b/configure.ac @@ -204

[Mesa-dev] [PATCH] i965/cs: Use exec all for CS terminate

2015-06-11 Thread Jordan Justen
This prevents an assertion from being hit with SIMD16: Assertion `inst->exec_size == dispatch_width() || force_writemask_all' failed. Signed-off-by: Jordan Justen Cc: Francisco Jerez --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH] i965/cs: Initialize GPGPU Thread Count

2015-06-11 Thread Jordan Justen
This field should always be set for gen8. In the bdw PRM, Volume 2d: Command Reference: Structures under INTERFACE_DESCRIPTOR_DATA, DWORD 6, Bits 9:0, Number of Threads in GPGPU Thread Group: "This field should not be set to 0 even if the barrier is disabled, since an accurate value is needed for

Re: [Mesa-dev] [PATCH] mesa: set override_version per api version override

2015-06-11 Thread Tapani Pälli
On 06/11/2015 09:05 PM, Jordan Justen wrote: On 2015-06-10 13:03:20, Jordan Justen wrote: Whoops. I re-wrote this last night: http://cgit.freedesktop.org/~jljusten/mesa/commit/?h=cs-33&id=3ebe7b79 On 2015-06-04 21:41:15, Tapani Pälli wrote: Before 9b5e92f get_gl_override was called only onc

Re: [Mesa-dev] [PATCH v2 3/3] meta: Abort meta path if ReadPixels need rgb to luminance conversion

2015-06-11 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 06/11/2015 08:36 PM, Anuj Phogat wrote: After recent addition of pbo testing in piglit test getteximage-luminance, it fails on i965. This patch makes a sub test pass. Signed-off-by: Anuj Phogat Cc: Cc: Tapani Palli --- src/mesa/drivers/common/meta_tex_subimage

Re: [Mesa-dev] [PATCH v2 13/82] glsl: buffer variables cannot be defined outside interface blocks

2015-06-11 Thread Samuel Iglesias Gonsálvez
On 11/06/15 20:38, Jordan Justen wrote: > On 2015-06-03 00:01:03, Iago Toral Quiroga wrote: >> From: Samuel Iglesias Gonsalvez >> >> Section 4.3.7 "Buffer Variables", GLSL 4.30 spec: >> >> "Buffer variables may only be declared inside interface blocks >> (section 4.3.9 “Interface Blocks”), which

Re: [Mesa-dev] [PATCH v2 0/6] Continu enabling Open Gl ES 3.1

2015-06-11 Thread Tapani Pälli
On 06/11/2015 03:08 PM, Tapani Pälli wrote: On 06/11/2015 03:01 PM, Tapani Pälli wrote: Patches 1,2,4,5 Reviewed-by: Tapani Pälli Just to add the r-b is for v3 that you sent separately for: "mesa/es3.1: enable ARB_shader_atomic_counters for GLES 3.1" (not the one in this particular serie

[Mesa-dev] [PATCH] EGL: Add pbuffer support for drm platform

2015-06-11 Thread Ying Liu
Add pbuffer support for drm platform, because some customers are still using this feature. Signed-off-by: Ying Liu --- src/egl/drivers/dri2/egl_dri2.c | 2 +- src/egl/drivers/dri2/platform_drm.c | 18 ++ 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/src/eg

Re: [Mesa-dev] EGL: Add pbuffer support for drm platform

2015-06-11 Thread Liu, Ying2
Marek, Thank you so much for your review. I have updated my patch. Ying -Original Message- From: Marek Olšák [mailto:mar...@gmail.com] Sent: Thursday, June 11, 2015 4:34 AM To: Liu, Ying2 Cc: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] EGL: Add pbuffer support for drm platfor

[Mesa-dev] [PATCH 2/3] glsl: enforce fragment shader input restrictions in GLSL ES 3.10

2015-06-11 Thread Timothy Arceri
--- src/glsl/ast_to_hir.cpp | 45 + 1 file changed, 45 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index d7ecc35..8236ff9 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -3610,6 +3610,51 @@ ast_decl

[Mesa-dev] [PATCH 3/3] glsl: enforce restriction on AoA interface blocks in GLSL ES 3.10

2015-06-11 Thread Timothy Arceri
--- src/glsl/ast_to_hir.cpp | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 8236ff9..93e0a82 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -5851,6 +5851,17 @@ ast_interface_block::hir(exec_list *instru

[Mesa-dev] [PATCH 1/3] glsl: enforce output variable rules for GLSL ES 3.10

2015-06-11 Thread Timothy Arceri
Some rules are already applied this just adds the missing ones. --- src/glsl/ast_to_hir.cpp | 49 + 1 file changed, 49 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 578711a..d7ecc35 100644 --- a/src/glsl/ast_to_h