On 2015-06-10 02:30:10, Samuel Iglesias Gonsálvez wrote: > On 09/06/15 19:34, Jordan Justen wrote: > > On 2015-06-09 00:30:45, Samuel Iglesias Gonsálvez wrote: > >> On 09/06/15 08:18, Samuel Iglesias Gonsálvez wrote: > >> I plan to modify patch [0] to set prog->MaxShaderStorageBlocks = 8 and > >> write a separate patch that makes i965 driver to set the following > >> constant values: > >> > >> * MaxShaderStorageBlocks = 12 > >> * MaxCombinedUniformBlocks = 36 (12 * 3 different shader types: vertex, > >> geometry and fragment) > > > > Will it need to be '* 5' with the 2 tessellation stages? I wonder if > > we can somehow guard against it being missed later. I guess TS tests > > should be able to catch this. > > > > There are two possibilities: > > 1) Add a FIXME comment in the separate patch for i965, where I am going > to modify the value of MaxCombinedUniformBlocks, saying that we don't > count tessellation stages yet. > > 2) Set MaxCombinedUniformBlocks = 12 * 5 in that separate patch and add > a comment saying that it counts tessellation stages, although they are > not supported yet. > > I prefer 1) because future TS support will need to do similar changes in > other places. What do you think?
Yeah, 1 seems fine. Thanks, -Jordan _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
