On 01/12/14 20:14, Jason Ekstrand wrote:
> On Mon, Dec 1, 2014 at 3:04 AM, Iago Toral Quiroga
> wrote:
>
>> From: Samuel Iglesias Gonsalvez
>>
>> Signed-off-by: Samuel Iglesias Gonsalvez
>> ---
>> src/mesa/main/format_pack.c.mako | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
On 01/12/14 20:14, Jason Ekstrand wrote:
> On Mon, Dec 1, 2014 at 3:04 AM, Iago Toral Quiroga
> wrote:
>
>> From: Samuel Iglesias Gonsalvez
>>
>> We will use this later on to handle uint conversion scenarios in a master
>> convert function.
>>
>> v2:
>> - Modify pack_uint_*() function generati
On Mon, 2014-12-01 at 13:25 -0500, Ilia Mirkin wrote:
> On Mon, Dec 1, 2014 at 6:04 AM, Iago Toral Quiroga wrote:
> > _BaseFormat is a GLenum (unsigned int) so testing if its value is
> > greater than 0 to detect the cases where _mesa_base_tex_format
> > returns -1 doesn't work.
> >
> > Fixing the
On Tuesday, December 02, 2014 07:54:19 AM Samuel Iglesias Gonsálvez wrote:
> On Monday, December 01, 2014 10:16:35 AM Jason Ekstrand wrote:
> > This looks much better. Two comments though. First, I think we need to
> > tweak the float_to_uint function to clamp above. I don't know that it
> > pro
On Mon, 2014-12-01 at 11:14 -0800, Jason Ekstrand wrote:
>
>
> On Mon, Dec 1, 2014 at 3:04 AM, Iago Toral Quiroga
> wrote:
> From: Samuel Iglesias Gonsalvez
>
> We will use this later on to handle uint conversion scenarios
> in a master
> convert functio
On Mon, 2014-12-01 at 09:24 -0700, Brian Paul wrote:
> On 12/01/2014 06:04 AM, Eduardo Lima Mitev wrote:
> > From: Iago Toral Quiroga
> >
> > The current code computes ctx->Array.LegalTypesMask just once,
> > however, computing this needs to consider ctx->API so we need
> > to make sure that the A
On 12/01/2014 05:29 PM, Brian Paul wrote:
> On 12/01/2014 06:04 AM, Eduardo Lima Mitev wrote:
>> This set of (unrelated) patches fixes over 230 tests from the dEQP
>> test suite [1].
>
> [...]
>
> The non-GLSL changes look good to me and are: Reviewed-by: Brian Paul
>
>
> The GLSL changes look O
The "Pixel Shader Computed Depth Mode" value is entirely based on the
shader program, so we can easily do it at compile time. This avoids the
if+switch on every 3DSTATE_WM (Gen7)/3DSTATE_PS_EXTRA (Gen8+) upload,
and shares a bit more code.
This also simplifies the PMA stall code, making it match
Commit c0347705 changed the Gen6-7 code to use ctx->_Shader rather than
ctx->Shader, but neglected to change the Gen4-5 or Gen8+ code.
This might fix SSO related bugs, but ALT mode is only used for ARB
programs, so if there's an actual problem, it's likely no one would
run into it.
Signed-off-by:
We use IEEE mode for GLSL programs, but need to use ALT mode for ARB
programs so that 0^0 == 1. The choice is based entirely on the shader
source language.
Previously, our code to determine which mode we wanted was duplicated
in 8 different places (VS and FS for Gen4-5, Gen6, Gen7, and Gen8).
The
This simply looks wrong - I don't see any code that uses _NEW_TRANSFORM
or BRW_NEW_VERTEX_PROGRAM. It looks like the intention was to duplicate
the brw_curbe_offsets atom's flags, which computes brw->curbe.vs_start.
This is unnecessary - we flag BRW_NEW_CURBE_OFFSETS whenever that field
changes; l
We don't access brw->vertex_program or ctx->_Shader since the previous
commit, so we don't need this dirty bit.
I think it's still necessary on Gen6 because it still conflates
constant uploading with unit state uploading. We can fix that later.
Signed-off-by: Kenneth Graunke
---
src/mesa/drive
On 12/01/2014 05:43 PM, Matteo Bruni wrote:
2014-12-01 14:04 GMT+01:00 Eduardo Lima Mitev :
The OpenGL ES Shading Language specification describes the
values that may be output by a fragment shader. These are
gl_FragColor and gl_FragData[0]. Multiple render targets
are not supported in GLES.
On Tue, Dec 2, 2014 at 3:05 AM, Iago Toral wrote:
> On Mon, 2014-12-01 at 13:25 -0500, Ilia Mirkin wrote:
>> On Mon, Dec 1, 2014 at 6:04 AM, Iago Toral Quiroga wrote:
>> > _BaseFormat is a GLenum (unsigned int) so testing if its value is
>> > greater than 0 to detect the cases where _mesa_base_te
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/drivers/common/meta.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c
index 87532c1..e106899 100644
--- a/src/mesa/drivers/common/meta.c
+++ b/src/mesa/drivers/common/meta.c
@@ -
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/main/texstate.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c
index e0f0852..6f7d781 100644
--- a/src/mesa/main/texstate.c
+++ b/src/mesa/main/texstate.c
@@ -930,8 +930,
Stop context creation if something failed. If something errored
during context creation we'd segfault. Now will clean up and
return error.
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/main/shared.c | 63 ++
1 file changed, 59 insertions(+), 4 de
On 12/02/2014 01:31 PM, Tapani Pälli wrote:
>>
>> AFAICS this restriction is lifted in ES 3.0+ (e.g. see section 3.9.2
>> in the OpenGL ES 3.0 spec).
>
> Yep, it seems this check should be against earlier versions and only
> when not having extensions that allow MRT enabled (NV_draw_buffers).
>
Ok, I've written a somewhat contrived test case here:
https://github.com/bpeel/glthing/tree/time-attribs
(Make sure to use the time-attribs branch)
The example draws a 1000 single-pixel points each with a separate draw
call. Each call uses a separate but identical VAO so that the driver
will be
On Mon, Nov 10, 2014 at 07:04:54PM +0200, Francisco Jerez wrote:
> EdB writes:
>
> > clCompileProgram should return CL_INVALID_COMPILER_OPTIONS
> > instead of CL_INVALID_BUILD_OPTIONS
>
> Looks good to me,
> Reviewed-by: Francisco Jerez
I've pushed this, thanks!
-Tom
>
> > ---
> > src/galli
On Mon, Dec 01, 2014 at 06:33:10PM -0500, Jan Vesely wrote:
> ping
I've pushed this, thanks.
-Tom
>
> On Mon, 2014-11-03 at 20:29 -0500, Jan Vesely wrote:
> > Signed-off-by: Jan Vesely
> > ---
> > src/gallium/drivers/r600/r600_llvm.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --g
On Mon, Nov 03, 2014 at 08:29:37PM -0500, Jan Vesely wrote:
> Signed-off-by: Jan Vesely
> ---
>
> moreover, the condition is never true now that clover appends dim info
>
> src/gallium/drivers/r600/evergreen_compute.c | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/src/gallium/driv
Series sort of sounds sensible but it's really outside my expertise.
Zack would be a much better reviewer.
This should be thoroughly tested too.
Jose
On 02/12/14 01:31, srol...@vmware.com wrote:
From: Roland Scheidegger
The prim assembler may change the prim type when injecting prim ids now
height=0 is legal for 1D array textures (as height=0 is legal for
2D arrays). Fixes new piglit ext_texture_array-errors test.
Cc: "10.3 10.4"
---
src/mesa/main/teximage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
inde
LGTM.
On 02/12/14 16:43, Brian Paul wrote:
height=0 is legal for 1D array textures (as height=0 is legal for
I think you mean "as depth=0 is legal for 2D arrays"
2D arrays). Fixes new piglit ext_texture_array-errors test.
Cc: "10.3 10.4"
---
src/mesa/main/teximage.c | 2 +-
1 file chan
On 12/02/2014 09:49 AM, Jose Fonseca wrote:
LGTM.
On 02/12/14 16:43, Brian Paul wrote:
height=0 is legal for 1D array textures (as height=0 is legal for
I think you mean "as depth=0 is legal for 2D arrays"
Yes, thanks.
-Brian
2D arrays). Fixes new piglit ext_texture_array-errors test
On 11/20/2014 05:19 PM, Kenneth Graunke wrote:
> On Thursday, November 20, 2014 11:14:49 AM Ian Romanick wrote:
>> From: Ian Romanick
>>
>> GL 3-ish versions of the spec are less clear that an error should be
>> generated here, so Ken (and I during review) just missed it in 1afe335.
>>
>> Signed-o
On Mon, Dec 1, 2014 at 11:03 PM, Samuel Iglesias Gonsálvez <
sigles...@igalia.com> wrote:
>
>
> On 01/12/14 20:00, Jason Ekstrand wrote:
> > On Mon, Dec 1, 2014 at 3:04 AM, Iago Toral Quiroga
> > wrote:
> >
> >> From: Jason Ekstrand
> >>
> >> We were auto-generating it before. The problem was t
On Tue, Dec 2, 2014 at 2:32 AM, Iago Toral wrote:
> On Mon, 2014-12-01 at 11:14 -0800, Jason Ekstrand wrote:
> >
> >
> > On Mon, Dec 1, 2014 at 3:04 AM, Iago Toral Quiroga
> > wrote:
> > From: Samuel Iglesias Gonsalvez
> >
> > We will use this later on to handle uint conversion
On Tue, Dec 2, 2014 at 8:24 AM, Ilia Mirkin wrote:
> On Tue, Dec 2, 2014 at 3:05 AM, Iago Toral wrote:
>> On Mon, 2014-12-01 at 13:25 -0500, Ilia Mirkin wrote:
>>> On Mon, Dec 1, 2014 at 6:04 AM, Iago Toral Quiroga
>>> wrote:
>>> > _BaseFormat is a GLenum (unsigned int) so testing if its value
On 11/26/2014 06:09 PM, Dave Airlie wrote:
> Glamor is 4x faster on my ILK using glsl 130 at core text using
> x11perf -ftext.
>
> Ian started writing a spec for this extension a while back, which seems like
> most of the work, this patch seems to do enough, to advertise GLSL 1.30.
Yeah... I star
On Tue, Dec 02, 2014 at 04:17:35PM +, Neil Roberts wrote:
> Ok, I've written a somewhat contrived test case here:
>
> https://github.com/bpeel/glthing/tree/time-attribs
>
> (Make sure to use the time-attribs branch)
>
> The example draws a 1000 single-pixel points each with a separate draw
>
On Tue, Dec 2, 2014 at 3:50 AM, Kenneth Graunke wrote:
> The "Pixel Shader Computed Depth Mode" value is entirely based on the
> shader program, so we can easily do it at compile time. This avoids the
> if+switch on every 3DSTATE_WM (Gen7)/3DSTATE_PS_EXTRA (Gen8+) upload,
> and shares a bit more
On 12/02/2014 08:17 AM, Neil Roberts wrote:
> Ok, I've written a somewhat contrived test case here:
>
> https://github.com/bpeel/glthing/tree/time-attribs
>
> (Make sure to use the time-attribs branch)
>
> The example draws a 1000 single-pixel points each with a separate draw
> call. Each call u
https://bugs.freedesktop.org/show_bug.cgi?id=86939
Bug ID: 86939
Summary: test_vf_float_conversions.cpp:63:12: error: expected
primary-expression before ‘union’
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
On 12/02/2014 08:17 AM, Neil Roberts wrote:
> Ok, I've written a somewhat contrived test case here:
>
> https://github.com/bpeel/glthing/tree/time-attribs
>
> (Make sure to use the time-attribs branch)
>
> The example draws a 1000 single-pixel points each with a separate draw
> call. Each call u
Neil wrote:
> It might be worth making a simpler hard-coded implementation of
> quicksort because calling qsort is probably not very sensible for
> such a small array and the function call overhead for each
> comparison is probably quite a bit.
Ok, here is a v2 of the patch which has a simple cus
On Tue, Dec 2, 2014 at 3:51 AM, Kenneth Graunke wrote:
> We don't access brw->vertex_program or ctx->_Shader since the previous
> commit, so we don't need this dirty bit.
>
> I think it's still necessary on Gen6 because it still conflates
> constant uploading with unit state uploading. We can fix
https://bugs.freedesktop.org/show_bug.cgi?id=86939
Matt Turner changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=86939
Vinson Lee changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED
On 11/27/2014 10:56 AM, Kalyan Kondapally wrote:
> This patch adds support for following GLES2 Texture Float extensions:
> 1)GL_OES_texture_float,
> 2)GL_OES_texture_half_float,
> 3)GL_OES_texture_float_linear,
> 4)GL_OES_texture_half_float_linear.
>
> Support for these extensions need to be expli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=86939
---
src/mesa/drivers/dri/i965/test_vf_float_conversions.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/test_vf_float_conversions.cpp
b/src/mesa/drivers/dri/i965/test_vf_float_conversi
Reviewed-by: Ian Romanick
On 12/02/2014 11:24 AM, Matt Turner wrote:
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=86939
> ---
> src/mesa/drivers/dri/i965/test_vf_float_conversions.cpp | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i96
Signed-off-by: Jan Vesely
---
You were right, this one was leaking too.
src/gallium/drivers/r600/r600_llvm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/r600/r600_llvm.c
b/src/gallium/drivers/r600/r600_llvm.c
index 3a3ee3a..a928fb8 100644
--- a/src/gallium/drivers/r
On Tue, 2014-12-02 at 11:33 -0500, Tom Stellard wrote:
> On Mon, Nov 03, 2014 at 08:29:37PM -0500, Jan Vesely wrote:
> > Signed-off-by: Jan Vesely
> > ---
> >
> > moreover, the condition is never true now that clover appends dim info
> >
> > src/gallium/drivers/r600/evergreen_compute.c | 4
A slightly updated and extended series of the dri3/present fixes for Mesa i
sent last week.
Patch 1 and 2 are same as before. Patch 3 now has signed off by Frank Binns
and reviewed by Chris Wilson. Patch 4 and 5 are additional fixes. The last
one makes INTEL_swap_events behave properly again when
Prevent calls to glXGetSyncValuesOML() and glXWaitForMscOML()
from overwriting the (ust,msc) values of the last successfull
swapbuffers call (PresentPixmapCompleteNotify event), as
glXWaitForSbcOML() relies on those values corresponding to
the most recent completed swap, not to whatever was last
re
Restores proper immediate tearing swap behaviour for
OpenGL bufferswap under DRI3/Present.
Cc: "10.3 10.4"
v2: Add Frank Binns signed off by for his original earlier
patch from April 2014, which is identical to this one, and
Chris Wilsons reviewed tag from May 2014 for that patch, ergo
also for
The code for emitting INTEL_swap_events swap completion
events needs to translate from 32-Bit sbc on the wire to
64-Bit sbc for the events and handle wraparound accordingly.
It assumed that events would be sent by the server in the
order their corresponding swap requests were emitted from
the clie
targetSBC == 0 is a special case, which asks the function
to block until all pending OpenGL bufferswap requests have
completed.
Currently the function just falls through for targetSBC == 0,
returning bogus results.
This breaks applications originally written and tested against
DRI2 which also rel
glXSwapBuffersMscOML() with target_msc=divisor=remainder=0 gets
translated into target_msc=divisor=0 but remainder=1 by the mesa
api. This is done for server DRI2 where there needs to be a way
to tell the server-side DRI2ScheduleSwap implementation if a call
to glXSwapBuffers() or glXSwapBuffersMsc
Ian, Dave
My ILK is down at the moment, but I don't recall any problem with clip
distances. All that work landed in mesa-10.0, and at the time passed
all the relevant piglits (with 1.30 + EXT_gpu_shader4 hacked in for
entrypoints). The Gen4-5 VS currently lowers all user clipping to clip
distances
This way we get a warning when an enum value is not handled
Signed-off-by: Jan Vesely
---
src/gallium/state_trackers/clover/core/kernel.cpp | 45 ++-
1 file changed, 20 insertions(+), 25 deletions(-)
diff --git a/src/gallium/state_trackers/clover/core/kernel.cpp
b/src/galli
Mostly signed/unsigned comparison
Signed-off-by: Jan Vesely
---
src/gallium/state_trackers/xvmc/context.c | 6 +++---
src/gallium/state_trackers/xvmc/subpicture.c | 2 +-
src/gallium/state_trackers/xvmc/xvmc_private.h | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git
The set of variable defs does not need to be ordered in any way, and
removing/adding elements is a fairly common operation in various
optimization passes.
This shortens runtime of piglit test fp-long-alu to ~11s from ~22s
No piglit regressions observed on nvc0!
Signed-off-by: Tobias Klausmann
--
From: José Fonseca
Nowadays GCC assumes stack pointer is 16-byte aligned even on 32-bits,
but that is an assumption OpenGL drivers (or any dynamic library for
that matter) can affort to make as there are many closed- and open-
source application binaries out there that only assume 4-byte stack
al
On 11/28/2014 01:08 PM, Kalyan Kondapally wrote:
> This patch adds support for following GLES2 Texture Float extensions:
> 1)GL_OES_texture_float,
> 2)GL_OES_texture_half_float,
> 3)GL_OES_texture_float_linear,
> 4)GL_OES_texture_half_float_linear.
>
> If we are using GLES context and the driver h
Kenneth Graunke writes:
> This simply looks wrong - I don't see any code that uses _NEW_TRANSFORM
> or BRW_NEW_VERTEX_PROGRAM. It looks like the intention was to duplicate
> the brw_curbe_offsets atom's flags, which computes brw->curbe.vs_start.
> This is unnecessary - we flag BRW_NEW_CURBE_OFFS
On 12/01/2014 05:04 AM, Eduardo Lima Mitev wrote:
> In OpenGL and OpenGL-Es 3+, GL_DEPTH_STENCIL_ATTACHMENT is a valid attachment
> point for the family of functions
> that invalidate a framebuffer object (e.g, glInvalidateFramebuffer,
> glInvalidateSubFramebuffer, etc).
> Currently, a GL_INVALID
On 12/01/2014 05:04 AM, Eduardo Lima Mitev wrote:
> In GLES3, multisampling is not supported for signed and unsigned integer
> internal formats. See
> https://www.khronos.org/opengles/sdk/docs/man3/docbook4/xhtml/glGetInternalformativ.xml.
>
> Fixes 19 dEQP tests under
> 'dEQP-GLES3.functional.s
Ian Romanick writes:
> On 11/26/2014 06:09 PM, Dave Airlie wrote:
>> Glamor is 4x faster on my ILK using glsl 130 at core text using
>> x11perf -ftext.
>>
>> Ian started writing a spec for this extension a while back, which seems like
>> most of the work, this patch seems to do enough, to advert
On Tue, Dec 2, 2014 at 3:36 PM, Ian Romanick wrote:
> On 11/28/2014 01:08 PM, Kalyan Kondapally wrote:
>> This patch adds support for following GLES2 Texture Float extensions:
>> 1)GL_OES_texture_float,
>> 2)GL_OES_texture_half_float,
>> 3)GL_OES_texture_float_linear,
>> 4)GL_OES_texture_half_floa
On 12/01/2014 05:04 AM, Eduardo Lima Mitev wrote:
> The OpenGL ES Shading Language specification describes the
> values that may be output by a fragment shader. These are
> gl_FragColor and gl_FragData[0]. Multiple render targets
> are not supported in GLES.
>
> Fixes dEQP test:
> * dEQP-GLES3.f
On 12/01/2014 05:04 AM, Eduardo Lima Mitev wrote:
> From: Samuel Iglesias Gonsalvez
>
> GLSL ES 3.00 spec, chapter 4.6.1 "The Invariant Qualifier",
>
> Only variables output from a shader can be candidates for invariance. This
> includes user-defined output variables and the built-in out
On 12/02/2014 12:54 PM, Ian Romanick wrote:
> On 12/01/2014 05:04 AM, Eduardo Lima Mitev wrote:
>> From: Samuel Iglesias Gonsalvez
>>
>> GLSL ES 3.00 spec, chapter 4.6.1 "The Invariant Qualifier",
>>
>> Only variables output from a shader can be candidates for invariance.
>> This
>> inclu
On 12/01/2014 05:04 AM, Eduardo Lima Mitev wrote:
> From: Samuel Iglesias Gonsalvez
>
> From GLSL ES 3.0, chapter 4.3.7 "Interface Blocks", page 38:
>
> "GLSL ES 3.0 does not support interface blocks for shader inputs or outputs."
>
> and from GLSL ES 3.0, chapter 4.6.1 "The invariant qualifier
With Brian's suggested change to the commit message, this patch is
Reviewed-by: Ian Romanick
On 12/01/2014 05:04 AM, Eduardo Lima Mitev wrote:
> From: Samuel Iglesias Gonsalvez
>
> For OpenGL ES 3.0 spec, the minor number for SHADING_LANGUAGE_VERSION is
> always
> two digits, matching the Ope
Oof. I'd really like to have Ken review this code. He's the expert in
this area...
On 12/01/2014 05:04 AM, Eduardo Lima Mitev wrote:
> From: Samuel Iglesias Gonsalvez
>
> Create a new search function to look for matching built-in functions by name
> and use it for built-in function redefinitio
It would be nice if this could be added to the existing logic for the
interaction between builtins and app-provided overloads -- or do we
need to fail earlier than that?
- Chris
On Tue, Dec 2, 2014 at 2:04 AM, Eduardo Lima Mitev wrote:
> From: Samuel Iglesias Gonsalvez
>
> Create a new search f
On 12/02/2014 01:27 PM, Jose Fonseca wrote:
From: José Fonseca
Nowadays GCC assumes stack pointer is 16-byte aligned even on 32-bits,
but that is an assumption OpenGL drivers (or any dynamic library for
that matter) can affort to make as there are many closed- and open-
can or cannot?
affort
Nine code to match vertex declaration to vs inputs was limiting
the number of possible combinations.
Some sm3 games have issues with that, because arbitrary (usage/index)
can be used.
This patch does the following changes to fix the problem:
. Change the numbers given to (usage/index) combination
With sm3, you can declare an input/output with an usage and an usage index.
Nine code hardcodes the translation usage/index to a corresponding TGSI code.
The translation was limited to a few usage/index combinations that were
corresponding
to most of the needs of games, but some games did not wor
This is the behaviour that Wine tests
Tested-by: David Heidelberg
Signed-off-by: Axel Davy
---
src/gallium/state_trackers/nine/query9.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gallium/state_trackers/nine/query9.c
b/src/gallium/state_trackers/nine/query9.c
index f22e821..c87b
Issuing D3DISSUE_END should:
. reset previous queries if possible
. end the query
Previous behaviour wasn't calling end_query for
queries not needing D3DISSUE_BEGIN, no resetting
previous queries.
This fixes several applications not launching properly.
Cc: "10.4"
Tested-by: David Heidelberg
Si
Applications are supposed to call CreateQuery with a NULL
ppQuery to know if the query is supported. We supported that.
However when ppQuery was not NULL, we were accepting to create the
query and were creating a dummy query even when the query is not
supported.
Wine has different behaviour. This
Some queries need the driver to advertise a cap to be supported.
For example r300 doesn't support them.
v2 (David): check also for PIPE_CAP_QUERY_PIPELINE_STATISTICS, fix wine
tests on r300g
Reviewed-by: David Heidelberg
Signed-off-by: Axel Davy
---
src/gallium/state_trackers/nine/
get_query_result flushes automatically, we don't need to flush.
Signed-off-by: Axel Davy
---
src/gallium/state_trackers/nine/query9.c | 13 +
src/gallium/state_trackers/nine/query9.h | 1 -
2 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/src/gallium/state_trackers/nin
It is the same behaviour as wine has.
Reviewed-by: David Heidelberg
Signed-off-by: Axel Davy
---
src/gallium/state_trackers/nine/query9.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/gallium/state_trackers/nine/query9.c
b/src/gallium/state_trackers/nine/query9.c
Nine was allowing that behaviour, but was not filling the result.
Tested-by: David Heidelberg
Signed-off-by: Axel Davy
---
src/gallium/state_trackers/nine/query9.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/src/gallium/state_trackers/nine/query9.c
b/src/g
This is the behaviour that wine tests.
Reviewed-by: David Heidelberg
Signed-off-by: Axel Davy
---
src/gallium/state_trackers/nine/query9.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/gallium/state_trackers/nine/query9.c
b/src/gallium/state_trackers/nine/query9
On 12/02/2014 03:51 AM, Kenneth Graunke wrote:
> Commit c0347705 changed the Gen6-7 code to use ctx->_Shader rather than
> ctx->Shader, but neglected to change the Gen4-5 or Gen8+ code.
>
> This might fix SSO related bugs, but ALT mode is only used for ARB
> programs, so if there's an actual probl
This patch is
Reviewed-by: Ian Romanick
On 12/02/2014 03:51 AM, Kenneth Graunke wrote:
> We use IEEE mode for GLSL programs, but need to use ALT mode for ARB
> programs so that 0^0 == 1. The choice is based entirely on the shader
> source language.
>
> Previously, our code to determine which m
On Tue, Dec 2, 2014 at 4:12 PM, Axel Davy wrote:
> Some queries need the driver to advertise a cap to be supported.
> For example r300 doesn't support them.
>
> v2 (David): check also for PIPE_CAP_QUERY_PIPELINE_STATISTICS, fix wine
> tests on r300g
>
> Reviewed-by: David Heidelberg
>
On 02/12/14 21:10, Brian Paul wrote:
On 12/02/2014 01:27 PM, Jose Fonseca wrote:
From: José Fonseca
Nowadays GCC assumes stack pointer is 16-byte aligned even on 32-bits,
but that is an assumption OpenGL drivers (or any dynamic library for
that matter) can affort to make as there are many clos
On Tue, Dec 2, 2014 at 4:12 PM, Axel Davy wrote:
> Issuing D3DISSUE_END should:
> . reset previous queries if possible
> . end the query
>
> Previous behaviour wasn't calling end_query for
> queries not needing D3DISSUE_BEGIN, no resetting
noR resetting
> previous queries.
>
> This fixes several
On 12/02/2014 12:51 PM, Eric Anholt wrote:
> Ian Romanick writes:
>
>> On 11/26/2014 06:09 PM, Dave Airlie wrote:
>>> Glamor is 4x faster on my ILK using glsl 130 at core text using
>>> x11perf -ftext.
>>>
>>> Ian started writing a spec for this extension a while back, which seems like
>>> most o
With the very minor corrections I've mentioned earlier, series is
Reviwed-by: Ilia Mirkin
On Tue, Dec 2, 2014 at 4:12 PM, Axel Davy wrote:
> This is the behaviour that wine tests.
>
> Reviewed-by: David Heidelberg
> Signed-off-by: Axel Davy
> ---
> src/gallium/state_trackers/nine/query9.c | 7
https://bugs.freedesktop.org/show_bug.cgi?id=86944
Bug ID: 86944
Summary: glsl_parser_extras.cpp", line 1455: Error: Badly
formed expression.
Product: Mesa
Version: git
Hardware: x86 (IA32)
OS: Solaris
On 3 December 2014 at 07:32, Ian Romanick wrote:
> On 12/02/2014 12:51 PM, Eric Anholt wrote:
>> Ian Romanick writes:
>>
>>> On 11/26/2014 06:09 PM, Dave Airlie wrote:
Glamor is 4x faster on my ILK using glsl 130 at core text using
x11perf -ftext.
Ian started writing a spec fo
On Tuesday, December 02, 2014 09:26:38 AM Ian Romanick wrote:
> On 11/20/2014 05:19 PM, Kenneth Graunke wrote:
> > On Thursday, November 20, 2014 11:14:49 AM Ian Romanick wrote:
> >> From: Ian Romanick
> >>
> >> GL 3-ish versions of the spec are less clear that an error should be
> >> generated he
https://bugs.freedesktop.org/show_bug.cgi?id=86944
--- Comment #1 from Matt Turner ---
(In reply to Vinson Lee from comment #0)
> Build error with Oracle Studio.
>
> [snip useless warnings]
> "../../src/glsl/glsl_parser_extras.cpp", line 1455: Error: Badly formed
> expression.
I'm not sure what
https://bugs.freedesktop.org/show_bug.cgi?id=86944
--- Comment #2 from Matt Turner ---
Oh, I bet there's something wrong with the macro. I'd try removing the
typeof(*v) cast in src/util/u_atomic.h around line 173. If that fixes it, we
should remove those casts from p_atomic_inc_return and p_atomi
This patch implements ARB_pipeline_statistics_query. This addition to GL does
not add a new API. Instead, it adds new tokens to the existing query APIs. The
work to hook up the new tokens is trivial due to it's similarity to the previous
work done for the query APIs. I've implemented all the new to
Am 02.12.2014 um 21:51 schrieb Eric Anholt:
> Ian Romanick writes:
>
>> On 11/26/2014 06:09 PM, Dave Airlie wrote:
>>> Glamor is 4x faster on my ILK using glsl 130 at core text using
>>> x11perf -ftext.
>>>
>>> Ian started writing a spec for this extension a while back, which seems like
>>> most
From: Roland Scheidegger
Multiple scenes per context are meant to be used so a new scene can be built
while another one is processed in rasterization. However, quite surprisingly,
this does not actually work (and according to git log, possibly never did,
though maybe it did at some point further
On Tue, Dec 02, 2014 at 02:47:53PM -0500, Jan Vesely wrote:
> Signed-off-by: Jan Vesely
I've pushed this, thanks!
-Tom
> ---
>
> You were right, this one was leaking too.
>
> src/gallium/drivers/r600/r600_llvm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/gallium/drivers/r6
On 3 December 2014 at 08:46, Dave Airlie wrote:
> On 3 December 2014 at 07:32, Ian Romanick wrote:
>> On 12/02/2014 12:51 PM, Eric Anholt wrote:
>>> Ian Romanick writes:
>>>
On 11/26/2014 06:09 PM, Dave Airlie wrote:
> Glamor is 4x faster on my ILK using glsl 130 at core text using
On Tue, Dec 2, 2014 at 9:33 PM, Ben Widawsky
wrote:
> This patch implements ARB_pipeline_statistics_query. This addition to GL does
> not add a new API. Instead, it adds new tokens to the existing query APIs. The
> work to hook up the new tokens is trivial due to it's similarity to the
> previous
https://bugs.freedesktop.org/show_bug.cgi?id=86690
--- Comment #7 from Alexandre Courbot ---
Some more input about this oddity.
We are really waiting for fences here. During the freezes I can see the EGL
client looping in nouveau_fence_wait(), and displaying the fence sequence and
the highest si
On Tue, Dec 02, 2014 at 10:47:37PM -0500, Ilia Mirkin wrote:
> On Tue, Dec 2, 2014 at 9:33 PM, Ben Widawsky
> wrote:
> > This patch implements ARB_pipeline_statistics_query. This addition to GL
> > does
> > not add a new API. Instead, it adds new tokens to the existing query APIs.
> > The
> > wo
1 - 100 of 113 matches
Mail list logo
