On Tue, 2016-11-15 at 05:32 +0100, Vedran Miletić wrote:
> The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 broke 3.9 and older
> versions of LLVM for Clover. This patch restores it and refactors the
> support using Clover compatibility layer for LLVM.
>
> Signed-off-by: Vedran Miletić
> ---
>
On Mon, 2016-11-14 at 09:29 -0800, Jason Ekstrand wrote:
> On Mon, Nov 14, 2016 at 5:23 AM, Iago Toral Quiroga m> wrote:
> > According to the spec for vkGetPhysicalDeviceImageFormatProperties:
> >
> > "If format is not a supported image format, or if the combination
> > of format,
> > type, tili
From: Dave Airlie
Just noticed this by inspection, while trying to locate other
CTS failures. Don't think it fixes anything, but it might be
needed once I find the proper fix.
---
src/amd/common/ac_nir_to_llvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd/common/a
On Mon, 2016-11-14 at 20:05 -0800, Kenneth Graunke wrote:
> On Monday, November 7, 2016 11:49:13 AM PST Samuel Iglesias Gonsálvez
> wrote:
> > OpenGL ES 3.2 says in section 8.10. "TEXTURE PARAMETERS", at the
> > end of
> > the section:
> >
> > "An INVALID_ENUM error is generated if target is TEXTU
https://bugs.freedesktop.org/show_bug.cgi?id=98606
charlie changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=98606
--- Comment #10 from charlie ---
Solved
I think these are the minimum steps used to fix my bug:
1) delete all installed files (includes and libraries) related to libva,
libvdpau and mesa.
2) compile in the following order: mesa with "./configure
I think you're aware, but I actually have an updated version of this patch
on my branch. Let me know if you want me to send it out.
The issue is that the texture width/height need not be a multiple of the
format's block size. However mip sizes are computed based on that unrounded
size.
On Nov 14,
Should I push the ones you mark as r-b or wait for a separate go-ahead
based on CI results?
On Nov 14, 2016 8:45 PM, "Cherniak, Bruce" wrote:
> Reviewing/commenting on each patch individually. We’re also testing more
> thoroughly in our CI.
>
> In general, your help and interest in OpenSWR is v
All formats are supported by the gallivm texturing logic (except some
compressed ones). Swr backend only needs to know about the format for
rendering, not texturing. Makes sense to me just list the renderable ones
here.
If you want a reminder of which formats could be renderable but aren't, how
ab
The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 broke 3.9 and older
versions of LLVM for Clover. This patch restores it and refactors the
support using Clover compatibility layer for LLVM.
Signed-off-by: Vedran Miletić
---
.../state_trackers/clover/llvm/codegen/bitcode.cpp | 9 ++-
src/
On Monday, November 7, 2016 11:49:13 AM PST Samuel Iglesias Gonsálvez wrote:
> OpenGL ES 3.2 says in section 8.10. "TEXTURE PARAMETERS", at the end of
> the section:
>
> "An INVALID_ENUM error is generated if target is TEXTURE_2D_-
> MULTISAMPLE or TEXTURE_2D_MULTISAMPLE_ARRAY , and pname is any
>
This works for now, but totally agree with you, we need work attached to
fences. That’s been high on my list.
Reviewed-by: Bruce Cherniak
> On Nov 12, 2016, at 5:00 PM, Ilia Mirkin wrote:
>
> Rendering could still be ongoing (or have yet to start) when the shader
> is deleted. There's no ref
For book-keeping, to know which formats we have left to support/enable, we’d
like to leave the -1 entries. It’s a little clutter, but the sore thumb gets
the hammer.
> On Nov 12, 2016, at 5:00 PM, Ilia Mirkin wrote:
>
> Signed-off-by: Ilia Mirkin
> ---
> src/gallium/drivers/swr/swr_screen.cp
This one is going to take a bit more testing and internal review before
adopting.
> On Nov 12, 2016, at 5:00 PM, Ilia Mirkin wrote:
>
> This is a bit of a mega-commit, but unfortunately there's no great way
> to break this up since a lot of different pieces have to match up. Here
> we do the fo
This table lists all supported formats (both renderable and texturable).
swr_texture_layout calls mesa_to_swr_format to convert the PIPE_FORMAT_* to the
appropriate SWR_FORMAT enum. Removing these entries would result in -1
(unsupported format). We might need to add a “is_renderable” field to
Reviewed-by: Bruce Cherniak
> On Nov 12, 2016, at 5:00 PM, Ilia Mirkin wrote:
>
> The EXT_texture_integer test says that blending and alphatest should
> all be disabled. st/mesa takes care of alphatest already.
>
> Fixes the ext_texture_integer-fbo-blending piglit test.
>
> Signed-off-by: Ili
Reviewed-by: Bruce Cherniak
> On Nov 12, 2016, at 5:00 PM, Ilia Mirkin wrote:
>
> Fixes the texsubimage piglit and lets the copyteximage one get further.
>
> Signed-off-by: Ilia Mirkin
> ---
> src/gallium/drivers/swr/swr_context.cpp | 5 +++--
> src/gallium/drivers/swr/swr_screen.cpp | 5 +++
Doesn’t look as though shader stencil export (GL_ARB_shader_stencil_export)
would be too hard to implement, until then best to disable it.
Reviewed-by: Bruce Cherniak
> On Nov 12, 2016, at 5:00 PM, Ilia Mirkin wrote:
>
> Signed-off-by: Ilia Mirkin
> ---
> src/gallium/drivers/swr/swr_screen.c
Reviewed-by: Bruce Cherniak
> On Nov 12, 2016, at 5:00 PM, Ilia Mirkin wrote:
>
> Signed-off-by: Ilia Mirkin
> ---
> src/gallium/drivers/swr/.gitignore | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/gallium/drivers/swr/.gitignore
> b/src/gallium/drivers/swr/.gitignore
> inde
We need to run this through CI for all core users.
> On Nov 12, 2016, at 5:00 PM, Ilia Mirkin wrote:
>
> There's no guarantee that mip width/height will be a multiple of the
> compressed block size. Make sure to round up when dividing.
>
> Signed-off-by: Ilia Mirkin
> ---
>
> Note - I don't a
Reviewed-by: Bruce Cherniak
> On Nov 12, 2016, at 5:00 PM, Ilia Mirkin wrote:
>
> The support in swr requires shaders to output the components as UINTs.
> This is not how GL or Gallium work, and since this is not a
> required-renderable format, just leave it out.
>
> Signed-off-by: Ilia Mirkin
Reviewed-by: Bruce Cherniak
> On Nov 12, 2016, at 5:00 PM, Ilia Mirkin wrote:
>
> Signed-off-by: Ilia Mirkin
> ---
> src/gallium/drivers/swr/swr_state.cpp | 20 +++-
> 1 file changed, 15 insertions(+), 5 deletions(-)
>
> diff --git a/src/gallium/drivers/swr/swr_state.cpp
> b/s
Reviewed-by: Bruce Cherniak
> On Nov 12, 2016, at 5:00 PM, Ilia Mirkin wrote:
>
> In a BGR10X2 or BGR5X1 situation, there's no need to try to quantize the
> X channel - the default will have the proper quantization required.
>
> Signed-off-by: Ilia Mirkin
> ---
> src/gallium/drivers/swr/raste
Reviewed-by: Bruce Cherniak
> On Nov 12, 2016, at 5:00 PM, Ilia Mirkin wrote:
>
> Noticed by inspection.
>
> Signed-off-by: Ilia Mirkin
> ---
>
> Entirely untested. Just happened to jump out at me that the two tiling modes
> didn't match, whereas every other instance in this file matches.
>
Reviewing/commenting on each patch individually. We’re also testing more
thoroughly in our CI.
In general, your help and interest in OpenSWR is very much appreciated!
> On Nov 12, 2016, at 5:00 PM, Ilia Mirkin wrote:
>
> This is a bit of a hodge-podge, but largely related to improving text
Reviewed-by: Bruce Cherniak
> On Nov 12, 2016, at 5:00 PM, Ilia Mirkin wrote:
>
> This is the format used for the primary surface of a
> PIPE_FORMAT_Z32_FLOAT_S8X24_UINT resource.
>
> Signed-off-by: Ilia Mirkin
> ---
> src/gallium/drivers/swr/rasterizer/memory/LoadTile.h | 1 +
> src/gallium
https://bugs.freedesktop.org/show_bug.cgi?id=77662
Nanley Chery changed:
What|Removed |Added
Summary|[SNB] fail to render to |Fail to render to different
https://bugs.freedesktop.org/show_bug.cgi?id=77662
Nanley Chery changed:
What|Removed |Added
Version|10.1|13.0
Assignee|i...@freedesktop.
ARB_enhanced_layouts only requires component qualifier support for
generic varyings, so this is all the vec4 backend knew how to handle.
This patch extends the backend to handle it for all varyings, so we
can use store_output intrinsics with a component set for things like
clip/cull distances. We
This also allows us to move it from a GL specific location to a
part of the compiler shared by both GL and Vulkan.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_gs.c| 4
src/mesa/drivers/dri/i965/brw_shader.cpp | 4
src/mesa/drivers/dri/i965/
Certain built-in arrays, such as gl_ClipDistance[], gl_CullDistance[],
gl_TessLevelInner[], and gl_TessLevelOuter[] are specified as scalar
arrays. Normal scalar arrays are sparse - each array element usually
occupies a whole vec4 slot. However, most hardware assumes these
built-in arrays are tig
The old approach works fine, and this approach isn't necessarily better.
But it at least has the advantage that Vulkan and GL use the same
approach. I originally wrote it to gain additional testing for the
new paths.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_compiler.c |
Signed-off-by: Kenneth Graunke
---
src/compiler/spirv/spirv_to_nir.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/compiler/spirv/spirv_to_nir.c
b/src/compiler/spirv/spirv_to_nir.c
index 9c5d331..5ff09c9 100644
--- a/src/compiler/spirv/spirv_to_nir.c
+++ b/src/compi
Everything is now in place, and we appear to pass the tests on Gen7+.
Signed-off-by: Kenneth Graunke
---
src/intel/vulkan/anv_device.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
index 0999fcf..2516f
Signed-off-by: Kenneth Graunke
---
src/intel/vulkan/anv_pipeline.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c
index bdc2f01..ab268c6 100644
--- a/src/intel/vulkan/anv_pipeline.c
+++ b/src/intel/vulkan/anv_pipeline.c
@@
We need to calculate the number of vec4 slots correctly.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_fs.h | 2 +-
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.h
b/src
Signed-off-by: Kenneth Graunke
---
src/compiler/nir_types.cpp | 6 ++
src/compiler/nir_types.h | 1 +
2 files changed, 7 insertions(+)
diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp
index 5b04e18..cc90efd 100644
--- a/src/compiler/nir_types.cpp
+++ b/src/compiler/nir_
Hello,
This series adds support for clip/cull distances in the Intel Vulkan
driver. It works a little differently than how we did it in OpenGL.
In GL, we have a pass that combines both float[] arrays into a single
vec4[2] variable. Drivers see a vec4[2] with swizzles and writemasks.
The pass is
This isn't useful for legacy GL, but will be used in Vulkan.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_compiler.h | 1 +
src/mesa/drivers/dri/i965/brw_shader.cpp | 2 ++
src/mesa/drivers/dri/i965/brw_vec4.cpp| 2 ++
src/mesa/drivers/dri/i965/b
We switched from a boolean to array lengths in gl_program a while back.
Signed-off-by: Kenneth Graunke
---
src/compiler/glsl/glsl_to_nir.cpp | 4 ++--
src/compiler/shader_info.h| 7 +--
src/mesa/program/prog_to_nir.c| 3 ++-
3 files changed, 9 insertions(+), 5 deletions(-)
diff
We weren't taking first_component into account when handling GS push
inputs. We hardly ever push GS inputs, so this was not caught by
existing tests. When I started using component qualifiers for the
gl_ClipDistance arrays, glsl-1.50-transform-feedback-type-and-size
started catching this.
Cc: "1
Signed-off-by: Kenneth Graunke
---
src/compiler/Makefile.sources | 1 +
src/compiler/nir/nir.h | 1 +
.../nir/nir_lower_clip_cull_distance_arrays.c | 187 +
3 files changed, 189 insertions(+)
create mode 100644 src/com
Signed-off-by: Kenneth Graunke
---
src/intel/vulkan/anv_private.h| 18 ++
src/intel/vulkan/gen8_pipeline.c | 15 ---
src/intel/vulkan/genX_pipeline_util.h | 5 +
3 files changed, 31 insertions(+), 7 deletions(-)
diff --git a/src/intel/vulkan/anv_priv
On Sun, Nov 13, 2016 at 11:58 PM, A223 A223 wrote:
> Hello,
>
> I was curious if there are any near/medium-term plans to add compute
> shader support to the following:
>
> llvmpipe?
> openswr?
CCing Ilia Mirkin, as I feel you may know something about this for
SWR... Thank you.
___
On Mon, Nov 14, 2016 at 11:10 AM, Ilia Mirkin wrote:
> On Mon, Nov 14, 2016 at 1:53 PM, A223 A223 wrote:
>> On Mon, Nov 14, 2016 at 10:37 AM, Ilia Mirkin wrote:
>>> My guess is that it can just be flipped on. You can force-enable it
>>> with MESA_EXTENSION_OVERRIDE=GL_ARB_copy_image to see if it
On Mon, Nov 14, 2016 at 10:37 AM, Ilia Mirkin wrote:
> My guess is that it can just be flipped on. You can force-enable it
> with MESA_EXTENSION_OVERRIDE=GL_ARB_copy_image to see if it works.
This does indeed get rid of the error. I'm still getting a white clear
color in my OpenGL application, an
Hello,
I was curious if there are any near/medium-term plans to add compute
shader support to the following:
llvmpipe?
openswr?
Thanks!
Andrew
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa
My application requires PIPE_CAP_MIXED_COLORBUFFER_FORMATS and I
noticed that it is not enabled for softpipe. I hardcoded it to be
turned on and did not notice any ill effects so far.
Is it necessary that PIPE_CAP_MIXED_COLORBUFFER_FORMATS be disabled
for softpipe?
Is there any possibility that SWR will see GL_ARB_copy_image support
sometime soon?
Thanks,
Andrew
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
There is no functionality in swr to clamp either vertex or frag colors.
This could be added in swr_shader, at which point these could be
re-enabled.
Fixes arb_color_buffer_float-render
Signed-off-by: Ilia Mirkin
---
src/gallium/drivers/swr/swr_screen.cpp | 5 +++--
1 file changed, 3 insertions(
Fixes gl-3.2-basevertex-vertexid
Signed-off-by: Ilia Mirkin
---
src/gallium/drivers/swr/swr_state.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/swr/swr_state.cpp
b/src/gallium/drivers/swr/swr_state.cpp
index 2c7f3be..8038ef5 100644
--- a/src/gallium/drivers/swr/swr
Fixes glsl-arb-fragment-coord-conventions.
Signed-off-by: Ilia Mirkin
---
src/gallium/drivers/swr/swr_shader.cpp | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/swr/swr_shader.cpp
b/src/gallium/drivers/swr/swr_shader.cpp
index f639df3..e4f9796
From: Eduardo Lima Mitev
This option was being ignored when packing compressed 3D and cube textures.
Fixes CTS test (on gen8+):
* GL45-CTS.gtf32.GL3Tests.packed_pixels.packed_pixels_pixelstore
v2: Drop API checks.
v3 (Ken): Just apply the existing code in more cases.
---
src/mesa/drivers/commo
A long time ago, patch authors were tasked with cherry-picking their
patches to stable branches. Today we Cc
mesa-sta...@lists.freedesktop.org and Emil rebases those patches onto
stable. Cc'ing the list happens even on patches sent for their first
review that are ultimately rejected, creating a lot
On 10/11/16 17:27, Kyriazis, George wrote:
-Original Message-
From: Emil Velikov [mailto:emil.l.veli...@gmail.com]
Sent: Thursday, November 10, 2016 8:14 AM
To: Kyriazis, George
Cc: ML mesa-dev
Subject: Re: [Mesa-dev] [PATCH v2 6/8] gallium: Enable swr driver
"gallium/targets: scons
On Mon, 2016-11-14 at 08:46 -0800, Jason Ekstrand wrote:
>
>
> On Sat, Nov 12, 2016 at 2:54 PM, Timothy Arceri bora.com> wrote:
> > On Sat, 2016-11-12 at 13:34 -0800, Jason Ekstrand wrote:
> >
> > I have two questions and two suggestions below.
> >
> > With the suggestions addressed and assum
On Mon, Nov 14, 2016 at 1:48 PM, A223 A223 wrote:
> On Sun, Nov 13, 2016 at 11:58 PM, A223 A223 wrote:
>> Hello,
>>
>> I was curious if there are any near/medium-term plans to add compute
>> shader support to the following:
>>
>> llvmpipe?
>> openswr?
>
> CCing Ilia Mirkin, as I feel you may know
On Mon, Nov 14, 2016 at 1:53 PM, A223 A223 wrote:
> On Mon, Nov 14, 2016 at 10:37 AM, Ilia Mirkin wrote:
>> My guess is that it can just be flipped on. You can force-enable it
>> with MESA_EXTENSION_OVERRIDE=GL_ARB_copy_image to see if it works.
>
> This does indeed get rid of the error. I'm stil
My guess is that it can just be flipped on. You can force-enable it
with MESA_EXTENSION_OVERRIDE=GL_ARB_copy_image to see if it works.
Cheers,
-ilia
On Mon, Nov 14, 2016 at 1:34 PM, A223 A223 wrote:
> Is there any possibility that SWR will see GL_ARB_copy_image support
> sometime soon?
>
> T
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Sat, Nov 12, 2016 at 1:35 PM Jason Ekstrand wrote:
> This series started off as me thinking that we should set the correct
> sampler and binding table entry counts because maybe caching those things
> would improve performance. Then it turned into spring cleaning. The end
> result is that ge
It seems like this still doesn't quite fix things - have a look at
fbo-mrt-alphatest in piglit. I had assumed this change would do the
trick, but no such luck.
On Wed, Nov 9, 2016 at 10:18 PM, Tim Rowley wrote:
> Alpha from render target 0 should always be used for alpha test for all
> render tar
Serge Martin writes:
> On Sunday 30 October 2016 16:07:25 Francisco Jerez wrote:
>> Serge Martin writes:
>> > ---
>> >
>> > src/gallium/state_trackers/clover/api/kernel.cpp | 47
>> > --
>> > src/gallium/state_trackers/clover/core/kernel.cpp | 6 +++
>> > src/gallium/state
On 11/14/2016 06:53 PM, Ilia Mirkin wrote:
On Mon, Nov 14, 2016 at 12:39 PM, Samuel Pitoiset
wrote:
On 11/10/2016 03:42 AM, Ilia Mirkin wrote:
Signed-off-by: Ilia Mirkin
---
v1 -> v2:
Move to handling this at SSA time. This is a lot more fragile since the
texture arguments have been
On Mon, Nov 14, 2016 at 12:39 PM, Samuel Pitoiset
wrote:
>
>
> On 11/10/2016 03:42 AM, Ilia Mirkin wrote:
>>
>> Signed-off-by: Ilia Mirkin
>> ---
>>
>> v1 -> v2:
>> Move to handling this at SSA time. This is a lot more fragile since the
>> texture arguments have been reordered already, but it
On Mon, Nov 14, 2016 at 05:26:09PM +, Lionel Landwerlin wrote:
> A commit from the CTS suite on the 1.0-dev branch started using
> VK_REMAINING_MIP_LEVELS, we're not dealing with it properly for clears.
>
> Fixes:
>dEQP-VK.api.image_clearing.clear_color_image.*
>
> Signed-off-by: Lionel L
Ilia Mirkin writes:
> On Mon, Nov 14, 2016 at 6:55 AM, Lionel Landwerlin
> wrote:
>> On 11/11/16 18:39, Ilia Mirkin wrote:
>>> On Fri, Nov 11, 2016 at 10:40 AM, Lionel Landwerlin
>>> wrote:
diff --git a/src/mesa/main/extensions_table.h
b/src/mesa/main/extensions_table.h
index 2d
On 11/10/2016 03:42 AM, Ilia Mirkin wrote:
Signed-off-by: Ilia Mirkin
---
v1 -> v2:
Move to handling this at SSA time. This is a lot more fragile since the
texture arguments have been reordered already, but it's still easy enough
to find the LOD argument.
.../nouveau/codegen/nv50_ir_l
Jan Vesely writes:
> On Mon, 2016-11-14 at 12:17 +0100, Vedran Miletić wrote:
>> ---
>> src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp | 10 --
>> 1 file changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp
>
https://bugs.freedesktop.org/show_bug.cgi?id=98595
--- Comment #12 from Brian Paul ---
(In reply to Jonathan Gray from comment #11)
> The proposed fix stops the assertion for me.
>
> With i965 I now hit a different problem that seems to be unrelated, the
> (OpenBSD) kernel logs
> error: [drm:pid
Also, please Cc stable
On Mon, Nov 14, 2016 at 9:29 AM, Jason Ekstrand
wrote:
> On Mon, Nov 14, 2016 at 5:23 AM, Iago Toral Quiroga
> wrote:
>
>> According to the spec for vkGetPhysicalDeviceImageFormatProperties:
>>
>> "If format is not a supported image format, or if the combination of
>> for
Thanks!
Reviewed-by: Jason Ekstrand
Cc: "13.0"
On Mon, Nov 14, 2016 at 9:26 AM, Lionel Landwerlin
wrote:
> A commit from the CTS suite on the 1.0-dev branch started using
> VK_REMAINING_MIP_LEVELS, we're not dealing with it properly for clears.
>
> Fixes:
>dEQP-VK.api.image_clearing.clear
I don't see a problem here
Reviewed-by: Jason Ekstrand
On Mon, Nov 14, 2016 at 6:10 AM, Lionel Landwerlin <
lionel.g.landwer...@intel.com> wrote:
> Sounds good too.
>
> Reviewed-by: Lionel Landwerlin
>
> On 14/11/16 13:23, Iago Toral Quiroga wrote:
>
>> Fixes dEQP-VK.api.image_clearing.clear_c
On Mon, Nov 14, 2016 at 5:23 AM, Iago Toral Quiroga
wrote:
> According to the spec for vkGetPhysicalDeviceImageFormatProperties:
>
> "If format is not a supported image format, or if the combination of
> format,
> type, tiling, usage, and flags is not supported for images, then
> vkGetPhysicalD
On Mon, Nov 14, 2016 at 2:46 AM, Timothy Arceri <
timothy.arc...@collabora.com> wrote:
> On Sat, 2016-11-12 at 13:34 -0800, Jason Ekstrand wrote:
> > ---
> > src/intel/blorp/blorp_genX_exec.h | 4 ++--
> > src/intel/genxml/gen6.xml | 16 +---
> > src/intel/genxml/gen7.xml
A commit from the CTS suite on the 1.0-dev branch started using
VK_REMAINING_MIP_LEVELS, we're not dealing with it properly for clears.
Fixes:
dEQP-VK.api.image_clearing.clear_color_image.*
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_blorp.c | 4 ++--
1 file changed, 2 insertio
Vinson Lee writes:
> Check for Clang before GCC.
>
> Clang defines __GNUC__ == 4 and __GNUC_MINOR__ == 2 and matches the GCC
> check but not the GCC version for trivial destructor.
>
> Fixes: 98ab905af0e0 ("mesa: Define introspection macro to determine
> whether a type is trivially destructible."
On Mon, Nov 14, 2016 at 2:35 AM, Timothy Arceri <
timothy.arc...@collabora.com> wrote:
> On Sat, 2016-11-12 at 13:34 -0800, Jason Ekstrand wrote:
>
> In this patch we no longer do:
>
> ps.RenderTargetResolveEnable = false;
>
> It would be nice to be consistent and either initialise everything or
The validation of the default in layout qualifier already assures that
we won't have 2 ast_gs_input_layout objects with different primitive
type values. In fact, the validation already assures that we won't
have 2 ast_gs_input_layout objects in the AST tree at all.
The check for an error in the sh
This reverts commit aaa69c79cd584db4d9c6ea7794e93d29f3d54572.
The commit was erroneous because the ast_layout_expression class is
meant to hold a list used for an after check that all the declared
values for a layout-qualifier-name are consistent.
Therefore, the check for the possibility of dupli
The merge into the default in layout qualifier duplicates a lot of
code that can be reused from the generic merge method.
Now, we use the generic merge method inside the specific merge for the
default in layout qualifier. The generic merge method has been
completed with some bits that were only pr
Since we modified the way in which multiple repetitions of the same
layout-qualifier-name in a single declaration collapse into the
ast_type_qualifier class, we can simplify the
merge_into_[in|out]_qualifier APIs through removing the create_node
parameter.
Signed-off-by: Andres Gomez
---
src/com
Consider this example:
" #version 150 core
#extension GL_ARB_shading_language_420pack: require
#extension GL_ARB_explicit_attrib_location: require
layout(location=0) out vec4 o;
layout(binding=2) layout(binding=3, std140) uniform U {
vec4 a;
} u[2];"
A
This reverts commit 4c863993780a11cea6f88fa0682796bee5794042.
The commit was erroneous because the ast_layout_expression class was
created to hold a list of values for a layout-qualifier-name which is
allowed to appear in more than one expression in the same
shader/program but not to hold differen
The GLSL parser has been simplified to check for the needed
GL_ARB_shading_language_420pack extension just when merging the
qualifiers in the proper cases.
Reviewed-by: Timothy Arceri
Signed-off-by: Andres Gomez
---
src/compiler/glsl/ast_type.cpp | 6 ++
src/compiler/glsl/glsl_parser.yy
Currently, the default in layout qualifier merge performs specific
validation and merge.
We want to split out the validation from the merge so they can be done
independently.
Additionally, for simplification, the direction of the validation and
merge is changed so the ast_type_qualifier calling t
After the previous modifications in the merging of the
layout-qualifier-name values, we no longer push the final value in a
declaration to the global values.
This regression happens because we don't call for merging on the
right-most layout qualifier of a declaration which is also the
overriding o
In the case of layout-qualifier-names that can appear multiple times
in different declarations of the same shader or, even, the same
program, but that have to consistently hold the same value we are
using the ast_layout_expression class which holds a list to store all
the appearances to be able to
The point mode value in an ast_type_qualifier can only be true if the
flag is already set since this layout-id-qualifier can only be or not
be present in a shader.
Hence, it is useless to check for its value if the flag is already
set. However, for coherence and compatibility with future changes w
Currently, the default out layout qualifier merge performs specific
validation and merge.
We want to split out the validation from the merge so they can be done
independently.
Additionally, for simplification, the direction of the validation and
merge is changed so the ast_type_qualifier calling
From page 46 (page 52 of the PDF) of the GLSL 4.20 spec:
" More than one layout qualifier may appear in a single
declaration. If the same layout-qualifier-name occurs in multiple
layout qualifiers for the same declaration, the last one overrides
the former ones."
Consider this examp
When a layout contains a duplicated layout-qualifier-name in a single
declaration, only the last occurrence should be taken into account.
From page 59 (page 65 of the PDF) of the GLSL 4.40 spec:
" More than one layout qualifier may appear in a single
declaration. Additionally, the same layo
On Sat, Nov 12, 2016 at 2:54 PM, Timothy Arceri <
timothy.arc...@collabora.com> wrote:
> On Sat, 2016-11-12 at 13:34 -0800, Jason Ekstrand wrote:
>
> I have two questions and two suggestions below.
>
> With the suggestions addressed and assuming the answer to both
> questions is yes, Patch 7-8 are
On Mon, 2016-11-14 at 12:17 +0100, Vedran Miletić wrote:
> ---
> src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp | 10 --
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp
> b/src/gallium/state_tracker
On Thu, 2016-11-10 at 16:53 -0800, Jason Ekstrand wrote:
> When Kristian reworked descriptor set allocation, somehow he forgot
> to
> actually store the offset in the free list. Somehow, this completely
> missed CTS testing until now... This fixes all 2744 of the new
> 'dEQP-VK.texture.filtering.*
On 11/14/2016 04:49 PM, Tom Stellard wrote:
> On Mon, Nov 14, 2016 at 01:44:18PM +0100, Dieter Nützel wrote:
>> Tested-by: Dieter Nützel
>>
>> Thanks Vedran!
>>
>
> Pushed, thanks!
>
> -Tom
>
Thank you!
Vedran
--
Vedran Miletić
vedran.miletic.net
On Mon, Nov 14, 2016 at 01:44:18PM +0100, Dieter Nützel wrote:
> Tested-by: Dieter Nützel
>
> Thanks Vedran!
>
Pushed, thanks!
-Tom
> Dieter
>
> Am 14.11.2016 12:17, schrieb Vedran Miletić:
> > ---
> > src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp | 10
> > --
> > 1 fi
On 14 November 2016 at 11:49, Liu Zhiquan wrote:
> mesa android path didn't support pbuffer, so add pbuffer support to
> fix most deqp and cts pbuffer test cases fail;
> add support of front buffer and single buffer config.
>
> Test status: android CTS EGL pbuffer test can run without native crash
On Mon, Nov 14, 2016 at 6:55 AM, Lionel Landwerlin
wrote:
> On 11/11/16 18:39, Ilia Mirkin wrote:
>> On Fri, Nov 11, 2016 at 10:40 AM, Lionel Landwerlin
>> wrote:
>>> diff --git a/src/mesa/main/extensions_table.h
>>> b/src/mesa/main/extensions_table.h
>>> index 2dbd7da..f58f2ad 100644
>>> --- a/
Sounds good too.
Reviewed-by: Lionel Landwerlin
On 14/11/16 13:23, Iago Toral Quiroga wrote:
Fixes dEQP-VK.api.image_clearing.clear_color_image.1d_r8g8b8_srgb
---
src/intel/vulkan/anv_formats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_formats.
1 - 100 of 126 matches
Mail list logo
