Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

2016-09-01 Thread Christian König
Am 02.09.2016 um 04:03 schrieb Michel Dänzer: On 02/09/16 10:17 AM, Michel Dänzer wrote: On 02/09/16 12:58 AM, Leo Liu wrote: On 09/01/2016 11:54 AM, Nayan Deshmukh wrote: I saw the code in dri3_glx.c and I could somewhat relate some basic code structure to the vl_winsys_dri3.c. But I am new t

Re: [Mesa-dev] [PATCH 09/12] intel/blorp: Allow single slice converter to suppress number of layers

2016-09-01 Thread Jason Ekstrand
On Thu, Sep 1, 2016 at 10:55 PM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Thu, Sep 01, 2016 at 08:40:52AM -0700, Jason Ekstrand wrote: > >We're not doing layered blits yet are we? Perhaps this can wait until > >then? > > No but as previous patch stops suppressing number

Re: [Mesa-dev] [PATCH 09/12] intel/blorp: Allow single slice converter to suppress number of layers

2016-09-01 Thread Pohjolainen, Topi
On Thu, Sep 01, 2016 at 08:40:52AM -0700, Jason Ekstrand wrote: >We're not doing layered blits yet are we? Perhaps this can wait until >then? No but as previous patch stops suppressing number of layers in brw_blorp_surface_info_init() unonditionally these asserts will start to fire. This

Re: [Mesa-dev] [PATCH 01/12] i965/rbc: Allow integer formats as advertised in isl_format.c

2016-09-01 Thread Pohjolainen, Topi
On Thu, Sep 01, 2016 at 02:33:48PM -0700, Jason Ekstrand wrote: >On Wed, Aug 31, 2016 at 8:17 AM, Topi Pohjolainen ><[1]topi.pohjolai...@intel.com> wrote: > > From: Topi Pohjolainen <[2]topi.pohjolai...@gmail.com> > Blorp consults brw_is_color_fast_clear_compatible() to see if an

Re: [Mesa-dev] [PATCH] Android: glsl: add rules to generate ir_expression*.h header files

2016-09-01 Thread Tapani Pälli
Hi; Thanks, I was trying to work on the same issue but did not quite get it working .. will test this one with N build. FYI this patch contains both of these (which I believe were issues already before mentioned changes, just somehow revealed only with N build?): https://patchwork.freedeskt

Re: [Mesa-dev] [Mesa-announce] Mesa 12.0.2 release candidate

2016-09-01 Thread Michel Dänzer
On 01/09/16 11:25 PM, Emil Velikov wrote: > Hello list, > > The candidate for the Mesa 12.0.2 is now available. Currently we have: > - 160 queued > - 9 nominated (outstanding) > - and 1 rejected patches [...] > Mesa stable queue > - > > Nominated (9) > = [...] > M

Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

2016-09-01 Thread Michel Dänzer
On 02/09/16 10:17 AM, Michel Dänzer wrote: > On 02/09/16 12:58 AM, Leo Liu wrote: >> On 09/01/2016 11:54 AM, Nayan Deshmukh wrote: >>> >>> I saw the code in dri3_glx.c and I could somewhat relate some basic >>> code structure to the vl_winsys_dri3.c. But I am new to this and not aware >>> of the >

[Mesa-dev] [PATCH] a4xx: make sure to actually clamp depth as requested

2016-09-01 Thread Ilia Mirkin
We were previously ... not clamping. I guess this meant that everything got clamped to 1/0, which was enough to pass the existing tests. Or perhaps the clamping would only happen to the rasterized depth value and not the frag shader's output depth value. Bugzilla: https://bugs.freedesktop.org/show

Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

2016-09-01 Thread Michel Dänzer
On 02/09/16 12:58 AM, Leo Liu wrote: > On 09/01/2016 11:54 AM, Nayan Deshmukh wrote: >> Hi Leo, >> >> I saw the code in dri3_glx.c and I could somewhat relate some basic >> code structure to the vl_winsys_dri3.c. But I am new to this and not aware >> of the >> terminology that you used about the b

Re: [Mesa-dev] [PATCH] loader/dri3: Overhaul dri3_update_num_back

2016-09-01 Thread Michel Dänzer
On 02/09/16 12:37 AM, Alex Deucher wrote: > On Thu, Sep 1, 2016 at 11:28 AM, Jason Ekstrand wrote: >> On Aug 31, 2016 11:39 PM, "Michel Dänzer" wrote: >>> On 01/09/16 02:05 PM, Jason Ekstrand wrote: On Wed, Aug 31, 2016 at 7:00 PM, Michel Dänzer >>> > wrote: >

Re: [Mesa-dev] [PATCH 07/12] anv/image: Memset hiz surfaces to 0 when binding memory

2016-09-01 Thread Jason Ekstrand
On Wed, Aug 31, 2016 at 8:29 PM, Nanley Chery wrote: > From: Jason Ekstrand > > Nanley Chery (amend): > - Change memset value from 0xff to 0 (a defined value for HiZ). > > Signed-off-by: Nanley Chery > --- > src/intel/vulkan/anv_image.c | 18 +- > 1 file changed, 17 insertions

Re: [Mesa-dev] [PATCH 1/2] nir/dead_cf: Don't crash on unreachable after-loop blocks

2016-09-01 Thread Connor Abbott
On Thu, Sep 1, 2016 at 6:19 PM, Jason Ekstrand wrote: > On Thu, Sep 1, 2016 at 12:41 PM, Connor Abbott wrote: >> >> As-is, this change will make us delete trivially infinite loops (i.e. >> loops with no break statement). The most likely scenario where we get >> one of those (besides for silly Pig

Re: [Mesa-dev] [PATCH 1/2] nir/dead_cf: Don't crash on unreachable after-loop blocks

2016-09-01 Thread Matt Turner
On Thu, Sep 1, 2016 at 3:19 PM, Jason Ekstrand wrote: > On Thu, Sep 1, 2016 at 12:41 PM, Connor Abbott wrote: >> >> As-is, this change will make us delete trivially infinite loops (i.e. >> loops with no break statement). The most likely scenario where we get >> one of those (besides for silly Pig

Re: [Mesa-dev] [PATCH 1/2] nir/dead_cf: Don't crash on unreachable after-loop blocks

2016-09-01 Thread Jason Ekstrand
On Thu, Sep 1, 2016 at 12:41 PM, Connor Abbott wrote: > As-is, this change will make us delete trivially infinite loops (i.e. > loops with no break statement). The most likely scenario where we get > one of those (besides for silly Piglit tests) is a developer with an > accidental bug in their sh

Re: [Mesa-dev] [PATCH 04/12] anv: Add func anv_image_has_hiz()

2016-09-01 Thread Jason Ekstrand
On Wed, Aug 31, 2016 at 8:29 PM, Nanley Chery wrote: > From: Chad Versace > > Nanley Chery (amend): > - Remove wip! tag > > Signed-off-by: Nanley Chery > --- > src/intel/vulkan/anv_private.h | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/src/intel/vulkan/anv_private.h b/

Re: [Mesa-dev] [PATCH 01/12] i965/rbc: Allow integer formats as advertised in isl_format.c

2016-09-01 Thread Jason Ekstrand
On Wed, Aug 31, 2016 at 8:17 AM, Topi Pohjolainen < topi.pohjolai...@intel.com> wrote: > From: Topi Pohjolainen > > Blorp consults brw_is_color_fast_clear_compatible() to see if any > restrictions apply for fast clear in addition to the capablities > advertised in isl_format.c::format_info[]. On

Re: [Mesa-dev] i965: Hardware assisted layered clears

2016-09-01 Thread Jason Ekstrand
Patches 7-12 are Reviewed-by: Jason Ekstrand On Wed, Aug 31, 2016 at 8:17 AM, Topi Pohjolainen < topi.pohjolai...@intel.com> wrote: > This series requests hardware to generate as many copies of drawing > primitives as there are layers to be cleared instead of submitting > separate render passes

[Mesa-dev] [Bug 97569] [swrast] piglit getteximage-formats regression

2016-09-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97569 Bug ID: 97569 Summary: [swrast] piglit getteximage-formats regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Keyw

[Mesa-dev] [Bug 97566] [dri3] The frame of a window and its open gl content are out of sync.

2016-09-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97566 --- Comment #1 from Manuel Schneider --- I forgot to mention that this bug seems to affect only Intel. The few people I talked to in irc that did not encouter this problem had radeon or nvidia drivers. Further in a vm (virtualbox) chromium is c

[Mesa-dev] [Bug 97566] [dri3] The frame of a window and its open gl content are out of sync.

2016-09-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97566 Chris Wilson changed: What|Removed |Added Summary|The frame of a window and |[dri3] The frame of a |

[Mesa-dev] [Bug 97566] The frame of a window and its open gl content are out of sync.

2016-09-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97566 Chris Wilson changed: What|Removed |Added QA Contact|intel-gfx-bugs@lists.freede |mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH 1/2] nir/dead_cf: Don't crash on unreachable after-loop blocks

2016-09-01 Thread Connor Abbott
As-is, this change will make us delete trivially infinite loops (i.e. loops with no break statement). The most likely scenario where we get one of those (besides for silly Piglit tests) is a developer with an accidental bug in their shader. In that case, it seems kinda mean to then delete the entir

Re: [Mesa-dev] [PATCH 03/12] isl/gen8+: Allow 3D auxiliary surfaces

2016-09-01 Thread Jason Ekstrand
On Wed, Aug 31, 2016 at 9:56 PM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Wed, Aug 31, 2016 at 05:41:24PM -0700, Jason Ekstrand wrote: > >On Wed, Aug 31, 2016 at 8:17 AM, Topi Pohjolainen > ><[1]topi.pohjolai...@intel.com> wrote: > > > > Otherwise once mcs buffer ge

[Mesa-dev] [PATCH] Android: glsl: add rules to generate ir_expression*.h header files

2016-09-01 Thread Rob Herring
Recent changes to generate ir_expression*.h header files broke Android builds. This adds the generation rules. This change is complicated due to creating a circular dependency between libmesa_glsl, libmesa_nir, and libmesa_compiler. Normally, we add static libraries so that include paths are added

[Mesa-dev] [PATCH 2/2] nir: Remove fake edges in the CF handling code

2016-09-01 Thread Jason Ekstrand
When NIR was first introduced, Connor added this fake-edge hack to work around issues related to unreachable blocks. Thanks to GLSL IR's jump lowering code, the only unreachable code you can have is a block after an infinite loop. With SPIR-V, we didn't have the jump lowering code so we could als

[Mesa-dev] [PATCH 1/2] nir/dead_cf: Don't crash on unreachable after-loop blocks

2016-09-01 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- src/compiler/nir/nir_opt_dead_cf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_opt_dead_cf.c b/src/compiler/nir/nir_opt_dead_cf.c index 3551124..1490e68 100644 --- a/src/compiler/nir/nir_opt_dead_cf.c +++ b/src/comp

Re: [Mesa-dev] [PATCH 11/33] intel/blorp: Use fake_interleaved_msaa in retile_w_to_y

2016-09-01 Thread Jason Ekstrand
On Thu, Sep 1, 2016 at 12:09 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Wed, Aug 31, 2016 at 02:22:30PM -0700, Jason Ekstrand wrote: > > --- > > src/intel/blorp/blorp_blit.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/src/intel/blorp/blor

Re: [Mesa-dev] Improving ralloc performance for the GLSL compiler

2016-09-01 Thread Ernst Sjöstrand
Haven't I read in many places that the Linux port of NS2 is extremely crappy? Perhaps you shouldn't pay too much attention to that... Then again, maybe it's a good torture test. :-) Regards //Ernst 2016-09-01 18:11 GMT+02:00 Marek Olšák : > On Aug 31, 2016 11:31 AM, "Eero Tamminen" > wrote: > >

Re: [Mesa-dev] [PATCH 0/8] intel: Add a common folder for code-sharing

2016-09-01 Thread Jordan Justen
On 2016-08-31 13:56:50, Jason Ekstrand wrote: > Right now, we have 3 places where code is shared between the Vulkan and GL > drivers: blorp, isl, and libi965_compiler. There are a few places where we > want to share misc. code that doesn't fall into any of these categories. > This little series ad

Re: [Mesa-dev] [PATCH 0/9] Enable GL_ARB_shader_atomic_counter_ops on i965

2016-09-01 Thread Ilia Mirkin
On Thu, Sep 1, 2016 at 2:10 PM, Ian Romanick wrote: > I have also applied the same changes to st_glsl_to_tgsi.cpp. The > changes were pretty straight forward, so they should be correct. > However, I have only verified that it builds. Note that all those extensions are enabled on softpipe (but no

Re: [Mesa-dev] [PATCH 2/9] glsl: Use the ir_intrinsic_* enums instead of the __intrinsic_* name strings

2016-09-01 Thread Ilia Mirkin
On Thu, Sep 1, 2016 at 2:10 PM, Ian Romanick wrote: > + case ir_intrinsic_atomic_counter_comp_swap: { > opcode = TGSI_OPCODE_ATOMCAS; > param = param->get_next(); > val = ((ir_instruction *)param)->as_rvalue(); > val->accept(this); > data2 = t

Re: [Mesa-dev] [PATCH 0/9] Enable GL_ARB_shader_atomic_counter_ops on i965

2016-09-01 Thread Ian Romanick
On 09/01/2016 11:10 AM, Ian Romanick wrote: > This is the updated series to enable GL_ARB_shader_atomic_counter_ops on > i965. Really only the first part of the series has changed. At Curro's > suggestion, I added an enum to specify which intrinsic an intrinsic is. > The string name is still trac

[Mesa-dev] [PATCH 8/9] i965: Refactor emission of atomic counter operations

2016-09-01 Thread Ian Romanick
From: Ian Romanick This will make it easier to add more operations. Signed-off-by: Ian Romanick Reviewed-by: Iago Toral Quiroga --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 19 --- src/mesa/drivers/dri/i965/brw_shader.cpp | 16 src/mesa/drivers/dri/i965/

[Mesa-dev] [PATCH 5/9] glsl: Kill __intrinsic_atomic_sub

2016-09-01 Thread Ian Romanick
From: Ian Romanick Just generate an __intrinsic_atomic_add with a negated parameter. Some background on the non-obvious reasons for the the big change to builtin_builder::call()... this is cribbed from some discussion with Ilia on mesa-dev. Why change builtin_builder::call() to allow taking der

[Mesa-dev] [PATCH 0/9] Enable GL_ARB_shader_atomic_counter_ops on i965

2016-09-01 Thread Ian Romanick
This is the updated series to enable GL_ARB_shader_atomic_counter_ops on i965. Really only the first part of the series has changed. At Curro's suggestion, I added an enum to specify which intrinsic an intrinsic is. The string name is still tracked because it is used for look-ups and for printing

[Mesa-dev] [PATCH 6/9] nir/intrinsics: Include atomic_counter_ in the names used in macro invocations

2016-09-01 Thread Ian Romanick
From: Ian Romanick Otherwise grepping for where atomic_counter_inc and friends are defined is a very frustrating experience. Signed-off-by: Ian Romanick Reviewed-by: Iago Toral Quiroga --- src/compiler/nir/nir_intrinsics.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

[Mesa-dev] [PATCH 1/9] glsl: Track a unique intrinsic ID with each intrinsic function

2016-09-01 Thread Ian Romanick
From: Ian Romanick textdata bss dec hex filename 7669337 277176 28624 7975137 79b0e1 lib64/i965_dri.before.so 7669889 277176 28624 7975689 79b309 lib64/i965_dri.after.so Signed-off-by: Ian Romanick --- src/compiler/glsl/builtin_functions.cpp | 208 ++

[Mesa-dev] [PATCH 7/9] nir/intrinsics: Add more atomic_counter ops

2016-09-01 Thread Ian Romanick
From: Ian Romanick v2: Delete some stray debug code notice by Iago. v3: Massive rebase on new ir_function_signature::intrinsic_id mechanism. Signed-off-by: Ian Romanick Reviewed-by: Iago Toral Quiroga [v1] --- src/compiler/glsl/glsl_to_nir.cpp| 63 +--- sr

[Mesa-dev] [PATCH 3/9] glsl: Add ir_function_signature::is_intrinsic() method

2016-09-01 Thread Ian Romanick
From: Ian Romanick This necessetated renaming the is_intrinsic field to _is_intrinsic. The next commit will remove the field. No change in "size." Signed-off-by: Ian Romanick --- src/compiler/glsl/builtin_functions.cpp | 4 ++-- src/compiler/glsl/glsl_to_nir.cpp| 6 +++--- s

[Mesa-dev] [PATCH 9/9] i965: Enable ARB_shader_atomic_counter_ops

2016-09-01 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Reviewed-by: Iago Toral Quiroga --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 23 --- src/mesa/drivers/dri/i965/brw_shader.cpp | 16 src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 16 +---

[Mesa-dev] [PATCH 2/9] glsl: Use the ir_intrinsic_* enums instead of the __intrinsic_* name strings

2016-09-01 Thread Ian Romanick
From: Ian Romanick textdata bss dec hex filename 7669889 277176 28624 7975689 79b309 lib64/i965_dri.before.so 7668369 277176 28624 7974169 79ad19 lib64/i965_dri.after.so Signed-off-by: Ian Romanick --- src/compiler/glsl/glsl_to_nir.cpp| 172 --

[Mesa-dev] [PATCH 4/9] glsl: Remove ir_function_signature::_is_intrinsic field

2016-09-01 Thread Ian Romanick
From: Ian Romanick textdata bss dec hex filename 7668369 277176 28624 7974169 79ad19 lib64/i965_dri.before.so 7668305 277176 28624 7974105 79acd9 lib64/i965_dri.after.so Signed-off-by: Ian Romanick --- src/compiler/glsl/builtin_functions.cpp | 2 -- src/compile

Re: [Mesa-dev] [PATCH] st/mesa: expose OES_geometry_shader and OES_texture_cube_map_array

2016-09-01 Thread Ian Romanick
I sent a piglit patch for this on 8/24. I missed that Tapani sent a R-b, so I'll push it now. On 09/01/2016 07:49 AM, Ilia Mirkin wrote: > On Thu, Sep 1, 2016 at 2:23 AM, Michel Dänzer wrote: >> >> This change broke these piglit tests with radeonsi: >> >> spec@glsl-es-3.10@built-in constants >>

Re: [Mesa-dev] [PATCH 1/8] intel: Add a new "common" library for more code sharing

2016-09-01 Thread Rob Herring
On Thu, Sep 1, 2016 at 12:37 PM, Mauro Rossi wrote: > Thanks > > Doing a first attempt in building, there is currently some generated > code missing in android build for recent gsls changes, > due to commit ee3cdac7857a5c0f30108e1b1963d042f2a5e8e6 "glsl: Use the > generated constant expression cod

Re: [Mesa-dev] [PATCH 1/8] intel: Add a new "common" library for more code sharing

2016-09-01 Thread Mauro Rossi
Thanks Doing a first attempt in building, there is currently some generated code missing in android build for recent gsls changes, due to commit ee3cdac7857a5c0f30108e1b1963d042f2a5e8e6 "glsl: Use the generated constant expression code" I'll send a patch for that problem soon and I'll check and r

Re: [Mesa-dev] [PATCH 3/3] aubinator: only use program_invocation_short_name with glibc/cygwin

2016-09-01 Thread Kristian Høgsberg
On Thu, Sep 1, 2016 at 10:12 AM, Jonathan Gray wrote: > program_invocation_short_name is a gnu extension. Limit use of it > to glibc and cygwin and otherwise use getprogname() which is available > on BSD and OS X. > > Signed-off-by: Jonathan Gray For the series, Reviewed-by: Kristian Høgsberg

[Mesa-dev] [PATCH 2/3] aubinator: include libgen.h for basename(3)

2016-09-01 Thread Jonathan Gray
Include libgen.h for basename as required by posix. The definition is not found on at least OpenBSD otherwise. Signed-off-by: Jonathan Gray --- src/intel/tools/aubinator.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 66107711

[Mesa-dev] [PATCH] Disable the code that allocates W|X memory on OpenBSD

2016-09-01 Thread Jonathan Gray
OpenBSD now has strict W^X enforcement. Processes that violate the policy get killed by the kernel. Don't attempt to use executable memory on OpenBSD to avoid this. Patch from Mark Kettenis. Cc: 11.2 12.0 Signed-off-by: Mark Kettenis Signed-off-by: Jonathan Gray --- src/gallium/auxiliary/rt

[Mesa-dev] [PATCH 3/3] aubinator: only use program_invocation_short_name with glibc/cygwin

2016-09-01 Thread Jonathan Gray
program_invocation_short_name is a gnu extension. Limit use of it to glibc and cygwin and otherwise use getprogname() which is available on BSD and OS X. Signed-off-by: Jonathan Gray --- src/intel/tools/aubinator.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/i

[Mesa-dev] [PATCH 1/3] aubinator: stop using non portable error() function

2016-09-01 Thread Jonathan Gray
error() is a gnu extension and is not present on OpenBSD and likely other systems. Convert use of error to fprintf/strerror/exit. Signed-off-by: Jonathan Gray --- src/intel/tools/aubinator.c | 46 + 1 file changed, 30 insertions(+), 16 deletions(-) d

Re: [Mesa-dev] [PATCH 1/8] intel: Add a new "common" library for more code sharing

2016-09-01 Thread Rob Herring
On Wed, Aug 31, 2016 at 3:56 PM, Jason Ekstrand wrote: > The first thing to go in this new library is brw_device_info. > > Signed-off-by: Jason Ekstrand > Cc: Rob Herring > --- > > The android build files I just copied-and-pasted from blorp but I don't > have an android build setup so I can't te

Re: [Mesa-dev] Mesa 12.0.2 release candidate

2016-09-01 Thread Timo Aaltonen
On 01.09.2016 19:47, Emil Velikov wrote: > On 1 September 2016 at 17:34, Timo Aaltonen wrote: >> On 01.09.2016 17:25, Emil Velikov wrote: >>> Hello list, >>> >>> The candidate for the Mesa 12.0.2 is now available. >> >> Forgot to push the tag? >> > Branch or tag ? The former was done a few minutes

Re: [Mesa-dev] Mesa 12.0.2 release candidate

2016-09-01 Thread Emil Velikov
On 1 September 2016 at 17:34, Timo Aaltonen wrote: > On 01.09.2016 17:25, Emil Velikov wrote: >> Hello list, >> >> The candidate for the Mesa 12.0.2 is now available. > > Forgot to push the tag? > Branch or tag ? The former was done a few minutes after the email, while the latter will be in a few

Re: [Mesa-dev] [PATCH mesa] isl: use existing util_next_power_of_two function

2016-09-01 Thread Eric Engestrom
On Thu, Sep 01, 2016 at 05:27:09PM +0100, Lionel Landwerlin wrote: > It was a poor choice of words on my side. s/reuse/copy/ > It seems src/intel/isl doesn't have many dependencies (outside of src/util). > When discussing this with Ilia on IRC, he mentioned that an attempt to have > more common uti

Re: [Mesa-dev] Mesa 12.0.2 release candidate

2016-09-01 Thread Timo Aaltonen
On 01.09.2016 17:25, Emil Velikov wrote: > Hello list, > > The candidate for the Mesa 12.0.2 is now available. Forgot to push the tag? -- t ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-

Re: [Mesa-dev] [PATCH 3/6] nvc0: add nvc0_screen_resize_text_area() helper

2016-09-01 Thread Samuel Pitoiset
On 09/01/2016 06:22 PM, Ilia Mirkin wrote: On Thu, Sep 1, 2016 at 12:14 PM, Samuel Pitoiset wrote: On 08/31/2016 11:36 PM, Ilia Mirkin wrote: On Wed, Aug 31, 2016 at 4:52 PM, Samuel Pitoiset wrote: This function will be helpful for resizing the code segment area when we need to evict a

Re: [Mesa-dev] [PATCH mesa] isl: use existing util_next_power_of_two function

2016-09-01 Thread Lionel Landwerlin
It was a poor choice of words on my side. s/reuse/copy/ It seems src/intel/isl doesn't have many dependencies (outside of src/util). When discussing this with Ilia on IRC, he mentioned that an attempt to have more common utils functions didn't get much traction, so that's why I ended up copying

Re: [Mesa-dev] [PATCH 3/6] nvc0: add nvc0_screen_resize_text_area() helper

2016-09-01 Thread Ilia Mirkin
On Thu, Sep 1, 2016 at 12:14 PM, Samuel Pitoiset wrote: > > > On 08/31/2016 11:36 PM, Ilia Mirkin wrote: >> >> On Wed, Aug 31, 2016 at 4:52 PM, Samuel Pitoiset >> wrote: >>> >>> This function will be helpful for resizing the code segment >>> area when we need to evict all shaders. >>> >>> Signed-

Re: [Mesa-dev] [PATCH 3/6] nvc0: add nvc0_screen_resize_text_area() helper

2016-09-01 Thread Samuel Pitoiset
On 08/31/2016 11:36 PM, Ilia Mirkin wrote: On Wed, Aug 31, 2016 at 4:52 PM, Samuel Pitoiset wrote: This function will be helpful for resizing the code segment area when we need to evict all shaders. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_context.h | 1 +

Re: [Mesa-dev] Improving ralloc performance for the GLSL compiler

2016-09-01 Thread Marek Olšák
On Aug 31, 2016 11:31 AM, "Eero Tamminen" wrote: > > Hi, > > > On 31.08.2016 08:03, Kenneth Graunke wrote: >> >> On Tuesday, August 30, 2016 3:52:12 PM PDT Ian Romanick wrote: >> [snip] >>> >>> I don't recall any native Linux games encountering this, but my memory >>> may have faded. There were s

Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

2016-09-01 Thread Leo Liu
On 09/01/2016 11:54 AM, Nayan Deshmukh wrote: Hi Leo, I saw the code in dri3_glx.c and I could somewhat relate some basic code structure to the vl_winsys_dri3.c. But I am new to this and not aware of the terminology that you used about the buffers. Could you please explain what needs to be

Re: [Mesa-dev] [PATCH mesa] isl: use existing util_next_power_of_two function

2016-09-01 Thread Ilia Mirkin
Oh well look at that. src/intel is actually hooked up to include from src/gallium/auxiliary. However this would be the first usage of u_math.h in src/intel and they have a bunch of functions which mirror functionality in u_math.h, so perhaps they like having copies? Not sure. On Thu, Sep 1, 2016 a

[Mesa-dev] [PATCH mesa] isl: use existing util_next_power_of_two function

2016-09-01 Thread Eric Engestrom
v3 of the patch had an updated commit message but the actual code was that of the v2. Use the existing function instead of creating a new one, like the commit message says. Fixes: 2dc6930a5a54c0f586ba ("isl: round format alignment to nearest power of 2") CC: Lionel Landwerlin CC: Jason Ekstrand

Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

2016-09-01 Thread Nayan Deshmukh
Hi Leo, I saw the code in dri3_glx.c and I could somewhat relate some basic code structure to the vl_winsys_dri3.c. But I am new to this and not aware of the terminology that you used about the buffers. Could you please explain what needs to be done in more detail or point me to where I can read a

Re: [Mesa-dev] [PATCH 07/12] i965/blorp: Instruct vertex fetcher to provide prim instance id

2016-09-01 Thread Jason Ekstrand
On Aug 31, 2016 9:06 AM, "Topi Pohjolainen" wrote: > > This will indicate target layer (Render Target Array Index) needed > for layered clears. > > v2: Use 3DSTATE_VF_SGVS for gen8+ > > Signed-off-by: Topi Pohjolainen > --- > src/intel/blorp/blorp_genX_exec.h | 26 ++ > 1

Re: [Mesa-dev] [PATCH 09/12] intel/blorp: Allow single slice converter to suppress number of layers

2016-09-01 Thread Jason Ekstrand
We're not doing layered blits yet are we? Perhaps this can wait until then? On Aug 31, 2016 9:06 AM, "Topi Pohjolainen" wrote: > Signed-off-by: Topi Pohjolainen > --- > src/intel/blorp/blorp_blit.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/src/intel/blorp/blorp_blit.c b/src/i

Re: [Mesa-dev] [PATCH 08/12] intel/blorp: Allow multiple layers

2016-09-01 Thread Jason Ekstrand
On Aug 31, 2016 9:06 AM, "Topi Pohjolainen" wrote: > > Signed-off-by: Topi Pohjolainen > --- > src/intel/blorp/blorp.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/src/intel/blorp/blorp.c b/src/intel/blorp/blorp.c > index 4dbba01..17c1ff4 100644 > --- a/src/i

Re: [Mesa-dev] [PATCH] loader/dri3: Overhaul dri3_update_num_back

2016-09-01 Thread Alex Deucher
On Thu, Sep 1, 2016 at 11:28 AM, Jason Ekstrand wrote: > On Aug 31, 2016 11:39 PM, "Michel Dänzer" wrote: >> >> On 01/09/16 02:05 PM, Jason Ekstrand wrote: >> > >> > >> > On Wed, Aug 31, 2016 at 7:00 PM, Michel Dänzer > > > wrote: >> > >> > On 31/08/16 11:21 PM, Jas

Re: [Mesa-dev] [PATCH] loader/dri3: Overhaul dri3_update_num_back

2016-09-01 Thread Jason Ekstrand
On Aug 31, 2016 11:39 PM, "Michel Dänzer" wrote: > > On 01/09/16 02:05 PM, Jason Ekstrand wrote: > > > > > > On Wed, Aug 31, 2016 at 7:00 PM, Michel Dänzer > > wrote: > > > > On 31/08/16 11:21 PM, Jason Ekstrand wrote: > > > On Aug 19, 2016 12:07 AM, "Michel Dän

Re: [Mesa-dev] [PATCH 12/33] intel/blorp: Stop using the X/YOffset field of RENDER_SURFACE_STATE

2016-09-01 Thread Jason Ekstrand
On Sep 1, 2016 1:31 AM, "Pohjolainen, Topi" wrote: > > On Wed, Aug 31, 2016 at 02:22:31PM -0700, Jason Ekstrand wrote: > > While it can be useful, the field has substantial limtations. In > > particular, the bittom 2 or 3 bits is missing so your offset always has to > > bottom >

[Mesa-dev] [AppVeyor] mesa master #2084 completed

2016-09-01 Thread AppVeyor
Build mesa 2084 completed Commit 2f3154f464 by Frank Binns on 8/4/2016 2:15 PM: wayland-drm: add missing NULL check\n\nAlthough malloc is unlikely to fail check its return value nevertheless.\n\nSigned-off-by: Frank Binns \nReviewed-by: Eric Engestrom \nReviewe

Re: [Mesa-dev] [PATCH] loader: fix sysfs uevent file parsing

2016-09-01 Thread Emil Velikov
On 31 August 2016 at 16:15, Eric Engestrom wrote: > On Mon, Jun 20, 2016 at 11:46:49AM +0100, Eric Engestrom wrote: >> On Fri, Jun 17, 2016 at 06:29:40PM +0100, Frank Binns wrote: >> > When trying to get a device name for an fd using sysfs, it would always >> > fail >> > as it was expecting key/v

Re: [Mesa-dev] [PATCH 20/20] gallium/radeon: remove VPORT_ZMIN/ZMAX from init config states

2016-09-01 Thread Nicolai Hähnle
Patches 8-20: Reviewed-by: Nicolai Hähnle On 29.08.2016 17:28, Marek Olšák wrote: From: Marek Olšák It's part of the viewport state now. --- src/gallium/drivers/r600/evergreen_state.c | 14 +- src/gallium/drivers/r600/r600_state.c | 6 -- src/gallium/drivers/radeonsi/s

Re: [Mesa-dev] [PATCH] st/mesa: expose OES_geometry_shader and OES_texture_cube_map_array

2016-09-01 Thread Ilia Mirkin
On Thu, Sep 1, 2016 at 2:23 AM, Michel Dänzer wrote: > > This change broke these piglit tests with radeonsi: > > spec@glsl-es-3.10@built-in constants > spec@oes_geometry_shader@built-in constants > > All the shaders fail compilation like this: > > Failed to compile shader gl_MaxAtomicCounterBindin

[Mesa-dev] [AppVeyor] mesa 12.0 #2083 failed

2016-09-01 Thread AppVeyor
Build mesa 2083 failed Commit 0fa0e2a505 by Ilia Mirkin on 8/31/2016 4:54 AM: nv30: only bail on color/depth bpp mismatch when surfaces are swizzled\n\nThe actual restriction is a little weaker than I originally thought. See\nhttps://bugs.freedesktop.org/show_b

Re: [Mesa-dev] [PATCH 07/20] radeonsi: fix cubemaps viewed as 2D

2016-09-01 Thread Nicolai Hähnle
On 29.08.2016 17:28, Marek Olšák wrote: From: Marek Olšák This fixes: GL43-CTS.texture_view.view_sampling Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/radeonsi/si_state.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src

Re: [Mesa-dev] Mesa 12.0.2 release candidate

2016-09-01 Thread Ilia Mirkin
On Thu, Sep 1, 2016 at 10:25 AM, Emil Velikov wrote: > Ilia Mirkin (1): > a4xx: make sure to actually clamp depth as requested > > Ilia, for the above we require the 700+loc 9f219c7047b ("freedreno: add > batch-cache and batch reordering") and maybe more. Can you cross-check if > that's the

[Mesa-dev] Mesa 12.0.2 release candidate

2016-09-01 Thread Emil Velikov
Hello list, The candidate for the Mesa 12.0.2 is now available. Currently we have: - 160 queued - 9 nominated (outstanding) - and 1 rejected patches The current queue fixes crashes in GLX, EGL and Wayland-EGL, resolves a number of memory leaks in the video decoding drivers, makes the Intel Vul

Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

2016-09-01 Thread Leo Liu
Hi Nayan, About the Prime, I think you have to do is to separate decoder render buffer and presentation back buffer, and copy back and forth between them for presentation and update. You might refer to similar implement in glx and egl from loader_dri3_helper.c by grep "is_different_gpu" Rega

Re: [Mesa-dev] [PATCH] glx/glvnd: list the strcmp arguments in correct order

2016-09-01 Thread Eric Engestrom
On Thu, Sep 01, 2016 at 10:36:44AM +0100, Emil Velikov wrote: > From: Emil Velikov > > Currently, due to the inverse order, strcmp will produce negative result > when the needle is towards the start of the haystack. Thus on the next > iteration(s) we'll end up further towards the end and eventual

Re: [Mesa-dev] Improving ralloc performance for the GLSL compiler

2016-09-01 Thread Marc Dietrich
Am Mittwoch, 31. August 2016, 22:07:48 CEST schrieb Emil Velikov: > On 31 August 2016 at 17:39, Marek Olšák wrote: > > On Wed, Aug 31, 2016 at 4:39 PM, Eero Tamminen > > > > wrote: > >> Hi, > >> > >> On 31.08.2016 16:37, Marek Olšák wrote: > >> ... > >> > >>> OK. I'm afraid malloc/calloc/reall

Re: [Mesa-dev] [PATCH] Revert "foo"

2016-09-01 Thread Emil Velikov
On 1 September 2016 at 10:47, Erik Faye-Lund wrote: > On Thu, Sep 1, 2016 at 11:36 AM, Emil Velikov > wrote: >> This reverts commit 917e906379bc261c65e2cc4942d7bd3d8366f030. > > Huh? I can't see this commit in mesa.git... Had some stale/nasty files around that git send-email picked up. Please ig

Re: [Mesa-dev] [PATCH] Revert "foo"

2016-09-01 Thread Erik Faye-Lund
On Thu, Sep 1, 2016 at 11:36 AM, Emil Velikov wrote: > This reverts commit 917e906379bc261c65e2cc4942d7bd3d8366f030. Huh? I can't see this commit in mesa.git... ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailm

[Mesa-dev] [PATCH] glx/glvnd: list the strcmp arguments in correct order

2016-09-01 Thread Emil Velikov
From: Emil Velikov Currently, due to the inverse order, strcmp will produce negative result when the needle is towards the start of the haystack. Thus on the next iteration(s) we'll end up further towards the end and eventually fail to locate the entry. Cc: "12.0" Signed-off-by: Emil Velikov -

[Mesa-dev] [PATCH] Revert "foo"

2016-09-01 Thread Emil Velikov
This reverts commit 917e906379bc261c65e2cc4942d7bd3d8366f030. --- src/glx/g_glxglvnddispatchfuncs.c | 109 +++--- src/glx/glxglvnd.c| 5 +- 2 files changed, 55 insertions(+), 59 deletions(-) diff --git a/src/glx/g_glxglvnddispatchfuncs.c b/src/gl

Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

2016-09-01 Thread Nayan Deshmukh
Thanks, Michel you saved a lot of my time. Christian, I will get in touch with Leo and get started on this task. Regards, Nayan. On Thu, Sep 1, 2016 at 2:08 PM, Christian König wrote: > Am 01.09.2016 um 05:28 schrieb Michel Dänzer: > >> On 31/08/16 06:53 PM, Nayan Deshmukh wrote: >> >>> Hi Chr

Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

2016-09-01 Thread Christian König
Am 01.09.2016 um 05:28 schrieb Michel Dänzer: On 31/08/16 06:53 PM, Nayan Deshmukh wrote: Hi Christian, You missed a few things in the merge. I will send in the updated patch. I looked at the code in vl_winsys.c and vl_winsys3.c and also at the code in presentation.c where delayed rendering is

Re: [Mesa-dev] [PATCH 12/33] intel/blorp: Stop using the X/YOffset field of RENDER_SURFACE_STATE

2016-09-01 Thread Pohjolainen, Topi
On Wed, Aug 31, 2016 at 02:22:31PM -0700, Jason Ekstrand wrote: > While it can be useful, the field has substantial limtations. In > particular, the bittom 2 or 3 bits is missing so your offset always has to bottom > be a multiple of 4 or 8. While surface alignments usually wo

[Mesa-dev] [PATCH] glsl: Add positional argument specifiers.

2016-09-01 Thread Vinson Lee
Fix build with Python < 2.7. File "./glsl/ir_expression_operation.py", line 360, in get_enum_name return "ir_{}op_{}".format(("un", "bin", "tri", "quad")[self.num_operands-1], self.name) ValueError: zero length field name in format Fixes: e31c72a331b1 ("glsl: Convert tuple into a class") S

Re: [Mesa-dev] [PATCH 11/33] intel/blorp: Use fake_interleaved_msaa in retile_w_to_y

2016-09-01 Thread Pohjolainen, Topi
On Wed, Aug 31, 2016 at 02:22:30PM -0700, Jason Ekstrand wrote: > --- > src/intel/blorp/blorp_blit.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c > index 05fad8f..2838a26 100644 > --- a/src/intel/blorp/blor

Re: [Mesa-dev] [PATCH 10/33] intel/blorp: Use isl_get_interleaved_msaa_px_size_sa

2016-09-01 Thread Pohjolainen, Topi
On Wed, Aug 31, 2016 at 02:22:29PM -0700, Jason Ekstrand wrote: > --- > src/intel/blorp/blorp_blit.c | 34 ++ > 1 file changed, 6 insertions(+), 28 deletions(-) Patches 1-10: Reviewed-by: Topi Pohjolainen > > diff --git a/src/intel/blorp/blorp_blit.c b/src/inte