On Thu, Sep 01, 2016 at 08:40:52AM -0700, Jason Ekstrand wrote: > We're not doing layered blits yet are we? Perhaps this can wait until > then?
No but as previous patch stops suppressing number of layers in brw_blorp_surface_info_init() unonditionally these asserts will start to fire. This actually points a flaw in the order of patches, this will need to precede the previous. Alternative is to add signaling to brw_blorp_surface_info_init() when to suppress? I didn't like that too much. Thoughts? > > On Aug 31, 2016 9:06 AM, "Topi Pohjolainen" > <[1]topi.pohjolai...@intel.com> wrote: > > Signed-off-by: Topi Pohjolainen <[2]topi.pohjolai...@intel.com> > --- > src/intel/blorp/blorp_blit.c | 3 --- > 1 file changed, 3 deletions(-) > diff --git a/src/intel/blorp/blorp_blit.c > b/src/intel/blorp/blorp_blit.c > index 170c381..026061b 100644 > --- a/src/intel/blorp/blorp_blit.c > +++ b/src/intel/blorp/blorp_blit.c > @@ -1271,9 +1271,6 @@ static void > surf_convert_to_single_slice(const struct isl_device *isl_dev, > struct brw_blorp_surface_info *info) > { > - /* This only makes sense for a single level and array slice */ > - assert(info->view.levels == 1 && info->view.array_len == 1); > - > /* Just bail if we have nothing to do. */ > if (info->surf.dim == ISL_SURF_DIM_2D && > info->view.base_level == 0 && info->view.base_array_layer == > 0 && > -- > 2.5.5 > _______________________________________________ > mesa-dev mailing list > [3]mesa-dev@lists.freedesktop.org > [4]https://lists.freedesktop.org/mailman/listinfo/mesa-dev > > References > > 1. mailto:topi.pohjolai...@intel.com > 2. mailto:topi.pohjolai...@intel.com > 3. mailto:mesa-dev@lists.freedesktop.org > 4. https://lists.freedesktop.org/mailman/listinfo/mesa-dev > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev