Re: [Mesa-dev] [PATCH v3 6/6] main: fix length of values written to glGetProgramResourceiv() for ACTIVE_VARIABLES

2015-10-07 Thread Iago Toral
On Thu, 2015-10-08 at 09:53 +1100, Timothy Arceri wrote: > On Wed, 2015-10-07 at 09:21 +0200, Samuel Iglesias Gonsalvez wrote: > > Return the number of values written. > > > > Signed-off-by: Samuel Iglesias Gonsalvez > > Reviewed-by: Timothy Arceri > > Are you guys going to split SSBO into the

Re: [Mesa-dev] [PATCH] mesa: add GL_UNSIGNED_INT_24_8 to _mesa_pack_depth_span

2015-10-07 Thread Tapani Pälli
On 10/01/2015 10:12 PM, Ian Romanick wrote: On 10/01/2015 09:50 AM, Tapani Pälli wrote: On 10/01/2015 03:17 PM, Iago Toral wrote: On Thu, 2015-10-01 at 08:28 +0300, Tapani Pälli wrote: Patch adds missing type (used with NV_read_depth) so that it gets

[Mesa-dev] [PATCH v2] mesa: add GL_UNSIGNED_INT_24_8 to _mesa_pack_depth_span

2015-10-07 Thread Tapani Pälli
Patch adds missing type (used with NV_read_depth) so that it gets handled correctly. This fixes errors seen with following CTS test: ES3-CTS.gtf.GL3Tests.packed_pixels.packed_pixels Signed-off-by: Tapani Pälli --- src/mesa/main/pack.c | 15 +++ 1 file changed, 15 insertions(+) d

Re: [Mesa-dev] [PATCH v3 5/6] glsl: fix matrix stride calculation for std430's row_major matrices with two columns

2015-10-07 Thread Samuel Iglesias Gonsálvez
On 08/10/15 00:47, Timothy Arceri wrote: > On Wed, 2015-10-07 at 09:21 +0200, Samuel Iglesias Gonsalvez wrote: >> It doesn't round up to vec4 size. >> >> Fixes 15 dEQP tests: >> >> dEQP >> -GLES31.functional.ssbo.layout.single_basic_type.std430.row_major_low >> p_mat2 >> dEQP >> -GLES31.functiona

Re: [Mesa-dev] [PATCH 0/3] Make pull constant loads in gen6 start at MRFs 16/17

2015-10-07 Thread Iago Toral
Hi Ken, I think this never got reviewed. Could you have a quick look at least to patch 1? That looks like something we want to fix since we currently have a hard-coded array size for 16 MRFs registers which won't do for SNB. Iago On Tue, 2015-09-22 at 14:00 +0200, Iago Toral Quiroga wrote: > Ori

Re: [Mesa-dev] [PATCH] main: fix length of values written to glGetProgramResourceiv() for ACTIVE_VARIABLES

2015-10-07 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 10/06/2015 11:08 AM, Samuel Iglesias Gonsalvez wrote: Return the number of values written. Signed-off-by: Samuel Iglesias Gonsalvez --- src/mesa/main/shader_query.cpp | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/mesa/m

Re: [Mesa-dev] [PATCH v2] main: fix TOP_LEVEL_ARRAY_SIZE and TOP_LEVEL_ARRAY_STRIDE

2015-10-07 Thread Samuel Iglesias Gonsálvez
On 07/10/15 16:25, Ilia Mirkin wrote: > On Tue, Oct 6, 2015 at 4:08 AM, Samuel Iglesias Gonsalvez > wrote: >> When the active variable is an array which is already a top-level >> shader storage block member, don't return its array size and stride >> when querying TOP_LEVEL_ARRAY_SIZE and TOP_LEV

[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope

2015-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92183 --- Comment #9 from Tapani Pälli --- (In reply to Emil Velikov from comment #8) > Iirc the mingw + autoconf build was dropped. So we might want to 'sync' with > the autoconf build. The latter currently requires gcc 4.2, whist 4.6 is > recommended

[Mesa-dev] [Bug 92342] BGRA_EXT and type UNSIGNED_BYTE is a valid combination for TexImage2D

2015-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92342 Jason Ekstrand changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 92265] Black windows in weston after update mesa to 11.0.2-1

2015-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92265 Jason Ekstrand changed: What|Removed |Added CC||kondapallykalyancontribute@

[Mesa-dev] [Bug 92342] BGRA_EXT and type UNSIGNED_BYTE is a valid combination for TexImage2D

2015-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92342 --- Comment #1 from Tapani Pälli --- are you testing with patches that fixed bug #92265 ? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

Re: [Mesa-dev] [PATCH] c11/threads: initialize timeout structure

2015-10-07 Thread Jan Vesely
On Tue, 2015-10-06 at 10:38 -0700, Ian Romanick wrote: > I had also noticed the unused parameter warning, but I had a patch > that > just papered over the problem. I'm a bit annoyed that GCC didn't > warn > (but I guess it couldn't really) that abs_time might be used > uninitialized. > > This pat

[Mesa-dev] [Bug 92342] BGRA_EXT and type UNSIGNED_BYTE is a valid combination for TexImage2D

2015-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92342 kalyank changed: What|Removed |Added CC||chad.vers...@intel.com -- You are receiving t

[Mesa-dev] [Bug 92342] BGRA_EXT and type UNSIGNED_BYTE is a valid combination for TexImage2D

2015-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92342 Bug ID: 92342 Summary: BGRA_EXT and type UNSIGNED_BYTE is a valid combination for TexImage2D Product: Mesa Version: 11.0 Hardware: Other OS: All

Re: [Mesa-dev] [PATCH] gallium/swrast: fix front buffer blitting.

2015-10-07 Thread Ian Romanick
On 10/07/2015 08:05 PM, Dave Airlie wrote: > From: Dave Airlie > > So I've known this was broken before, cogl has a workaround > for it from what I know, but with the gallium based swrast > drivers BlitFramebuffer from back to front or vice-versa > was pretty broken. > > The legacy swrast driver

Re: [Mesa-dev] [PATCH 10/12] i965/cs: Get max_cs_threads from brw_compiler devinfo

2015-10-07 Thread Jason Ekstrand
On Oct 7, 2015 3:36 PM, "Kristian Høgsberg" wrote: > > On Wed, Oct 7, 2015 at 3:11 PM, Matt Turner wrote: > > On Wed, Oct 7, 2015 at 7:11 AM, Kristian Høgsberg Kristensen > > wrote: > >> Signed-off-by: Kristian Høgsberg Kristensen > >> --- > >> src/mesa/drivers/dri/i965/brw_fs.cpp | 5 +++-- >

Re: [Mesa-dev] [PATCH] nir/sweep: Reparent the shader name

2015-10-07 Thread Matt Turner
On Wed, Oct 7, 2015 at 8:45 PM, Jason Ekstrand wrote: > On Oct 7, 2015 8:40 PM, "Matt Turner" wrote: >> On Wed, Oct 7, 2015 at 8:30 PM, Jason Ekstrand >> wrote: >> > --- >> >> Because otherwise it was being freed? > > Yes Cool. Put something to that effect in the commit message, and Reviewed-b

[Mesa-dev] [Bug 92122] [bisected, cts] Regression with Assault Android Cactus

2015-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92122 Tapani Pälli changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

[Mesa-dev] [Bug 92265] Black windows in weston after update mesa to 11.0.2-1

2015-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92265 Jason Ekstrand changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] nir/sweep: Reparent the shader name

2015-10-07 Thread Jason Ekstrand
On Oct 7, 2015 8:40 PM, "Matt Turner" wrote: > > On Wed, Oct 7, 2015 at 8:30 PM, Jason Ekstrand wrote: > > --- > > Because otherwise it was being freed? Yes > > src/glsl/nir/nir_sweep.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/src/glsl/nir/nir_sweep.c b/src/glsl/nir/nir

Re: [Mesa-dev] [PATCH] nir/sweep: Reparent the shader name

2015-10-07 Thread Matt Turner
On Wed, Oct 7, 2015 at 8:30 PM, Jason Ekstrand wrote: > --- Because otherwise it was being freed? > src/glsl/nir/nir_sweep.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/glsl/nir/nir_sweep.c b/src/glsl/nir/nir_sweep.c > index d354975..b6ce43b 100644 > --- a/src/glsl/nir/nir_sw

[Mesa-dev] [PATCH] nir/sweep: Reparent the shader name

2015-10-07 Thread Jason Ekstrand
--- src/glsl/nir/nir_sweep.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/nir/nir_sweep.c b/src/glsl/nir/nir_sweep.c index d354975..b6ce43b 100644 --- a/src/glsl/nir/nir_sweep.c +++ b/src/glsl/nir/nir_sweep.c @@ -154,6 +154,8 @@ nir_sweep(nir_shader *nir) /* First, move owner

Re: [Mesa-dev] [PATCH 10/17] st/mesa: make Z/S drawpix shaders independent of variants, don't use Mesa IR

2015-10-07 Thread Roland Scheidegger
Am 08.10.2015 um 02:02 schrieb Marek Olšák: > Hi Brian, > > This is the commit that broke DrawPixels on llvmpipe, but not radeonsi > and softpipe. It's fixed in v2, which is attached. > > Marek > > On Tue, Oct 6, 2015 at 3:26 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> - there is no conn

Re: [Mesa-dev] [PATCH] mesa: Correctly handle GL_BGRA_EXT in ES3 format_and_type checks

2015-10-07 Thread Ian Romanick
On 10/07/2015 03:58 PM, Jason Ekstrand wrote: > The EXT_texture_format_BGRA extension (which mesa supports > unconditionally) adds a new format and internal format called GL_BGRA_EXT. > Previously, this was not really handled at all in > _mesa_ex3_error_check_format_and_type. When the checks w

[Mesa-dev] [PATCH] gallium/swrast: fix front buffer blitting.

2015-10-07 Thread Dave Airlie
From: Dave Airlie So I've known this was broken before, cogl has a workaround for it from what I know, but with the gallium based swrast drivers BlitFramebuffer from back to front or vice-versa was pretty broken. The legacy swrast driver tracks when a front buffer is used and does the get/put im

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/4] mesa: Expose function to calculate whether a shader image unit is valid.

2015-10-07 Thread Ian Romanick
On 09/03/2015 06:53 AM, Francisco Jerez wrote: > A future commit will remove all texture object-dependent derived state > from the image unit struct to make validation unnecessary on texture > state changes. Instead of checking gl_image_unit::_Valid drivers will > be required to call this function

[Mesa-dev] [Bug 92265] Black windows in weston after update mesa to 11.0.2-1

2015-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92265 --- Comment #11 from Eduardo Lima Mitev --- (In reply to Emil Velikov from comment #8) > Eduardo, the faulty commit (breaking KDE/kwin and weston) has landed a week+ > ago. Will you have a chance to look into it soon ? Alternatively I'll revert >

[Mesa-dev] [PATCH 2/4] program: remove unused cloning and combining functions

2015-10-07 Thread Marek Olšák
From: Marek Olšák --- src/mesa/program/program.c | 250 - src/mesa/program/program.h | 44 2 files changed, 294 deletions(-) diff --git a/src/mesa/program/program.c b/src/mesa/program/program.c index 23d8be8..eb1f8be 100644 --- a/src/mesa/pr

[Mesa-dev] [PATCH 3/4] program: remove other unused functions

2015-10-07 Thread Marek Olšák
From: Marek Olšák --- src/mesa/program/program.c | 134 - src/mesa/program/program.h | 9 --- 2 files changed, 143 deletions(-) diff --git a/src/mesa/program/program.c b/src/mesa/program/program.c index eb1f8be..1fcb8e0 100644 --- a/src/mesa/program

[Mesa-dev] [PATCH 1/4] program: remove unused function _mesa_find_line_column

2015-10-07 Thread Marek Olšák
From: Marek Olšák --- src/mesa/program/program.c | 43 --- src/mesa/program/program.h | 5 - 2 files changed, 48 deletions(-) diff --git a/src/mesa/program/program.c b/src/mesa/program/program.c index e94c102..23d8be8 100644 --- a/src/mesa/program/pr

[Mesa-dev] [PATCH 0/4] program: removal of Mesa IR functions

2015-10-07 Thread Marek Olšák
Hi, Some of these functions became unused after I made the big st/mesa patch series. Hopefully, nobody will miss them. The last one is a cleanup. Please review. src/mesa/drivers/dri/i915/i915_fragprog.c | 7 +- src/mesa/drivers/dri/i965/brw_program.c | 10 +- .../

[Mesa-dev] [PATCH 4/4] program: remove _mesa_init_*_program wrappers

2015-10-07 Thread Marek Olšák
From: Marek Olšák They didn't do anything useful. --- src/mesa/drivers/dri/i915/i915_fragprog.c | 7 +- src/mesa/drivers/dri/i965/brw_program.c| 10 +- .../drivers/dri/i965/test_fs_cmod_propagation.cpp | 2 +- .../dri/i965/test_fs_saturate_propagation.cpp | 2 +-

Re: [Mesa-dev] [PATCH 10/17] st/mesa: make Z/S drawpix shaders independent of variants, don't use Mesa IR

2015-10-07 Thread Marek Olšák
Hi Brian, This is the commit that broke DrawPixels on llvmpipe, but not radeonsi and softpipe. It's fixed in v2, which is attached. Marek On Tue, Oct 6, 2015 at 3:26 AM, Marek Olšák wrote: > From: Marek Olšák > > - there is no connection to user fragment shaders, so having these as > shader

Re: [Mesa-dev] Request to expose new AZDO exts: bindless, sparse tex+others exts..

2015-10-07 Thread oscar bg
Thanks Kenneth and Ilia for response.. Kenneth what I meant to compete with Vulkan was but was said in AZDO GDC presentation, namely to avoid rewriting current engines to Vulkan for acheiving low overhead in OpenGL using a few new extensions.. Also this *might* in Skyalke for me is a sure yes as i

Re: [Mesa-dev] [PATCH] mesa: Correctly handle GL_BGRA_EXT in ES3 format_and_type checks

2015-10-07 Thread Jason Ekstrand
On Wed, Oct 7, 2015 at 4:18 PM, Ilia Mirkin wrote: > On Wed, Oct 7, 2015 at 6:58 PM, Jason Ekstrand wrote: >> The EXT_texture_format_BGRA extension (which mesa supports >> unconditionally) adds a new format and internal format called GL_BGRA_EXT. >> Previously, this was not really handled at

Re: [Mesa-dev] [PATCH 5/6] i965: Implement nir_intrinsic_shader_clock

2015-10-07 Thread Connor Abbott
On Wed, Oct 7, 2015 at 7:51 AM, Emil Velikov wrote: > Signed-off-by: Emil Velikov > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 9 + > src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 10 ++ > 2 files changed, 19 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs

Re: [Mesa-dev] [PATCH] mesa: Correctly handle GL_BGRA_EXT in ES3 format_and_type checks

2015-10-07 Thread Ilia Mirkin
On Wed, Oct 7, 2015 at 6:58 PM, Jason Ekstrand wrote: > The EXT_texture_format_BGRA extension (which mesa supports > unconditionally) adds a new format and internal format called GL_BGRA_EXT. > Previously, this was not really handled at all in > _mesa_ex3_error_check_format_and_type. When the

[Mesa-dev] [Bug 92265] Black windows in weston after update mesa to 11.0.2-1

2015-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92265 --- Comment #10 from Jason Ekstrand --- I just sent a patch to the list that fixes this bug: http://lists.freedesktop.org/archives/mesa-dev/2015-October/096511.html -- You are receiving this mail because: You are the QA Contact for the bug. Yo

[Mesa-dev] [PATCH] mesa: Correctly handle GL_BGRA_EXT in ES3 format_and_type checks

2015-10-07 Thread Jason Ekstrand
The EXT_texture_format_BGRA extension (which mesa supports unconditionally) adds a new format and internal format called GL_BGRA_EXT. Previously, this was not really handled at all in _mesa_ex3_error_check_format_and_type. When the checks were tightened in commit f15a7f3c, we accidentally tigh

Re: [Mesa-dev] [PATCH v3 6/6] main: fix length of values written to glGetProgramResourceiv() for ACTIVE_VARIABLES

2015-10-07 Thread Timothy Arceri
On Wed, 2015-10-07 at 09:21 +0200, Samuel Iglesias Gonsalvez wrote: > Return the number of values written. > > Signed-off-by: Samuel Iglesias Gonsalvez Reviewed-by: Timothy Arceri Are you guys going to split SSBO into their own list? There was talk about this recently, but I don't recall what

Re: [Mesa-dev] [PATCH 4/6] nir: add shader_clock intrinsic

2015-10-07 Thread Connor Abbott
On Wed, Oct 7, 2015 at 4:48 PM, Emil Velikov wrote: > On 7 October 2015 at 18:04, Connor Abbott wrote: >> On Wed, Oct 7, 2015 at 7:51 AM, Emil Velikov >> wrote: >>> XXX: commit message, comment in nir_intrinsics.h >>> >>> Signed-off-by: Emil Velikov >>> --- >>> src/glsl/nir/glsl_to_nir.cpp |

Re: [Mesa-dev] [PATCH v3 5/6] glsl: fix matrix stride calculation for std430's row_major matrices with two columns

2015-10-07 Thread Timothy Arceri
On Wed, 2015-10-07 at 09:21 +0200, Samuel Iglesias Gonsalvez wrote: > It doesn't round up to vec4 size. > > Fixes 15 dEQP tests: > > dEQP > -GLES31.functional.ssbo.layout.single_basic_type.std430.row_major_low > p_mat2 > dEQP > -GLES31.functional.ssbo.layout.single_basic_type.std430.row_major_med

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

2015-10-07 Thread Mark Janes
Brian Paul writes: > On 10/05/2015 05:18 PM, Mark Janes wrote: >> I tested this patch and found: >> >> regressions: >>spec.arb_shader_storage_buffer_object.layout-std140-write-shader (BDW >> only) >> expected[1] = 1.00. Read value: 0.00 >> >>spec.arb_copy_image.arb_copy_image-srgb-

Re: [Mesa-dev] [PATCH 10/12] i965/cs: Get max_cs_threads from brw_compiler devinfo

2015-10-07 Thread Kristian Høgsberg
On Wed, Oct 7, 2015 at 3:11 PM, Matt Turner wrote: > On Wed, Oct 7, 2015 at 7:11 AM, Kristian Høgsberg Kristensen > wrote: >> Signed-off-by: Kristian Høgsberg Kristensen >> --- >> src/mesa/drivers/dri/i965/brw_fs.cpp | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git

Re: [Mesa-dev] [PATCH v3 4/6] main: buffer array variables can have array size of 0 if they are unsized

2015-10-07 Thread Timothy Arceri
On Wed, 2015-10-07 at 09:21 +0200, Samuel Iglesias Gonsalvez wrote: > From ARB_program_query_interface: > > For the property ARRAY_SIZE, a single integer identifying the > number of > active array elements of an active variable is written to . > The > array size returned is in units of the t

Re: [Mesa-dev] [PATCH v3 3/6] main: consider that unsized arrays have at least one active element

2015-10-07 Thread Timothy Arceri
On Wed, 2015-10-07 at 09:21 +0200, Samuel Iglesias Gonsalvez wrote: > From ARB_shader_storage_buffer_object: > > "When using the ARB_program_interface_query extension to enumerate > the > set of active buffer variables, only the first element of arrays > (sized > or unsized) will be enumerated"

Re: [Mesa-dev] [PATCH v3 1/6] main: fix goto in program_resource_top_level_array_stride

2015-10-07 Thread Timothy Arceri
On Wed, 2015-10-07 at 09:20 +0200, Samuel Iglesias Gonsalvez wrote: > Use found_top_level_array_stride instead of > found_top_level_array_size. > > Signed-off-by: Samuel Iglesias Gonsalvez Reviewed-by: Timothy Arceri > --- > src/mesa/main/shader_query.cpp | 4 ++-- > 1 file changed, 2 inserti

Re: [Mesa-dev] [PATCH 10/12] i965/cs: Get max_cs_threads from brw_compiler devinfo

2015-10-07 Thread Matt Turner
On Wed, Oct 7, 2015 at 7:11 AM, Kristian Høgsberg Kristensen wrote: > Signed-off-by: Kristian Høgsberg Kristensen > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp > b/src/mesa/drivers/

Re: [Mesa-dev] make distclean failing

2015-10-07 Thread Ilia Mirkin
Edit shader_enums.Plo and replace shader_enums.cpp with shader_enums.c (or vice-versa) On Wed, Oct 7, 2015 at 6:00 PM, Andy Furniss wrote: > Noticed recently that make distclean is failing for me - > > Making distclean in mesa > make[2]: Entering directory '/mnt/sdb1/Src64/Mesa-git/mesa/src/mesa'

Re: [Mesa-dev] [PATCH 09/12] i965: Move brw_get_shader_time_index() call out of emit functions

2015-10-07 Thread Matt Turner
On Wed, Oct 7, 2015 at 7:11 AM, Kristian Høgsberg Kristensen wrote: > diff --git a/src/mesa/drivers/dri/i965/brw_wm.c > b/src/mesa/drivers/dri/i965/brw_wm.c > index 242114f..1d020f6 100644 > --- a/src/mesa/drivers/dri/i965/brw_wm.c > +++ b/src/mesa/drivers/dri/i965/brw_wm.c > @@ -224,8 +224,14 @@

[Mesa-dev] make distclean failing

2015-10-07 Thread Andy Furniss
Noticed recently that make distclean is failing for me - Making distclean in mesa make[2]: Entering directory '/mnt/sdb1/Src64/Mesa-git/mesa/src/mesa' Makefile:2486: ../glsl/.deps/shader_enums.Plo: No such file or directory make[2]: *** No rule to make target '../glsl/.deps/shader_enums.Plo'. St

[Mesa-dev] [Bug 92265] Black windows in weston after update mesa to 11.0.2-1

2015-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92265 John Dulaney changed: What|Removed |Added CC||jdula...@fedoraproject.org --- Comment #9

[Mesa-dev] [PATCH 2/4 v2] glsl: Restrict initializers for global variables to constant expression in ES

2015-10-07 Thread Ian Romanick
From: Ian Romanick v2: Combine this check with the existing const and uniform checks. This change depends on the previous patch (glsl: Only set ir_variable::constant_value for const-decorated variables). Fixes: ES2-CTS.shaders.negative.initialize ES3-CTS.shaders.negative.initialize

[Mesa-dev] [PATCH 1/4] glsl: Only set ir_variable::constant_value for const-decorated variables

2015-10-07 Thread Ian Romanick
From: Ian Romanick Right now we're also setting for uniforms, and that doesn't seem to hurt things. The next patch will make general global variables in GLSL ES, and those definitely should not have constant_value set! Signed-off-by: Ian Romanick --- src/glsl/ast_to_hir.cpp | 9 ++--- 1 f

[Mesa-dev] [PATCH 4/4] glsl: In later GLSL versions, sequence operator is cannot be a constant expression

2015-10-07 Thread Ian Romanick
From: Ian Romanick Fixes: ES3-CTS.shaders.negative.constant_sequence spec/glsl-es-3.00/compiler/global-initializer/from-sequence.vert spec/glsl-es-3.00/compiler/global-initializer/from-sequence.frag Signed-off-by: Ian Romanick --- src/glsl/ast_to_hir.cpp | 43 +

[Mesa-dev] [PATCH 3/4] glsl: Add method to determine whether an expression contains the sequence operator

2015-10-07 Thread Ian Romanick
From: Ian Romanick This will be used in the next patch to enforce some language sematics. Signed-off-by: Ian Romanick --- src/glsl/ast.h| 6 src/glsl/ast_function.cpp | 11 +++ src/glsl/ast_to_hir.cpp | 80 +++ 3 files changed

[Mesa-dev] [PATCH 08/12] i965: Move brw_select_clip_planes() to brw_shader.cpp

2015-10-07 Thread Kristian Høgsberg Kristensen
We call this from the compiler so move it to brw_shader.cpp. Signed-off-by: Kristian Høgsberg Kristensen --- src/mesa/drivers/dri/i965/brw_shader.cpp | 26 ++ src/mesa/drivers/dri/i965/brw_vs.c | 25 - 2 files changed, 26 insertions(+), 25 de

[Mesa-dev] [PATCH 05/12] i965/cs: Split out helper for building local id payload

2015-10-07 Thread Kristian Høgsberg Kristensen
The initial motivation for this patch was to avoid calling brw_cs_prog_local_id_payload_dwords() in gen7_cs_state.c from the compiler. This commit ends up refactoring things a bit more so as to split out the logic to build the local id payload to brw_fs.cpp. This moves the payload building closer t

[Mesa-dev] [PATCH 02/12] util: Move DRI parse_debug_string() to util

2015-10-07 Thread Kristian Høgsberg Kristensen
We want to use intel_debug.c in code that doesn't link to dri common. Signed-off-by: Kristian Høgsberg Kristensen --- src/mesa/drivers/dri/i965/intel_debug.c | 5 ++-- src/util/Makefile.sources | 2 ++ src/util/debug.c| 53 +

[Mesa-dev] [PATCH 09/12] i965: Move brw_get_shader_time_index() call out of emit functions

2015-10-07 Thread Kristian Høgsberg Kristensen
brw_get_shader_time_index() is all tangled up in brw_context state and we can't call it from the compiler. Thanks the Jasons recent refactoring, we can just get the index and pass to the emit functions instead. Signed-off-by: Kristian Høgsberg Kristensen --- src/mesa/drivers/dri/i965/brw_cs.c

[Mesa-dev] [PATCH 12/12] i965: Link compiler unit tests to libi965_compiler.la

2015-10-07 Thread Kristian Høgsberg Kristensen
We can now link the unit tests against just libi965_compiler.la. This lets us drop a lot of DRI driver dependencies, but we still pull in all of libmesa and more. This also provides a few standalone users of libi965_compiler.la, which will help us accidentally using i965_dri.so functions from the

[Mesa-dev] [PATCH 03/12] i965: Configure bufmgr debug options from intel_screen.c

2015-10-07 Thread Kristian Høgsberg Kristensen
We need the debug flag parsing and INTEL_DEBUG in the compiler, but we don't want the dependency on bufmgr (libdrm_intel) in there. Move to intel_screen.c. Signed-off-by: Kristian Høgsberg Kristensen --- src/mesa/drivers/dri/i965/intel_debug.c | 14 +- src/mesa/drivers/dri/i965/inte

[Mesa-dev] [PATCH 10/12] i965/cs: Get max_cs_threads from brw_compiler devinfo

2015-10-07 Thread Kristian Høgsberg Kristensen
Signed-off-by: Kristian Høgsberg Kristensen --- src/mesa/drivers/dri/i965/brw_fs.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 65c3628..b79b4a4 100644 --- a/src/mesa/drivers/dri/i965/

[Mesa-dev] [PATCH 04/12] i965: Move brw_link_shader() and friends to new file brw_link.cpp

2015-10-07 Thread Kristian Høgsberg Kristensen
We want to use the rest of brw_shader.cpp with the rest of the compiler without pulling in the GLSL linking code. Signed-off-by: Kristian Høgsberg Kristensen --- src/mesa/drivers/dri/i965/Makefile.sources | 1 + src/mesa/drivers/dri/i965/brw_link.cpp | 280 + sr

[Mesa-dev] [PATCH 11/12] i965: Break out backend compiler to its own library

2015-10-07 Thread Kristian Høgsberg Kristensen
This introduces a new libtool helper library, libi965_compiler.la. This library is moderately self-contained, but still needs to link to all of libmesa.la among other things. Signed-off-by: Kristian Høgsberg Kristensen --- src/mesa/drivers/dri/i965/Makefile.am | 6 +- src/mesa/drivers/dr

[Mesa-dev] [PATCH 07/12] i965: Use util_next_power_of_two() for brw_get_scratch_size()

2015-10-07 Thread Kristian Høgsberg Kristensen
This function computes the next power of two, but at least 1024. We can do that by bitwise or'ing in 1023 and calling util_next_power_of_two(). We use brw_get_scratch_size() from the compiler so we need it out of brw_program.c. We could move it to brw_shader.cpp, but let's make it a small inline f

[Mesa-dev] [PATCH 00/12] Introduce libi965_compiler.la

2015-10-07 Thread Kristian Høgsberg Kristensen
This series introduces a new libtool convenience library, libi965_compiler.la. Most of the series is concerned with moving bits of code around to allow for splitting the compiler files in the second-to-last patch. The end result is still not completely ideal - we still have a bunch of brw_context

[Mesa-dev] [PATCH 06/12] i965: Move brw_mark_surface_used() to brw_shader.cpp

2015-10-07 Thread Kristian Høgsberg Kristensen
brw_program.c won't be part of the compiler library, but we need brw_mark_surface_used() in the compiler. Move to brw_shader.cpp. Signed-off-by: Kristian Høgsberg Kristensen --- src/mesa/drivers/dri/i965/brw_program.c | 10 -- src/mesa/drivers/dri/i965/brw_shader.cpp | 10 ++ 2

[Mesa-dev] [PATCH 01/12] i965: Move brw_dump_ir() out of brw_*_emit() functions

2015-10-07 Thread Kristian Høgsberg Kristensen
We move these calls one level up into the codegen functions. Signed-off-by: Kristian Høgsberg Kristensen --- src/mesa/drivers/dri/i965/brw_cs.c| 3 +++ src/mesa/drivers/dri/i965/brw_fs.cpp | 13 - src/mesa/drivers/dri/i965/brw_gs.c| 3 ++

Re: [Mesa-dev] [PATCH 00/17] Rework Mesa/ST shader compilation logic (Part 1)

2015-10-07 Thread Marek Olšák
On Wed, Oct 7, 2015 at 9:54 PM, Brian Paul wrote: > On 10/07/2015 12:34 PM, Brian Paul wrote: >> >> On 10/05/2015 07:26 PM, Marek Olšák wrote: >>> >>> Hi, >>> >>> This is a start of reworking how st/mesa translates and creates >>> shaders. The result of this patch series is this: >>> >>> In LinkSh

Re: [Mesa-dev] [PATCH 4/6] nir: add shader_clock intrinsic

2015-10-07 Thread Emil Velikov
On 7 October 2015 at 18:04, Connor Abbott wrote: > On Wed, Oct 7, 2015 at 7:51 AM, Emil Velikov wrote: >> XXX: commit message, comment in nir_intrinsics.h >> >> Signed-off-by: Emil Velikov >> --- >> src/glsl/nir/glsl_to_nir.cpp | 6 ++ >> src/glsl/nir/nir_intrinsics.h | 2 ++ >> 2 files ch

Re: [Mesa-dev] [PATCH 00/17] Rework Mesa/ST shader compilation logic (Part 1)

2015-10-07 Thread Brian Paul
On 10/07/2015 12:34 PM, Brian Paul wrote: On 10/05/2015 07:26 PM, Marek Olšák wrote: Hi, This is a start of reworking how st/mesa translates and creates shaders. The result of this patch series is this: In LinkShader or ProgramStringNotify, the shader is translated to TGSI as-is. There are no

Re: [Mesa-dev] [PATCH 00/17] Rework Mesa/ST shader compilation logic (Part 1)

2015-10-07 Thread Brian Paul
On 10/05/2015 07:26 PM, Marek Olšák wrote: Hi, This is a start of reworking how st/mesa translates and creates shaders. The result of this patch series is this: In LinkShader or ProgramStringNotify, the shader is translated to TGSI as-is. There are no shader code modifications for shader vari

Re: [Mesa-dev] [PATCH 2/2] r600g: Enable GL_ARB_gpu_shader5 extension

2015-10-07 Thread Glenn Kennard
On Wed, 07 Oct 2015 19:59:03 +0200, Benjamin Bellec wrote: Le 07/10/2015 19:13, Glenn Kennard a écrit : On Wed, 07 Oct 2015 19:04:15 +0200, Benjamin Bellec wrote: Hi Glenn, The series doesn't apply on current master. Regard. It's not meant to apply directly on master. Quoting from th

Re: [Mesa-dev] [PATCH 2/2] r600g: Enable GL_ARB_gpu_shader5 extension

2015-10-07 Thread Benjamin Bellec
Le 07/10/2015 19:13, Glenn Kennard a écrit : > On Wed, 07 Oct 2015 19:04:15 +0200, Benjamin Bellec > wrote: > >> Hi Glenn, >> >> The series doesn't apply on current master. >> >> Regard. >> > > It's not meant to apply directly on master. Quoting from the notes in > patch 1/2: > > This patch depend

[Mesa-dev] [Bug 91596] EGL_KHR_gl_colorspace (v2) causes problem with Android-x86 GUI

2015-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91596 --- Comment #22 from Rob Clark --- (In reply to Chih-Wei Huang from comment #20) > (In reply to Rob Clark from comment #17) > > (In reply to Emil Velikov from comment #15) > > > Upon closer look the mappings in drm_format_from_hal and get_pipe_fo

Re: [Mesa-dev] [PATCH 1/2] i965: Add a second successor to BRW_OPCODE_WHILE

2015-10-07 Thread Matt Turner
On Mon, Oct 5, 2015 at 6:29 AM, Neil Roberts wrote: > It is possible to directly predicate the WHILE instruction. In this > case there will be a second successor block because the execution can > resume from the instruction after the loop. This will be used in a > subsequent patch. > --- > src/me

Re: [Mesa-dev] [PATCH] glsl: add varyings to resource list only with SSO

2015-10-07 Thread Kenneth Graunke
On Wednesday, October 07, 2015 10:04:06 AM Tapani Pälli wrote: > Varyings can be considered inputs or outputs of a program only when > SSO is in use. With multi-stage programs, inputs contain only inputs > for first stage and outputs contains outputs of the final shader stage. > > I've tested that

Re: [Mesa-dev] [PATCH 2/2] r600g: Enable GL_ARB_gpu_shader5 extension

2015-10-07 Thread Dieter Nützel
Am 07.10.2015 19:13, schrieb Glenn Kennard: On Wed, 07 Oct 2015 19:04:15 +0200, Benjamin Bellec wrote: Hi Glenn, The series doesn't apply on current master. Regard. It's not meant to apply directly on master. Quoting from the notes in patch 1/2: This patch depends on prior patch: r60

Re: [Mesa-dev] [PATCH 2/2] r600g: Enable GL_ARB_gpu_shader5 extension

2015-10-07 Thread Glenn Kennard
On Wed, 07 Oct 2015 19:04:15 +0200, Benjamin Bellec wrote: Hi Glenn, The series doesn't apply on current master. Regard. It's not meant to apply directly on master. Quoting from the notes in patch 1/2: This patch depends on prior patch: r600g/sb: Support gs5 sampler indexing /Gle

Re: [Mesa-dev] [PATCH 2/2] r600g: Enable GL_ARB_gpu_shader5 extension

2015-10-07 Thread Benjamin Bellec
Hi Glenn, The series doesn't apply on current master. Regard. -- Benjamin 2015-10-07 19:00 GMT+02:00 Ilia Mirkin : > On Wed, Oct 7, 2015 at 12:53 PM, Marek Olšák wrote: > > On Wed, Oct 7, 2015 at 5:17 PM, Glenn Kennard > wrote: > >> Signed-off-by: Glenn Kennard > >> --- > >> Now that SB sup

Re: [Mesa-dev] [PATCH 4/6] nir: add shader_clock intrinsic

2015-10-07 Thread Connor Abbott
On Wed, Oct 7, 2015 at 7:51 AM, Emil Velikov wrote: > XXX: commit message, comment in nir_intrinsics.h > > Signed-off-by: Emil Velikov > --- > src/glsl/nir/glsl_to_nir.cpp | 6 ++ > src/glsl/nir/nir_intrinsics.h | 2 ++ > 2 files changed, 8 insertions(+) > > diff --git a/src/glsl/nir/glsl_t

Re: [Mesa-dev] [PATCH 2/2] r600g: Enable GL_ARB_gpu_shader5 extension

2015-10-07 Thread Ilia Mirkin
On Wed, Oct 7, 2015 at 12:53 PM, Marek Olšák wrote: > On Wed, Oct 7, 2015 at 5:17 PM, Glenn Kennard wrote: >> Signed-off-by: Glenn Kennard >> --- >> Now that SB supports the GS5 features we can safely enable the >> extension. >> >> Note that gallium state tracker clamps the GLSL language / GL ve

Re: [Mesa-dev] [PATCH 1/2] radeonsi: remove TC L2 cache flush for index buffers on VI

2015-10-07 Thread Alex Deucher
On Wed, Oct 7, 2015 at 12:54 PM, Marek Olšák wrote: > Ping > For the series: Reviewed-by: Alex Deucher > On Sat, Oct 3, 2015 at 7:55 PM, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeonsi/si_state_draw.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletio

Re: [Mesa-dev] [PATCH 1/2] radeonsi: remove TC L2 cache flush for index buffers on VI

2015-10-07 Thread Marek Olšák
Ping On Sat, Oct 3, 2015 at 7:55 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeonsi/si_state_draw.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c > b/src/gallium/drivers/radeonsi/si_sta

Re: [Mesa-dev] [PATCH 2/2] r600g: Enable GL_ARB_gpu_shader5 extension

2015-10-07 Thread Marek Olšák
On Wed, Oct 7, 2015 at 5:17 PM, Glenn Kennard wrote: > Signed-off-by: Glenn Kennard > --- > Now that SB supports the GS5 features we can safely enable the > extension. > > Note that gallium state tracker clamps the GLSL language / GL version > since GL_ARB_tessellation_shader isn't implemented ye

[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope

2015-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92183 --- Comment #8 from Emil Velikov --- Iirc the mingw + autoconf build was dropped. So we might want to 'sync' with the autoconf build. The latter currently requires gcc 4.2, whist 4.6 is recommended. Although as Brian said, I'm not sure if we hav

[Mesa-dev] [PATCH 1/2] r600g/sb: SB support for UBO indexing

2015-10-07 Thread Glenn Kennard
Signed-off-by: Glenn Kennard --- This patch depends on prior patch: r600g/sb: Support gs5 sampler indexing Two items that could be improved on in some future patch: Clauses using UBO indexing still lock the cache line for a constant used to load the index register, which causes some instruction

[Mesa-dev] [PATCH 2/2] r600g: Enable GL_ARB_gpu_shader5 extension

2015-10-07 Thread Glenn Kennard
Signed-off-by: Glenn Kennard --- Now that SB supports the GS5 features we can safely enable the extension. Note that gallium state tracker clamps the GLSL language / GL version since GL_ARB_tessellation_shader isn't implemented yet. docs/GL3.txt | 16 do

Re: [Mesa-dev] [PATCH v4] i965/fs: Handle non-const sample number in interpolateAtSample

2015-10-07 Thread Francisco Jerez
Neil Roberts writes: > If a non-const sample number is given to interpolateAtSample it will > now generate an indirect send message with the sample ID similar to > how non-const sampler array indexing works. Previously non-const > values were ignored and instead it ended up using a constant 0 val

[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope

2015-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92183 --- Comment #7 from Brian Paul --- (In reply to Tapani Pälli from comment #6) > (In reply to Vinson Lee from comment #5) > > mesa: ca2e16d26ec46e604c76ab72d3ec14a7a8643cc8 (master 11.1.0-devel) > > > > Build is still failing on older versions on

Re: [Mesa-dev] [PATCH] i965: Don't tell the hardware about our UAV access.

2015-10-07 Thread Francisco Jerez
Emil Velikov writes: > On 26 September 2015 at 21:25, Francisco Jerez wrote: >> Emil Velikov writes: >> >>> Hi all, >>> >>> On 10 September 2015 at 00:30, Mark Janes wrote: Mark Janes writes: > Francisco Jerez writes: > >> Mark Janes writes: >> >>> When I teste

Re: [Mesa-dev] [PATCH] i965: Don't tell the hardware about our UAV access.

2015-10-07 Thread Emil Velikov
On 26 September 2015 at 21:25, Francisco Jerez wrote: > Emil Velikov writes: > >> Hi all, >> >> On 10 September 2015 at 00:30, Mark Janes wrote: >>> Mark Janes writes: >>> Francisco Jerez writes: > Mark Janes writes: > >> When I tested this, I saw an intermittent BSW gpu

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/4] mesa: Expose function to calculate whether a shader image unit is valid.

2015-10-07 Thread Emil Velikov
On 24 September 2015 at 11:45, Emil Velikov wrote: > Hi all, > > On 3 September 2015 at 14:53, Francisco Jerez wrote: >> A future commit will remove all texture object-dependent derived state >> from the image unit struct to make validation unnecessary on texture >> state changes. Instead of che

[Mesa-dev] [Bug 92265] Black windows in weston after update mesa to 11.0.2-1

2015-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92265 --- Comment #8 from Emil Velikov --- Eduardo, the faulty commit (breaking KDE/kwin and weston) has landed a week+ ago. Will you have a chance to look into it soon ? Alternatively I'll revert this for stable - 11.0.3 (coming in 2-3 days). -- You

Re: [Mesa-dev] [PATCH v2] main: fix TOP_LEVEL_ARRAY_SIZE and TOP_LEVEL_ARRAY_STRIDE

2015-10-07 Thread Ilia Mirkin
On Tue, Oct 6, 2015 at 4:08 AM, Samuel Iglesias Gonsalvez wrote: > When the active variable is an array which is already a top-level > shader storage block member, don't return its array size and stride > when querying TOP_LEVEL_ARRAY_SIZE and TOP_LEVEL_ARRAY_STRIDE > respectively. > > Fixes the f

Re: [Mesa-dev] [PATCH 2/6] main: fix goto in program_resource_top_level_array_stride

2015-10-07 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 10/02/2015 10:13 AM, Samuel Iglesias Gonsalvez wrote: Use found_top_level_array_stride instead of found_top_level_array_size. Signed-off-by: Samuel Iglesias Gonsalvez --- src/mesa/main/shader_query.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

Re: [Mesa-dev] [PATCH v2] main: fix TOP_LEVEL_ARRAY_SIZE and TOP_LEVEL_ARRAY_STRIDE

2015-10-07 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 10/06/2015 11:08 AM, Samuel Iglesias Gonsalvez wrote: When the active variable is an array which is already a top-level shader storage block member, don't return its array size and stride when querying TOP_LEVEL_ARRAY_SIZE and TOP_LEVEL_ARRAY_STRIDE respectively. F

[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope

2015-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92183 --- Comment #6 from Tapani Pälli --- (In reply to Vinson Lee from comment #5) > mesa: ca2e16d26ec46e604c76ab72d3ec14a7a8643cc8 (master 11.1.0-devel) > > Build is still failing on older versions on MinGW. This error occurs with > mingw-w64 2.0.1-

[Mesa-dev] [PATCH v4] i965/fs: Handle non-const sample number in interpolateAtSample

2015-10-07 Thread Neil Roberts
If a non-const sample number is given to interpolateAtSample it will now generate an indirect send message with the sample ID similar to how non-const sampler array indexing works. Previously non-const values were ignored and instead it ended up using a constant 0 value. The generator will try to

  1   2   >