Re: r19986 - in /lyx-devel/trunk/src: EmbeddedFiles.cpp front...

2007-09-01 Thread Bo Peng
On 9/2/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Author: bpeng > Date: Sun Sep 2 07:36:39 2007 > New Revision: 19986 > > URL: http://www.lyx.org/trac/changeset/19986 > Log: > Embedding: fix a file selection and a file copy bug This patch finishes the embedding dialog. Please review Embed

Re: r19968 - in /lyx-devel/trunk/src: TextMetrics.cpp insets/...

2007-09-01 Thread Martin Vermeer
On Sun, Sep 02, 2007 at 12:46:00AM +0200, Abdelrazak Younes wrote: > Alfredo Braunstein wrote: > > Abdelrazak Younes wrote: > >>> But what about deeply nested stuff, or stuff inside minipages etc. It > >>> seems difficult to come up with good heuristics to avoid that metrics > >>> call without usi

Re: r19968 - in /lyx-devel/trunk/src: TextMetrics.cpp insets/...

2007-09-01 Thread Martin Vermeer
On Sun, Sep 02, 2007 at 12:29:50AM +0200, Abdelrazak Younes wrote: > Alfredo Braunstein wrote: > > Abdelrazak Younes wrote: > >>> How can this work? You have to compute metrics on the restricted > >>> textwidth (less the button width) because that's how it's painted after. > >> That's because the

Re: Compilation broken on Mac (current svn)

2007-09-01 Thread Roger Mc Murtrie
MKDIR_P doesn't appear to be defined anywhere on my system. The best solution that I can come up with is to add MKDIR_P ?= mkdir -p to development/MacOSX/Makefile.am Doing this for both LyX1.5.2svn and LyX1.6.0svn (trunk) produced working versions of LyX1.5.2svn and LyX1.6.0svn Roger On 02

Re: merge Foo*ButtonPolicy into a single class.

2007-09-01 Thread Abdelrazak Younes
Andre Poenitz wrote: 190 lines less looks like a good reason to me. I look forward to the day this button controller thing will go away entirely ;-) Abdel.

merge Foo*ButtonPolicy into a single class.

2007-09-01 Thread Andre Poenitz
190 lines less looks like a good reason to me. Andre' Index: qt4/Qt2BC.h === --- qt4/Qt2BC.h (revision 19980) +++ qt4/Qt2BC.h (working copy) @@ -34,7 +34,7 @@ { public: /// - Qt2BC(ButtonController const & parent); +

Re: r19968 - in /lyx-devel/trunk/src: TextMetrics.cpp insets/...

2007-09-01 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Alfredo Braunstein wrote: Abdelrazak Younes wrote: But what about deeply nested stuff, or stuff inside minipages etc. It seems difficult to come up with good heuristics to avoid that metrics call without using textwidth. I think that by testing he dimension of the but

Re: r19968 - in /lyx-devel/trunk/src: TextMetrics.cpp insets/...

2007-09-01 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Abdelrazak Younes wrote: But what about deeply nested stuff, or stuff inside minipages etc. It seems difficult to come up with good heuristics to avoid that metrics call without using textwidth. I think that by testing he dimension of the button and if we forbid openi

Re: r19968 - in /lyx-devel/trunk/src: TextMetrics.cpp insets/...

2007-09-01 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Abdelrazak Younes wrote: But what about deeply nested stuff, or stuff inside minipages etc. It seems difficult to come up with good heuristics to avoid that metrics call without using textwidth. I think that by testing he dimension of the button and if we forbid openi

Re: r19968 - in /lyx-devel/trunk/src: TextMetrics.cpp insets/...

2007-09-01 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Could you remind me why of the comment "// This expression should not contain mi.base.texwidth" of line InsetCollapsable:212 ? svn blame tells me: 211 1447217/07/2006 07:30:36 vermeer Abdel.

Re: r19968 - in /lyx-devel/trunk/src: TextMetrics.cpp insets/...

2007-09-01 Thread Alfredo Braunstein
Abdelrazak Younes wrote: >> But what about deeply nested stuff, or stuff inside minipages etc. It >> seems difficult to come up with good heuristics to avoid that metrics >> call without using textwidth. > > I think that by testing he dimension of the button and if we forbid > openinlined if the

Re: r19984 - /lyx-devel/trunk/src/EmbeddedFiles.cpp

2007-09-01 Thread Abdelrazak Younes
Bo, please verify this. Abdel. [EMAIL PROTECTED] wrote: Author: younes Date: Sun Sep 2 00:26:59 2007 New Revision: 19984 URL: http://www.lyx.org/trac/changeset/19984 Log: Fix MSVC warning. Modified: lyx-devel/trunk/src/EmbeddedFiles.cpp Modified: lyx-devel/trunk/src/EmbeddedFiles.cpp UR

Re: r19968 - in /lyx-devel/trunk/src: TextMetrics.cpp insets/...

2007-09-01 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Abdelrazak Younes wrote: How can this work? You have to compute metrics on the restricted textwidth (less the button width) because that's how it's painted after. That's because the InsetText dimension doesn't change, it stays lower that 0.5 * workWidth, no matter if

Re: Please help improve the embedding feature.

2007-09-01 Thread José Matos
On Saturday 01 September 2007 15:31:28 Jean-Marc Lasgouttes wrote: > > Cite one advantage of compressed vs zipped. Compression rate. You asked. ;-) Compare gzip -9 with zip. :-) > JMarc -- José Abílio

Re: About the metrics cleanup

2007-09-01 Thread José Matos
On Saturday 01 September 2007 19:49:50 Martin Vermeer wrote: > Sorry, this last one (lyx2lyx) is false alarm Thank you. :-) > - Martin -- José Abílio

Re: r19968 - in /lyx-devel/trunk/src: TextMetrics.cpp insets/...

2007-09-01 Thread Alfredo Braunstein
Abdelrazak Younes wrote: >> How can this work? You have to compute metrics on the restricted >> textwidth (less the button width) because that's how it's painted after. > > That's because the InsetText dimension doesn't change, it stays lower > that 0.5 * workWidth, no matter if there's a button

Re: About the metrics cleanup

2007-09-01 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Martin Vermeer wrote: (BTW this is what I tried with the original wide() but I wasn't clever enough) I know ;-) Hum, I guess I should clarify that I didn't meant you wasn't clever enough, I just meant of course that I know that that's also what you wanted to achi

Re: About the metrics cleanup

2007-09-01 Thread Abdelrazak Younes
Martin Vermeer wrote: On Sat, Sep 01, 2007 at 05:15:40PM +0200, Abdelrazak Younes wrote: Hi there, I think I have advanced well enough that trunk is usable again with regards to painting. Please report (or try to fix ;-)) any problem you encounter. What Alfredo said... kaboom on new doc.

Re: simplify frontend logic

2007-09-01 Thread Abdelrazak Younes
Andre Poenitz wrote: On Sat, Sep 01, 2007 at 08:32:17AM +0200, Abdelrazak Younes wrote: Andre Poenitz wrote: I plan to 'manually expand' the current uses QController as in the attached patch. The result is not only shorter but also simpler. No need for a template with a template argument (QCon

Re: r19968 - in /lyx-devel/trunk/src: TextMetrics.cpp insets/...

2007-09-01 Thread Abdelrazak Younes
Alfredo Braunstein wrote: == --- lyx-devel/trunk/src/insets/InsetCollapsable.cpp (original) +++ lyx-devel/trunk/src/insets/InsetCollapsable.cpp Sat Sep 1 11:24:20 2007 @@ -213,13 +213,7 @@ open

Re: crash in current trunk

2007-09-01 Thread Abdelrazak Younes
Alfredo Braunstein wrote: C-N -> crash Here's the backtrace: I forgot to test new document :-( I'll remove the assertion for now. Btw, you didn't answer to my post about rev 19968. I think that the part about collapsables has to be reverted. Ah sorry, I missed that. I'll look at it now.

Re: r19981 - in /lyx-devel/trunk/src/frontends/qt4: GuiEmbedd...

2007-09-01 Thread Bo Peng
On 9/1/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Author: bpeng > Date: Sat Sep 1 22:48:51 2007 > New Revision: 19981 > > URL: http://www.lyx.org/trac/changeset/19981 > Log: > Embedding dialog: use two buttons (will have more) for the actions This is the promised last patch for the embedd

Re: New in LyX 1.6

2007-09-01 Thread Pavel Sanda
> How do I add a new sub-category there? afair is enough to create new page add !!! Categories Category: [[!Development]], [[!LyX_1_6]] pavel

more frontend/* matter

2007-09-01 Thread Andre Poenitz
Remove >100 more lines, one more intermediate two-argument class template layer. No visible changes. Again, just for the record ;-} Andre' Index: qt4/Qt2BC.h === --- qt4/Qt2BC.h (revision 19976) +++ qt4/Qt2BC.h (working copy) @@ -2

Re: New in LyX 1.6

2007-09-01 Thread Andre Poenitz
On Sat, Sep 01, 2007 at 01:51:34PM +0100, José Matos wrote: > On Saturday 01 September 2007 09:15:50 Juergen Spitzmueller wrote: > > I've set up a wiki page, since development seems to gain speed: > > http://wiki.lyx.org/LyX/NewInLyX16 > > > > please fill in. > > I would like to have a wiki page

Re: 1.6.0 plan?

2007-09-01 Thread Andre Poenitz
On Sat, Sep 01, 2007 at 10:15:04AM +0200, Abdelrazak Younes wrote: > Juergen Spitzmueller wrote: > >Bo Peng wrote: > > > >>I had the same plea. > >> > >>Jurgen, what is your opinion? > > > >I'm not sure I like it. The diff to 1.5.1 gets bigger and bigger. > >However, if the current situation stops

Re: simplify frontend logic

2007-09-01 Thread Andre Poenitz
On Fri, Aug 31, 2007 at 10:15:24PM -0400, Richard Heck wrote: > Andre Poenitz wrote: > >I plan to 'manually expand' the current uses QController as in the > >attached patch. > > > >The result is not only shorter but also simpler. No need for a template > >with a template argument (QController) anym

Re: Merge QController into individual dialogs

2007-09-01 Thread Andre Poenitz
On Sat, Sep 01, 2007 at 08:45:53AM +0200, Abdelrazak Younes wrote: > Andre Poenitz wrote: > >Patch attached. Includes various cleanup, too. Will commit. > > I see you didn't wait for an answer to your previous question (my answer > particularly)... While I am happy that you work on this, I think

Re: simplify frontend logic

2007-09-01 Thread Andre Poenitz
On Sat, Sep 01, 2007 at 08:32:17AM +0200, Abdelrazak Younes wrote: > Andre Poenitz wrote: > >I plan to 'manually expand' the current uses QController as in the > >attached patch. > > > >The result is not only shorter but also simpler. No need for a template > >with a template argument (QController)

Re: Q-->Gui: A Plea

2007-09-01 Thread Andre Poenitz
On Fri, Aug 31, 2007 at 10:21:02PM -0400, Richard Heck wrote: > > Andre, > > Could you please apply this patch to branch? I would oppose such a move. Only bugfixes to branch. This is ordinary development. > I understand that other changes may make > [EMAIL PROTECTED]> svn merge -c $MYPATCHNUM

Re: r19977 - in /lyx-devel/trunk/src: EmbeddedFiles.cpp Embed...

2007-09-01 Thread Bo Peng
On 9/1/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Author: bpeng > Date: Sat Sep 1 22:08:16 2007 > New Revision: 19977 > > URL: http://www.lyx.org/trac/changeset/19977 > Log: > Embedding dialog: add extract and extractAll functions With the addition of extract and extractAll functions, the

Re: 1.6.0 plan?

2007-09-01 Thread Andre Poenitz
On Sat, Sep 01, 2007 at 05:03:36PM +0200, Alfredo Braunstein wrote: > Abdelrazak Younes wrote: > > >> Code needs time > >> to mature, IMO. > > > As I said before, if XML is mostly ready (say 3/4) put it in now or > > forget about it. > > +1. All major surgery should happend at the beginning of t

Re: Please help improve the embedding feature.

2007-09-01 Thread Andre Poenitz
On Sat, Sep 01, 2007 at 04:30:47PM +0200, Jean-Marc Lasgouttes wrote: > José Matos <[EMAIL PROTECTED]> writes: > > >> Because this feature more or less duplicates with embedding, and if we > >> decide to go with .lyz for lyx bundle format, .lyx will always be a > >> plain text file. > > > > I th

Re: About the metrics cleanup

2007-09-01 Thread Martin Vermeer
On Sat, Sep 01, 2007 at 07:35:30PM +0300, Martin Vermeer wrote: > On Sat, Sep 01, 2007 at 05:15:40PM +0200, Abdelrazak Younes wrote: > > Hi there, > > > > I think I have advanced well enough that trunk is usable again with > > regards > > to painting. Please report (or try to fix ;-)) any pro

Re: About the metrics cleanup

2007-09-01 Thread Martin Vermeer
On Sat, Sep 01, 2007 at 05:15:40PM +0200, Abdelrazak Younes wrote: > Hi there, > > I think I have advanced well enough that trunk is usable again with regards > to painting. Please report (or try to fix ;-)) any problem you encounter. Another problem (José?) when I try to load an existing fi

Re: About the metrics cleanup

2007-09-01 Thread Martin Vermeer
On Sat, Sep 01, 2007 at 05:15:40PM +0200, Abdelrazak Younes wrote: > Hi there, > > I think I have advanced well enough that trunk is usable again with regards > to painting. Please report (or try to fix ;-)) any problem you encounter. What Alfredo said... kaboom on new doc. > I > have not

Re: 1.6.0 plan?

2007-09-01 Thread Martin Vermeer
On Sat, Sep 01, 2007 at 05:03:36PM +0200, Alfredo Braunstein wrote: > Abdelrazak Younes wrote: > > >> Code needs time > >> to mature, IMO. > > > As I said before, if XML is mostly ready (say 3/4) put it in now or > > forget about it. > > +1. All major surgery should happend at the beginning of t

Re: [Cvslog] r19965 - in /lyx-devel/trunk/src: BufferParams.cpp Buffer...

2007-09-01 Thread Richard Heck
Jean-Marc Lasgouttes wrote: [EMAIL PROTECTED] writes: That makes another simplification both possible and desirable. For some reason, whenever you change the Document Class combobox in Document Settings, LyX tries to read whatever you choose _before_ you try to hit "Apply". Why? I see no goo

Re: New in LyX 1.6

2007-09-01 Thread Richard Heck
Juergen Spitzmueller wrote: José Matos wrote: Any objection? Not from me anyway (good idea). Nor from me, and I added a blurb about layout modules, which are nearly done now. I just need to commit the GUI stuff, but that will take more effort now because of the Q->GUI switch. rh

crash in current trunk

2007-09-01 Thread Alfredo Braunstein
C-N -> crash Here's the backtrace: #4 0x0807e5f8 in boost::assertion_failed (expr=0x8a95fa2 "w >= 0", function=0x8a96200 "void lyx::TextMetrics::computeRowMetrics(lyx::pit_type, lyx::Row&) const", file=0x8a95f61 "../../src/TextMetrics.cpp", line=318) at ../../src/boost.cpp:56 #5 0x0844c

About the metrics cleanup

2007-09-01 Thread Abdelrazak Younes
Hi there, I think I have advanced well enough that trunk is usable again with regards to painting. Please report (or try to fix ;-)) any problem you encounter. I have not touched at tabular yet, so maybe there would be problem there. You will notice a big change WRT to text inset geometry: i

Re: 1.6.0 plan?

2007-09-01 Thread Alfredo Braunstein
Abdelrazak Younes wrote: >> Code needs time >> to mature, IMO. > As I said before, if XML is mostly ready (say 3/4) put it in now or > forget about it. +1. All major surgery should happend at the beginning of the cycle (exactly to give time for the code to mature). A/

Re: 1.6.0 plan?

2007-09-01 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: If Andre is serious about cleaning up the dialog, backporting patches will soon be impossible anyway. So, my opinion is that we should not do the renaming in 1.5.x. +1 One solution to limit the trouble is to deliver 1.

Re: 1.6.0 plan?

2007-09-01 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > If Andre is serious about cleaning up the dialog, backporting patches > will soon be impossible anyway. So, my opinion is that we should not > do the renaming in 1.5.x. +1 > One solution to limit the trouble is to deliver 1.6.0 sooner. This > means

Re: Please help improve the embedding feature.

2007-09-01 Thread Jean-Marc Lasgouttes
José Matos <[EMAIL PROTECTED]> writes: > LyX supports compressed files in a clean way, so let us leave that way. > I don't want to appear rude but we should be very cautious about removing > features, and in this case the feature is well written and robust. How many > bug reports did we had ab

Re: Please help improve the embedding feature.

2007-09-01 Thread Jean-Marc Lasgouttes
José Matos <[EMAIL PROTECTED]> writes: >> Because this feature more or less duplicates with embedding, and if we >> decide to go with .lyz for lyx bundle format, .lyx will always be a >> plain text file. > > I think that the dos time is gone long ago and a lyx suffix should stand > for > lyx f

Re: [Cvslog] r19965 - in /lyx-devel/trunk/src: BufferParams.cpp Buffer...

2007-09-01 Thread Jean-Marc Lasgouttes
[EMAIL PROTECTED] writes: > That makes another simplification both possible and desirable. For > some reason, whenever you change the Document Class combobox in > Document Settings, LyX tries to read whatever you choose _before_ > you try to hit "Apply". Why? I see no good reason. Maybe to be ab

Re: Please help improve the embedding feature.

2007-09-01 Thread Bo Peng
> I think that the dos time is gone long ago and a lyx suffix should stand for > lyx files no matter what the internal format used. This can be done easily later after you and JMarc (and others) reach an agreement. I personally like a unique .lyx extension, even if compression is removed. > > Y

Re: Please help improve the embedding feature.

2007-09-01 Thread José Matos
On Saturday 01 September 2007 03:14:11 Bo Peng wrote: > Because this feature more or less duplicates with embedding, and if we > decide to go with .lyz for lyx bundle format, .lyx will always be a > plain text file. I think that the dos time is gone long ago and a lyx suffix should stand for ly

Re: New in LyX 1.6

2007-09-01 Thread Juergen Spitzmueller
José Matos wrote: > Any objection? Not from me anyway (good idea). Jürgen

Re: New in LyX 1.6

2007-09-01 Thread José Matos
On Saturday 01 September 2007 09:15:50 Juergen Spitzmueller wrote: > I've set up a wiki page, since development seems to gain speed: > http://wiki.lyx.org/LyX/NewInLyX16 > > please fill in. I would like to have a wiki page for each new feature/development/cleanup and then to use this page as an

Re: r19968 - in /lyx-devel/trunk/src: TextMetrics.cpp insets/...

2007-09-01 Thread Alfredo Braunstein
== > --- lyx-devel/trunk/src/insets/InsetCollapsable.cpp (original) > +++ lyx-devel/trunk/src/insets/InsetCollapsable.cpp Sat Sep 1 11:24:20 2007 > @@ -213,13 +213,7 @@ > openinlined_ = !hasFixedWid

Re: Severe usability bugs in lyx 1.5

2007-09-01 Thread Pavel Sanda
> 1. This one is very annoying. Open the attached file crazyscroll.lyx and > position section 2 head "This title at the top" at the top of the text > window, in the uppermost possible position while still being totally > visible. I advise you to use the scrollbar arrows, because mouse scrolli

Re: Redefine Minimalistic and use for Branch inset

2007-09-01 Thread Abdelrazak Younes
Martin Vermeer wrote: See attached. I defined Minimalistic (up till now unused) as being just a text inset when open, and just a button (with the first few words of the content displayed on it) when closed. This will make the visual appearance more compact when there are lots of branches. It is

Redefine Minimalistic and use for Branch inset

2007-09-01 Thread Martin Vermeer
See attached. I defined Minimalistic (up till now unused) as being just a text inset when open, and just a button (with the first few words of the content displayed on it) when closed. This will make the visual appearance more compact when there are lots of branches. It is not without its challen

Re: New in LyX 1.6

2007-09-01 Thread Martin Vermeer
On Sat, Sep 01, 2007 at 10:15:50AM +0200, Juergen Spitzmueller wrote: > I've set up a wiki page, since development seems to gain speed: > http://wiki.lyx.org/LyX/NewInLyX16 > > please fill in. > > Jürgen Thanks, I put in insetcollapsable configurability. - Martin

Re: New in LyX 1.6

2007-09-01 Thread Abdelrazak Younes
Juergen Spitzmueller wrote: I've set up a wiki page, since development seems to gain speed: http://wiki.lyx.org/LyX/NewInLyX16 please fill in. I've added multiple work area. Abdel.

New in LyX 1.6

2007-09-01 Thread Juergen Spitzmueller
I've set up a wiki page, since development seems to gain speed: http://wiki.lyx.org/LyX/NewInLyX16 please fill in. Jürgen

1.6.0 plan?

2007-09-01 Thread Abdelrazak Younes
Juergen Spitzmueller wrote: Bo Peng wrote: I had the same plea. Jurgen, what is your opinion? I'm not sure I like it. The diff to 1.5.1 gets bigger and bigger. However, if the current situation stops people from backporting, I can live with the change. If Andre is serious about cleaning up

Re: Q-->Gui: A Plea

2007-09-01 Thread Juergen Spitzmueller
Bo Peng wrote: > I had the same plea. > > Jurgen, what is your opinion? I'm not sure I like it. The diff to 1.5.1 gets bigger and bigger. However, if the current situation stops people from backporting, I can live with the change. Jürgen P.S.: I'll be on a conference for a few days (until Thur

Re: [Cvslog] r19966 - /lyx-devel/trunk/lib/configure.py

2007-09-01 Thread José Matos
On Saturday 01 September 2007 05:09:03 [EMAIL PROTECTED] wrote: > Author: rgheck > Date: Sat Sep 1 06:09:03 2007 > New Revision: 19966 > > URL: http://www.lyx.org/trac/changeset/19966 > Log: > Add export to 1.5.x to trunk. > > Modified: > lyx-devel/trunk/lib/configure.py > > Modified: lyx-deve