Andre Poenitz wrote:
On Sat, Sep 01, 2007 at 08:32:17AM +0200, Abdelrazak Younes wrote:
Andre Poenitz wrote:
I plan to 'manually expand' the current uses QController as in the
attached patch.
The result is not only shorter but also simpler. No need for a template
with a template argument (QController) anymore.
You don't even need the GuiView thing (the former QView). My solution
was to get completely rid of it. See GuiViewSource for a simple example
of it:
- GuiViewSource directly inherits ControlViewSource
- GuiViewSourceDialog only inherits *QWidget* and "uses" the
GuiViewSource controller.
For some classes, you don't even need the first Controller inheritence,
the dialog can use the controller in src/frontends/controllers/ directly.
This dialog is then encapsulated in a DockWidget by LyX (ses Dialogs.cpp
and my helper class DockView).
By the way, we have a problem with your renaming: you renamed QView to
GuiView but this name was already taken by the Qt4 specialisation of
LyXView.
Maybe I'll arrive at a point where I understand the code at some time...
You don't even have to if you use my simple framework.
I am on the way... And I also think that rewriting at least the simple
dialogs would be less hassle. But I'd like to understand the current
setup as well to make sure I do not miss something crucial, therefore
the 'baby steps' approach I am currently taking.
Fair enough.
Abdel.
