On Sat, Sep 01, 2007 at 08:45:53AM +0200, Abdelrazak Younes wrote: > Andre Poenitz wrote: > >Patch attached. Includes various cleanup, too. Will commit. > > I see you didn't wait for an answer to your previous question (my answer > particularly)... While I am happy that you work on this, I think you > could have committed your changes one class at a time, couldn't you?
Could I? Maybe. But there would not really be a point to it. If the thing were to be reverted, one would revert all of it, not only for 14 out of 39 cases. > I also think that you could have ditch th QController thing altogether > using the method I outlined in my answer to your question. > > By the way, what's the need to post such a big patch a minute before > committing? I asked that myself and did not really found an answer. Andre'