Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Lars Gullik Bjønnes
Peter Kümmel <[EMAIL PROTECTED]> writes: | Hi Abdel, Bo | | here the next version with your embedded suggestions. | I've also simplified the floating code. | | Peter | Index: frontends/qt3/QtView.C | === | --- frontends/qt3/QtView.C

Re: Aspell / Windows Fixed

2006-06-20 Thread Stephen Harris
Stephen Harris wrote: > There is good gnus and bad news. The Aspell execution has been > disconnected from C:\Aspell, rather cleverly, IMHO. But, the > Dictionary still seems to be tied to C:\Aspell, so spellchecking > doesn't work. Joost replied

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Martin Vermeer
On Tue, Jun 20, 2006 at 03:00:41PM +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> Your question presupposes that these two mechanisms would have > Martin> anything in common. They have not. display() is a property of > Martin> the inse

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Bo Peng
On 6/20/06, Peter Kümmel <[EMAIL PROTECTED]> wrote: Hi Abdel, Bo here the next version with your embedded suggestions. I've also simplified the floating code. Looks fine to me (others may have higher standard though). Is this patch against the trunk or some branch? I can not apply cleanly. B

Re: Updated Windows Installer

2006-06-20 Thread Joost Verburg
Enrico Forestieri wrote: If you have multiple msys dll's in your path, you can experience problems: http://www.mingw.org/MinGWiki/index.php/mSysFromScratch-mSysDLL That's only when compiling MSYS and the copy of LyX won't be in the system path. Joost

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
Hi Abdel, Bo here the next version with your embedded suggestions. I've also simplified the floating code. Peter Index: frontends/qt3/lyx_gui.C === --- frontends/qt3/lyx_gui.C (revision 14157) +++ frontends/qt3/lyx_gui.C (wor

Re: Aspell / Windows Fixed

2006-06-20 Thread Joost Verburg
There is good gnus and bad news. The Aspell execution has been disconnected from C:\Aspell, rather cleverly, IMHO. But, the Dictionary still seems to be tied to C:\Aspell, so spellchecking doesn't work. That's because you installed Aspell in C:\Aspell using the data installer intended for the c

Re: Aspell / Windows Fixed

2006-06-20 Thread Stephen Harris
Stephen Harris wrote: "A new Windows installer for LyX 1.4.2svn is available for testing: ftp://ftp.devel.lyx.org/pub/lyx/pre/lyx-142svn-20060617.exe ftp://ftp.devel.lyx.org/pub/lyx/pre/lyx-142svn-20060617-bundle.exe Again there are a number of improvements: English thesaurus (Aiksaurus) is

Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h

2006-06-20 Thread Bo Peng
Just tested. It is broken. Saving/restoring env is more difficult than I expected. :-( Actually, with all the cached tests, I do not save much time either. Fast_start is back. I was trying to find a real fix other than an unnecessary io.h test, and forget to restore the test afterwards. BOOST

Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h

2006-06-20 Thread Bo Peng
On 20 Jun 2006 18:20:16 +0200, Lars Gullik Bjønnes <[EMAIL PROTECTED]> wrote: "Bo Peng" <[EMAIL PROTECTED]> writes: | > That is what we have setup automake to do. | > (except that we have so far not bothered to split config.h) | | Really? src/config.h.in: Hmm da hmm... you are right... We shou

Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h

2006-06-20 Thread Jose' Matos
On Tuesday 20 June 2006 17:20, Lars Gullik Bjønnes wrote: > "Bo Peng" <[EMAIL PROTECTED]> writes: > | > That is what we have setup automake to do. > | > (except that we have so far not bothered to split config.h) > | > | Really? src/config.h.in: > > Hmm da hmm... you are right... > > We should prob

Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h

2006-06-20 Thread Lars Gullik Bjønnes
"Bo Peng" <[EMAIL PROTECTED]> writes: | > That is what we have setup automake to do. | > (except that we have so far not bothered to split config.h) | | Really? src/config.h.in: Hmm da hmm... you are right... We should probably create boost_config.h for autotools as well. That would avoid the i

Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h

2006-06-20 Thread Bo Peng
That is what we have setup automake to do. (except that we have so far not bothered to split config.h) Really? src/config.h.in: #define BOOST_USER_CONFIG #if !defined(ENABLE_ASSERTIONS) # define BOOST_DISABLE_ASSERTS 1 #endif #define BOOST_ENABLE_ASSERT_HANDLER 1 You see, I am trying to be

Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h

2006-06-20 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Right, when compiling boost .cpp file you have to pass | DBOOST_USER_CONFIG= to the compiler. That's | what scons do already, isn't it? That is what we have setup automake to do. (except that we have so far not bothered to split config.h) --

Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h

2006-06-20 Thread Abdelrazak Younes
Bo Peng wrote: I think it is the other way around Bo. BOOST_USER_CONFIG is defined in "common/config.h" for all lyx files. If a lyx file include some boost header, the boost_header will look automatically into the file defined by BOOST_USER_CONFIG. So no need to redefine this macro inside boost/c

Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h

2006-06-20 Thread Bo Peng
I think it is the other way around Bo. BOOST_USER_CONFIG is defined in "common/config.h" for all lyx files. If a lyx file include some boost header, the boost_header will look automatically into the file defined by BOOST_USER_CONFIG. So no need to redefine this macro inside boost/config.h. lyx s

Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h

2006-06-20 Thread Abdelrazak Younes
Bo Peng wrote: But do we need "#define BOOST_USER_CONFIG " in there also? It should be in boost/config.h, and passed to boost source files. You can check scons_lyx.log. I do not think this is need for lyx osurces, but I might be wrong. I think it is the other way around Bo. BOOST_USER_CONFIG

Re: Aspell / Windows Fixed

2006-06-20 Thread Stephen Harris
Angus Leeming wrote: > Ok, Joost. Now done. Files are currently uploading to the usual place. > Rather nicely, because I'm overwriting existing files with apache:wiki > ownership, the new versions of these files also have this ownership ;-) Thanks! > I modified the aspell_dict.sh script a littl

Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h

2006-06-20 Thread Bo Peng
But do we need "#define BOOST_USER_CONFIG " in there also? It should be in boost/config.h, and passed to boost source files. You can check scons_lyx.log. I do not think this is need for lyx osurces, but I might be wrong. Bo

Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h

2006-06-20 Thread Abdelrazak Younes
Bo Peng wrote: > I did not test this > patch against msvc, but the previous version did work (the > boost_config.h one). I think it is a msvc problem indeed because I don't remember having it with mingw. This is indeed only with msvc. I guess you know the reason but I can explain again: With

Re: [Patch] qt4/QtView renamed to GuiView

2006-06-20 Thread Lars Gullik Bjønnes
Edwin Leuven <[EMAIL PROTECTED]> writes: | Abdelrazak Younes wrote: | > class GuiImplementation: public Gui | | class Gui: public GuiBase | | is prettier though... No... I don't agree... the rest of the code is going to see 'Gui' if anything, class QtGui : public Gui would have been ok with

Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h

2006-06-20 Thread Bo Peng
>> Also, when I run scons again after the configuration was done, it insist >> on recompiling everything from the beginning. Running "scons >> fast_start=no" work as expected. Looks like your patch broke the >> fast_start=yes option. Just tested. It is broken. Saving/restoring env is more diff

Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h

2006-06-20 Thread Bo Peng
> I did not test this > patch against msvc, but the previous version did work (the > boost_config.h one). I think it is a msvc problem indeed because I don't remember having it with mingw. This is indeed only with msvc. I guess you know the reason but I can explain again: With msvc, boost empl

Re: r14163 - in /lyx-devel/trunk/development/scons: SConstruc...

2006-06-20 Thread Abdelrazak Younes
[EMAIL PROTECTED] wrote: Author: bpeng Date: Tue Jun 20 16:44:46 2006 New Revision: 14163 Log: Scons: config.h moves to BUILDDIR/common, boost_config.h moves to BUILDDIR/boost. and new BUILDDIR/intl/config.h Do not use debug libraries for win/mingw. Did not try it yet. Modified:

Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h

2006-06-20 Thread Abdelrazak Younes
Bo Peng wrote: It solved the intl include problem but not the boost library problem: LINK : fatal error LNK1104: cannot open file 'libboost_signals-vc80-mt-s-1_33_1.lib' Did not you report success with a previous patch? I don't think so. I did not test this patch against msvc, but the pre

Re: Do we need some cash for the lyx project?

2006-06-20 Thread Abdelrazak Younes
Martin Vermeer wrote: On Tue, Jun 20, 2006 at 03:47:41PM +0200, Abdelrazak Younes wrote: I was browsing the wiki and I saw this in , Maybe this guy, Charles Fox, is willing to give this $120 bounty now? * Charles Fox -- I am willing to pay a $120 bount

Re: [Patch] qt4/QtView renamed to GuiView

2006-06-20 Thread Jose' Matos
On Tuesday 20 June 2006 15:33, Abdelrazak Younes wrote: > shxxt, I'll do it now. Thanks. Fixed, thanks. :-) > Abdel. -- José Abílio

Re: [Patch] qt4/QtView renamed to GuiView

2006-06-20 Thread Abdelrazak Younes
Edwin Leuven wrote: Abdelrazak Younes wrote: shxxt, I'll do it now. Thanks. had to add it to sconstruct as well (moc-able files...) I've corrected that one earlier. Abdel.

Re: Do we need some cash for the lyx project?

2006-06-20 Thread Martin Vermeer
On Tue, Jun 20, 2006 at 03:47:41PM +0200, Abdelrazak Younes wrote: > I was browsing the wiki and I saw this in > , Maybe this guy, Charles Fox, is > willing to give this $120 bounty now? > > * Charles Fox -- I am willing to pay a $120 bounty for a working

Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h

2006-06-20 Thread Bo Peng
It solved the intl include problem but not the boost library problem: LINK : fatal error LNK1104: cannot open file 'libboost_signals-vc80-mt-s-1_33_1.lib' Did not you report success with a previous patch? I did not test this patch against msvc, but the previous version did work (the boost_confi

Re: [PATCH] Re-orgnization of scons and generatiion of multiple config.h

2006-06-20 Thread Abdelrazak Younes
Bo Peng wrote: Abdel, please check if the attached patch has addressed all your concerns. It solved the intl include problem but not the boost library problem: LINK : fatal error LNK1104: cannot open file 'libboost_signals-vc80-mt-s-1_33_1.lib' Also, when I run scons again after the configu

Re: [Patch] qt4/QtView renamed to GuiView

2006-06-20 Thread Edwin Leuven
Abdelrazak Younes wrote: shxxt, I'll do it now. Thanks. had to add it to sconstruct as well (moc-able files...)

Re: qt4: table borders are wrong

2006-06-20 Thread Edwin Leuven
Abdelrazak Younes wrote: Is it with the table toolbar or the table dialog? both if i insert a table, select it, and unset all borders with toolbar i still see a grid there seems to be a problem with drawing, not with the dialog or toolbar

Re: [Patch] qt4/QtView renamed to GuiView

2006-06-20 Thread Abdelrazak Younes
Jose' Matos wrote: On Tuesday 20 June 2006 10:34, Abdelrazak Younes wrote: In preparation for the next round of GUI API cleanup. Abdel. Log: t4/QtView renamed to GuiView You forgot to update autotools: shxxt, I'll do it now. Thanks. Abdel.

Re: qt4: table borders are wrong

2006-06-20 Thread Abdelrazak Younes
Edwin Leuven wrote: Edwin Leuven wrote: for example: unsetting the top border of a newly inserted table only unsets visually the top left cell... abdel, did you have a look at this one? try to set/unset some borders and check whether this matches the dvi output. over here it doesn't and i th

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Bo Peng
> The logic is that width and height should work without valid posx, and > poxy. (saveGeometry controls that). I wondered if there is a case where the width is saved but not the position, couldn't the pos!=-1 be removed? At least this was the original logic. Saving windows width/height is safe,

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
Bo Peng wrote: >> I've also implemented the patch for the qt3 frontend. >> Now Qt3 and Qt4 are an par on Linux and Windows. >> Diff against current svn. > > Thanks. I have not read what Abdel says about the patch. Here is mine: > >> - if (posx != -1 && posy != -1) >> - view.mo

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Abdelrazak Younes
Peter Kümmel wrote: Abdelrazak Younes wrote: Hum, we are talking about floating window geometry right? Why do you think about floatingGeometry_ instead of normalGeometry and setFloatingGeometry() instead of initNormalGeometry() ? floating is also a good description, but 'normal' is the name

Re: [Patch] qt4/QtView renamed to GuiView

2006-06-20 Thread Jose' Matos
On Tuesday 20 June 2006 10:34, Abdelrazak Younes wrote: > In preparation for the next round of GUI API cleanup. > > Abdel. > > Log: > t4/QtView renamed to GuiView You forgot to update autotools: make[5]: Entering directory `/home/jamatos/lyx/lyx-devel/src/frontends/qt4' /usr/lib/qt4///bin/moc -o

Re: qt4: table borders are wrong

2006-06-20 Thread Edwin Leuven
Edwin Leuven wrote: for example: unsetting the top border of a newly inserted table only unsets visually the top left cell... abdel, did you have a look at this one? try to set/unset some borders and check whether this matches the dvi output. over here it doesn't and i think there are drawing

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Bo Peng
I've also implemented the patch for the qt3 frontend. Now Qt3 and Qt4 are an par on Linux and Windows. Diff against current svn. Thanks. I have not read what Abdel says about the patch. Here is mine: - if (posx != -1 && posy != -1) - view.move(QPoint(posx, posy)); + v

Do we need some cash for the lyx project?

2006-06-20 Thread Abdelrazak Younes
I was browsing the wiki and I saw this in , Maybe this guy, Charles Fox, is willing to give this $120 bounty now? Abdel. Outline mode Like MS Word/Powerpoint, I would like to be able to edit in the TOC window, using TAB and Shift-TAB to quickly promote/de

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Bennett Helm
On Jun 20, 2006, at 9:27 AM, Martin Vermeer wrote: On Tue, Jun 20, 2006 at 09:14:20AM -0400, Bennett Helm wrote: On Jun 20, 2006, at 9:00 AM, Jean-Marc Lasgouttes wrote: Finally, when typing random text in a footnote, everytime the text gets near the right margin, the all the lines of the foo

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
Abdelrazak Younes wrote: > Peter Kümmel wrote: >> Peter Kümmel wrote: >> -QtView::QtView(unsigned int width, unsigned int height) >> +QtView::QtView() >> : QMainWindow(), LyXView(), commandbuffer_(0), >> frontend_(*this) >> { >> -resize(width, height); >> -

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
Abdelrazak Younes wrote: >> No, this is given by frameGeometry, see >> http://doc.trolltech.com/4.1/geometry.html >> same for Qt3 > > Hum, frameGeometry doesn't include the "Window Title" but it still > include menubar and toolbar IIUC so I guess I am still right :-) Yes, I've realized it, see o

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Martin Vermeer
On Tue, Jun 20, 2006 at 09:14:20AM -0400, Bennett Helm wrote: > On Jun 20, 2006, at 9:00 AM, Jean-Marc Lasgouttes wrote: > > >Finally, when typing random text in a footnote, everytime the text > >gets near the right margin, the all the lines of the footnote move > >right and left. Is that the effe

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Abdelrazak Younes
Peter Kümmel wrote: Peter Kümmel wrote: -QtView::QtView(unsigned int width, unsigned int height) +QtView::QtView() : QMainWindow(), LyXView(), commandbuffer_(0), frontend_(*this) { -resize(width, height); - qApp->setMainWidget(this); -bufferview_.reset(new BufferView(this

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Abdelrazak Younes
Peter Kümmel wrote: Abdelrazak Younes wrote: view.show(); -view.init(); So you don't need LyXView::init() anymore or is it done elsewhere? before the if (width ... I think it makes more sense to initialize before showing and resizing. Of course yes. I haven't seen it. //

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Bennett Helm
On Jun 20, 2006, at 9:00 AM, Jean-Marc Lasgouttes wrote: Finally, when typing random text in a footnote, everytime the text gets near the right margin, the all the lines of the footnote move right and left. Is that the effect that you described, Bennett? I think so. You're typing at the end of

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
Peter Kümmel wrote: -QtView::QtView(unsigned int width, unsigned int height) +QtView::QtView() : QMainWindow(), LyXView(), commandbuffer_(0), frontend_(*this) { -resize(width, height); - qApp->setMainWidget(this); -bufferview_.res

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
>>> -QtView::QtView(unsigned int width, unsigned int height) >>> +QtView::QtView() >>> : QMainWindow(), LyXView(), commandbuffer_(0), frontend_(*this) >>> { >>> -resize(width, height); >>> - >>> qApp->setMainWidget(this); >>> >>> -bufferview_.reset(new BufferView(this, widt

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Your question presupposes that these two mechanisms would have Martin> anything in common. They have not. display() is a property of Martin> the inset (or in math, a mode of the inset). Wide() is a Martin> status element of text

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
Abdelrazak Younes wrote: > Peter Kümmel wrote: >> Bo Peng wrote: But when you prefer the (-1,-1) solution I'll change it. >>> Since (-1, -1) will save a significant amount of coding, I prefer this. >>> >>> Bo >> >> Here the patch with above changes. > > Hello Peter, > > Thanks for the update

Re: [Better patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Martin Vermeer
On Mon, 2006-06-19 at 10:44 -0400, Bennett Helm wrote: > On Jun 18, 2006, at 5:24 AM, Martin Vermeer wrote: > > > On Sat, Jun 17, 2006 at 11:24:51PM +0300, Martin Vermeer wrote: > >> On Wed, Jun 14, 2006 at 11:14:19AM +0300, Martin Vermeer wrote: > >> > >> ... > >> > >>> PS Getting rid of Wide() w

Re: [Patch] qt4/QtView renamed to GuiView

2006-06-20 Thread Abdelrazak Younes
Edwin Leuven wrote: Abdelrazak Younes wrote: class GuiImplementation: public Gui class Gui: public GuiBase is prettier though... Don't tell me that now! FWIW I agree but it's too late. Abdel.

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Abdelrazak Younes
Peter Kümmel wrote: Bo Peng wrote: But when you prefer the (-1,-1) solution I'll change it. Since (-1, -1) will save a significant amount of coding, I prefer this. Bo Here the patch with above changes. Hello Peter, Thanks for the updated patch and sorry for the inconvenience that my merg

Re: Updated Windows Installer

2006-06-20 Thread Edwin Leuven
Angus Leeming wrote: N! I already have these things installed. Trust the user! trust the user to mess up

Re: [Patch] qt4/QtView renamed to GuiView

2006-06-20 Thread Edwin Leuven
Abdelrazak Younes wrote: class GuiImplementation: public Gui class Gui: public GuiBase is prettier though...

Re: LyX Window placed in the upper left corner

2006-06-20 Thread Peter Kümmel
now i've also implemented the qt3 stuff. see ' Qt4 frontend save/restore geoemtry patch' thread

Re: Qt4 frontend save/restore geoemtry patch

2006-06-20 Thread Peter Kümmel
Bo Peng wrote: >> But when you prefer the (-1,-1) solution I'll change it. > > Since (-1, -1) will save a significant amount of coding, I prefer this. > > Bo Here the patch with above changes. I've also implemented the patch for the qt3 frontend. Now Qt3 and Qt4 are an par on Linux and Windows.

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-20 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Andre Poenitz <[EMAIL PROTECTED]> writes: | > | And to not try to force Lars making changes. We'd end up with | > ideas like | > | 'do not use virtual functions in the public interface of classes' and a | > | free demon

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Martin Vermeer
On Tue, 2006-06-20 at 13:41 +0300, Martin Vermeer wrote: > On Tue, 2006-06-20 at 11:55 +0200, Jean-Marc Lasgouttes wrote: > > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > > > Martin> In my newfound tradition of making everything simpler :-) If > > Martin> you paint the whole ta

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Martin Vermeer
On Tue, 2006-06-20 at 11:55 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> In my newfound tradition of making everything simpler :-) If > Martin> you paint the whole tabular background, you don't have to > Martin> figure out what cell

Re: [patch] font selection redesign completed

2006-06-20 Thread Juergen Spitzmueller
Helge Hafting wrote: > Spin buttons allows a faster way of adjusting a value in small > increments, I am not sure that is needed here.  It is not as if people > are likely to do a lot of stepwise adjusting back and forth on > that font scale factor. I think exactly that is the case. Stepwise adju

Re: [patch] font selection redesign completed

2006-06-20 Thread Helge Hafting
Georg Baum wrote: Juergen Spitzmueller wrote: Anyway, I'd really be careful to not betray the user to overuse this scale function. Since the QSpinBox is not able to deal with floating values anyway, I don't want to change the gui just for the sake of the principle. If you insist, I can change

Re: Updated Windows Installer

2006-06-20 Thread Enrico Forestieri
On Tue, Jun 20, 2006 at 11:30:24AM +0200, Joost Verburg wrote: > Angus Leeming wrote: > >N! I already have these things installed. Trust the user! > > > >I manually deleted your shell and python directories, adjusted path_prefix > >to > >"C:/MSys/bin;C:/Python24;..." and everything works p

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> In my newfound tradition of making everything simpler :-) If Martin> you paint the whole tabular background, you don't have to Martin> figure out what cell you're in... You are saying it is not a problem because you repaint the

Re: Updated Windows Installer

2006-06-20 Thread Enrico Forestieri
On Tue, Jun 20, 2006 at 08:42:47AM +, Angus Leeming wrote: > Joost Verburg <[EMAIL PROTECTED]> writes: > > > This installer worked out correctly that I have MikTeX, MSys, Python > > > already installed. However, when I install LyX 1.4 I find that > > > c:\Program Files\LyX14 contains: > > > a

[Patch] qt4/QtView renamed to GuiView

2006-06-20 Thread Abdelrazak Younes
In preparation for the next round of GUI API cleanup. Abdel. Log: t4/QtView renamed to GuiView Index: GuiImplementation.C === --- GuiImplementation.C (revision 14153) +++ GuiImplementation.C (working copy) @@ -12,14 +12,14 @@ #i

Re: Updated Windows Installer

2006-06-20 Thread Joost Verburg
Angus Leeming wrote: N! I already have these things installed. Trust the user! I manually deleted your shell and python directories, adjusted path_prefix to "C:/MSys/bin;C:/Python24;..." and everything works perfectly. Sure, it will work. But you don't notice any difference, right? I c

Re: r14152 - in /lyx-devel/trunk: development/scons/SConstruc...

2006-06-20 Thread Abdelrazak Younes
Peter Kümmel wrote: Have you forgotten to add qt4/Application.h? I get an error here. Not me, tortoiseSVN. Apparently renamed file were merged correctly but new files were not. I just corrected that... Abdel.

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-20 Thread Martin Vermeer
On Mon, 2006-06-19 at 15:05 +0300, Martin Vermeer wrote: > On Mon, 2006-06-19 at 11:21 +0200, Jean-Marc Lasgouttes wrote: > > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > > > >> Done. I propose this for trunk and 1.4 (Jean-Marc?), as it fixes a > > >> rendering bug. > > > > Ma

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-20 Thread Abdelrazak Younes
Jose' Matos wrote: On Tuesday 20 June 2006 09:21, Abdelrazak Younes wrote: Man, we should definitely take a decision on that! Please don't let this discussion dye. Usually I don't point such mistakes or else I would be forced to look to my own. ;-) In this case I make an exception: d

Re: r14152 - in /lyx-devel/trunk: development/scons/SConstruc...

2006-06-20 Thread Peter Kümmel
Have you forgotten to add qt4/Application.h? I get an error here.

Re: r14152 - in /lyx-devel/trunk: development/scons/SConstruc...

2006-06-20 Thread Abdelrazak Younes
Peter Kümmel wrote: msvc needs a return value, so what should I use, just a constant? Yes but please return 0. Obviously frontends other than qt4 do not make use of the id yet. The same fix shall be done for xform and gtk. I'll do that. Abdel. Index: qt3/GuiImplementation.h =

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-20 Thread Jose' Matos
On Tuesday 20 June 2006 09:21, Abdelrazak Younes wrote: > Man, we should definitely take a decision on that! Please don't let this > discussion dye. Usually I don't point such mistakes or else I would be forced to look to my own. ;-) In this case I make an exception: dye != die dye is

Re: r14152 - in /lyx-devel/trunk: development/scons/SConstruc...

2006-06-20 Thread Peter Kümmel
msvc needs a return value, so what should I use, just a constant? Index: qt3/GuiImplementation.h === --- GuiImplementation.h (revision 14152) +++ GuiImplementation.h (working copy) @@ -55,6 +55,7 @@ work_area_.reset(ne

Re: Updated Windows Installer

2006-06-20 Thread Angus Leeming
Joost Verburg <[EMAIL PROTECTED]> writes: > > This installer worked out correctly that I have MikTeX, MSys, Python > > already installed. However, when I install LyX 1.4 I find that > > c:\Program Files\LyX14 contains: > > and the python and shell directories aren't empty: > > Note that the inst

Re: WARNING: GUI Cleanup merge

2006-06-20 Thread Abdelrazak Younes
I resolved my svn problem and I am going to check in now! Abdel. Abdelrazak Younes wrote: Abdelrazak Younes wrote: Hello, I am going to merge my branch now so please wait for a few minutes if you want to commit something that touches the GUI API cleanup work. I will wait until tomorrow be

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-20 Thread Abdelrazak Younes
Andre Poenitz wrote: On Mon, Jun 19, 2006 at 06:17:58PM +0200, Abdelrazak Younes wrote: - Long variables are named like thisLongVariableName. So without the trailing underscore then? For me variables are temporary variables inside a function or variable passed to a function. We are t

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-20 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Andre Poenitz <[EMAIL PROTECTED]> writes: | And to not try to force Lars making changes. We'd end up with ideas like | 'do not use virtual functions in the public interface of classes' and a | free demonstration that it hurts nicely (aka 'doDispatch') Oh, but I don't

Re: Aspell / Windows Fixed

2006-06-20 Thread Joost Verburg
Angus Leeming wrote: Ok, Joost. Now done. Files are currently uploading to the usual place. Rather nicely, because I'm overwriting existing files with apache:wiki ownership, the new versions of these files also have this ownership ;-) Thanks! I modified the aspell_dict.sh script a little to g

Re: Updated Windows Installer

2006-06-20 Thread Joost Verburg
Angus Leeming wrote: I tried it out. Some points: if I grab the AspellData installer from the wiki, I don't get any say in where to install it. It is dated 17 June, so presumably the c:/Aspell location need no longer be hardwired. I do get the option of where to install the dictionaries, but