[Lldb-commits] [PATCH] D95710: [lldb/Commands] Add command options for ScriptedProcess to ProcessLaunch

mib updated this revision to Diff 323911. mib edited the summary of this revision. mib added a comment. Add getters and setters for scripted process managing class name and dictionary in `SBLaunchInfo`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95710/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading for lldb

DavidSpickett added a comment. > This patch also looks quite good. Some minor nits inline and also move gdb* > changes into a single patch with both client and server side code. Cool, I wasn't sure how to split while keeping it readable but that sounds good. Comment at: lldb/

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

mib updated this revision to Diff 323916. mib marked an inline comment as done. mib edited the summary of this revision. mib added a comment. - Fixed unittest's `liblldb` linking issue by unwrapping the `SBError` type into a `lldb_private::Status` in the ScriptInterpreter. - Renamed ScriptInterp

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. thanks @DavidSpickett for the review. I have updated diff incorporating you suggestions. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:454 bool NativeRegisterContextLinux_arm64::IsSVE(unsigned reg) const { - if

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid updated this revision to Diff 323928. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/new/ https://reviews.llvm.org/D96458 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm64.cpp l

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

mib updated this revision to Diff 323930. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95711/new/ https://reviews.llvm.org/D95711 Files: lldb/bindings/python/python-wrapper.swig lldb/include/lldb/API/SBData.h lldb/include/lldb/API/SBError.h

[Lldb-commits] [PATCH] D95712: [lldb/bindings] Add Python ScriptedProcess base class to lldb module

mib added a comment. In D95712#2563091 , @labath wrote: > Unfortunately I don't have the bandwidth to review this, though I feel that > this should have a wider discussion, given that its destined to become a > pretty big chunk of our public immutable ap

[Lldb-commits] [PATCH] D96766: [lldb] [Process/FreeBSD] Introduce mips64 FPU reg support

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. Herald added subscribers: atanasyan, arichardson, ki.stfu, sdardis. mgorny requested review of this revision. https://reviews.llvm.org/D96766 Files: lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBS

[Lldb-commits] [PATCH] D95712: [lldb/bindings] Add Python ScriptedProcess base class to lldb module

mib updated this revision to Diff 323940. mib added a comment. Changed python API to allow lazy fetching for threads and memory regions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95712/new/ https://reviews.llvm.org/D95712 Files: lldb/binding

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 323943. mib marked 10 inline comments as done. mib added a comment. - Address @JDevlieghere comments: - Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95713/new/ https://reviews.llvm.org/D95713 Files: ll

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 323945. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95713/new/ https://reviews.llvm.org/D95713 Files: lldb/source/Plugins/Process/CMakeLists.txt lldb/source/Plugins/Process/scripted/CMakeLists.txt lldb/sourc

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

werat created this revision. werat added a reviewer: jankratochvil. Herald added a reviewer: shafik. werat requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. Apply changes from https://reviews.llvm.

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

werat added a comment. Herald added a subscriber: JDevlieghere. Hi @jankratochvil, can you take a look at this, please? I can't claim I fully understand what's the difference here, but this aligns with your comment at https://reviews.llvm.org/D92643#inline-900717 :) Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D96779: [lldb] Fix shared library directory computation on windows

labath created this revision. labath added reviewers: JDevlieghere, stella.stamenova. labath requested review of this revision. Herald added a project: LLDB. Our code for locating the shared library directory works via dladdr (or the windows equivalent) to locate the path of an address known to re

[Lldb-commits] [lldb] 85f025e - [lldb/test] Test lldb-server named pipe functionality on windows

Author: Pavel Labath Date: 2021-02-16T15:47:39+01:00 New Revision: 85f025e5b33d148808177427eebca4cc14f93079 URL: https://github.com/llvm/llvm-project/commit/85f025e5b33d148808177427eebca4cc14f93079 DIFF: https://github.com/llvm/llvm-project/commit/85f025e5b33d148808177427eebca4cc14f93079.diff

[Lldb-commits] [PATCH] D96260: [lldb/test] Test lldb-server named pipe functionality on windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG85f025e5b33d: [lldb/test] Test lldb-server named pipe functionality on windows (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96260/new/

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. Thanks for catching those. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96778/new/ https://reviews.llvm.org/D96778 _

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

jankratochvil added a comment. In D96778#2565414 , @werat wrote: > I can't claim I fully understand what's the difference here, but this aligns > with your comment at https://reviews.llvm.org/D92643#inline-900717 :) If interested the problem was `DWARFAt

[Lldb-commits] [PATCH] D96634: [lldb][JITLoaderGDB] Test debug support in llvm-jitlink

sgraenitz added a comment. Thanks for taking a look. Planning to to give this a try as soon as JITLink support landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96634/new/ https://reviews.llvm.org/D96634 __

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid added a comment. Subsequent update will resolve review comments. @DavidSpickett thanks for review. much appreciated Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:79 + m_mte_ctrl_reg = 0; + DavidSpickett wrote:

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid updated this revision to Diff 324017. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid updated this revision to Diff 324018. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h

[Lldb-commits] [PATCH] D96459: [LLDB] Pull AuxVec info into NativeRegisterContextLinux_arm64

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:104 + + return 0; +} DavidSpickett wrote: > Do I understand correctly that this will be filled in in a further patch? So > right now it's only re

[Lldb-commits] [PATCH] D96459: [LLDB] Pull AuxVec info into NativeRegisterContextLinux_arm64

omjavaid updated this revision to Diff 324021. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96459/new/ https://reviews.llvm.org/D96459 Files: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp lldb/source/Plugins/Process/Linux/NativeProcessLinux.h lldb/source/Plugins/Process

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1198 + + if (m_mte_ctrl_is_valid) +return error; omjavaid wrote: > DavidSpickett wrote: > > Just to confirm I understand this logic. > >

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

labath added a comment. In general, I believe such a situation can occur even now, if DW_AT_specification/DW_AT_abstract_origin uses DW_FORM_ref_addr. And I think dsymutil actually produces such references. However, I don't think one can meaningfully use DW_AT_specification/DW_AT_abstract_origi

[Lldb-commits] [PATCH] D96427: Support multi-configuration generators correctly in several config files

stella.stamenova created this revision. Herald added subscribers: teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, mgorny. Herald added a reviewer: JDevlieghere. Heral

[Lldb-commits] [PATCH] D96427: Support multi-configuration generators correctly in several config files

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM. I'm surprised the `dsymutil` one slipped through the cracks, we have a bot that should (?) be testing this configuration: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-standalone/ Repository: rG LLVM Github M

[Lldb-commits] [PATCH] D96427: Support multi-configuration generators correctly in several config files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed98676fa483: Support multi-configuration generators correctly in several config files (authored by stella.stamenova). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D96427: Support multi-configuration generators correctly in several config files

teemperor added a comment. In D96427#2555251 , @JDevlieghere wrote: > LGTM. I'm surprised the `dsymutil` one slipped through the cracks, we have a > bot that should (?) be testing this configuration: > http://green.lab.llvm.org/green/view/LLDB/job/lldb-

[Lldb-commits] [PATCH] D96427: Support multi-configuration generators correctly in several config files

stella.stamenova updated this revision to Diff 323053. stella.stamenova edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96427/new/ https://reviews.llvm.org/D96427 Files: clang/test/Unit/lit.site.cfg.py.in lld/t

[Lldb-commits] [PATCH] D95712: [lldb/bindings] Add Python ScriptedProcess base class to lldb module

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. In D95712#2563091 , @labath wrote: > Unfortunately I don't have the bandwidth to review this, though I feel that > this should ha

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

dblaikie added a comment. In D96778#2565677 , @jankratochvil wrote: > In D96778#2565414 , @werat wrote: > >> I can't claim I fully understand what's the difference here, but this aligns >> with your comment at htt

[Lldb-commits] [PATCH] D96779: [lldb] Fix shared library directory computation on windows

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Seems like a reasonable solution. LGTM. Comment at: lldb/include/lldb/Host/HostInfoBase.h:44-46 + using SharedLibraryDirectoryHelper = void(FileSpec &this_file);

[Lldb-commits] [PATCH] D96779: [lldb] Fix shared library directory computation on windows

labath added inline comments. Comment at: lldb/include/lldb/Host/HostInfoBase.h:44-46 + using SharedLibraryDirectoryHelper = void(FileSpec &this_file); + + static void Initialize(SharedLibraryDirectoryHelper *helper = nullptr); JDevlieghere wrote: > Why a funct

[Lldb-commits] [PATCH] D96779: [lldb] Fix shared library directory computation on windows

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Host/HostInfoBase.h:44-46 + using SharedLibraryDirectoryHelper = void(FileSpec &this_file); + + static void Initialize(SharedLibraryDirectoryHelper *helper = nullptr); labath wrote: > JDevliegher

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support [WIP]

labath added a reviewer: omjavaid. labath added a comment. I'm torn about the ReadHardwareDebugInfo interface. On one hand, there's no use case now for distinguishing the failure to retrieve breakpoint info from successfully determining that we support zero breakpoints. So we could make the fun

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

labath added a comment. I'm sorry, my response times are pretty slow these days. I'm thinking about this `ConfigureRegisterInfos` business. I get that the vector length is variable, and so we need to refresh it after every stop. However, the set of enabled extensions seems more static. Is it p

[Lldb-commits] [PATCH] D96795: [FileCollector] Fix that the file system case-sensitivity check was inverted

This revision was automatically updated to reflect the committed changes. Closed by commit rGf88b502d9bc7: [FileCollector] Fix that the file system case-sensitivity check was inverted (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [lldb] f88b502 - [FileCollector] Fix that the file system case-sensitivity check was inverted

Author: Raphael Isemann Date: 2021-02-16T20:21:32+01:00 New Revision: f88b502d9bc7c2d7db8db340d5b98fc7f46eba9c URL: https://github.com/llvm/llvm-project/commit/f88b502d9bc7c2d7db8db340d5b98fc7f46eba9c DIFF: https://github.com/llvm/llvm-project/commit/f88b502d9bc7c2d7db8db340d5b98fc7f46eba9c.dif

[Lldb-commits] [PATCH] D96779: [lldb] Fix shared library directory computation on windows

labath added inline comments. Comment at: lldb/include/lldb/Host/HostInfoBase.h:44-46 + using SharedLibraryDirectoryHelper = void(FileSpec &this_file); + + static void Initialize(SharedLibraryDirectoryHelper *helper = nullptr); JDevlieghere wrote: > labath wrot

[Lldb-commits] [PATCH] D96779: [lldb] Fix shared library directory computation on windows

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Host/HostInfoBase.h:44-46 + using SharedLibraryDirectoryHelper = void(FileSpec &this_file); + + static void Initialize(SharedLibraryDirectoryHelper *helper = nullptr); labath wrote: > JDevliegher

[Lldb-commits] [PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

shafik created this revision. shafik added reviewers: aaron.ballman, rsmith, teemperor. Herald added a subscriber: arphaman. shafik requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Currently `TypePrinter` lumps anonymous classes and unname

[Lldb-commits] [PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

shafik added a comment. Note: I am not fixing how we treat anonymous and unnamed enums, I could not find a way to figure out if an enum was anonymous or not. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96807/new/ https://reviews.llvm.org/D96807 __

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

mib updated this revision to Diff 324071. mib added a comment. Fixed null deref crash when unwrapping SBError opaque ptr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95711/new/ https://reviews.llvm.org/D95711 Files: lldb/bindings/python/python

[Lldb-commits] [PATCH] D95712: [lldb/bindings] Add Python ScriptedProcess base class to lldb module

mib updated this revision to Diff 324072. mib added a comment. Add disclaimer in the base class docstring saying that the interface is not stable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95712/new/ https://reviews.llvm.org/D95712 Files: l

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 324075. mib added a comment. Update `ScriptedProcess::GetMemoryRegions` to load regions lazily. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95713/new/ https://reviews.llvm.org/D95713 Files: lldb/source/Plugins

[Lldb-commits] [lldb] 1db2888 - [lldb] Remove some nanosleep preprocessor magic

Author: Pavel Labath Date: 2021-02-16T21:07:57+01:00 New Revision: 1db2888e70709930da6c22ab83706c7695962ace URL: https://github.com/llvm/llvm-project/commit/1db2888e70709930da6c22ab83706c7695962ace DIFF: https://github.com/llvm/llvm-project/commit/1db2888e70709930da6c22ab83706c7695962ace.diff

[Lldb-commits] [lldb] 901ea29 - [lldb] Delete superfluous semicolon

Author: Pavel Labath Date: 2021-02-16T21:07:58+01:00 New Revision: 901ea29662c88cb8f87d650cef2ed64a9f0d480f URL: https://github.com/llvm/llvm-project/commit/901ea29662c88cb8f87d650cef2ed64a9f0d480f DIFF: https://github.com/llvm/llvm-project/commit/901ea29662c88cb8f87d650cef2ed64a9f0d480f.diff

[Lldb-commits] [PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

aaron.ballman added a comment. Thank you for working on this! In general, I like the change. Comment at: clang/lib/AST/TypePrinter.cpp:1308 +} else if ((isa(D) && cast(D)->isAnonymousStructOrUnion()) || +isa(D)) { OS << "anonymous"; I think

[Lldb-commits] [lldb] 9f38001 - [lldb] [Process/FreeBSD] Ensure that errors are always handled

Author: Michał Górny Date: 2021-02-16T22:21:37+01:00 New Revision: 9f38001bf07252bc29671cf49b42351f34172dea URL: https://github.com/llvm/llvm-project/commit/9f38001bf07252bc29671cf49b42351f34172dea DIFF: https://github.com/llvm/llvm-project/commit/9f38001bf07252bc29671cf49b42351f34172dea.diff

[Lldb-commits] [PATCH] D96558: [lldb] [Process/FreeBSD] Ensure that errors are always handled

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f38001bf072: [lldb] [Process/FreeBSD] Ensure that errors are always handled (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D96817: Fix deep copying for OptionValue classes

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: clayborg, JDevlieghere, labath, teemperor. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: mgorny. tatyana-krasnukha requested review of this revision. Herald added a subscriber: lldb-commits. Some impl

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support [WIP]

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.h:62-63 std::array m_reg_data; + dbreg m_dbreg; + bool m_read_dbreg; labath wrote: > maybe Optional Tried it but it feels really artificial he

[Lldb-commits] [PATCH] D96623: [lldb-vscode] Fix lldb init file stdout issue

clayborg added a comment. After thinking about this a bit more, it seems a mistake that we can't change the file handles _prior_ to sourcing the init files. I have proposed one solution in the inline comments to create a new SBDebugger::Create() method that takes the input output and error file

[Lldb-commits] [PATCH] D96623: [lldb-vscode] Fix lldb init file stdout issue

clayborg added a comment. I added Jim and Pavel to get some more feedback. The main issue is the Visual Studio Code debug adaptors like lldb-vscode receive and send packets on STDIN and STDOUT. The debugger is created during the "initialize" request which expects a response. If the debugger tri

[Lldb-commits] [PATCH] D96817: Fix deep copying for OptionValue classes

dblaikie added a comment. Perhaps all these clone implementations could be provided via mixin instead? struct base { virtual std::shared_ptr Clone() = 0; ... }; template struct base_clone_helper : IntermediateBase { static_assert(std::is_base_of::value); std::shared_ptr Cl

[Lldb-commits] [PATCH] D96817: Fix deep copying for OptionValue classes

dblaikie added inline comments. Comment at: lldb/unittests/Interpreter/TestOptionValue.cpp:173 + // Trigger the callback second time. + file_list_copy_ptr->SetValueFromString(llvm::StringRef("0 another/path"), + eVarSetOperationReplace);

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

jankratochvil added a comment. In D96778#2566208 , @dblaikie wrote: > I expect it'd be good to have a test case showing the sort of DWARF that DWZ > produces for cross-CU references of enumerators. There is a testcase in D91014

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

dblaikie added a comment. In D96778#2567255 , @jankratochvil wrote: > In D96778#2566208 , @dblaikie wrote: > >> I expect it'd be good to have a test case showing the sort of DWARF that DWZ >> produces for cross-CU

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

jankratochvil added a comment. In D96778#2567261 , @dblaikie wrote: > That tests some other cross-cu references, but if it was testing the changes > in this patch, wouldn't the test be failing (& I guess it isn't)? It isn't testing the specific cross-CU

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

aadsm added a comment. > We should have a test for this. how do you recommend doing this? I spent a couple of hours on this but got no where. From what I understood we should prefer lit tests, so I was thinking of creating a binary that dlopens a module. However, I wasn't able to create a bina

[Lldb-commits] [PATCH] D96829: Add "Undeclared registers are marked as Undefined" to UnwindPlan, adopt it in arch default unwind plans

jasonmolenda created this revision. jasonmolenda added a reviewer: labath. jasonmolenda added a project: LLDB. Herald added subscribers: JDevlieghere, pengfei, atanasyan, jrtc27, kbarton, kristof.beyls, nemanjai, sdardis. jasonmolenda requested review of this revision. The ABI plugins can provide

[Lldb-commits] [PATCH] D96833: [lldb] Print a useful error message when trying to import modules with dots or dashes

JDevlieghere created this revision. JDevlieghere added reviewers: labath, kastiglione, mib. JDevlieghere requested review of this revision. LLDB does not like to import Python files with dashes or dots in their name. While the former are technically allowed, they're discouraged [1]. Dots are all

[Lldb-commits] [PATCH] D96833: [lldb] Print a useful error message when trying to import modules with dots or dashes

JDevlieghere updated this revision to Diff 324169. JDevlieghere edited the summary of this revision. JDevlieghere added a comment. module specification -> module names CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96833/new/ https://reviews.llvm.org/D96833 Files: lldb/source/Plugins/

[Lldb-commits] [PATCH] D96833: [lldb] Print a useful error message when trying to import modules with dots or dashes

JDevlieghere added a comment. FWIW I played around with `__import__` and `importlib.import_module` which does allow you to import modules with dashes, but unlike `import` it doesn't add them to the globals. I'm sure there's a way around that, but it didn't seem worth to additional complexity.

[Lldb-commits] [PATCH] D96829: Add "Undeclared registers are marked as Undefined" to UnwindPlan, adopt it in arch default unwind plans

jasonmolenda added a comment. I marked Pavel as the reviewer for this because he's maybe the most likely to have an opinion about this change; I don't mean to sign you up for review work if you don't have time right now. I don't know if the specifics of the patch are especially interesting, bu

[Lldb-commits] [PATCH] D96829: Add "Undeclared registers are marked as Undefined" to UnwindPlan, adopt it in arch default unwind plans

clayborg added a comment. Makes sense, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96829/new/ https://reviews.llvm.org/D96829 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [PATCH] D96839: Add a callout to the LanguageRuntime to override the normal UnwindPlan used for a frame

jasonmolenda created this revision. jasonmolenda added a reviewer: jasonmolenda. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. jasonmolenda requested review of this revision. Swift is gaining asynchronous functions, which may not be executing when a function they ca

[Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth. Herald added subscribers: pengfei, arphaman, kristof.beyls. mstorsjo requested review of this revision. Herald added a project: LLDB. It was pointed out to me that the docs previously only said i386 was supported, while I

[Lldb-commits] [PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

teemperor added a comment. LGTM. Regarding the LLDB example: Given that the LLDB API is in theory not bound to the semantics a specific language, I think one can argue that `IsAnonymousType` could also return true for unnamed classes. The use case that triggered this whole discussion was someo